Feed Advanced Search

Mon, Mar 30

feverfew added a comment to D28363: Don't incorrectly claim to support KIO::open.

@elvisangelaccio Done. I don't know how you choose for fixes in release branches to get into master so I'll let you sort that out (and what is it, for future reference)?

Mon, Mar 30, 5:20 PM · KIO GDrive
feverfew closed D28363: Don't incorrectly claim to support KIO::open.
Mon, Mar 30, 5:17 PM · KIO GDrive
feverfew committed R219:aa6e987eed44: Don't incorrectly claim to support KIO::open (authored by feverfew).
Don't incorrectly claim to support KIO::open
Mon, Mar 30, 5:17 PM
feverfew closed D28440: Mark KIOFuse mounts as Probably slow.
Mon, Mar 30, 5:02 PM · Frameworks
feverfew committed R241:ec5adbccc23d: Mark KIOFuse mounts as Probably slow (authored by feverfew).
Mark KIOFuse mounts as Probably slow
Mon, Mar 30, 5:02 PM
feverfew added reviewers for D28440: Mark KIOFuse mounts as Probably slow: Frameworks, dfaure, broulik, bruns.
Mon, Mar 30, 2:54 PM · Frameworks
feverfew requested review of D28440: Mark KIOFuse mounts as Probably slow.
Mon, Mar 30, 2:51 PM · Frameworks
feverfew updated the diff for D28290: Sync terminal with KIOFuse mount when browing remote directories.
  • Only do DBus call if mount is KIOFuse mount
  • make interface member of class
  • switch to camel case
Mon, Mar 30, 12:42 PM · Dolphin

Fri, Mar 27

feverfew added a project to D28363: Don't incorrectly claim to support KIO::open: KIO GDrive.
Fri, Mar 27, 9:17 PM · KIO GDrive
feverfew requested review of D28363: Don't incorrectly claim to support KIO::open.
Fri, Mar 27, 9:16 PM · KIO GDrive

Wed, Mar 25

feverfew added a reviewer for D28290: Sync terminal with KIOFuse mount when browing remote directories: Dolphin.

Demo of feature:

Wed, Mar 25, 8:32 PM · Dolphin
feverfew requested review of D28290: Sync terminal with KIOFuse mount when browing remote directories.
Wed, Mar 25, 8:30 PM · Dolphin

Thu, Mar 19

feverfew accepted D27999: [DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice.

Quick testing with fish protocol doesn't break anything KIOFuse side. Going to page in @ngraham, if it works for him with smb it's an all good from the "KIOFuse people" ;)

Thu, Mar 19, 7:14 PM · Frameworks

Fri, Mar 13

feverfew added a comment to D27999: [DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice.

don't merge yet, looking at the code I sense something might break here but I need some time to do my own testing first.

Fri, Mar 13, 2:17 PM · Frameworks

Thu, Mar 12

feverfew added a reviewer for D27999: [DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice: feverfew.

I'll review this when I have a chance (sometime this week).

Thu, Mar 12, 12:12 PM · Frameworks

Tue, Mar 3

feverfew added a comment to D27810: Correctly disable UDS_ACCESS being set.

I am pretty sure I picked that up somewhere, might be worth asking lxr for possible other places we set ACCESS to -1

Tue, Mar 3, 8:26 PM · Frameworks, Dolphin
feverfew added a comment to T8449: Replacement of KDE Identity System.

I have extensive experience in Django, maybe in the summer I can help work in this direction.

Tue, Mar 3, 2:52 PM · Websites, Sysadmin

Mar 1 2020

feverfew closed D21795: [KAuth] Add support for action details in Polkit1 backend..
Mar 1 2020, 5:58 PM · Frameworks
feverfew committed R283:f53d6a29a049: [KAuth] Add support for action details in Polkit1 backend. (authored by feverfew).
[KAuth] Add support for action details in Polkit1 backend.
Mar 1 2020, 5:58 PM
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • Fix &
  • Use enum class
  • Use enum instead of string comparison
Mar 1 2020, 5:56 PM · Frameworks
feverfew committed R318:7a2885853a42: Merge branch 'release/19.12' (authored by feverfew).
Merge branch 'release/19.12'
Mar 1 2020, 5:23 PM
feverfew committed R318:af45eb0af521: Fix typo in comment (authored by feverfew).
Fix typo in comment
Mar 1 2020, 5:21 PM
feverfew committed R318:fef7eebc6e3c: Fix files not being highlighted if directory of file is already open (authored by feverfew).
Fix files not being highlighted if directory of file is already open
Mar 1 2020, 5:19 PM
feverfew closed D27389: Fix files not being highlighted if directory of file is already open.
Mar 1 2020, 5:19 PM · Dolphin

Feb 26 2020

feverfew added a comment to D21795: [KAuth] Add support for action details in Polkit1 backend..

I believe most of your (@sitter) comments (apart from the misaligned & probably were caused by me forgetting to rebase), lmk if otherwise.

Feb 26 2020, 9:59 PM · Frameworks
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • Merge branch 'master' into arcpatch-D21795_1
  • Update version
Feb 26 2020, 9:42 PM · Frameworks
feverfew planned changes to D21795: [KAuth] Add support for action details in Polkit1 backend..

Ok, I see what's going on here. Earlier I mucked up the diff a bit and had to go back to different diff id and reapply my changes. In the process I forgot to rebase onto master. Once I do that David's copyright will be back in (and the event loop goes with it).

Feb 26 2020, 2:08 PM · Frameworks

Feb 25 2020

feverfew added a comment to D27643: FileChooser: download remote files to a cache location to open them through the portal.

With a brief look the ideal scenario is to be able to use DesktopExecParser::resultingArguments, or a class that calls it KRun. That should do the conversion. I'm just not sure if you have the information required to use it.

Feb 25 2020, 9:04 PM · Plasma
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • Fix the diff
Feb 25 2020, 8:35 PM · Frameworks

Feb 24 2020

feverfew accepted D27153: port sftp to Result system to force serialization of error/finish condition.
Feb 24 2020, 11:22 PM · Frameworks, Dolphin

Feb 20 2020

feverfew added a comment to D21795: [KAuth] Add support for action details in Polkit1 backend..

Ok I've commandeered this on request, as we're so close to getting this done. I've simply addressed sitter's comments here seeming as they're simple enough to do so without understanding the code that well. I haven't actually tested this in any capacity, as again, I'm not too familiar with this code and what it's trying to accomplish. If someone could point me in the correct direction I'll test as well.

Feb 20 2020, 11:42 PM · Frameworks
ngraham awarded D21795: [KAuth] Add support for action details in Polkit1 backend. a Love token.
Feb 20 2020, 10:44 PM · Frameworks
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • add const &
Feb 20 2020, 10:43 PM · Frameworks
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • Rebase
  • Respond to sitter's comments
Feb 20 2020, 10:33 PM · Frameworks
feverfew commandeered D21795: [KAuth] Add support for action details in Polkit1 backend..
Feb 20 2020, 10:32 PM · Frameworks

Feb 16 2020

feverfew updated the test plan for D27389: Fix files not being highlighted if directory of file is already open.
Feb 16 2020, 4:34 PM · Dolphin
feverfew updated the diff for D27389: Fix files not being highlighted if directory of file is already open.
  • Remote unnecessary newline
Feb 16 2020, 3:19 PM · Dolphin
feverfew updated the diff for D27389: Fix files not being highlighted if directory of file is already open.
  • Actually fix the bug
Feb 16 2020, 2:39 PM · Dolphin

Feb 14 2020

feverfew requested review of D27389: Fix files not being highlighted if directory of file is already open.
Feb 14 2020, 12:05 AM · Dolphin

Feb 13 2020

feverfew requested changes to D27153: port sftp to Result system to force serialization of error/finish condition.

Good stuff, I'll admit I kind of skimmed over the bits that were rewrites error(...); return; -> Result::fail(), I assume you've mapped correctly there. Only minor comments from me.

Feb 13 2020, 10:40 PM · Frameworks, Dolphin

Feb 10 2020

feverfew added a comment to D27291: install smb as both smb:// and cifs://.

feverfew: you're probably looking at master while this is a patch for the 19.12 branch.
See https://phabricator.kde.org/D26358 which happened in master.

I guess that makes this commit ok for 19.12, but it has to be redone differently in master.

Feb 10 2020, 10:32 PM · Frameworks, Dolphin
feverfew added a comment to D27291: install smb as both smb:// and cifs://.

I'm a bit confused here, isn't the protocol file now a JSON file? I'm looking at the repo and it appears to be the case, so I'm not seeing how this diff is seeing this as a rename?

Feb 10 2020, 10:19 PM · Frameworks, Dolphin

Jan 11 2020

feverfew committed R320:3bb841890e5a: Add support for FileJob->truncate() in smb/sftp slaves (authored by feverfew).
Add support for FileJob->truncate() in smb/sftp slaves
Jan 11 2020, 9:32 PM
feverfew closed D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Jan 11 2020, 9:32 PM · Frameworks, Dolphin
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.
  • Merge branch 'master' into arcpatch-D26191
  • adhere to protcol -> json switch
Jan 11 2020, 9:30 PM · Frameworks, Dolphin
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Cleanup code according to comments

Jan 11 2020, 9:24 PM · Frameworks, Dolphin

Jan 2 2020

feverfew committed R241:fcf4529f62e1: Adding support for mounting KIOFuse URLs for applications that don't use KIO (authored by feverfew).
Adding support for mounting KIOFuse URLs for applications that don't use KIO
Jan 2 2020, 6:29 PM
feverfew closed D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Jan 2 2020, 6:29 PM · Frameworks

Jan 1 2020

feverfew committed R241:578fbf45297b: Add truncation support to FileJob (authored by feverfew).
Add truncation support to FileJob
Jan 1 2020, 11:59 PM
feverfew closed D26148: Add truncation support to FileJob.
Jan 1 2020, 11:59 PM · Frameworks
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Fix introduction of BIC method

Jan 1 2020, 11:59 PM · Frameworks, Dolphin
feverfew added a comment to D26148: Add truncation support to FileJob.

Thanks @dfaure! Would you be able to also review D26191?

Yes, once it has been ported to virtual_hook as well.

Jan 1 2020, 11:07 PM · Frameworks
feverfew updated the diff for D26148: Add truncation support to FileJob.

Fix introduction of BIC method

Jan 1 2020, 2:59 PM · Frameworks

Dec 25 2019

feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Add fact that protocol supports truncation

Dec 25 2019, 10:49 PM · Frameworks, Dolphin
feverfew updated the summary of D26148: Add truncation support to FileJob.
Dec 25 2019, 10:47 PM · Frameworks
feverfew updated the diff for D26148: Add truncation support to FileJob.

Add feature to determine if protocol supports truncation

Dec 25 2019, 10:46 PM · Frameworks

Dec 24 2019

feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Avoid code duplication

Dec 24 2019, 6:52 PM · Frameworks, Dolphin
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Avoid free(NULL)

Dec 24 2019, 6:47 PM · Frameworks, Dolphin

Dec 23 2019

feverfew added inline comments to D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Dec 23 2019, 7:12 PM · Frameworks, Dolphin
feverfew added a comment to D26148: Add truncation support to FileJob.
In D26148#582365, @apol wrote:

It would be interesting to explain why it's important or how it's to be used in the commit message.

Dec 23 2019, 7:05 PM · Frameworks
feverfew updated the summary of D26148: Add truncation support to FileJob.
Dec 23 2019, 7:04 PM · Frameworks
feverfew updated the summary of D26148: Add truncation support to FileJob.
Dec 23 2019, 7:03 PM · Frameworks
feverfew added a dependency for D26191: Add support for FileJob->truncate() in smb/sftp slaves: D26148: Add truncation support to FileJob.
Dec 23 2019, 5:42 PM · Frameworks, Dolphin
feverfew added a dependent revision for D26148: Add truncation support to FileJob: D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Dec 23 2019, 5:42 PM · Frameworks
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.
  • Free unneeded struct pointer
Dec 23 2019, 5:13 PM · Frameworks, Dolphin
feverfew requested review of D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Dec 23 2019, 5:12 PM · Frameworks, Dolphin

Dec 22 2019

feverfew updated the diff for D26148: Add truncation support to FileJob.

Add unit test for truncation

Dec 22 2019, 1:15 PM · Frameworks

Dec 21 2019

feverfew requested review of D26148: Add truncation support to FileJob.
Dec 21 2019, 5:39 PM · Frameworks

Dec 20 2019

feverfew committed R871:bbdf8950e0d4: Add KIOFuse to mapping (authored by feverfew).
Add KIOFuse to mapping
Dec 20 2019, 12:50 PM
feverfew closed D26104: Add KIOFuse to mapping.
Dec 20 2019, 12:50 PM · Plasma

Dec 19 2019

feverfew requested review of D26104: Add KIOFuse to mapping.
Dec 19 2019, 1:58 PM · Plasma

Dec 16 2019

feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

fix indentation

Dec 16 2019, 1:24 PM · Frameworks

Dec 14 2019

feverfew updated the test plan for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Dec 14 2019, 6:39 PM · Frameworks
feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
  • fix code style
Dec 14 2019, 6:32 PM · Frameworks
feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

For SMB shares I guess what can happen is that the URL doesn't have a username in it, but it still needs a password? IIRC there was no username in "old" samba (W95, W98, XP, ...?).
This might explain what you were saying about people having password problems even with empty userInfo() (which means username and password).
But we can hardly know, just by looking at a URL, if a password is needed... I guess most of time a password is actually needed? Maybe you're right after all, and we should always send SMB urls to kiofuse..... Dunno.

Dec 14 2019, 6:30 PM · Frameworks

Dec 13 2019

feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

The current patch should be tested with latest kio-fuse master, as the blacklisting has been moved there to keep this patch clean.

Dec 13 2019, 2:56 PM · Frameworks
feverfew committed R247:e2ee1e3b3154: Move KIOFuse from kdereview to extragear/base (authored by feverfew).
Move KIOFuse from kdereview to extragear/base
Dec 13 2019, 2:03 PM
feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

On further looking, it seems like git grep doesn't really tell the full picture. It seems like resultingArguments is called before resolveURLs is, so I've simplified the diff as requested.

Dec 13 2019, 12:32 PM · Frameworks
feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
  • Merge branch 'master' into arcpatch-D23384
  • Address comments
  • Remove unnecessary mount requests in krun
  • Only use KIOFuse if password is empty
Dec 13 2019, 12:02 PM · Frameworks

Dec 12 2019

feverfew added inline comments to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Dec 12 2019, 7:38 PM · Frameworks
feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Why does KRun duplicate all of the (new) code from DesktopExecParser, when DesktopExecParser is actually a helper class for KRun?
I would expect it to have solved all this already, unless I'm missing something about the various code paths.
The code you changed in krun.cpp was supposed to simply resolve desktop:/foo to file:///bleh but everything else about %u/%f is done by DesktopExecParser.

Dec 12 2019, 7:20 PM · Frameworks
feverfew added a comment to T12219: Try to get QKeyChain as a framework.

"KeyChain" already has the "K" prefix ;) so Let's just drop the Q

Dec 12 2019, 4:35 PM · KF6

Dec 6 2019

feverfew added a comment to D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings.

What about "Baloo file search"?

Dec 6 2019, 4:08 PM · Plasma

Dec 5 2019

feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Thanks for the reviews everyone! I'll update the diff and respond to the comments no later than Tuesday

Dec 5 2019, 2:14 PM · Frameworks

Dec 4 2019

feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Issues with KIOFuse itself should be opened up as an issue, or as a reply to the MR that is being tested; this differential only concerns communication between the KIOFuse mount and KIO itself.

Dec 4 2019, 5:14 PM · Frameworks

Dec 3 2019

feverfew updated the summary of D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Dec 3 2019, 10:29 PM · Frameworks
feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

don't send http(s) to kioexec

Dec 3 2019, 10:27 PM · Frameworks
feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

So before this patch we had the following behaviour:

Dec 3 2019, 9:33 PM · Frameworks
feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

ignore scheme handler

Dec 3 2019, 3:30 PM · Frameworks
feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

I'm afraid that even with that change, the issue is still present. I honestly don't think it would be the worst thing in the world if we always handed the kio-fuse paths to apps that don't use ioslaves.

It would be. I like to have links like http://kde.org opened properly in the web browser, ftp://some/where opened in an FTP client and so on...
Media players know more about the format and streaming it than kio-fuse ever could, so avoiding layers in between if possible is definitely an advantage.

Dec 3 2019, 12:48 PM · Frameworks
feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Convert KIO URLs to KIOFuse URL is app is not KIO-enabled.

Dec 3 2019, 12:47 PM · Frameworks

Dec 2 2019

feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Chek for userInfo instead of just password

Dec 2 2019, 11:37 PM · Frameworks
feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Check for password instead of authority

Dec 2 2019, 6:43 PM · Frameworks

Dec 1 2019

feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

This isn't reaching KIOFuse at all. I believe this is related to this bug and that you've also blogged about:
https://bugs.kde.org/show_bug.cgi?id=330192
https://pointieststick.com/2018/01/17/videos-on-samba-shares/

This can be solved in this patch (and I did, although I removed it at Harald's request). I think I'll move it back in, and will leave it if it does solve this issue for you.

Great! Once it's back in, I'll re-test that.

Updated the diff. give it a go...
Also I assume that if it does work for you it resolves 330192?

Yay case #1 is fixed now! VLC and SMPlayer still unnecessarily download the URL locally like Totem does, but the large video file does at least open now when accesses from the non-FUSE location in Dolphin.

This seems like the best solution. From what I understand, not sending the credentials is a security feature, so doing it via KIOFuse is unavoidable

Dec 1 2019, 6:54 PM · Frameworks
feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

@ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the application being started, and the application, if it supports gvfs, re-translates that into a URL and uses that instead if it makes more sense. This way "dumb" apps get a local file (with all the limitations of doing synchronous I/O over the network) and network-transparent applications use URLs.
On the other hand, the KDE logic is "if the app takes %f and not %u in the Exec line, it doesn't support remote URLs, so we need to download the file first" (that's done by kioexec). If you see a "download first" check if kioexec is running. But if it's the app doing it, then I have no idea.

kioexec is not running during any of these lengthy downloads. Totem, VLC, and SMplayer all have %U in their desktop files, FWIW.

We may want to rethink this logic anyway. Any app that doesn't integrate with ioslaves should get the FUSE path rather than a locally-downloaded file, irrespective of whether or not its desktop file has %f or %u IMO. There are just too many disadvantages to the locally downloaded file approach, which is why we're doing this FUSE thing in the first place.

Perhaps the "lengthy local download first" issue is caused by not having https://invent.kde.org/kde/kio-fuse/merge_requests/2 yet.

Dec 1 2019, 6:49 PM · Frameworks
feverfew added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

This isn't reaching KIOFuse at all. I believe this is related to this bug and that you've also blogged about:
https://bugs.kde.org/show_bug.cgi?id=330192
https://pointieststick.com/2018/01/17/videos-on-samba-shares/

This can be solved in this patch (and I did, although I removed it at Harald's request). I think I'll move it back in, and will leave it if it does solve this issue for you.

Great! Once it's back in, I'll re-test that.

Updated the diff. give it a go...
Also I assume that if it does work for you it resolves 330192?

Dec 1 2019, 12:25 PM · Frameworks
feverfew updated the diff for D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
  • Get rid of unnecessary copying of URLs
  • Switch to interface generated at compile time
  • Delete unused interfaces
  • Merge branch 'master' into arcpatch-D23384
  • remove kiofuseinterface from build
  • Align arguments
  • Only send original URLs to non-KIO apps if authority is empty
Dec 1 2019, 12:13 PM · Frameworks
feverfew reopened D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Dec 1 2019, 12:13 PM · Frameworks
feverfew committed R241:51af997d7ed4: Align arguments (authored by feverfew).
Align arguments
Dec 1 2019, 12:04 PM
feverfew committed R241:ce78a65e9c79: Only send original URLs to non-KIO apps if authority is empty (authored by feverfew).
Only send original URLs to non-KIO apps if authority is empty
Dec 1 2019, 12:04 PM