Feed Advanced Search

Yesterday

feverfew added a comment to T11619: Window Activation.

@davidedmundson would be happy to work on this. Do you have the URL to the proposal on the mailing list?

Sat, Sep 14, 9:32 PM · Plasma on Wayland

Wed, Sep 11

feverfew added a comment to T11599: KUserFeedback integration.

There is a BoF on this!

Wed, Sep 11, 7:31 AM · Dolphin
feverfew accepted D23860: DolphinTabWidget: cleanup index-by-URL API usage.

Assuming it's tested LGTM.

Wed, Sep 11, 7:30 AM · Dolphin

Mon, Sep 2

feverfew added a comment to D23672: Making sure that DBus objects are all created before the service.

Go for it ;)

Mon, Sep 2, 8:35 PM · Dolphin
feverfew updated the diff for D23655: Fixing bugs in new folders in tabs feature.

Simplifying getIndexByUrl function

Mon, Sep 2, 8:29 PM · Dolphin
feverfew added inline comments to D23672: Making sure that DBus objects are all created before the service.
Mon, Sep 2, 8:08 PM · Dolphin
feverfew updated the test plan for D23672: Making sure that DBus objects are all created before the service.
Mon, Sep 2, 11:24 AM · Dolphin
feverfew added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

@ngraham I believe if you rebase on D23672 then the FIXME is solved. I also believe that dolphinInstanceData() should have an empty QString() in your case. I've tested your patch with an empty QString() and it worked, it might not work with what you currently have...

Mon, Sep 2, 11:08 AM · Dolphin
feverfew updated the summary of D23655: Fixing bugs in new folders in tabs feature.
Mon, Sep 2, 11:04 AM · Dolphin
feverfew updated the test plan for D23655: Fixing bugs in new folders in tabs feature.
Mon, Sep 2, 11:03 AM · Dolphin
feverfew updated the diff for D23655: Fixing bugs in new folders in tabs feature.
  • Revert "Fixing bugs in new folders in tabs feature"
Mon, Sep 2, 11:02 AM · Dolphin
feverfew requested review of D23672: Making sure that DBus objects are all created before the service.
Mon, Sep 2, 11:00 AM · Dolphin
feverfew added a comment to D23655: Fixing bugs in new folders in tabs feature.

@ngraham I believe the diff in src/main.cpp may help with the speed issues in D11382. Haven't checked though...

Mon, Sep 2, 12:04 AM · Dolphin
feverfew requested review of D23655: Fixing bugs in new folders in tabs feature.
Mon, Sep 2, 12:01 AM · Dolphin

Fri, Aug 30

feverfew committed R320:7ffa4f8e99de: Merge branch 'Applications/19.08' (authored by feverfew).
Merge branch 'Applications/19.08'
Fri, Aug 30, 9:28 AM
feverfew committed R320:28fdc41f1d45: Fixing implementation of FileJob interface in smb/sftp slaves (authored by feverfew).
Fixing implementation of FileJob interface in smb/sftp slaves
Fri, Aug 30, 9:25 AM
feverfew closed D23207: Fixing implementation of FileJob interface in smb/sftp slaves.
Fri, Aug 30, 9:25 AM · Frameworks, Dolphin
feverfew closed D23194: Making FileJob behave consistently..
Fri, Aug 30, 9:18 AM · Frameworks
feverfew committed R241:3154fc3e096e: Making FileJob behave consistently. (authored by feverfew).
Making FileJob behave consistently.
Fri, Aug 30, 9:18 AM

Tue, Aug 27

feverfew added a comment to D23207: Fixing implementation of FileJob interface in smb/sftp slaves.

Not knowing the background here at a glance I would argue that SlaveBase in KIO should be getting state verification on all of this,.

Tue, Aug 27, 3:18 PM · Frameworks, Dolphin

Mon, Aug 26

feverfew added reviewers for D23207: Fixing implementation of FileJob interface in smb/sftp slaves: sitter, dfaure.
Mon, Aug 26, 5:03 PM · Frameworks, Dolphin
feverfew updated the diff for D23194: Making FileJob behave consistently..
  • Removing flush on write
Mon, Aug 26, 2:43 PM · Frameworks
feverfew updated the diff for D23194: Making FileJob behave consistently..
  • Fixing typos
  • Adding test for reading of 0 bytes and asserting that the close signal is

actually emitted.

Mon, Aug 26, 2:36 PM · Frameworks

Sun, Aug 25

feverfew added inline comments to D23194: Making FileJob behave consistently..
Sun, Aug 25, 8:11 PM · Frameworks
feverfew requested review of D23454: Fixing bug where MTP slave does not return error in stat()/mimetype().
Sun, Aug 25, 7:47 PM · Frameworks, Dolphin
feverfew added a comment to D23445: Fixing bug where split view opens with no URLs.

Will do.

I thought all GSoC students needed to have commit access though? Please apply. https://community.kde.org/Infrastructure/Get_a_Developer_Account
Sun, Aug 25, 4:39 PM · Dolphin
feverfew added a comment to D23445: Fixing bug where split view opens with no URLs.

Thanks for the quick fix. Stable branch please!

Sun, Aug 25, 4:33 PM · Dolphin
feverfew requested review of D23445: Fixing bug where split view opens with no URLs.
Sun, Aug 25, 4:21 PM · Dolphin
feverfew added a comment to D21691: Open new instance of Dolphin if no URLs are given.

Go ahead, I'm sure you can fix it in no time.

Sun, Aug 25, 4:08 PM · Dolphin

Fri, Aug 23

ngraham awarded D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO a Mountain of Wealth token.
Fri, Aug 23, 9:26 PM · Frameworks
feverfew requested review of D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Fri, Aug 23, 6:09 PM · Frameworks

Wed, Aug 21

feverfew added a comment to D22708: [WIP] Add a kded module infra for fuse mount services.

Also feel free to pop by #kde-fm for discussions or if you want to ask a question.

It kicks me out for not having a registered nickname even though I totally do and am using it. If it's not necessary anymore, it might be nice to remove that restriction.

Wed, Aug 21, 5:44 PM · Frameworks
feverfew added a comment to D22708: [WIP] Add a kded module infra for fuse mount services.

Oh good. :) Is there anywhere I can follow the progress?

Wed, Aug 21, 5:40 PM · Frameworks
feverfew added a comment to D22708: [WIP] Add a kded module infra for fuse mount services.

What?

Wed, Aug 21, 5:35 PM · Frameworks

Mon, Aug 19

feverfew updated the diff for D23194: Making FileJob behave consistently..

Making comments clearer

Mon, Aug 19, 3:55 PM · Frameworks
feverfew added inline comments to D11382: Add an option to show tabs from last time when Dolphin starts.
Mon, Aug 19, 10:46 AM · Dolphin
feverfew added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

This is ready for re-review, with one specific thing I could use help debugging: when you enable the new option, launching Dolphin and opening new windows becomes interminably slow, probably due to some extra DBus overhead that's still a bit beyond my comprehension. See the FIXME in the code.

Mon, Aug 19, 12:19 AM · Dolphin

Fri, Aug 16

feverfew added inline comments to D23194: Making FileJob behave consistently..
Fri, Aug 16, 5:47 PM · Frameworks
feverfew added inline comments to D23194: Making FileJob behave consistently..
Fri, Aug 16, 5:44 PM · Frameworks
feverfew updated the diff for D23207: Fixing implementation of FileJob interface in smb/sftp slaves.

Unnecessary min version upgraded

Fri, Aug 16, 5:11 PM · Frameworks, Dolphin
feverfew added reviewers for D23207: Fixing implementation of FileJob interface in smb/sftp slaves: chinmoyr, fvogt.
Fri, Aug 16, 5:07 PM · Frameworks, Dolphin
feverfew requested review of D23207: Fixing implementation of FileJob interface in smb/sftp slaves.
Fri, Aug 16, 5:02 PM · Frameworks, Dolphin
feverfew added inline comments to D23194: Making FileJob behave consistently..
Fri, Aug 16, 3:48 PM · Frameworks

Aug 16 2019

feverfew added inline comments to D23194: Making FileJob behave consistently..
Aug 16 2019, 1:37 PM · Frameworks
feverfew updated the diff for D23194: Making FileJob behave consistently..

Addressing comments

Aug 16 2019, 1:33 PM · Frameworks

Aug 15 2019

feverfew updated the summary of D23194: Making FileJob behave consistently..
Aug 15 2019, 9:40 PM · Frameworks
feverfew updated the summary of D23194: Making FileJob behave consistently..
Aug 15 2019, 9:10 PM · Frameworks
feverfew requested review of D23194: Making FileJob behave consistently..
Aug 15 2019, 9:09 PM · Frameworks
feverfew abandoned D23159: Prevent error() being emitted when purposefully reading 0 bytes.
Aug 15 2019, 7:15 PM · Frameworks
feverfew added inline comments to D23159: Prevent error() being emitted when purposefully reading 0 bytes.
Aug 15 2019, 6:53 PM · Frameworks
feverfew added inline comments to D23159: Prevent error() being emitted when purposefully reading 0 bytes.
Aug 15 2019, 12:35 AM · Frameworks

Aug 14 2019

feverfew requested review of D23159: Prevent error() being emitted when purposefully reading 0 bytes.
Aug 14 2019, 6:15 PM · Frameworks

Aug 11 2019

feverfew accepted D23087: Do not match daemonized dolphin instances: part 2.

Can't test, but looks sane to me. I have a small comment, but can be left for later if time is of the essence.

Aug 11 2019, 11:02 AM · Dolphin

Jul 18 2019

feverfew added a comment to T11117: KDE is All About the Apps.

Also would like to see a push for advertising KDE Apps on Windows and Mac OS, where possible. This will bring us a wider audience, and can even help switch people to Linux.

Jul 18 2019, 2:20 PM · Goal Setting 2019

Jul 16 2019

feverfew added a comment to T11074: Make KDE more Accessible for Everybody.

I also believe T11093 can tie very well with this and T11080. If we brainstorm properly we can standardise certain widgets such that many goals are met at once, with a decreased maintenance burden for everyone involved.

Jul 16 2019, 1:26 PM · Goal Setting 2019

Jul 15 2019

feverfew awarded T11093: Improve Consistency across the Board a Like token.
Jul 15 2019, 2:49 PM · Consistency, Goal Setting 2019

Jul 14 2019

feverfew added a comment to T11074: Make KDE more Accessible for Everybody.

Note that this goal is necessary for T11080 to succeed. It's quite common in a lot of companies/governments that they make suitable provisions for those with disabilities, where possible.

Jul 14 2019, 10:45 AM · Goal Setting 2019

Jun 25 2019

feverfew added a comment to D21736: Adding option to open externally called folder in a new tab.

Thanks, the issue is fixed now. I could not find any other behavioral regressions, and I've verified that the new feature behaves correctly. The code looks good to me too!

Next, do you think you could work on https://bugs.kde.org/show_bug.cgi?id=408919?

Jun 25 2019, 11:11 AM · Dolphin

Jun 23 2019

cfeck awarded D21736: Adding option to open externally called folder in a new tab a Like token.
Jun 23 2019, 11:28 AM · Dolphin
feverfew updated the diff for D21736: Adding option to open externally called folder in a new tab.

Rebasing onto master

Jun 23 2019, 11:04 AM · Dolphin
feverfew updated the diff for D21736: Adding option to open externally called folder in a new tab.
  • Simplifying option
  • Fixing regression
Jun 23 2019, 11:01 AM · Dolphin
feverfew added a comment to D21736: Adding option to open externally called folder in a new tab.

Nope, same behavior after a rebase on current master.

Be careful when you say nope/yes ;) was very confused if you meant rebasing it solved it or not.

Oh gosh, I'm sorry. I'm too tired for this right now and need to go to bed.

So for example if you open a jpg, and ask to open in containing folder it'll reopen in gwenview and also be selected in Dolphin?

Almost. Here's a video that shows the issue (with apologies to @broulik):

Jun 23 2019, 10:36 AM · Dolphin
feverfew updated the diff for D21736: Adding option to open externally called folder in a new tab.
  • Fixing regression
Jun 23 2019, 10:35 AM · Dolphin

Jun 22 2019

feverfew added a comment to D21736: Adding option to open externally called folder in a new tab.

Nope, same behavior after a rebase on current master.

Jun 22 2019, 11:36 PM · Dolphin
feverfew added a comment to D21736: Adding option to open externally called folder in a new tab.

Ran into an interesting bug with this. With the feature turned off, using the "Open Containing Folder" feature in many KDE apps causes a new Dolphin window to open with the path of the file itself, not its containing folder. As a result, the file gets opened a second time.

With the feature turned on, everything works properly and the file's containing folder is opened in a new tab in the running Dolphin instance

Jun 22 2019, 6:35 PM · Dolphin
feverfew added a comment to D21691: Open new instance of Dolphin if no URLs are given.

@elvisangelaccio note I can't actually commit this as I don't have commit access.

Jun 22 2019, 1:22 PM · Dolphin

Jun 17 2019

feverfew added inline comments to D21736: Adding option to open externally called folder in a new tab.
Jun 17 2019, 11:25 AM · Dolphin
feverfew updated the diff for D21736: Adding option to open externally called folder in a new tab.
  • Simplifying option
Jun 17 2019, 11:24 AM · Dolphin
feverfew updated the diff for D21691: Open new instance of Dolphin if no URLs are given.
  • Making comment clearer
Jun 17 2019, 11:20 AM · Dolphin

Jun 15 2019

feverfew added a comment to D21736: Adding option to open externally called folder in a new tab.

Thanks! Will review once the feature in and of itself works reliably enough for me to test it in various use cases; first I'd like to see https://bugs.kde.org/show_bug.cgi?id=408244 and https://bugs.kde.org/show_bug.cgi?id=408387 fixed.

Jun 15 2019, 9:04 PM · Dolphin

Jun 10 2019

feverfew requested review of D21736: Adding option to open externally called folder in a new tab.
Jun 10 2019, 8:13 PM · Dolphin

Jun 9 2019

feverfew updated the diff for D21691: Open new instance of Dolphin if no URLs are given.

Fix identation

Jun 9 2019, 1:05 PM · Dolphin
feverfew added a reviewer for D21691: Open new instance of Dolphin if no URLs are given: ngraham.
Jun 9 2019, 1:04 PM · Dolphin
feverfew requested review of D21691: Open new instance of Dolphin if no URLs are given.
Jun 9 2019, 12:59 PM · Dolphin
feverfew accepted D21666: Do not match daemonized dolphin instances.
Jun 9 2019, 11:25 AM · Dolphin

May 29 2019

feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Removing trailing whitespace
May 29 2019, 9:41 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Removing trailing whitespace
May 29 2019, 9:37 PM · Dolphin

May 28 2019

feverfew added a comment to D16648: Open externally called files/directories in new tabs.

Tested also on gnome, window activation works fine also there.

@feverfew Do you have commit access?

May 28 2019, 10:25 PM · Dolphin

May 27 2019

feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Implementing code review suggestion
May 27 2019, 11:26 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Adding fallback to always opening new window if running in Wayland session
May 27 2019, 11:22 PM · Dolphin

May 24 2019

feverfew added inline comments to D16648: Open externally called files/directories in new tabs.
May 24 2019, 6:03 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Coding style change
May 24 2019, 6:02 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Simplifying conditional
May 24 2019, 5:56 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Styling fixes
May 24 2019, 5:53 PM · Dolphin

May 23 2019

feverfew added inline comments to D16648: Open externally called files/directories in new tabs.
May 23 2019, 10:54 AM · Dolphin

May 21 2019

feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Addressing code review comments
  • Adding back macro
  • Allow window activation without forceActiveWindow()
  • Avoiding duplication of tabs
  • Distributing URLs among all instances
  • Making ShowFolders/ShowItems also check if URLs are open in other tabs
  • Ensuring current instance is considered when needed
  • Removing unnecessary include
  • Overloading openFiles/openDirectories
  • Removing unnecessary new line
  • Amend test
  • Fixing header file
May 21 2019, 11:12 PM · Dolphin
feverfew updated subscribers of D16648: Open externally called files/directories in new tabs.

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.

Not quite sure whether Qt supports that, but you could overload the methods of MainWindow so that the slots accept a QStringList and just pass it on.

May 21 2019, 5:45 PM · Dolphin
feverfew added a comment to D16648: Open externally called files/directories in new tabs.

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

May 21 2019, 1:48 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Removing unnecessary include
May 21 2019, 11:38 AM · Dolphin
feverfew updated the summary of D16648: Open externally called files/directories in new tabs.
May 21 2019, 11:31 AM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Allow window activation without forceActiveWindow()
  • Avoiding duplication of tabs
  • Distributing URLs among all instances
  • Making ShowFolders/ShowItems also check if URLs are open in other tabs
  • Ensuring current instance is considered when needed
May 21 2019, 11:28 AM · Dolphin

Apr 24 2019

feverfew added a comment to D16648: Open externally called files/directories in new tabs.

activateWindow works if and only if your X startup info is correct.

When you launch dolphin through a UI (on gnome or Plasma) you will see an extra environment variable on your dolphin process.

DESKTOP_STARTUP_ID=David-Desktop;1555336591;362121;16299_TIME219914845

Qt normally handles this internally.

If you then call into an existing dolphin you need to pass this and import it the other side before calling window->activate().
See KStartupInfo or QX11Extras::setAppTime

Plasma isn't really involved.

Apr 24 2019, 1:37 PM · Dolphin

Apr 15 2019

feverfew added a comment to D16648: Open externally called files/directories in new tabs.

This made me think: what about non-plasma systems?
e.g. GNOME doesn't even have a taskbar, what's gonna happen there?

Apr 15 2019, 12:07 PM · Dolphin

Apr 13 2019

feverfew added inline comments to D16648: Open externally called files/directories in new tabs.
Apr 13 2019, 9:40 AM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Adding back macro
Apr 13 2019, 9:33 AM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Addressing code review comments
Apr 13 2019, 9:31 AM · Dolphin

Mar 27 2019

feverfew added a comment to T10263: FUSE daemon for accessing KIO Slaves.

@feverfew Sure! I don't know much about GSoC though, I hope that's not an issue.

@fvogt Great, I can tell you more about it on a platform of your choice. What's your preferred method of contact (.e.g email) so we can get a project submitted (deadline is 9th April)?

E-Mail is fine - you can use the one here on phab.

Mar 27 2019, 9:43 PM

Mar 26 2019

feverfew added a comment to D16648: Open externally called files/directories in new tabs.

Also, can you please update the Summary and the Test Plan? We should remove mentions of the option (which we dropped) and we should use FEATURE: instead of BUG:.

Mar 26 2019, 11:24 PM · Dolphin
feverfew updated the test plan for D16648: Open externally called files/directories in new tabs.
Mar 26 2019, 11:23 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Merge branch 'master' into arcpatch-D16648
Mar 26 2019, 11:21 PM · Dolphin