I think it is undesireable to change the default, because all users are now used to having it PlainText, so they are now dumping things-that-looks-like-html into it and expecting it to be plaintext.

Looks good to me. I haven't tested that the tool and the generated output matches, but I trust volker in that.

In D14529#302624, @aacid wrote:

Ok, second option, we are actually installing these files ourselves, right?

yesplease.

In D14885#310496, @mlaurent wrote:

+2 for me too
but "Add a couple of alternative keys" where do you find theses infos ?
Could you add it in a readme for example ?

In D14832#309209, @vkrause wrote:

+2 assuming this isn't still included by any depending modules

Improve deprecation documentation

In D14565#302581, @cfeck wrote:

In D14565#302551, @safaalfulaij wrote:

Maybe you should use largeValue instead of largevalue.

Yes, that would be consistent with what we do elsewhere.

s/largevalue/largeValue/

After reading my kcontacts code, the file and the file generated from countrieslistcldr.git's generate app, besides the fact that the file is 10 times bigger because 10 times as much data, there might be an issue that in the "original" file, it seems to be english first, then other languages, for each country. I haven't reproduced that part of it.

Note that I'm not a maintainer, so feel free to ignore.

• a/src/extractorengine.cpp

+++ b/src/extractorengine.cpp
@@ -145,7 +145,11 @@ QString BarcodeJsApi::decodePdf417(const QVariant &img) const

      tf.rotate(-90);
     image = image.transformed(tf);
}

• return BarcodeDecoder::decodePdf417(image);

+ QString value = BarcodeDecoder::decodePdf417(image);
+ if (!value.isEmpty()) {
+ return value;
+ }
+ return BarcodeDecoder::decodePdf417(image.mirrored(false,true));

}
return {};

}

Check width/height for rotating rather than having the user do it.

duplicate.

Better handling of custom path to CMakeLists

1. The current code only works if discount is installed into existing locations (discount_INCLUDE_DIR is never used), and as a user of the FindPackage, you don't have to care about the include directory. It comes from the target.
2. The whole thing with targets vs variables: if you link against a double colon target, it fails at cmake time if something is wrong. If something is wrong with the variable, it fails at link time. E.g. trying to link discard::Lib fails at cmake time, linking ${discard_LIBRARIES} gives a link error.

Add spaces around if.

It is not a quest to make qrc work. it is just a "don't crash if such a thing is received". Will add some spaces.

Fix review comments

A quick review of some quirks and weirdnesses in c++

I am a bit unsure if this is the right approach. I can still be convinced both ways.

@mlaurent : I would love to add it to stable and not to master, since next frameworks release might trigger these issues, and that's coming out before 18:04

Thanks. The ability to cleanly do something like that was one of the reasons for the api changes I did between qt4 and qt5.