This task can be closed I think, as it was redesigned with 5.19

Happy that this will land pretty soon!

I commented on D25343 about this. Also note the following inline comment. If we decide on (really) "OutQuad" for slide-in and "InQuad" (or "OutQuad" in code), we just need to adjust L467. Maybe we should also add a comment at L506 that the easing curve will be reversed.

As mentioned in D18000 I think the following two things should be adjusted. I think it is more natural that way.

In D18000#587121, @ngraham wrote:

But InQuad for animating from invisible to visible is what we do in other places and it's what we're planning to formalize in D25343. Shouldn't we be consistent?

Video of what I mean

WAIT. The slide-in animation is choppy, as we are using InQuad. This means it starts smooth and ends linear. IMO it should be the other way around. Start linear, end smooth.

👍

In D18000#582786, @ngraham wrote:

Would you like me to take over this if you're lacking the time?

Couldn't find time for this either. I will probably start working on this again, when my development environment is set up again.

In D13243#572829, @ngraham wrote:

@sefaeyeoglu what do you think about the above? ^^

Ping!

In D24407#544728, @ngraham wrote:

I had a feeling. I say let's land this, then fix that. Do you agree?

In D24407#544715, @ngraham wrote:

In D24407#544714, @sefaeyeoglu wrote:

In D24407#544707, @ngraham wrote:

That should be fixed by D24402, in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

Sorry that I didn't really make it obvious what I was referring to. For some reason I can check multiple PA sources as default. Sinks on the other hand behave as they should and change their checked state.

P.S. I am master of all repos right now (using kdesrc-build)

How strange. Is that a pre-existing problem, or was it introduced by this patch?

In D24407#544707, @ngraham wrote:

That should be fixed by D24402, in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

Nice work! It looks very good now.

In D24161#538988, @ngraham wrote:

Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port devices, show the port chooser combobox instead of the name of the current port, in both the KCM and the applet. There's guaranteed to be enough room (we'd be replacing a string with the same string in a combobox). Then remove the "Ports" items in the applet's hamburger menu.

Oh and I just noticed a regression I didn't see before landing the patch, sorry. :/ The icons no longer match between the KCM and the applet when I add an external bluetooth device:

In D24161#538988, @ngraham wrote:

Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port devices, show the port chooser combobox instead of the name of the current port, in both the KCM and the applet. There's guaranteed to be enough room (we'd be replacing a string with the same string in a combobox). Then remove the "Ports" items in the applet's hamburger menu.

Oh and I just noticed a regression I didn't see before landing the patch, sorry. :/ The icons no longer match between the KCM and the applet when I add an external bluetooth device:

Change behaviour of configuration.

I think Nate's idea on how to display this in the applet config is better. Will do that instead

Put checkbox into own category

Align mute button centered with slider

Fix wrong display name of default-device button

In D13243#538519, @davidedmundson wrote:

What's the use case?

In D24161#538429, @ngraham wrote:

I love it, and the code changes look sane to me.

Plasma folks or @drosca, any objections?

Add copyright header

Rebase onto master

In D13243#538434, @ngraham wrote:

Yikes, looks like this never went anywhere. :/

Can you rebase it?

Make icon full height for playback devices, too

Right! I completely forgot about that. Will work on it

Remove stepping again, change label text of port selection

Remove redundant whitespace from copyright header

Use QQC2 ToolButton instead of Button for Mute. Add stepping to volume slider, similar to applet.

Import QtQuick.Controls as QQC2 and fix ToolTip delay

Set domain for all i18n strings

In D24161#536408, @GB_2 wrote:

Please add reviewers and subscribers next time.

We should definitely define how the easing curves should look. Generally I think we should always use some kind of decelerating, but not accelerating, easing for appear animations and accelerating, but not decelerating, for disappear animations. We could look at Material design and specifically on how they are doing easing: https://material.io/design/motion/speed.html#easing.

Fix wrong opacity condition for vertical popups

Fix syntax error

Tidy up code

I recently set up a proper working environment again and started tinkering with different easings and slide-lengths. I decided to make a compromise between the old animation and the one I proposed before.

Compomise between old behaviour and my proposal. Now uses fixed slideLength again, but with different easing.

There are probably people, who would still prefer different titlebar colors from the rest of the window. Therefore I'd add a "Breeze Dark Classic" color scheme to @filipf's proposal, that uses the same titlebar color as "Breeze Classic".
Also why are there different text colors between current Breeze Classic and current Breeze Light?

I can only speak from experience. I don't know if there are any scientific studies that look at user experience with a focus of animation.

I don't really think that it looks that different than other animations. If one gets used to it it isn't that strange anymore.

In D18000#387577, @abetts wrote:

Do you have a before and after gif or video?

In D18000#387618, @zzag wrote:

I tested this patch. In general, it doesn't feel consistent with other animations. I suggest to open a new task regarding easing curves before actually changing them.

In D18000#387577, @abetts wrote:

Do you have a before and after gif or video?

I just added the if statement back (but keeping the interpolate). It actually looks better now!

Change opacity for custom slideLengths only

Restore support for custom slideLength

I personally feel, that timing functions for things appearing should not accelerate, but rather only decelerate.
I am often designing things with influences from different design guidelines, but when it comes to animation I often look at the Material Design Guidelines, as I think that Material Design animations feel natural. They have a section about things appearing and disappearing here. Therefore I chose decelerating/accelerating timing functions.

I thought this is about controlling the system volume and not the media player volume :/

Is this still relevant? As far as I can tell album art and position is not supported with all MPRIS media players.

Can someone benchmark this? Would be nice to know how much this affects performance.

I tried to implement this feature, but I can't seem to get the DropArea working. Could it be possible that PlasmoidViewer does not support drag 'n' drop? It always appears as an icon inside the PlasmoidViewer similar to FolderView on the normal desktop.