I dont know if have any vote right but if i had my vote goes to "master"
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Nov 25 2022
Aug 24 2021
This one needs an extra step which also needs to be removed from kdesrc-build's kf5-extragear-build-include file
May 19 2021
May 16 2021
I think this forgotten to be closed after 4 years :)
Oct 13 2020
@ngraham pong :) sorry i have completely forgotten this after invent migration. On the other hand i have just changed my harddrive to ssd and planing to install my kde dev system tonight or morning.
After than that i will first check @elvisangelaccio 's suggestion and then move this one into invent and make mr in there
Sep 10 2020
Jun 7 2020
In D29847#674807, @adridg wrote:https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes
There's already a CMake-time check for <crypt.h>, it's just not used. (HAVE_CRYPT_H)
or if this is just for linux think we can make it just directly
if defined(Q_OS_LINUX)
Sorry i have written one of them twice , so is this aproach wrong ?
#if !defined(Q_OS_UNIX) && !defined(Q_OS_BSD4) && !defined(Q_OS_FREEBSD) && !defined(Q_OS_NETBSD) && !defined(Q_OS_OPENBSD)
Apr 1 2020
is there a KDE policy about usage of qCWarning( , qCDebug( ?
Because afaik debug one can be ignored by system and some of those might be important to show to user to see
So for example this one looks like a warning instead of a debug info for me ( but not sure what your opinions are) :
qCDebug(KIO_FILE) << "libc failed to extract list of xattr from file";
or this one :
qCDebug(KIO_FILE) << "cant copy Extended attributes";
other than those for me it looks ok
Mar 31 2020
I still need to learn how to use arc land properly
Mar 29 2020
Mar 24 2020
Not just include problem but also got a problem about new Qt version :
Mar 19 2020
Mar 15 2020
Mar 2 2020
Mar 1 2020
i will try to dig in a little more tonight when i return back to house
btw if needed i can send a screen record about this
In D27736#620341, @birkhoff wrote:On my Arch virtual machine, if I have the terminal open when ejecting an optical disc (working directory in the disc), dolphin doesn't do anything. It probably returned too early or m_deviceToTearDown is falsely set to nullptr for some reason.
Could anyone commit it for me because i didnt make my setup on my box yet. ( planing yo switch to a new laptop thus didnt setup my current git configuration yet ( certificates) )
Feb 29 2020
Feb 26 2020
Freebsd side broken again :
00:31:45 ./build/icons-dark/generated/devices/24/network-wired-activated.svg:14: parser error : Opening and ending tag mismatch: g line 8 and svg
00:31:45 </svg>
00:31:45 ^
00:31:45 ./build/icons-dark/generated/devices/24/network-wired-activated.svg:15: parser error : EndTag: '</' not found
00:31:45
00:31:45 ^
00:31:45 gmake[2]: * [CMakeFiles/breeze-validate-svg.dir/build.make:57: CMakeFiles/breeze-validate-svg] Error 1
00:31:45 gmake[1]: * [CMakeFiles/Makefile2:213: CMakeFiles/breeze-validate-svg.dir/all] Error 2
00:31:45 gmake[1]: *** Waiting for unfinished jobs....
Feb 25 2020
Feb 23 2020
2 Question :
1- isnt that method should be const'ified ?
2- also its name will be much better isIgnoreableMountPoint (or something can be more understandable
that it will just return true or false ) becase right now it looks like
"ignore that mount point"
Feb 14 2020
isnt this also needs #include <QLocale>
Feb 11 2020
Oct 3 2019
Aug 10 2019
In D22976#509675, @aacid wrote:And what are you or ben waiting for? You've both got commit access :)
@aacid:
;) in here we are in sacrifice feast , and i dont have my laptop with me ( sorry about that )
ben mentioned that this also needs to be cherrypicked to stable branch too.
Jul 24 2019
Because i was away for a short vacation i coudnt commit this one but
@dfaure committed same thing :) with 0c5430697bdcf41a45046107b28014e40c49a11a
So i think we need to discard this review
Jul 19 2019
i will just commit this to master or do i need to xommit to a branch then merge it to master ? (i have been away from kde about more then 6 years)
Jul 18 2019
Jul 10 2019
In D22319#493318, @mpyne wrote:Change is good to commit. Please let me know if you're not able to commit and I can on your behalf.
Jul 8 2019
libassuan-devel for gpgme
hmm also texinfo is missing for libgpg-error
Jun 20 2019
In D21919#482275, @ngraham wrote:Maybe we should also consider renaming the KCM to be "Gaming Controller" since I don't know how many people are actually using standalone joysticks anymore. I remember that those were all the rage in the 90s, but probably these days people are just using their XBox controllers or whatever.
Nov 2 2017
Oct 17 2017
Jul 15 2017
Oct 16 2016
In line 57 QCoreApplication -> QGuiApplication