Doesn't seem to be relevant anymore.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
May 3 2023
Aug 19 2022
Aug 29 2021
In D18758#678707, @apol wrote:Let's abandon it, I'd be wary of bringing in such a big dependency into our codebase just like that.
Aug 26 2021
So, do we want to get this in?
Mar 31 2021
Mark the revision as closed to reflect reality.
Mar 2 2021
In D17816#677446, @kdudka wrote:I was wondering why copying files in Krusader or Dolphin from a vfat-formatted memory card stopped working for me after update. After copying the first file, the transfer stopped progressing and the process ended up consuming 100% CPU forever. Later I discovered that the cause of the breakage was this patch: If fgetxattr() fails with ENOTSUP, the code loops indefinitely calling fgetxattr().
The following hotfix made copying of files in Krusader work again for me:
...However, the code might need bigger changes to cover all the cases. I do not fully understand the (IMO over-complicated) loops around flistxattr() and fgetxattr(). Note that the fact that one of them uses while (true) { ... } whereas the other one uses do { ... } while (true) does not improve code readability either.
Nov 17 2020
Oct 30 2020
Oct 29 2020
- Put FileProtocol::copyXattrs inside a #if
Oct 19 2020
AFAIK, Phabricator is being retired in favor of GitLab. Why not create an issue there? https://invent.kde.org/kdevelop/kdevelop/-/issues
Oct 17 2020
Another bump.
Sep 21 2020
- Address comments.
Sep 17 2020
- More const QString.
Sep 10 2020
- Make checkXattrFsSupport accept directory as a parameter.
- Consitify QStrings.
Sep 6 2020
- Return "true" if the file doesn't have any xattrs.
Aug 25 2020
Bump.
Jul 30 2020
Rebase on master.
Jun 30 2020
- Remove extraneous debugging output.
Jun 29 2020
- Handle attrs with empty values.
- Add test for it.
- Fix syscalls for FreeBSD case.
Jun 23 2020
- Improve comment.
Jun 20 2020
- Rebase on master.
Jun 3 2020
I'd appreciate if someone test this on Linux and MacOS. I got FreeBSD covered.
- Address comments.
Jun 2 2020
Almost every comment have been addressed. Please, give this another look.
- Address comments.
Jun 1 2020
- Change the algorithm in FileProtocol::copyXattrs()
May 27 2020
Mark stale command as done.
- Use std::function to store a generator function for m_setXattrCmd's arguments.
May 24 2020
- Refactor common code from compareXattr() into readXattr() as requested in comments.
May 19 2020
- Use full paths to command line utilities and pass xattr args correctly.
- Mark some stale comments as done.
May 17 2020
- Fix tests on FreeBSD.
- Fix bug: Move keylist.squeeze() call before acquiring an interator.
May 15 2020
I decided to help with this a bit.
May 9 2020
Apr 15 2020
In T12977#226721, @adridg wrote:If I mount the CD (e.g. by "make accessible from other applications") and then press the physical eject button (no applications are open on that mount), it does not eject. The disk stays mounted. I honestly don't know what behavior I expect, though.
Mar 16 2020
Mar 13 2020
Feb 26 2020
Feb 23 2020
Feb 12 2020
Oct 2 2019
Sep 27 2019
Sep 26 2019
Jul 20 2019
I'm not familiar with KDE release engineering, so I'm asking to do merging someone else.
In D22525#498393, @dfaure wrote:I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc.
So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries have a different meaning, one that we can't know client-side).
Jul 19 2019
In D22525#497556, @cfeck wrote:Oh, if the latter syntax also works, then you are right.
Jul 18 2019
In D22525#497332, @cfeck wrote:Could we only apply the :xx check on the filename part, not on the server part? Someone might expect that http://path.to/file.txt:99 also works for remote files.
Jul 10 2019
Jul 9 2019
Jun 18 2019
In D18758#481339, @mwolff wrote:so, I've now committed an alternative fix (or so I hope...) see:
commit bd048e67f056b5be25ed57fb2be947444f68c24e Author: Milian Wolff <mail@milianw.de> Date: Mon Jun 17 22:26:32 2019 +0200 Guard against crashes when IStatus object gets destroyed at bad times
Jun 10 2019
Now the test passes!
In D20967#477314, @bruns wrote:Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code?
It compiles now, but the test fails:
May 28 2019
In D18758#469623, @apol wrote:Quite possibly, it doesn't happen outside of tests after all, right?
May 24 2019
I'm more interested in fixing the intial issue. With KIO jobs in openProject turned async, the crash now happens right in qWait(1) of KDevelop::TestCore::shutdown(). And what's strange is that adding qWait(1) at the end of testReload() test still fixes issue.
May 21 2019
Changes:
- Import QtPromise 0.5.0 into kdevplatform/3dparty/ directory.
- Remove synchronious KIO calls from Project::open() and use QPromises there instead.
May 7 2019
- Use compiler executable name instead of absolute path.
May 6 2019
- Address some comments.
May 2 2019
This commit introduced a crash in some tests on FreeBSD. The m_listing mutex gets locked twice by the same thread causing deadlock exception.
Apr 13 2019
In D18758#449319, @mwolff wrote:Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?
Apr 11 2019
Apr 10 2019
Address comments.
Apr 9 2019
In D18296#445829, @dfaure wrote:Is the makeURL function still used, or should it be removed now?
Apr 6 2019
In D18296#444642, @elvisangelaccio wrote:Is it really necessary to copy urlinfo.h here? Wouldn't be enough to just create a static function and put the URL parsing logic there?
@thomassc it is because I commandeered your revision to be able to update it. If you want, you do the same. First select "Commandeer Revision" at the bottom of this page, and then use arc diff (possibly with --update D18567) to update it.
Apr 5 2019
Simplify code.