Feed Advanced Search

May 25 2019

heikobecker committed R493:ffa5d6321d1a: Fully qualify signal argument (authored by heikobecker).
Fully qualify signal argument
May 25 2019, 8:56 AM
heikobecker committed R493:e5474935d950: Avoid detaching temporary containers (authored by heikobecker).
Avoid detaching temporary containers
May 25 2019, 8:56 AM
heikobecker committed R493:a7d258942344: Don't include <QtModule/QHeader> (authored by heikobecker).
Don't include <QtModule/QHeader>
May 25 2019, 8:56 AM
heikobecker committed R493:8e2849f5f357: Move const to proper place (authored by heikobecker).
Move const to proper place
May 25 2019, 8:56 AM
heikobecker committed R493:77838d8f13c5: Make constructors which can be called with 1 argument explicit (authored by heikobecker).
Make constructors which can be called with 1 argument explicit
May 25 2019, 8:56 AM
heikobecker committed R493:116af2010321: Use single quotes for single chars (authored by heikobecker).
Use single quotes for single chars
May 25 2019, 8:56 AM

May 22 2019

heikobecker committed R493:8cfcfb9001c3: Use Q_OBJECT for QObject derived classes (authored by heikobecker).
Use Q_OBJECT for QObject derived classes
May 22 2019, 8:43 PM
heikobecker committed R493:9b54ebb78472: Use QLatin1String with startsWith/endWiths (authored by heikobecker).
Use QLatin1String with startsWith/endWiths
May 22 2019, 8:43 PM
heikobecker committed R493:32294409b177: Make comparison operator const (authored by heikobecker).
Make comparison operator const
May 22 2019, 8:43 PM
heikobecker committed R493:92c0c7b07a58: Use QString::clear() instead of assigning QString::null (authored by heikobecker).
Use QString::clear() instead of assigning QString::null
May 22 2019, 8:43 PM
heikobecker committed R493:6deb14bd3d5d: Use QString::remove instead of replace (authored by heikobecker).
Use QString::remove instead of replace
May 22 2019, 8:43 PM
heikobecker committed R493:ef65d19b17a6: Fix includes (authored by heikobecker).
Fix includes
May 22 2019, 8:43 PM
heikobecker committed R493:febf7e238d98: Use single quotes for single chars (authored by heikobecker).
Use single quotes for single chars
May 22 2019, 8:43 PM

May 11 2019

heikobecker committed R404:704e91530bef: Drop unused kmines.notifyrc (authored by heikobecker).
Drop unused kmines.notifyrc
May 11 2019, 10:22 AM
heikobecker closed D21130: Drop unused kmines.notifyrc.
May 11 2019, 10:22 AM

May 10 2019

heikobecker committed R404:1622b734ca20: Add .arcconfig (authored by heikobecker).
Add .arcconfig
May 10 2019, 8:58 PM
heikobecker requested review of D21130: Drop unused kmines.notifyrc.
May 10 2019, 2:54 PM
heikobecker closed D21129: Require KF5 5.58.0 like the rest of Plasma.
May 10 2019, 2:37 PM · Plasma
heikobecker committed R114:2a2e73781481: Require KF5 5.58.0 like the rest of Plasma (authored by heikobecker).
Require KF5 5.58.0 like the rest of Plasma
May 10 2019, 2:37 PM
heikobecker requested review of D21129: Require KF5 5.58.0 like the rest of Plasma.
May 10 2019, 2:33 PM · Plasma
heikobecker committed R201:8accd831a5ab: Merge remote-tracking branch 'origin/Applications/19.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/19.04'
May 10 2019, 11:44 AM
heikobecker committed R201:34d4b059cd09: Add DesktopEntry to notifyrc (authored by heikobecker).
Add DesktopEntry to notifyrc
May 10 2019, 11:44 AM
heikobecker closed D21117: Add DesktopEntry to notifyrc.
May 10 2019, 11:44 AM · KDE PIM
heikobecker requested review of D21117: Add DesktopEntry to notifyrc.
May 10 2019, 10:21 AM · KDE PIM
heikobecker committed R181:fc370bbebf79: Set urgency to Low for track changes (authored by heikobecker).
Set urgency to Low for track changes
May 10 2019, 10:16 AM
heikobecker committed R181:14ddd1fb2ddd: Add DesktopEntry to notifyrc (authored by heikobecker).
Add DesktopEntry to notifyrc
May 10 2019, 10:16 AM

Apr 29 2019

heikobecker committed R99:fd2f3be36bd5: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Apr 29 2019, 6:40 PM

Apr 28 2019

heikobecker added a comment to D20874: Match test not run due to executable not found to jenkins <failure>.

Mind going into the background of how CTest can setup a test but not know how to find the binary?

Apr 28 2019, 8:19 AM

Apr 18 2019

heikobecker committed R467:e03e65378a93: Merge remote-tracking branch 'origin/Applications/19.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 18 2019, 1:18 PM
heikobecker committed R467:eb117b98a107: Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set (authored by heikobecker).
Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set
Apr 18 2019, 1:17 PM
heikobecker closed D20662: Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set.
Apr 18 2019, 1:17 PM
heikobecker updated the diff for D20662: Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set.

Fixed the commit which introduced the newer ECM requirement

Apr 18 2019, 1:16 PM
heikobecker added reviewers for D20662: Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set: kossebau, dfaure.
Apr 18 2019, 1:10 PM
heikobecker requested review of D20662: Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set.
Apr 18 2019, 1:08 PM

Apr 13 2019

heikobecker added a comment to D20488: Fix build with poppler <0.58.

Thanks for landing.

Apr 13 2019, 8:18 AM · Okular

Apr 12 2019

heikobecker requested review of D20488: Fix build with poppler <0.58.
Apr 12 2019, 11:31 AM · Okular

Mar 28 2019

heikobecker added a comment to D20061: Avoid tiny cards on high screen resolutions.

Can't really say anything about the maximum number, but cards are indeed not tiny anymore on my ~170 DPI display (probably rather low HiDPI)

Mar 28 2019, 6:29 PM

Mar 26 2019

heikobecker requested review of D20067: Use QTEST_GUILESS_MAIN.
Mar 26 2019, 7:06 PM · Konsole

Mar 25 2019

heikobecker committed R349:78ccb5126aef: Merge remote-tracking branch 'origin/Applications/19.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/19.04'
Mar 25 2019, 7:50 AM
heikobecker committed R349:5a510ea08f84: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Mar 25 2019, 7:49 AM
heikobecker committed R349:4e68e2ac2426: Define _BSD_SOURCE for strdup and timerclear (authored by heikobecker).
Define _BSD_SOURCE for strdup and timerclear
Mar 25 2019, 7:48 AM
heikobecker committed R349:be0c18843c44: Include <strings.h> for strcasecmp (authored by heikobecker).
Include <strings.h> for strcasecmp
Mar 25 2019, 7:48 AM
heikobecker closed D19615: Define _BSD_SOURCE for strdup and timerclear.
Mar 25 2019, 7:47 AM
heikobecker committed R349:c7f9a029ab76: Define _BSD_SOURCE for strdup and timerclear (authored by heikobecker).
Define _BSD_SOURCE for strdup and timerclear
Mar 25 2019, 7:47 AM
heikobecker committed R349:ff7d456bca5c: Include <strings.h> for strcasecmp (authored by heikobecker).
Include <strings.h> for strcasecmp
Mar 25 2019, 7:47 AM
heikobecker closed D19614: Include <strings.h> for strcasecmp.
Mar 25 2019, 7:47 AM

Mar 23 2019

heikobecker committed R546:39772585033c: tests: Fix build with Qt 5.13 (authored by heikobecker).
tests: Fix build with Qt 5.13
Mar 23 2019, 12:40 AM

Mar 21 2019

heikobecker committed R361:1ad912d02310: Merge remote-tracking branch 'origin/Applications/19.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/19.04'
Mar 21 2019, 9:53 PM
heikobecker committed R361:3e6ea0c66386: Don't implicitly require KF5 5.57.0 (authored by heikobecker).
Don't implicitly require KF5 5.57.0
Mar 21 2019, 9:51 PM
heikobecker committed R364:d4c7c90e74e5: Only add_definitions in one place (authored by heikobecker).
Only add_definitions in one place
Mar 21 2019, 9:45 PM
heikobecker added a comment to D19920: Add High DPI support.

Also tiny for me.

Mar 21 2019, 9:43 PM

Mar 10 2019

heikobecker committed R732:27313664cbee: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Mar 10 2019, 7:14 PM
heikobecker committed R732:99681cc0675a: Add COPYING file (authored by heikobecker).
Add COPYING file
Mar 10 2019, 7:13 PM
heikobecker closed D19649: Add COPYING file.
Mar 10 2019, 7:13 PM
heikobecker requested review of D19649: Add COPYING file.
Mar 10 2019, 9:33 AM
heikobecker committed R732:977264f52d82: Silence CMake policy CMP0063 warning (authored by heikobecker).
Silence CMake policy CMP0063 warning
Mar 10 2019, 9:21 AM

Mar 8 2019

heikobecker added a reviewer for D19614: Include <strings.h> for strcasecmp: mpyne.
Mar 8 2019, 3:56 PM
heikobecker added a reviewer for D19615: Define _BSD_SOURCE for strdup and timerclear: mpyne.
Mar 8 2019, 3:56 PM
heikobecker requested review of D19615: Define _BSD_SOURCE for strdup and timerclear.
Mar 8 2019, 3:53 PM
heikobecker requested review of D19614: Include <strings.h> for strcasecmp.
Mar 8 2019, 3:51 PM

Mar 6 2019

heikobecker added a reviewer for D19401: LONG_LONG_MAX is an obsolete GNU name for LLONG_MAX: mutlaqja.
Mar 6 2019, 7:56 PM · KDE Edu
heikobecker committed R364:9b11312c9e17: Revert "Make it compile without foreach" (authored by heikobecker).
Revert "Make it compile without foreach"
Mar 6 2019, 2:56 PM
heikobecker added a reverting change for R364:b29fc1f7bd4c: Make it compile without foreach: R364:9b11312c9e17: Revert "Make it compile without foreach".
Mar 6 2019, 2:56 PM

Feb 27 2019

heikobecker requested review of D19401: LONG_LONG_MAX is an obsolete GNU name for LLONG_MAX.
Feb 27 2019, 10:26 PM · KDE Edu

Feb 13 2019

heikobecker requested review of D18983: Use the python version found by cmake in build_theme.sh.
Feb 13 2019, 4:04 PM · Plasma

Feb 11 2019

heikobecker committed R8:f43cb54c71d7: Use check_symbol_exists instead of check_function_exists (authored by heikobecker).
Use check_symbol_exists instead of check_function_exists
Feb 11 2019, 12:26 PM
heikobecker closed D18866: Use check_symbol_exists instead of check_function_exists.
Feb 11 2019, 12:26 PM · Calligra: 3.0

Feb 10 2019

heikobecker updated the diff for D18866: Use check_symbol_exists instead of check_function_exists.

Added missing "h". Thanks for noticing that.

Feb 10 2019, 11:20 AM · Calligra: 3.0
heikobecker added a comment to D18866: Use check_symbol_exists instead of check_function_exists.

What about the other ​check_function_exists, should they also be changed?

Feb 10 2019, 11:08 AM · Calligra: 3.0
heikobecker updated the diff for D18866: Use check_symbol_exists instead of check_function_exists.

Replaced other check_function_exists invocations

Feb 10 2019, 11:04 AM · Calligra: 3.0
heikobecker committed R352:eef034d3efbf: Merge remote-tracking branch 'origin/Applications/18.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.12'
Feb 10 2019, 10:26 AM
heikobecker committed R352:8df422b10b50: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Feb 10 2019, 10:22 AM
heikobecker committed R352:70fa1a80ce05: Don't include <fstab.h> anymore (authored by heikobecker).
Don't include <fstab.h> anymore
Feb 10 2019, 10:21 AM
heikobecker closed D18780: Don't include <fstab.h> anymore.
Feb 10 2019, 10:21 AM

Feb 8 2019

heikobecker requested review of D18866: Use check_symbol_exists instead of check_function_exists.
Feb 8 2019, 9:39 PM · Calligra: 3.0

Feb 6 2019

heikobecker requested review of D18780: Don't include <fstab.h> anymore.
Feb 6 2019, 8:53 AM

Feb 2 2019

heikobecker accepted D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.

Thanks!

Feb 2 2019, 9:01 PM
heikobecker accepted D18674: Add missing QStandardPaths to fix build.

Yeah, that didn't happen for me as well, but QSP is actually used (line 75).

Feb 2 2019, 8:49 PM

Jan 25 2019

heikobecker committed R224:fab782d91c62: Use KAboutData to set information about the daemon (authored by heikobecker).
Use KAboutData to set information about the daemon
Jan 25 2019, 11:02 PM
heikobecker closed D18542: Use KAboutData to set information about the daemon.
Jan 25 2019, 11:02 PM · KDE Connect
heikobecker added a comment to D18542: Use KAboutData to set information about the daemon.

Didn't add any copyright information or any author because I just didn't know who to put there.

Jan 25 2019, 10:03 PM · KDE Connect
heikobecker requested review of D18542: Use KAboutData to set information about the daemon.
Jan 25 2019, 10:00 PM · KDE Connect

Jan 18 2019

heikobecker committed R115:a629c6257ff5: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 2:38 PM
heikobecker committed R115:89992d14d696: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 2:37 PM
heikobecker closed D18363: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 2:37 PM · Plasma
heikobecker committed R120:27385ba173cf: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 2:36 PM
heikobecker committed R120:129dfcfd69d6: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 2:36 PM
heikobecker closed D18362: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 2:36 PM · Plasma
heikobecker committed R119:9e9ca8828c87: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 2:34 PM
heikobecker committed R119:779854fa6431: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 2:33 PM
heikobecker closed D18360: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 2:33 PM · Plasma
heikobecker committed R116:33a817ebd6d9: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 1:51 PM
heikobecker committed R116:7793c31e0132: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 1:51 PM
heikobecker closed D18364: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:51 PM · Plasma
heikobecker committed R108:ad5700b8123e: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 1:50 PM
heikobecker closed D18359: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:49 PM · KWin
heikobecker committed R108:79eeea6b5822: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 1:49 PM
heikobecker requested review of D18364: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:27 PM · Plasma
heikobecker requested review of D18363: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:27 PM · Plasma
heikobecker requested review of D18362: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:23 PM · Plasma