Python3 still can't be used after this change: python2 is explicitely required at FindPythonModuleGeneration.cmake:177 (and all subsequent calls to sip_generator.py are done with ${GPB_PYTHON2_COMMAND}). This can be adjusted in another review though.

Escape semicolon

In D14962#312931, @sirgienko wrote:

Hi, @arojas
First, Thanks!
Second, I couldn't found julia 1.0.0. As I see, there are problems with JULIA_LIBDL_COMMAND: cmake drop ; symbol (I don't see the symbol in message output).
I add escaping for this symbol (\) and all start works fine.
Do you haven't problem with version 1.0.0?

Use correct version

Fix indentation

Use QT_VERSION_CHECK macro

In D14945#311947, @filipesaraiva wrote:

Thanks @arojas, do you know if this change break the compatibility with previous versions of Sage?

This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead?

In D12761#309635, @asturmlechner wrote:

ping, is this ready to merge?

Thanks

Fix build with older sip

I just tested on Neon Dev with PyQt 5.11 and python plugins build and work fine

In D14182#293778, @rempt wrote:

Hm, I'm afraid it doesn't work for me on Neon 18.04:

Remove space after '-n', apparently sip doesn't like it

New patch at https://phabricator.kde.org/D14182

In D14061#293606, @rempt wrote:

Argh... I guess the only thing I can do now is add a manual override cmake flag.

No idea about this error (the location of the QtCore/QtCoremod.sip hasn't changed in 5.11 so it should be found as before, and in any case it should be unrelated to this patch).

This has been approved for two weeks and fixes a major issue... could the fix be pushed and then keep working on the auto test later? It already missed 5.48

8ee0958ae632e49773b79f837daaf40305777d06 is still wrong: ${PYQT5_VERSION} is the alphanumeric version string, it can't be compared with 5.11.0. Either

We are comparing string-formatted versions, so you should use STRGREATER, not VERSION_GREATER. Otherwise this will give unexpected results: on my system the if() evalulates to false even though I have PyQt 5.11, and in the appimage it seems to evaluate to TRUE with PyQt 5.9.

Oh, STRGREATER_EQUAL requires cmake 3.7. If can be safely changed to STRGREATER, since PYQt 5.11.0 was withdrawn upstream so no distro shound be using it.

I do, just let me know what's the preferred merge workflow: push to 4.1 then merge to master or push to master and cherry-pick in 4.1?

In D13967#290458, @nicolasfella wrote:

Thanks! The purpose part is already released, so I guess the second case will only be relevant for people who self-compile KDE Connect with an older Purpose version.

Sure it will, at least in all packaging systems I know of. The issue here is the time between one update and the other one, when there would be two plugins (if purpose is updated first) or none (if kdeconnect is updated first). I'd suggest to bump KF5_MIN_VERSION to 5.48 to at least prevent the latter.

In D14005#289515, @sirgienko wrote:

As I see, this code don't need, because sage understand foo? and ?foo as help request, so we don't need change foo? and ?foo to help(foo) command. And this also make the source code command (foo??) working.