There are similar uses in knotes, korganizer, kdepim-runtime and kdepim-addons. If this is approved, is it OK to commit similar fixes to those without review?

Merged in aad5c77d029e7fae354a298b57e1af3b3ac9447d

Shouldn't this come with a kconf_update script? Already existing icons will not be fixed by this, since they use a copy of the desktop file in .local/share/plamsa_icons

In D7999#158351, @arojas wrote:

Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to this change (and should be properly fixed instead of worked around here IMO)

Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to this change (and should be properly fixed instead of worked around here IMO)

Committed in e4bd62964198cea6cb1ac24d8a5200556186edc1

In D8259#154575, @lueck wrote:

why not use KDE_INSTALL_METAINFODIR?

Ping. Would be nice to get this in 5.11 to reduce environment noise.

Actually I can't reproduce the QQC1 crashes anymore, even with QT_QUICK_CONTROLS_1_STYLE set to Desktop

In D7953#148962, @fvogt wrote:

This is not as clear as it could be. What about just not setting QT_QUICK_CONTROLS_1_STYLE in the first place?
QT_QUICK_CONTROLS_1_STYLE is only necessary because of QT_QUICK_CONTROLS_STYLE.

Superseded by D7953

so is this OK for 5.11?

Opened D7953 for the QQuickStyle approach. Keeping this open in case the new dependency is not acceptable for 5.11 at this stage.

Indeed, replacing the qputenv line with QQuickStyle::setStyle(QLatin1String("org.kde.desktop")) fixes the inheritance problem: minuet doesn't crash anymore and systemsettings is correctly themed. Unfortunately QQC1 (such as kalgebramobile) still crash, is there something equivalent for QQC1?

In D7943#148121, @davidedmundson wrote:

Revert what?

This change would also fix the crashes if the style was set in startkde as it used to, does it make sense to revert the change or you prefer to leave it where it is?

In D7943#148093, @davidedmundson wrote:

I don't see why we should be unsetting anything if a user has explicitly gone out of their way to set it.

We're not doing it from startkde anymore.

In D6665#141883, @aacid wrote:

So archlinux is using https://git.archlinux.org/svntogit/packages.git/tree/trunk/kdelibs4support-openssl-1.1.patch?h=packages/kdelibs4support

@arojas why did you guys not try to contribute that?

No idea if it can be used to at least compare your version with theirs to see how "good" it is.

In D7588#141262, @ltoscano wrote:

I tested it with the older libqalculate, and the linking works as well. Let's go for it; is it for Applications/17.08 as you did with other similar commits?

In D7588#141259, @ltoscano wrote:

Shouldn't also the following line be changed (step/CMakeLists.txt)?

set(qalculate_LIBS ${QALCULATE_LIBRARIES} ${CLN_LIBRARIES})

I understand that CLN_LIBRARIES would be empty, so maybe it's not a real issue

Fix build without libqalculate

Fix build without libqalculate

In D6826#128634, @wbauer wrote:

Hm, doesn't build here:

[ 28%] Building CXX object CMakeFiles/kfloppy.dir/floppy.cpp.o
In file included from /usr/include/kcompletion.h:26:0,
                 from /usr/include/kcombobox.h:27,
                 from /home/wolfi/projects/KFloppy/floppy.cpp:48:
/usr/include/kshortcut.h: In function 'uint qHash(const KShortcut&)':
/usr/include/kshortcut.h:248:34: error: call of overloaded 'qHash(int)' is ambiguous
     return qHash(key.primary()[0]) + qHash(key.primary()[1]);
                                  ^

In D6827#127516, @aacid wrote:

Is commented out, do you have time to read the git log to figure out if it is commented because of porting issues or because it is a feature that was never finished?

Only comment it out, the code using it is still there