Feed Advanced Search

Aug 16 2018

rkflx closed D14846: Polish Reduce Red Eye UI.
Aug 16 2018, 7:52 PM
rkflx updated the diff for D14846: Polish Reduce Red Eye UI.
  • rebase
  • use QStringLiteral
Aug 16 2018, 7:50 PM
rkflx updated the summary of D14846: Polish Reduce Red Eye UI.
Aug 16 2018, 7:50 PM
rkflx added a comment to D14846: Polish Reduce Red Eye UI.

Thanks for the review. I have more small patches like that slowly making it through the pipeline, I hope you don't mind me requesting yet another review every other day ;) (Still fighting with the cursor issues though, sorry for the wait in that Diff of yours…)

Aug 16 2018, 7:49 PM
rkflx added a comment to D14869: [RFC] Increase default font sizes by 1 pt.

@ngraham I've got a couple of questions regarding your RFC:

Aug 16 2018, 7:41 AM · Plasma

Aug 15 2018

rkflx added a comment to D14700: Bump QT_MIN_VERSION and KF5_MIN_VERSION.

(I'll clean up the #ifdefs separately, mainly asking for general consensus for the version bump here.)

Aug 15 2018, 10:54 PM
rkflx committed R260:2f18ec3383a2: Remove obsolete version checks (authored by rkflx).
Remove obsolete version checks
Aug 15 2018, 10:53 PM

Aug 14 2018

rkflx added a comment to T9273: Announcement text for the Applications 18.08 release.

Thanks! I added the context menu back, cleaned up the blur and most importantly redacted the window title :)

Aug 14 2018, 10:44 PM · KDE Promo, KDE Applications
rkflx added a comment to T9273: Announcement text for the Applications 18.08 release.

(You might want to use Rectangular Region, because none of the other modes can capture both a shadow and a context menu at the same time. It's a bug in Spectacle, I actually had to GIMP the screenshot for Gwenview…)

Aug 14 2018, 10:24 PM · KDE Promo, KDE Applications
rkflx added a comment to T9273: Announcement text for the Applications 18.08 release.

I can try, the problem is that I need to blur most of it since that's full of my folders/emails, I don't have a clean demo setup handy.

Aug 14 2018, 10:06 PM · KDE Promo, KDE Applications
rkflx committed R260:4545e1f99093: Allow to double-click to accelerate crop and red-eye modifications (authored by rkflx).
Allow to double-click to accelerate crop and red-eye modifications
Aug 14 2018, 8:50 PM
rkflx closed D14755: Allow to double-click to accelerate crop and red-eye modifications.
Aug 14 2018, 8:50 PM
rkflx updated the diff for D14755: Allow to double-click to accelerate crop and red-eye modifications.

confirm -> correct

Aug 14 2018, 8:45 PM
rkflx updated subscribers of T9273: Announcement text for the Applications 18.08 release.

KMail, KDE's powerful email client, features some improvements in the travel data extraction engine. It now supports UIC 918.3 and SNCF train ticket barcodes and Wikidata-powered train station location lookup. Support for multi-traveler itineraries was added, and KMail now has integration with the KDE Itinerary app.

Aug 14 2018, 7:20 PM · KDE Promo, KDE Applications
rkflx added a comment to T9273: Announcement text for the Applications 18.08 release.

@cfeck Sorry for not providing screenshots earlier. Was just about to capture some when I noticed your commit.

Aug 14 2018, 7:19 PM · KDE Promo, KDE Applications
rkflx requested review of D14846: Polish Reduce Red Eye UI.
Aug 14 2018, 4:06 PM
rkflx updated the diff for D14755: Allow to double-click to accelerate crop and red-eye modifications.
  • Update wording with my suggestion from yesterday.
  • Remove empty line.
Aug 14 2018, 4:01 PM

Aug 13 2018

rkflx committed R260:cdd75b6c1e16: Bump QT_MIN_VERSION and KF5_MIN_VERSION (authored by rkflx).
Bump QT_MIN_VERSION and KF5_MIN_VERSION
Aug 13 2018, 8:36 PM
rkflx closed D14700: Bump QT_MIN_VERSION and KF5_MIN_VERSION.
Aug 13 2018, 8:36 PM
rkflx added a comment to D14700: Bump QT_MIN_VERSION and KF5_MIN_VERSION.

Distros that are still shipping very old versions of Qt aren't going to be shipping bleeding-edge versions of Gwenview--or KDE Applications more generally.

Aug 13 2018, 8:35 PM
rkflx added inline comments to D14755: Allow to double-click to accelerate crop and red-eye modifications.
Aug 13 2018, 8:35 PM
rkflx added a comment to D14755: Allow to double-click to accelerate crop and red-eye modifications.

Looks good to me. Works as stated and I can't find any issues, also zooming by Ctrl+DoubleClick still works.

Aug 13 2018, 11:19 AM
rkflx added a comment to T9358: "External" tagging for gwenview.

Hi, thanks for reaching out.

Aug 13 2018, 10:46 AM · KPhotoAlbum, Gwenview

Aug 12 2018

rkflx added a comment to T9273: Announcement text for the Applications 18.08 release.
In T9273#153875, @cfeck wrote:

If more time is needed for the text, I can commit it Friday night.

Aug 12 2018, 7:20 AM · KDE Promo, KDE Applications
rkflx added a comment to D13344: Add possibility to sort by rating.

@faridb Are you still around?

Aug 12 2018, 7:16 AM
rkflx committed R166:c20367043a2b: Merge remote-tracking branch 'origin/Applications/18.08' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 12 2018, 6:33 AM
rkflx committed R166:6eebb57e6e1f: Fix missing notification title found by -Wswitch-enum (authored by rkflx).
Fix missing notification title found by -Wswitch-enum
Aug 12 2018, 6:32 AM
rkflx closed D14716: Fix missing notification title found by -Wswitch-enum.
Aug 12 2018, 6:32 AM
rkflx added a comment to D14755: Allow to double-click to accelerate crop and red-eye modifications.

(I'm aware that the size slider for Reduce Red Eye now is quite long. There will be a follow-up fixing that along with a bunch of other issues.)

Aug 12 2018, 6:28 AM
rkflx requested review of D14755: Allow to double-click to accelerate crop and red-eye modifications.
Aug 12 2018, 6:27 AM

Aug 11 2018

rkflx committed R166:45d34b0ae5d4: Fix -Wswitch-default warnings (authored by rkflx).
Fix -Wswitch-default warnings
Aug 11 2018, 10:58 PM

Aug 10 2018

rkflx committed R166:982555d911eb: Deduplicate default filename template code (authored by rkflx).
Deduplicate default filename template code
Aug 10 2018, 7:51 PM
rkflx added a commit to T9252: Improve default filename when saving: R166:982555d911eb: Deduplicate default filename template code.
Aug 10 2018, 7:51 PM · Spectacle
rkflx closed D14588: Deduplicate default filename template code.
Aug 10 2018, 7:51 PM
rkflx removed projects from T9273: Announcement text for the Applications 18.08 release: Spectacle, Gwenview.

Thank you everyone who wrote and improved the text! It's in a pretty good state now as far as I could tell when checking thoroughly (at least for the apps that are present in the etherpad, we might want to expand next time…).

Aug 10 2018, 7:40 PM · KDE Promo, KDE Applications
rkflx added a comment to T7927: Fonts “easy mode”.

@progwolff Any comments on the proposal below?

Aug 10 2018, 6:04 PM · VDG, Plasma: KCM Redesign

Aug 9 2018

rkflx committed R166:c15d63d78345: Fix more warnings uncovered by -Wswitch-enum (authored by rkflx).
Fix more warnings uncovered by -Wswitch-enum
Aug 9 2018, 8:21 PM
rkflx requested review of D14716: Fix missing notification title found by -Wswitch-enum.
Aug 9 2018, 8:10 PM
rkflx updated subscribers of D14588: Deduplicate default filename template code.

Anybody else from Spectacle wanna review this, since @ngraham is busy? (When I asked in the task whether to commit directly, the answer was a bit ambiguous…).

Aug 9 2018, 1:13 PM
rkflx accepted D14202: Change default shortcut for "Zoom To Fit" action.

Thanks, works great. Unless @asturmlechner or @kmorwinski find anything wrong with this until Monday, let's land this to the frameworks branch.

Aug 9 2018, 1:12 PM
rkflx accepted D14201: Set system default shortcut Ctrl+0 for "Actual Size" action.

@muhlenpfordt I'd say go ahead with landing (after updating the version). It would be good to still have some testing time before the next Frameworks release.

Aug 9 2018, 1:12 PM · Frameworks
rkflx added a comment to D14700: Bump QT_MIN_VERSION and KF5_MIN_VERSION.

(I'll clean up the #ifdefs separately, mainly asking for general consensus for the version bump here.)

Aug 9 2018, 8:22 AM
rkflx added a comment to T7927: Fonts “easy mode”.

In this mockup, is the bottom section dedicated to choose fonts differently than general but for specific elements, like a titlebar, window, buttons, etc?

Aug 9 2018, 8:19 AM · VDG, Plasma: KCM Redesign
rkflx requested review of D14700: Bump QT_MIN_VERSION and KF5_MIN_VERSION.
Aug 9 2018, 8:19 AM

Aug 8 2018

rkflx committed R260:b883cb894c11: Undo custom support for ccache (authored by rkflx).
Undo custom support for ccache
Aug 8 2018, 11:04 PM
rkflx added a comment to T7927: Fonts “easy mode”.

One more quick idea (have not really thought about it, no final wording etc.):

Aug 8 2018, 9:07 PM · VDG, Plasma: KCM Redesign
rkflx added a comment to T7927: Fonts “easy mode”.

Yes, I had worried about that, but hadn't come up with a solution.

Aug 8 2018, 8:48 PM · VDG, Plasma: KCM Redesign
rkflx added a comment to T7927: Fonts “easy mode”.

Have you thought about how to keep the simple and the advanced tabs in sync, in particular when the user chooses conflicting options in both of them at the same time?

Aug 8 2018, 8:20 PM · VDG, Plasma: KCM Redesign
rkflx accepted D14662: KPropertiesDialog: switch to label in setFileNameReadOnly(true).
Aug 8 2018, 7:55 AM · Frameworks

Aug 7 2018

rkflx added a comment to D14578: Fix video controls volume slider not vertically centered sometimes.

It seems to come from a Phonon::AudioOutput::volumeChanged signal but no idea why this happens only sometimes.

Aug 7 2018, 10:17 PM
rkflx committed R260:a8dcc6cade3c: Deduplicate some conditional branches in RasterImageView (authored by rkflx).
Deduplicate some conditional branches in RasterImageView
Aug 7 2018, 10:14 PM
rkflx added a comment to D14662: KPropertiesDialog: switch to label in setFileNameReadOnly(true).

Thanks for the help. Works great, just one inline question about an edge case (everything else LGTM).

Aug 7 2018, 5:25 PM · Frameworks
rkflx accepted D14512: Make dependency on KActivities optional.

Thanks, LGTM now.

Aug 7 2018, 5:24 PM
rkflx added a comment to D7581: HiDPI Support for Gwenview.

how to handle the freedesktop.org thumbnail caching spec

Aug 7 2018, 5:24 PM · Gwenview

Aug 6 2018

rkflx committed R260:b630e152bb60: Remove no-ops when adjusting URLs (authored by rkflx).
Remove no-ops when adjusting URLs
Aug 6 2018, 9:48 PM
rkflx added a comment to D13901: Touch support for Gwenview.

Are there some quirks we didn't account for when you git checkout a specific revision and build it?

Aug 6 2018, 8:07 PM · Gwenview
rkflx added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

What fullscreen issue?

Aug 6 2018, 8:05 PM · Gwenview
rkflx added a comment to D14610: Use KLineEdit for folder name if folder has write access, else use QLabel.

Hmm, well, for IconApplet's use case

Aug 6 2018, 7:46 PM · Frameworks
rkflx requested changes to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Thanks for the update. This leaves us with the Browse mode and Fullscreen issues.

Aug 6 2018, 7:45 PM · Gwenview
rkflx added inline comments to D14512: Make dependency on KActivities optional.
Aug 6 2018, 7:45 PM
rkflx updated the diff for D14588: Deduplicate default filename template code.
  • Use function instead of static const
Aug 6 2018, 5:54 PM
rkflx updated subscribers of D14583: [MainWindow] Navigate through mouse forward/back buttons.

There are two more problem I noticed, this time in View mode:

  • Repeatedly clicking fast on one of the forward or backward buttons will only change the image for every second click.
  • Doing the same for videos will accidentally trigger fullscreen mode.
Aug 6 2018, 5:53 PM · Gwenview
rkflx requested changes to D7581: HiDPI Support for Gwenview.

Yeah, a lot has happened since last year. After the finishing touches are done, this should be checked carefully again.

Aug 6 2018, 5:53 PM · Gwenview

Aug 5 2018

rkflx committed R260:4655089fc732: Remove extra break statements (authored by rkflx).
Remove extra break statements
Aug 5 2018, 10:54 PM
rkflx added a comment to D14449: Modify device usage information.

+1 for using the same label but putting the information on more than one line like @rkflx suggests.

Aug 5 2018, 10:42 PM · Frameworks
rkflx added a comment to T9250: Revive bug triaging days.
Aug 5 2018, 10:42 PM · Bugsquad
rkflx added a comment to D14449: Modify device usage information.

This comment has been deleted.

Aug 5 2018, 3:03 PM · Frameworks
rkflx requested changes to D14449: Modify device usage information.

Thanks, looking better than before now. There are still some improvements you could make:

  • There is a superfluous space before the comma in the second line.
  • I'd prefer the bar to be a bit wider by default. However, it turns out there is a problem with my original suggestion (see inline comment).
  • The vertical spacing between the first and the second line is too big, it should be the same as for Size:. However, there should still be enough spacing so it also looks good with the Oxygen style. As far as I can see this is an issue with how Breeze renders the KCapacityBar, in particular the bounding rect contains unnecessary margins (+Ctrl-click on it in GammaRay and compare Breeze and Oxygen). Of course that's material for a patch in a different repo, but the "hole" in your current screenshot does not look good (the second line is closer to the bottom than to the first line, which is bad!), and it would be better to fix the problem there before landing the KIO patch.
Aug 5 2018, 12:37 PM · Frameworks
rkflx added a comment to D14610: Use KLineEdit for folder name if folder has write access, else use QLabel.

KPropertiesDialog::setFileNameReadOnly
m_bFromTemplate

Aug 5 2018, 12:37 PM · Frameworks
rkflx added a comment to D14449: Modify device usage information.

Let me plug my suggestion again:

Device capacity: ==----- 24% used of 94.4 Gib
                 22.5 GiB used, 71.9 GiB free

if this design is used , then the capacity bar would look elongated and stretched, which doesn't looks good.

Aug 5 2018, 9:13 AM · Frameworks

Aug 4 2018

rkflx added a comment to D14378: Remove custom icon selection for trash.
In D14378#303463, @pino wrote:

... that change the role I have in this review. Sorry, I will not do that. You have already all the data needed, including the fact that the patch is acked already. Unless you really care about the green tick, just to see that "everybody accepted it".

Aug 4 2018, 10:52 PM · Dolphin
rkflx added a comment to D14610: Use KLineEdit for folder name if folder has write access, else use QLabel.

@shubham Thanks for helping out with T9297!

Aug 4 2018, 10:52 PM · Frameworks
rkflx accepted D14578: Fix video controls volume slider not vertically centered sometimes.

Thanks for the updates, LGTM ;)

Aug 4 2018, 10:51 PM
rkflx committed R260:faa2be4ad6bf: Remove disabled kipi include (authored by rkflx).
Remove disabled kipi include
Aug 4 2018, 10:50 PM

Aug 3 2018

rkflx added a comment to D13901: Touch support for Gwenview.

To properly test whether your patch introduces a regression, you would have to compare Gwenview's behaviour with 2324a8681a44 against that with D13901.

Yep, that's exactly what I did. 2324a8681a44 does not have the bug.

Aug 3 2018, 10:34 PM · Gwenview
rkflx added a comment to D14578: Fix video controls volume slider not vertically centered sometimes.

Initialize HudSlider for video controls after widget is setup

Aug 3 2018, 10:34 PM
rkflx updated the task description for T9252: Improve default filename when saving.
Aug 3 2018, 9:58 PM · Spectacle
rkflx added a revision to T9252: Improve default filename when saving: D14588: Deduplicate default filename template code.
Aug 3 2018, 9:58 PM · Spectacle
rkflx requested review of D14588: Deduplicate default filename template code.
Aug 3 2018, 9:58 PM
rkflx committed R260:2aa2a4e127f4: Remove superfluous Qt version check (authored by rkflx).
Remove superfluous Qt version check
Aug 3 2018, 9:57 PM
rkflx accepted D14578: Fix video controls volume slider not vertically centered sometimes.

Nice! This fixes even the time slider which showed the same issue when trying to open a video with an unsupported codec.

Aug 3 2018, 9:55 PM
rkflx added a comment to D7087: Add "Copy Info" button to the About System KCM.

Happy birthday D7087, you are now 1 year old.

Aug 3 2018, 9:54 PM · Plasma
rkflx added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Yeah, click in Browse window buttons are not handled, it's needed there ?

Aug 3 2018, 5:30 PM · Gwenview
rkflx added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

It works everywhere, i use such a mice for years (more than 5) you miss a lot :)

Aug 3 2018, 5:15 PM · Gwenview
rkflx requested changes to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Okay, seems nobody around here has such a mouse anymore, but I think in View mode this is working fine.

Aug 3 2018, 5:07 PM · Gwenview
rkflx added inline comments to D14583: [MainWindow] Navigate through mouse forward/back buttons.
Aug 3 2018, 4:38 PM · Gwenview
rkflx added inline comments to D14583: [MainWindow] Navigate through mouse forward/back buttons.
Aug 3 2018, 4:31 PM · Gwenview
rkflx requested changes to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Thanks, I'll have to look for such a device. Meanwhile, I've got a couple of inline comments.

Aug 3 2018, 4:24 PM · Gwenview
rkflx added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Thanks for the patch.

Aug 3 2018, 4:06 PM · Gwenview
rkflx added a comment to D13901: Touch support for Gwenview.

after
git checkout 2324a8681a44
and
arc patch D13901
I have found the same issue.

Aug 3 2018, 10:43 AM · Gwenview

Aug 2 2018

rkflx added a comment to D13901: Touch support for Gwenview.

@steffenh, I'm afraid I've found a regression in your patch as compared to git master from the point where you branched (2324a8681a444cd1b9b441e481adb15c09f92837)

Aug 2 2018, 9:32 PM · Gwenview
rkflx committed R166:c7a8e8cafe91: Merge remote-tracking branch 'origin/Applications/18.08' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 2 2018, 11:50 AM
rkflx committed R260:330c6cfa9fae: Merge remote-tracking branch 'origin/Applications/18.08' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 2 2018, 11:45 AM
rkflx committed R260:c61693ccff2b: Disable setImageData for dragging of unmodified images (authored by rkflx).
Disable setImageData for dragging of unmodified images
Aug 2 2018, 11:42 AM
rkflx closed D14543: Disable setImageData for dragging of unmodified images.
Aug 2 2018, 11:42 AM

Aug 1 2018

rkflx committed R260:2d06e2a0efe1: Remove the last reimp markers remaining (authored by rkflx).
Remove the last reimp markers remaining
Aug 1 2018, 9:44 PM
rkflx requested changes to D14512: Make dependency on KActivities optional.

Thanks for the patch.

Aug 1 2018, 9:38 PM
rkflx requested review of D14543: Disable setImageData for dragging of unmodified images.
Aug 1 2018, 9:37 PM
rkflx added a comment to D13249: Refine behaviour for dragging modified images to external applications.

Spectacle seems to have a similiar issue when dragging the screenshot preview to the desktop.

That's interesting, thanks for the hint! I assume you are running Spectacle 17.12, but since Spectacle 18.04 there is D10427, which actually removes setImageData to make it work for Chromium, and apparently also fixes the issue you are reporting when dragging to the desktop.

Correct - I used 17.12.3. Tested with 18.07.80 in a Neon VM does not show this problem (but drop on desktop does nothing).

Aug 1 2018, 9:34 PM
rkflx accepted D9342: Make sure, a newly saved image is selected in ContextManager.

Let's hope for the best ;)

Aug 1 2018, 9:34 PM