In D9342#301811, @muhlenpfordt wrote:

Added modifications from P250 by rkflx

Okay, here's my patch (don't laugh, I know it looks fishy):

Just realized this actually fixes a problem present in KDE 3 already (KDE 2 did not have the second line yet, as far as I could tell in a short but very interesting test).

Drag-and-drop to the Desktop still works

Thanks for investigating!

I knew I came across this link before, and indeed, we have a bug about this: https://bugs.kde.org/show_bug.cgi?id=228934. Quote:

Hi, thanks for your contribution.

Thanks for the patch.

Gwenview, we have a problem:

Short report on this issue: I worked pretty hard on this the last weekend and also the weeks before. Every time I think I got it, there is one minor detail breaking everything again. There must be a way to eliminate mDirListerFinished (and meanwhile I also suspect mUrlToSelect can and should go), however I still have not found it :/

In D14449#300841, @dhaumann wrote:

Device capacity: 94.4 Gib
Device usage:    ==------ 24% full (71.9 GiB free, 22.5 GiB used)

Could you give this a try with screenshot?

In D14449#300327, @ngraham wrote:

Here's another idea for how to express everything while remaining compact in the horizontal dimension:

Device capacity: ====---------- 24% full
                 22.5 GiB used, 71.9 GiB free
                 94.4 Gib total size

In D14449#300086, @ngraham wrote:

Device capacity: 94.4 Gib
Device usage:    ==------ 24% full (71.9 GiB free, 22.5 GiB used)

Awesome. I'll look at it soon (but not sure how much time I can spend during the week, so please bear with me…).

In D14407#299046, @rkflx wrote:

Use "Reduce Red Eye" for now.
I guess "Fix Red Eye" or "Correct Red Eye" would also be fine, I cannot really make up my mind. @ngraham Let me know if you prefer one of those.

Checked this now more thoroughly. There are a couple of unrelated changes that sneaked in, but it's mostly fine I guess.

@lbeltrame fixed it for @mlaurent in 1cab13f0970f – Thanks.

In D14406#298917, @muhlenpfordt wrote:

I tested a couple of situations in crop tool witch your first patch but never noticed the cross hair cursor until you pointed it out.

Use "Reduce Red Eye" for now.

@muhlenpfordt Did you get a notification about my last comment here? If not, perhaps you should consider adding yourself as a "Watcher" of the project…

This breaks the build, please fix: https://build.kde.org/job/Applications%20gwenview%20kf5-qt5%20FreeBSDQt5.10/63/console

I mainly opened this Diff to discuss about the wording of that tool in general. In particular in the sidebar most image operations use the imperative form, only Red Eye Reduction is different. This is relevant not only in the sidebar, but also in the Edit menu and for the accepting button (future patch ;).

I (and the reviewers for D14386) should have grepped for Qt::CrossCursor… Anyway, we catched it in time ;)

Wow, I didn't even know Gwenview did that!

In D14324#298315, @muhlenpfordt wrote:

Found the reason for this. :)
The previous mousePressEvent needs to be accepted somewhere (for zooming in AbstractImageView), otherwise the subsequent mouseReleaseEvent is not triggered.

In D13901#297753, @steffenh wrote:

It sounds a bit strange that setting different keyboard shortcuts for the rotate actions will get it working. Is it possible that you have some kind of global gesture recognizer running in your desktop session, which detects that action and then sends the keyboard shortcut combination to Gwenview?

Yes, I know it is strange. I found this in OpenSuse Leap 15.0 and a fresh KDE Neon 5.13, no global gesture recognizer is running.I found this by accident, I was looking which event I get in the DocumentView::sceneEventFilter with a qDebug()<<event;, to my surprise I found this:

Thanks, can confirm that the issue with doubled resizing is fixed. Accepting for now, even though the code is not the most concise yet.

@steffenh Could you report how touchpad gestures are working for you in Qt's example app (see https://doc.qt.io/qt-5/qtwidgets-gestures-imagegestures-example.html)?

Off you go!

Thanks, this fixes the issue of getting stuck, as well as the minimum size.

Haha, I worked on the same issue, but you catched an earlier time window to post the Diff. Good for you ;) That said, this way I also know exactly where I can break you patch (see inline comment, obviously was also broken in the KDE 4 version).

Thanks! Uses accept and ignore just like I suspected when suggesting this, and works very well for middle click.

LGTM, works great!

Thanks for your support ;)

In T9250#152470, @xyquadrat wrote:

After your research it'd be better to pick another program, but I am not sure which choice would work out well. Do you have an idea for an alternative?

@ngraham Would this patch be something you could back?

In D14284#296439, @steffenh wrote:

Thank you for the help, I have it working now.

Thanks for the initiative, Julian.

In D14284#296276, @steffenh wrote:

I not sure, I have used KDevelop 5.2.3 to get the Gwenview source from git. I make a new branch from master to do my coding and use the run or the debug function from KDevelop to test my work. It should pick up my self-compiled library or not?

In D11203#296151, @kapillamba4 wrote:

In D11203#273352, @rkflx wrote:

Fix "Open" button in screenshot notification not responding to click

I don't really understand how to reproduce the problem from your test plan. Could you add detailed steps to reproduce, so I can check how it works before and after your patch? Ideally in terms of Spectacle's command line arguments, which should be similar to the global shortcuts.

In the first screen recording you can see that open button does not work sometimes, it might be because of QTimer:singleShot

In D11203#296132, @kapillamba4 wrote:

@rkflx i think someone else should take over

In D14284#296087, @steffenh wrote:

display the active image name, if you have more than one image in the view mode

Do you mean that in Compare mode the window title should change when clicking on another image? For me this is already the case without your patch.

Interesting, in KDE Neon 5.13 (Plasma 5.13.2, KDE Framework 5.47.0, Qt 5.11.0) yes it works without my patch. In my working Linux (OpenSuse Leap15.0, Plasma 5.12.5, KDE Framework 5.45.0, Qt 5.9.4) is it doesn't work without my patch.

Bug 378061

Thanks for the review!

Interesting idea ;)

In D11203#273352, @rkflx wrote:

It seems like your patch fixes multiple things, so it would be better if you could split your patch into separate Diffs too (see also https://community.kde.org/Infrastructure/Phabricator#.22Please_do_that_in_a_separate_commit.22).

Refactoring sneak peek (headed for master, will post a Diff once the bug fix landed), which still needs testing and a commit message: P243

Add comment. There is no TODO, because I hope with D12626 we'll still be able to support Qt 5.6.

Thanks for the explanation.

Is there something wrong with our Git branch setup for KDE Applications? Today Scott, Peter and you all had problems with merging stable into master…

Thanks, commit it already ;)

In D14196#294948, @ngraham wrote:

"while dragging selection box" is pretty common and well understood in English.