Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jul 23 2019

shubham committed R16:7af8045f3263: Add unit test for Device (authored by shubham).
Add unit test for Device
Jul 23 2019, 6:30 AM
shubham closed D22629: Add unit test for Device.
Jul 23 2019, 6:30 AM

Jul 22 2019

shubham added a comment to D22629: Add unit test for Device.

@stikonas @cjlcarvalho ping?

Jul 22 2019, 8:14 PM
shubham updated the diff for D22629: Add unit test for Device.

Remove more useless includes

Jul 22 2019, 4:51 AM
shubham updated the diff for D22629: Add unit test for Device.

Remove useless includes

Jul 22 2019, 4:46 AM
shubham updated the diff for D22629: Add unit test for Device.

Check for all the available devices

Jul 22 2019, 4:44 AM

Jul 21 2019

shubham added reviewers for D22629: Add unit test for Device: stikonas, cjlcarvalho.
Jul 21 2019, 7:49 PM
shubham requested review of D22629: Add unit test for Device.
Jul 21 2019, 7:48 PM
shubham committed R119:5a79ff3db16f: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt (authored by shubham).
Remove duplicate occurence of Qt5::DBus in CMakeLists.txt
Jul 21 2019, 5:57 PM
shubham closed D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt.
Jul 21 2019, 5:57 PM · Plasma
shubham added reviewers for D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt: davidedmundson, broulik.
Jul 21 2019, 5:54 PM · Plasma
shubham added a comment to D22588: [Pager] Don't link kdelibs4support.

I have put up a patch to remove duplicate occurrence of DBus here.
https://phabricator.kde.org/D22619

Jul 21 2019, 5:53 PM · Plasma
shubham requested review of D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt.
Jul 21 2019, 5:52 PM · Plasma
shubham added inline comments to D22593: Compile helper into standalone application.
Jul 21 2019, 3:13 PM · KDE Partition Manager

Jul 20 2019

shubham added a comment to D21505: Removing unnecessary ";" that were giving warnings.

@karinapassos Can you commit it yourself?

Jul 20 2019, 7:08 PM
shubham reopened D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 20 2019, 6:53 PM · KDE Partition Manager
shubham added a dependent revision for D22438: Authorize using Polkit backend and compile Helper as standalone application: D22593: Compile helper into standalone application.
Jul 20 2019, 6:50 PM · KDE Partition Manager
shubham added a dependency for D22593: Compile helper into standalone application: D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 20 2019, 6:50 PM · KDE Partition Manager
shubham updated the test plan for D22593: Compile helper into standalone application.
Jul 20 2019, 6:50 PM · KDE Partition Manager
shubham updated the diff for D22593: Compile helper into standalone application.

Diff relative to Polkit backend patch

Jul 20 2019, 6:49 PM · KDE Partition Manager
shubham requested review of D22593: Compile helper into standalone application.
Jul 20 2019, 6:48 PM · KDE Partition Manager
shubham added inline comments to D22588: [Pager] Don't link kdelibs4support.
Jul 20 2019, 3:34 PM · Plasma

Jul 18 2019

shubham closed D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 18 2019, 3:33 PM · KDE Partition Manager
shubham committed R16:fbf8912e0aa9: [WIP]: Authorize using Polkit backend and implement QDBus communication between… (authored by shubham).
[WIP]: Authorize using Polkit backend and implement QDBus communication between…
Jul 18 2019, 3:33 PM
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Add function to revoke authorization

Jul 18 2019, 2:09 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

remove code causing false statement

Jul 18 2019, 7:01 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 18 2019, 6:50 AM · KDE Partition Manager

Jul 16 2019

shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

I have added the action in .rc files still I can not see them added in the menu.

Jul 16 2019, 6:18 AM · Documentation, Dolphin
shubham updated the test plan for D22444: Add Reset Zoom Level action inside View menu.
Jul 16 2019, 6:17 AM · Documentation, Dolphin
shubham updated the diff for D22444: Add Reset Zoom Level action inside View menu.

Add action to View menu

Jul 16 2019, 6:15 AM · Documentation, Dolphin

Jul 15 2019

shubham updated the diff for D22479: Prompt user to save or discard changes.

Remove m_unsavedChange.
Yes, this is copied from dolphin

Jul 15 2019, 6:53 PM · Kate
shubham added reviewers for D22481: Do not show play/pause button when no media is playing: broulik, Plasma, VDG.
Jul 15 2019, 6:47 PM · Plasma
shubham requested review of D22481: Do not show play/pause button when no media is playing.
Jul 15 2019, 6:46 PM · Plasma
shubham added a comment to D22479: Prompt user to save or discard changes.

dolphin 19.07.70
Maybe because I am on KDE neon dev unstable edition

Jul 15 2019, 6:12 PM · Kate
shubham added a comment to D22479: Prompt user to save or discard changes.

It is done in dolphin.

Jul 15 2019, 6:07 PM · Kate
shubham added reviewers for D22479: Prompt user to save or discard changes: cullmann, ngraham.
Jul 15 2019, 6:01 PM · Kate
shubham requested review of D22479: Prompt user to save or discard changes.
Jul 15 2019, 6:01 PM · Kate
shubham added a comment to D22145: Add "Open Containing Folder" feature.

Shouldn't this be below Open Recent?

Jul 15 2019, 5:53 PM · Okular
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Return false when action not authorized

Jul 15 2019, 2:31 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Initialize helper and connect to signals

Jul 15 2019, 2:26 PM · KDE Partition Manager
shubham added inline comments to D22183: Add click to play/pause feature on previews for audio/video.
Jul 15 2019, 8:23 AM · Dolphin
shubham updated the summary of D22444: Add Reset Zoom Level action inside View menu.
Jul 15 2019, 7:54 AM · Documentation, Dolphin
shubham updated the diff for D22444: Add Reset Zoom Level action inside View menu.

Get default icon size
@ngraham Ping

Jul 15 2019, 7:54 AM · Documentation, Dolphin

Jul 14 2019

shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt auth-polkit-backend patch

Jul 14 2019, 4:37 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Do not make virtual function, was just testing

Jul 14 2019, 4:32 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Make functions virtual

Jul 14 2019, 4:04 PM · KDE Partition Manager
shubham updated the summary of D22444: Add Reset Zoom Level action inside View menu.
Jul 14 2019, 3:35 PM · Documentation, Dolphin
shubham added inline comments to D22444: Add Reset Zoom Level action inside View menu.
Jul 14 2019, 3:35 PM · Documentation, Dolphin
shubham retitled D22444: Add Reset Zoom Level action inside View menu from Add zoom reset action to [RFC]: Add zoom reset action.
Jul 14 2019, 3:33 PM · Documentation, Dolphin
shubham updated the diff for D22444: Add Reset Zoom Level action inside View menu.

use default value

Jul 14 2019, 3:33 PM · Documentation, Dolphin

Jul 13 2019

shubham added inline comments to D22444: Add Reset Zoom Level action inside View menu.
Jul 13 2019, 5:58 PM · Documentation, Dolphin
shubham updated the diff for D22444: Add Reset Zoom Level action inside View menu.

Set zoom to 5px

Jul 13 2019, 5:56 PM · Documentation, Dolphin
shubham updated the diff for D22444: Add Reset Zoom Level action inside View menu.

Correct documentation

Jul 13 2019, 5:11 PM · Documentation, Dolphin
shubham updated the diff for D22444: Add Reset Zoom Level action inside View menu.

Add / atend of action name in .rc

Jul 13 2019, 5:09 PM · Documentation, Dolphin
shubham added reviewers for D22444: Add Reset Zoom Level action inside View menu: ngraham, elvisangelaccio.
Jul 13 2019, 5:07 PM · Documentation, Dolphin
shubham requested review of D22444: Add Reset Zoom Level action inside View menu.
Jul 13 2019, 5:06 PM · Documentation, Dolphin
shubham updated the summary of D22321: Add unit test for Polkit backend.
Jul 13 2019, 4:03 PM · KDE Partition Manager
shubham added inline comments to D22321: Add unit test for Polkit backend.
Jul 13 2019, 4:00 PM · KDE Partition Manager
shubham removed a dependent revision for D21970: [WIP]: Implement PolkitQt1 Authorization backend: D22321: Add unit test for Polkit backend.
Jul 13 2019, 3:59 PM · KDE Partition Manager
shubham edited dependencies for D22321: Add unit test for Polkit backend, added: 1; removed: 1.
Jul 13 2019, 3:59 PM · KDE Partition Manager
shubham added a dependent revision for D22438: Authorize using Polkit backend and compile Helper as standalone application: D22321: Add unit test for Polkit backend.
Jul 13 2019, 3:59 PM · KDE Partition Manager
shubham updated the summary of D22321: Add unit test for Polkit backend.
Jul 13 2019, 3:58 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Add QTest to cmake

Jul 13 2019, 3:57 PM · KDE Partition Manager
shubham requested review of D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 13 2019, 2:14 PM · KDE Partition Manager

Jul 12 2019

shubham committed R16:10108e4ee413: a (authored by shubham).
a
Jul 12 2019, 2:39 PM
shubham committed R16:1acb3681e3a9: Merge branches 'auth-polkit' and 'qdbus' into auth-polkit-backend (authored by shubham).
Merge branches 'auth-polkit' and 'qdbus' into auth-polkit-backend
Jul 12 2019, 2:39 PM
shubham closed D21773: [WIP]: QDBus communication from helper towards Application.
Jul 12 2019, 2:39 PM · KDE Partition Manager
shubham committed R16:740df271fb03: [WIP]: QDBus communication from helper towards Application (authored by shubham).
[WIP]: QDBus communication from helper towards Application
Jul 12 2019, 2:39 PM
shubham committed R16:1d341559ceda: [WIP]: Implement PolkitQt1 Authorization backend (authored by shubham).
[WIP]: Implement PolkitQt1 Authorization backend
Jul 12 2019, 8:24 AM
shubham closed D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 8:24 AM · KDE Partition Manager
shubham removed a dependency for D21970: [WIP]: Implement PolkitQt1 Authorization backend: D21773: [WIP]: QDBus communication from helper towards Application.
Jul 12 2019, 8:20 AM · KDE Partition Manager
shubham removed a dependent revision for D21773: [WIP]: QDBus communication from helper towards Application: D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 8:20 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Comment out connects for now

Jul 12 2019, 8:17 AM · KDE Partition Manager
shubham reopened D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 7:07 AM · KDE Partition Manager
shubham committed R16:09fe99e520a6: Revert "Merge branch 'qdbus' into auth-backend" (authored by shubham).
Revert "Merge branch 'qdbus' into auth-backend"
Jul 12 2019, 7:01 AM
shubham added a reverting change for R16:01a840da8b5d: Merge branch 'qdbus' into auth-backend: R16:09fe99e520a6: Revert "Merge branch 'qdbus' into auth-backend".
Jul 12 2019, 7:01 AM
shubham reopened D21773: [WIP]: QDBus communication from helper towards Application.
Jul 12 2019, 6:33 AM · KDE Partition Manager
shubham committed R16:01a840da8b5d: Merge branch 'qdbus' into auth-backend (authored by shubham).
Merge branch 'qdbus' into auth-backend
Jul 12 2019, 6:32 AM
shubham committed R16:202bc48b16a0: [WIP]: Implement PolkitQt1 Authorization backend (authored by shubham).
[WIP]: Implement PolkitQt1 Authorization backend
Jul 12 2019, 6:32 AM
shubham committed R16:e8613fe48a07: [WIP]: QDBus communication from helper towards Application (authored by shubham).
[WIP]: QDBus communication from helper towards Application
Jul 12 2019, 6:32 AM
shubham closed D21773: [WIP]: QDBus communication from helper towards Application.
Jul 12 2019, 6:32 AM · KDE Partition Manager
shubham closed D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 6:32 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Rebase wrt qdbus patch

Jul 12 2019, 6:26 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Comment out connects for now

Jul 12 2019, 6:24 AM · KDE Partition Manager
shubham added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 4:32 AM · KDE Partition Manager

Jul 11 2019

shubham added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 11 2019, 8:58 AM · KDE Partition Manager
shubham added a dependent revision for D21773: [WIP]: QDBus communication from helper towards Application: D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 11 2019, 8:45 AM · KDE Partition Manager
shubham added a dependency for D21970: [WIP]: Implement PolkitQt1 Authorization backend: D21773: [WIP]: QDBus communication from helper towards Application.
Jul 11 2019, 8:45 AM · KDE Partition Manager
shubham updated the summary of D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 11 2019, 8:45 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove KAuth dependence

Jul 11 2019, 8:44 AM · KDE Partition Manager
shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

Remove extra include

Jul 11 2019, 7:37 AM · KDE Partition Manager
shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

include moc

Jul 11 2019, 7:35 AM · KDE Partition Manager
shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

Proper rebase and fix merge conflicts with Polkit backend

Jul 11 2019, 7:18 AM · KDE Partition Manager

Jul 10 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove unnecessary include

Jul 10 2019, 8:05 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Add timer to quit()

Jul 10 2019, 8:03 AM · KDE Partition Manager
shubham added a dependent revision for D21970: [WIP]: Implement PolkitQt1 Authorization backend: D22321: Add unit test for Polkit backend.
Jul 10 2019, 7:21 AM · KDE Partition Manager
shubham added a dependency for D22321: Add unit test for Polkit backend: D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 10 2019, 7:21 AM · KDE Partition Manager
shubham updated the summary of D22321: Add unit test for Polkit backend.
Jul 10 2019, 7:21 AM · KDE Partition Manager

Jul 9 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Now compiles, authorizing using the Polkit backend

Jul 9 2019, 7:42 AM · KDE Partition Manager
shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

cleanup

Jul 9 2019, 6:26 AM · KDE Partition Manager
First
Prev
Next