Abandoned in favour of above comments

In D20109#440244, @stikonas wrote:

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

Move QCA header outside Qt headers

Do not change argument type for percent(KJob*, unsigned long) signal

I did not find any other occurrences of unsigned long long, so probably quint64 is the coding style

Do not delete area

@aacid area is a RegularAreaRect object which is a QRect bounding the selected text. "area" is to be deleted in all the cases except the case in which it is not possible to delete it since "area" will not contain any text in it and hence it will be nullptr. (case: if text is empty string) and hence return is called instead of deleting the "area".

In D18744#437473, @ngraham wrote:

In D18744#437461, @shubham wrote:

Try to fix the crash. I could not test it because for me I could not see the entry added to the menu.

You gotta fix that. :) Try deleting ~/.local/share/kxmlgui5/okular/partrc Does that help?

Try to fix the crash. I could not test it because for me I could not see the entry added to the menu.

@ngraham @aacid Ping?

Remove useless return

In D19008#419058, @shubham wrote:

@drosca I had a look at those and found some python files doing something, still, I can't figure out what I have to do. Can you help a bit?

Make requested changes by Albert and Nate

Rebase on master

Surely I can do that, but currently I am busy with my exams. Give me a week's time.

@aacid Ping?

@aacid @ngraham Is this good to go now?

I will wait for @aacid's review before landing it.

@aacid @ngraham Can you please confirm it now works to your expectations so that I can go ahead pushing this?

remove check for layout Direction

1. Try to fix crash case
2. Improve comment

In D18816#419557, @aacid wrote:

The ping is on your side, you still haven't explained why this is needed and what it fixes

In D18744#419287, @yurchor wrote:

In D18744#419212, @shubham wrote:

@yurchor what about the crash case, is it fixed now?

No. I think that the action should be created in part.cpp, setEnabled(false) by default, then setEnabled(true) in the Part::openFile to avoid the crash.

Regretfully, no function (like isOpened) for setEnabled to connect to.

@yurchor what about the crash case, is it fixed now?

@aacid Do you have anything to say?

@ngraham Any updates?

@ngraham Any updates?

@drosca I had a look at those and found some python files doing something, still, I can't figure out what I have to do. Can you help a bit?

I can't test it since for me, somehow I don't see the action added to the menu.

Enable action for all the modes
Try to fix crash

Ping?

What's the call?

@aacid ping?

In D15742#415891, @ngraham wrote:

Nice job, @shubham. Wanna do the same thing for Okular next? https://bugs.kde.org/show_bug.cgi?id=361756. Probably doesn't need an option there.

Proper rebase on master

@emateli do you know how can I go to previous version I have uploaded?

Yes, noticed, going to fix in a moment

Rebase on master

Changes as requested by ngraham and kurt

How do I resolve this?

Remove shortcut and it's documentation

I think this is going towards being abandoned.

what should I now name the gui message? It will become quite big then.

I can confirm that middle click on empty portion of the bar creates a new tab.

2. Quadruple-click to select whole page What do other folks think?

In my view quadruple click does not make sense because it is seldom the user can think it can result in some kind of action or behaviour.
Secondly, this feature then would remain hidden or unknown about, even though I originally implemented this in double click. I would prefer double click over quadruple since for me double click is expected to do something, but surely quadruple is not.(I don't know about others)
At the end you all are much more experienced amd understand UX way better than me, I will leave this to you.

In D18744#412143, @ngraham wrote:

OK, works for me now. I'm not thrilled about the Alt-P shortcut since it's the only one in the menu that uses only the Alt modifier. But I won't block on that. I'll hand this back to the Okular folks now.

because that report also requests the feature of middle-clicking in empty areas of the tab bar to create new tabs.
...Unless you want to implement that, too. :)

I think it is not required, because we would be just duplicating the double click behaviour then. Currently double click does this.

@cullmann Don't you think this is some nice feature to have, having think of frustration one can have when they close kate thinking it will only close current tab, and unexpectedly all their tabs are closed.

Remove unnecessary change
Correct wordings

@hindenburg @ngraham Friendly Ping

Correct shortcut in documentation
Fix coding style

Add config option in TabBar settings

Do not use camel case in strings

Make closing tabs on middle mouse button configurable

How to take settings into account?

In D19008#412781, @drosca wrote:

I meant that I don't want this feature. Context menu on page is already very long, and if it contained every action that someone requested on bugzilla, it would not even fit on screen.

So, as with other similar features, I always say that it should go into plugin. It is now also possible to create script plugins (instead of C++ libraries), which is preferred for adding functionality such as this patch.

I did not get what you meant, can you please explain a bit?