Feed Advanced Search

Oct 31 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.

I am not sure we can use a nickname as author because of licensing.

Oct 31 2020, 2:26 PM · Ark

Oct 27 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.

Hello all,
Is there someone to commit this change?
Papoteur

Oct 27 2020, 9:32 AM · Ark

Oct 24 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.

No, I don't have commit credentials. Go for myself.

Can you provide full name for commit message or should I use your nickname? And can you provide email-address?

Oct 24 2020, 7:39 AM · Ark

Oct 23 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.

My screenshot is showing preview of the compressed file (source) as "destination".

Hi Patrick,
Is it different with the original ark?

Ark 20.04.1 from Arch repos shows the thumbnail of source file twice.

Oct 23 2020, 8:58 PM · Ark

May 20 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.

Ark 20.04.1 from Arch repos shows the thumbnail of source file twice.

May 20 2020, 6:48 AM · Ark

May 18 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.

My screenshot is showing preview of the compressed file (source) as "destination".

May 18 2020, 6:17 AM · Ark

May 9 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.

No, I don't have commit credentials. Go for myself.

May 9 2020, 2:11 PM · Ark

May 8 2020

papoteur updated the diff for D27181: Rename dialog displays also source file information.

And now?

May 8 2020, 7:53 PM · Ark

May 6 2020

papoteur added inline comments to D27181: Rename dialog displays also source file information.
May 6 2020, 6:46 AM · Ark

May 5 2020

papoteur updated the diff for D27181: Rename dialog displays also source file information.
May 5 2020, 7:16 AM · Ark

May 4 2020

papoteur updated the diff for D27181: Rename dialog displays also source file information.

Should be OK now.

May 4 2020, 7:59 PM · Ark

May 3 2020

papoteur updated the diff for D27181: Rename dialog displays also source file information.

This version modifies the function signature of OverwriteQuery to pass directly data from source file.
Call to the function are adapted in the whole repo. I have tested it with extraction of one single file and a complete archive. Thus I have tested only the call from libarchiveplugin, line 306. I don't know how to test other calls.

May 3 2020, 5:40 PM · Ark

Apr 12 2020

papoteur updated the diff for D27181: Rename dialog displays also source file information.

This new patch provides data from source by calling setSourceData.
However, from my tests, it is never called.

Apr 12 2020, 2:23 PM · Ark

Apr 11 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.
Apr 11 2020, 6:56 AM · Ark

Feb 8 2020

papoteur added a comment to D27181: Rename dialog displays also source file information.

Btw, You can mark the comment you treated as "Done" in phabricator, it it eases the review work.

Feb 8 2020, 4:55 PM · Ark
papoteur updated the diff for D27181: Rename dialog displays also source file information.

Hello,
This patch has corrections for comments.

Feb 8 2020, 2:30 PM · Ark
papoteur added a comment to T1879: Investigate replacements for RenameDialog.

See D27181 which keep rename dialog but solve the problem it had.

Feb 8 2020, 6:04 AM · Ark
papoteur moved T1879: Investigate replacements for RenameDialog from Backlog to Under review on the Ark board.
Feb 8 2020, 6:01 AM · Ark

Feb 5 2020

papoteur requested review of D27181: Rename dialog displays also source file information.
Feb 5 2020, 10:01 PM · Ark