Thank you David.
I can finally save in FatCRM again.

the installed layout looks like this now:

I followed the example of KArchive
If KParts is the the better example I will change the patch accordingly.

I would appreciate a quick resolution to this crash or at least a temporary commit of Martin's patch.
In the meantime I will commit locally so kontact doesn't crash every time I send an email.

no objections. looks ok to me.

absolutely

agree that Q_FALLTHROUGH(); is a better idea.
it doesn't duplicate code and it informs the reader that the fallthrough is intentional

please close this

I guess this QLocale::bcp47Name() is useless in this situation.

I will change krazy to not complain about GNUC

I wish I knew how the job could be bad. I can't reproduce.
I guess this doesn't cause any damage but I won't be hurt if you reject this patch. I had a core file so I made a patch

all I know is I had a crash there

ping.
this is still relevant.
some kconfigxt files don't set the kcfgfile element.

Dan is correct. I'm not sure what I was thinking at the time it was so long ago.

In D12019#243301, @mkoller wrote:

you can push directly.
then close this phab and also close the bugs you opened regarding this problem

thanks!

versit subdir is removed
relocate the includes from vcalformat.h to vcalformat.cpp

In D10799#212787, @dvratil wrote:

Should the entire versit directory be removed as well?

see D10799

Dan,
I tried your patch and hit the infinite recursion within seconds in my inbox folder.
Going back to my patch.

well, Dan already approved it. So sure.