In D21903#508769, @aferraris wrote:

Finally, this patchset has been thoroughly tested for ext4 and btrfs filesystems.
If everything is OK, I can add support for fat32 blocksize before merging.

Yes, and you need to add it to cmake. That part of code is autogenerated.

Before it's pushed (once it compiles) also refactor code a bit so that
there isn't that much code duplication.

I guesss it's alright to go in for now.

Looks alright. I'll try to compile myself and see what are those linking errors when you have those two lines uncommented...

-i bytes-per-inodeI am a bit worried that this API would be hard to use from GUI clients. Although in general, I think direction is good.

I think QSignalSpy is in QtTest, not QtWidgets.

So far rest seems alright.

Can you also mention motivation in commit message

Once issues mentioned above are fixed.

Oh, I see. Sorry for missing that out. Then I guess commit it to master.

If you want this commit, you can just merge master branch into your branch.

Looks good, just keep space consistent where I mentioned. Then you can push this to master branch.

I think startHelper() is much better.

Hmm, regarding license, I guess it will be fine. KTorrent is GPLv2 or later. So GPLv3 would work.

Yes, it looks fine to me too. Please fix those issues that wbauer already mentioned and then you can commit (or ask somebody to commit if for you if you don't have commit access).

In D21340#469511, @cjlcarvalho wrote:

There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.

Maybe push to 4.0 branch?

Also in general, I think we should create a bool variable where we store data, so that we only run this

Well, in principle both mean exactly the same thing, so I don't have strong opinion on this. I probably use them interchangeably anyway. Well, it's auto, so we don't care what type it is... So based on that I would say no need to make a commit. Other parts of KDE codebase also don't have unified style here. Just checked kwin, it has both auto and auto *

In D21251#466412, @shubham wrote:

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

In D21251#466408, @shubham wrote:

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

In D21251#466401, @shubham wrote:

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
Please push this and the other revision on my behalf : )

oh ok, that's fine then.

In D21251#466395, @shubham wrote:

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

We also don't need this. Q_SLOTS are needed with old style Qt syntax where SIGNAL and SLOTS are used. With the new Qt5 connect syntax, you can just connect to any function, so no need to involve moc on this function.

The other include (#include "externalcommandhelper.h") I think can still go away but please test that it builds in a clean build dir.

It is needed by std::unique_ptr and std::unordered_set. We shouldn't rely on header being pulled in by some other header.

Maybe push to 4.0 branch?

Ship it

If I commit this myself, I need your mail address for git commit --author. Is it the same as in reviewboard (I can't see the one from Phabricator)?

In D13849#384351, @davidedmundson wrote:

It runtime requires Qt 5.12 for xdg-output which the shell needs for fullscreen, which means we can merge for Plasma 5.16

Looks fine.