Feed Advanced Search

Mar 27 2019

stikonas added a comment to D20076: Do not use C data type.

Hmm, do we really need this? quint64 is unsigned long long. It's just a typedef, so both can be used interchangeably. And unsigned long long is also C++ data type, not just C... Altgough, obviously this change wouldn't break anything. I guess it's just a question of code style but I didn't find any KDE recommendations. Any other opinions from other reviewers?

Mar 27 2019, 1:22 PM · KDE Partition Manager

Mar 17 2019

stikonas accepted D19772: Follow KDE HIG by using ellipis.
Mar 17 2019, 10:44 PM

Mar 10 2019

stikonas committed R17:f6e22288b9cd: Require Frameworks 5.56 as this is what KPMcore needs anyway. (authored by stikonas).
Require Frameworks 5.56 as this is what KPMcore needs anyway.
Mar 10 2019, 10:32 PM

Feb 28 2019

stikonas committed R16:92065f7a23cf: Add a function to convert QStringList of flag names to flags. (authored by stikonas).
Add a function to convert QStringList of flag names to flags.
Feb 28 2019, 12:22 AM
stikonas committed R17:a6861bf202a6: When importing partition table, pass the flags to Partition class. (authored by stikonas).
When importing partition table, pass the flags to Partition class.
Feb 28 2019, 12:18 AM
stikonas committed R17:cf513b98732b: Use explicit class method overrides. (authored by stikonas).
Use explicit class method overrides.
Feb 28 2019, 12:18 AM
stikonas committed R17:730b2a999225: Fix race condition in reading fstype on partition table import. (authored by stikonas).
Fix race condition in reading fstype on partition table import.
Feb 28 2019, 12:18 AM

Feb 17 2019

stikonas committed R473:0c8c8d09b0b8: Merge branch '5.1' (authored by stikonas).
Merge branch '5.1'
Feb 17 2019, 8:18 PM
stikonas committed R473:dab5abcd2172: Allow creating torrent for a single file. (authored by jivatotin).
Allow creating torrent for a single file.
Feb 17 2019, 8:04 PM
stikonas committed R120:99bd3b86f263: Fix a typo in a comment. (authored by stikonas).
Fix a typo in a comment.
Feb 17 2019, 6:06 PM

Feb 16 2019

stikonas committed R16:594c90f4ba02: Update INSTALL.md with new dependencies. (authored by stikonas).
Update INSTALL.md with new dependencies.
Feb 16 2019, 11:51 AM
stikonas committed R17:2a90cc465203: Add syntax highlighing for code snippets in README.md. Try 2 (authored by stikonas).
Add syntax highlighing for code snippets in README.md. Try 2
Feb 16 2019, 12:12 AM
stikonas committed R17:52513f9c7503: Add syntax highlighing for code snippets in README.md (authored by stikonas).
Add syntax highlighing for code snippets in README.md
Feb 16 2019, 12:11 AM
stikonas committed R17:db7401229c28: Rename changelog file. (authored by stikonas).
Rename changelog file.
Feb 16 2019, 12:11 AM
stikonas committed R16:f5b5728c7f45: Specify language for code snippets in README.md (authored by stikonas).
Specify language for code snippets in README.md
Feb 16 2019, 12:05 AM

Feb 15 2019

stikonas committed R16:015f44f535d5: Merge branch 'aacid/kpmcore-uses_authcore' (authored by stikonas).
Merge branch 'aacid/kpmcore-uses_authcore'
Feb 15 2019, 11:40 PM
stikonas committed R16:6f703b93097c: Merge branch 'add_override' into 'master' (authored by stikonas).
Merge branch 'add_override' into 'master'
Feb 15 2019, 11:35 PM
stikonas committed R16:ecb78121f36d: Allow moving partitions of unknown type. (authored by stikonas).
Allow moving partitions of unknown type.
Feb 15 2019, 7:51 PM

Feb 12 2019

stikonas committed R436:94c7c9ada210: Add Wayland support (authored by stikonas).
Add Wayland support
Feb 12 2019, 11:29 PM
stikonas closed D18909: Add Wayland support.
Feb 12 2019, 11:29 PM

Feb 10 2019

stikonas updated the diff for D18909: Add Wayland support.

Coding style adjusted

Feb 10 2019, 10:20 PM
stikonas updated the diff for D18909: Add Wayland support.

Added more error handling if executable is not found.

Feb 10 2019, 9:07 PM
stikonas retitled D18909: Add Wayland support from Add wayland support to Add Wayland support.
Feb 10 2019, 7:41 PM
stikonas requested review of D18909: Add Wayland support.
Feb 10 2019, 7:40 PM
stikonas committed R16:39a5645c387b: Explicitely specify underlying type for Capacity enums. (authored by stikonas).
Explicitely specify underlying type for Capacity enums.
Feb 10 2019, 1:43 AM
stikonas committed R17:98d59e69ff51: Use scoped enums for PartitionTable::Flag. (authored by stikonas).
Use scoped enums for PartitionTable::Flag.
Feb 10 2019, 1:30 AM
stikonas committed R17:1d86260ad541: Use strongly typed enum for Capacity::Unit. (authored by stikonas).
Use strongly typed enum for Capacity::Unit.
Feb 10 2019, 1:30 AM
stikonas committed R16:723b05107d83: Use strongly typed enum for Capacity:Unit. (authored by stikonas).
Use strongly typed enum for Capacity:Unit.
Feb 10 2019, 12:51 AM

Feb 9 2019

stikonas committed R16:28e1308ec5e9: Switch to scoped name PartitionTable::Flag:: (authored by stikonas).
Switch to scoped name PartitionTable::Flag::
Feb 9 2019, 6:07 PM
stikonas committed R16:3df5acb9e334: Add scanDevices function that uses flags instead of bools. (authored by stikonas).
Add scanDevices function that uses flags instead of bools.
Feb 9 2019, 3:41 PM
stikonas committed R16:bfa6a327af16: Also print command input if KPMCORE_DEBUG is set. (authored by stikonas).
Also print command input if KPMCORE_DEBUG is set.
Feb 9 2019, 3:41 PM

Feb 3 2019

stikonas committed R883:1534621: Updated Lithuanian translation..
Updated Lithuanian translation.
Feb 3 2019, 5:08 PM

Jan 24 2019

stikonas committed R16:5a163f8bee5f: Detect MBR Extended LBA partitions. (authored by stikonas).
Detect MBR Extended LBA partitions.
Jan 24 2019, 7:52 PM

Jan 13 2019

stikonas committed R17:135853ef50b1: Bump version for beta. (authored by stikonas).
Bump version for beta.
Jan 13 2019, 6:02 PM
stikonas committed R16:8a3d95e5ec05: Bump version for beta. (authored by stikonas).
Bump version for beta.
Jan 13 2019, 6:02 PM
stikonas committed R17:a5e8d318d0cf: Add support for Apple File System (APFS). (authored by stikonas).
Add support for Apple File System (APFS).
Jan 13 2019, 5:54 PM
stikonas committed R16:559c326be720: Add detection support for Apple File System (APFS). (authored by stikonas).
Add detection support for Apple File System (APFS).
Jan 13 2019, 5:34 PM
stikonas committed R16:e749b01b8e85: Fix a typo in filesystem support dialog. (authored by stikonas).
Fix a typo in filesystem support dialog.
Jan 13 2019, 1:18 PM
stikonas committed R17:6f1ca2cca9ca: Add BitLocker support. (authored by stikonas).
Add BitLocker support.
Jan 13 2019, 3:18 AM
stikonas committed R16:708318a5ad0c: Add BitLocker detection support. (authored by stikonas).
Add BitLocker detection support.
Jan 13 2019, 2:26 AM

Jan 12 2019

stikonas committed R16:9fa20fb1e2c6: Remove "mv" command from allowed external command list (authored by stikonas).
Remove "mv" command from allowed external command list
Jan 12 2019, 11:18 PM
stikonas committed R16:055b1fe3e506: Make device model names prettier. (authored by stikonas).
Make device model names prettier.
Jan 12 2019, 12:24 AM
stikonas committed R16:90ebdb9b42a5: Merge branch 'master' into raid-support (authored by stikonas).
Merge branch 'master' into raid-support
Jan 12 2019, 12:07 AM
stikonas committed R16:ca07ad5ab0ae: Silence RAID warnings in master. (authored by stikonas).
Silence RAID warnings in master.
Jan 12 2019, 12:07 AM

Jan 11 2019

stikonas committed R16:e5a20926cdf4: Fix device names spanning two lines. (authored by stikonas).
Fix device names spanning two lines.
Jan 11 2019, 11:58 PM

Jan 7 2019

stikonas updated subscribers of T10243: Some KDE applications could use better icons.
Jan 7 2019, 1:38 PM · KDE Applications, VDG
stikonas updated subscribers of T10243: Some KDE applications could use better icons.

By the way, what about duplicate icons? When transitioning from Oxygen
to Breeze, KDE Partition Manager was given the same icon as Filelight
(which actually looks more like filelight window rather than disk
partitioning).

Jan 7 2019, 10:22 AM · KDE Applications, VDG
stikonas committed R16:cabe4861ac43: Add GPLv3 in markdown format. (authored by stikonas).
Add GPLv3 in markdown format.
Jan 7 2019, 12:24 AM

Jan 6 2019

stikonas committed R16:052a258adbfd: Update INSTALL.md (authored by stikonas).
Update INSTALL.md
Jan 6 2019, 7:24 PM
stikonas committed R16:7cd15253480a: INSTALL -> INSTALL.md (authored by stikonas).
INSTALL -> INSTALL.md
Jan 6 2019, 7:16 PM
stikonas committed R16:c2ed6634df00: Merge branch 'master' into raid-support (authored by stikonas).
Merge branch 'master' into raid-support
Jan 6 2019, 5:48 PM
stikonas committed R17:6ff67eb277ce: Add GPLv3 license in Markdown format. (authored by stikonas).
Add GPLv3 license in Markdown format.
Jan 6 2019, 5:42 PM
stikonas committed R17:021b23fa71e8: Slightly update TODO file. (authored by stikonas).
Slightly update TODO file.
Jan 6 2019, 5:39 PM
stikonas committed R17:406f9e3d4f95: Rename INSTALL -> INSTALL.md (authored by stikonas).
Rename INSTALL -> INSTALL.md
Jan 6 2019, 5:34 PM
stikonas committed R17:79cd742e54e3: Also add installation instructions for Gentoo. (authored by stikonas).
Also add installation instructions for Gentoo.
Jan 6 2019, 5:27 PM
stikonas committed R17:6b9dfa2d1e60: Merge branch 'master' into raid-support (authored by stikonas).
Merge branch 'master' into raid-support
Jan 6 2019, 5:21 PM
stikonas committed R17:2b30ce7fe6ee: Merge branch 'patch-1' into 'master' (authored by stikonas).
Merge branch 'patch-1' into 'master'
Jan 6 2019, 5:21 PM
stikonas committed R17:30dd9c9e44f7: Merge branch 'master' into 'master' (authored by stikonas).
Merge branch 'master' into 'master'
Jan 6 2019, 5:21 PM

Jan 3 2019

stikonas added a comment to T10090: SMART Status GUI Issues.

@cjlcarvalho Just double checked, it's still an issue.

Jan 3 2019, 10:33 PM · KDE Partition Manager
stikonas added a comment to T10090: SMART Status GUI Issues.

@cjlcarvalho I don't recall any patch that fixed this. I can try to test
later today.

Jan 3 2019, 10:38 AM · KDE Partition Manager

Jan 1 2019

stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

No timeline yet. First of all, there needs to be a new release of smartmontools. But probably best to work in a branch for a while.

Jan 1 2019, 9:40 PM · KDE Partition Manager
stikonas committed R16:47cdc9e40505: Update smartmontool (runtime) dependency. (authored by stikonas).
Update smartmontool (runtime) dependency.
Jan 1 2019, 9:32 PM

Dec 25 2018

stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

Dec 25 2018, 10:14 PM · KDE Partition Manager
stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

We can try this out, since I have some more time now, I decided to continue with the 'tab' idea discussed during Google Code-In. Not sure about the names of the tabs though. Tell me if you prefer this, I think it leaves a lot of room for expanding this feature if needed.
Image 1
Image 2

Dec 25 2018, 9:41 AM · KDE Partition Manager

Dec 24 2018

stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).

Any particular languages? I think expanding the label's area would do for this.

Dec 24 2018, 11:07 PM · KDE Partition Manager

Dec 23 2018

stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).

Dec 23 2018, 1:25 PM · KDE Partition Manager

Dec 19 2018

stikonas committed R16:faca8f7f0d54: S.M.A.R.T. attribute 178 is same as 179 (authored by anthonyfieroni).
S.M.A.R.T. attribute 178 is same as 179
Dec 19 2018, 11:47 PM
stikonas closed D17683: [kpmcore] S.M.A.R.T. attribute 178 is same as 179.

Pushed.

Dec 19 2018, 11:47 PM
stikonas added a comment to D17683: [kpmcore] S.M.A.R.T. attribute 178 is same as 179.

I'll push it later today.

Dec 19 2018, 10:41 PM
stikonas added a comment to D17683: [kpmcore] S.M.A.R.T. attribute 178 is same as 179.

I'll push it later today.

Dec 19 2018, 2:00 PM

Dec 11 2018

stikonas accepted D17475: rebrand index.
Dec 11 2018, 1:02 AM

Dec 6 2018

stikonas committed R16:d4f3ac62ae0d: Use drive-removable-media-usb icon for USB devices. (authored by stikonas).
Use drive-removable-media-usb icon for USB devices.
Dec 6 2018, 2:00 AM

Dec 1 2018

stikonas committed R883:1529606: Updated Lithuanian translation..
Updated Lithuanian translation.
Dec 1 2018, 6:55 PM

Nov 29 2018

stikonas committed R16:80f5a32dc04c: Remove remaining cases of call to dd binary. (authored by stikonas).
Remove remaining cases of call to dd binary.
Nov 29 2018, 10:57 PM

Nov 25 2018

stikonas committed R16:09e4d47e0711: Do not use external process dd. (authored by stikonas).
Do not use external process dd.
Nov 25 2018, 8:53 PM

Nov 24 2018

stikonas closed D17129: Updated SMART widget GUI to better display SMART info..
Nov 24 2018, 11:00 PM · KDE Partition Manager
stikonas committed R17:beed97ee8402: Updated SMART widget GUI to better display SMART info. (authored by varunp).
Updated SMART widget GUI to better display SMART info.
Nov 24 2018, 11:00 PM
stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?

I just joined, I am working on Google Code-In. It could also be that I have yet to receive an account verification email.

Nov 24 2018, 8:13 PM · KDE Partition Manager
stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?

Nov 24 2018, 8:06 PM · KDE Partition Manager
stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

arc land is throwing an error:

fatal: remote error: service not enabled: /partitionmanager.git

Is there any solution, I am new to using arc and Phabricator.

Nov 24 2018, 7:45 PM · KDE Partition Manager
stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Oh and please add

BUG: 401230
Nov 24 2018, 7:11 PM · KDE Partition Manager
stikonas accepted D17129: Updated SMART widget GUI to better display SMART info..

Maybe ship this first. If you want to add bad sectors and power cycles (which I am fine with), then in a separate commit.

Nov 24 2018, 7:09 PM · KDE Partition Manager
stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Can you attach some before and after screenshots? I think this is usually customary with GUI changes.

Nov 24 2018, 10:03 AM · KDE Partition Manager

Nov 12 2018

stikonas committed R16:4f3a9db3487b: Print commands that are being run if KPMCORE_DEBUG is set (authored by stikonas).
Print commands that are being run if KPMCORE_DEBUG is set
Nov 12 2018, 1:46 AM

Nov 1 2018

stikonas added a comment to D16577: Getting lsblk kname in the cases where the model name isn't available.

Actually now I'm thinking, maybe we should always read KNAME for devices and partitions and store it. We need it in quite a few places in the code and I think right now we just follow symlinks.

Nov 1 2018, 12:52 PM · KDE Partition Manager
stikonas accepted D16577: Getting lsblk kname in the cases where the model name isn't available.

It fixes the problem for me. So in principle it can go in. I would probably put on command line parameter per line, easier to read.

Nov 1 2018, 12:48 PM · KDE Partition Manager

Oct 29 2018

stikonas committed R16:2007f2b8ea90: Allow copyblocks to be used together with small QByteArrays. (authored by stikonas).
Allow copyblocks to be used together with small QByteArrays.
Oct 29 2018, 12:31 AM
stikonas closed D16487: Allow copyblocks to be used together with small QByteArrays..
Oct 29 2018, 12:31 AM
stikonas added a comment to T9935: LVM VG rename.

Yeah, then it should be defined for VolumeGroupDevice in the GUI and LVM VG, RAID devices should implement their methods...

Oct 29 2018, 12:13 AM · KDE Partition Manager

Oct 28 2018

stikonas committed R17:58cfa4b2bb17: Adjust whitespace. (authored by stikonas).
Adjust whitespace.
Oct 28 2018, 9:27 PM
stikonas committed R17:9e0ae352f59b: Set QApplication Window Icon. (authored by stikonas).
Set QApplication Window Icon.
Oct 28 2018, 9:23 PM
stikonas created T9940: Use QCA to store LUKS passphrase.
Oct 28 2018, 6:04 PM · KDE Partition Manager
stikonas updated the task description for T9939: Disallow read only btrfs resizing.
Oct 28 2018, 5:54 PM · KDE Partition Manager
stikonas created T9939: Disallow read only btrfs resizing.
Oct 28 2018, 5:53 PM · KDE Partition Manager
stikonas created T9938: Split ExternalCommandHelper.
Oct 28 2018, 5:50 PM · KDE Partition Manager
stikonas created T9937: Legacy Boot flag.
Oct 28 2018, 5:49 PM · KDE Partition Manager
stikonas created T9936: LVM LV rename.
Oct 28 2018, 5:47 PM · KDE Partition Manager
stikonas created T9935: LVM VG rename.
Oct 28 2018, 5:46 PM · KDE Partition Manager
stikonas updated the task description for T9934: Create LUKS2 volumes.
Oct 28 2018, 5:46 PM · KDE Partition Manager
stikonas created T9934: Create LUKS2 volumes.
Oct 28 2018, 5:45 PM · KDE Partition Manager