Hmm, do we really need this? quint64 is unsigned long long. It's just a typedef, so both can be used interchangeably. And unsigned long long is also C++ data type, not just C... Altgough, obviously this change wouldn't break anything. I guess it's just a question of code style but I didn't find any KDE recommendations. Any other opinions from other reviewers?
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Mar 27 2019
Mar 17 2019
Mar 10 2019
Feb 28 2019
Feb 17 2019
Feb 16 2019
Feb 15 2019
Feb 12 2019
Feb 10 2019
Coding style adjusted
Added more error handling if executable is not found.
Feb 9 2019
Feb 3 2019
Jan 24 2019
Jan 13 2019
Jan 12 2019
Jan 11 2019
Jan 7 2019
By the way, what about duplicate icons? When transitioning from Oxygen
to Breeze, KDE Partition Manager was given the same icon as Filelight
(which actually looks more like filelight window rather than disk
partitioning).
Jan 6 2019
Jan 3 2019
@cjlcarvalho Just double checked, it's still an issue.
@cjlcarvalho I don't recall any patch that fixed this. I can try to test
later today.
Jan 1 2019
In D17129#382304, @stikonas wrote:In D17129#382302, @varunp wrote:Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?
No timeline yet. First of all, there needs to be a new release of smartmontools. But probably best to work in a branch for a while.
Dec 25 2018
In D17129#382302, @varunp wrote:Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?
In D17129#382057, @varunp wrote:
Dec 24 2018
In D17129#381530, @varunp wrote:In D17129#381250, @stikonas wrote:One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).
Any particular languages? I think expanding the label's area would do for this.
Dec 23 2018
One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).
Dec 19 2018
Pushed.
In D17683#379487, @stikonas wrote:I'll push it later today.
I'll push it later today.
Dec 11 2018
Dec 6 2018
Dec 1 2018
Nov 29 2018
Nov 25 2018
Nov 24 2018
In D17129#365497, @varunp wrote:In D17129#365496, @stikonas wrote:Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?
I just joined, I am working on Google Code-In. It could also be that I have yet to receive an account verification email.
Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?
In D17129#365465, @varunp wrote:arc land is throwing an error:
fatal: remote error: service not enabled: /partitionmanager.gitIs there any solution, I am new to using arc and Phabricator.
Oh and please add
BUG: 401230
Maybe ship this first. If you want to add bad sectors and power cycles (which I am fine with), then in a separate commit.
Can you attach some before and after screenshots? I think this is usually customary with GUI changes.
Nov 12 2018
Nov 1 2018
Actually now I'm thinking, maybe we should always read KNAME for devices and partitions and store it. We need it in quite a few places in the code and I think right now we just follow symlinks.
It fixes the problem for me. So in principle it can go in. I would probably put on command line parameter per line, easier to read.
Oct 29 2018
Yeah, then it should be defined for VolumeGroupDevice in the GUI and LVM VG, RAID devices should implement their methods...