Scrapping this for now, since I have a few improvements on this, but it needs to be reworked. Ill make a PR with updated version on GitLab instance.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Feb 9 2020
Sep 17 2019
Sep 16 2019
In D23989#532692, @ngraham wrote:I wonder if this should maybe be backported to 5.62, since it represents a regression introduced in that release. Thoughts?
- Incorporated feedback
In D22510#532295, @broulik wrote:This patch breaks running Windows EXE files. Clicking them does nothing now. Right clicking and explicitly choosing "Run with wine program launcher" works.
Sep 3 2019
- Reverted change to KRun::isExecutableFile
Sep 2 2019
Fixed according to comments, hope I haven't forget anything this time.
Sorry for the API change, I thought it may make sense to add it like this since isExecutableFile and isExecutable are a part of it.
I also added showing the errorString from setExecuteBit to makeServiceExecutable, since it used similar dialog to KRun::runUrl
- Incorporated feedback
Thanks for your guidance!
I don't have developer account, so can't land myself.
Should I fix those two other comments before landing?
- Removed leftover kfileitem.h include
Reversed my changes to isExecutableFile method as per D23660, since my changes aren't needed anymore. Also added hasExecuteBit method.
- Reverse change to KRun::isExeutableFile
- Incorporated feedback
Aug 29 2019
First of all, sorry for the mess I made here with Arcanist. My SSD died recently and I lost original repository with those changes, so I used arc patch to pull it back, updated the code and pushed here with arc diff --update. I'm not sure if it affects anything though, I tested on fresh repository and it can be patched with this revision without problem.
In response to the feedback, I ditched my original dialog - it is now shared with that from makeServiceExecutable helper function (the one that shows for .desktop files), and its code is moved to showUntrustedProgramWarning method. Code for setting executable bit is also moved, from makeFileExecutable to setExecuteBit.
Desktop and script files also show another type of dialog, one which ask user whether to open or execute the file, but I decided not to use it here with executables since I don't think anyone needs to open executables with external programs.
Incorporated feedback
Aug 26 2019
In D22854#517776, @apol wrote:Have you reflected on what users need changing or we're just adding this because it's possible?
I'm not opposing having this, but if something can be improved, I'd improve it for everyone first.
Jul 31 2019
Jul 22 2019
Jul 17 2019
In D22510#496804, @ngraham wrote:If the use case you're targeting is specifically AppImage files, it might make sense to coordinate with upstream, where they're working on ways to improve this: https://github.com/AppImage/appimaged/issues/30. There's a small helper called AppImageLauncher that can do this automatically, so I'm not sure it makes sense to use KRun for it. @probono?
One of the commits did not upload
Jul 15 2019
In D22456#496025, @apol wrote:LGTM can you land it?
- Added missing header for column with session name