Feed Advanced Search

Jun 14 2018

pprkut requested review of D13547: Expression syntax improvements.
Jun 14 2018, 7:18 PM · KDevelop
pprkut updated the task description for T6804: PHP 7.2 features.
Jun 14 2018, 5:58 AM · KDevelop

Jun 13 2018

pprkut committed R52:f749cedb538e: Add support for the object typehint. (authored by pprkut).
Add support for the object typehint.
Jun 13 2018, 8:56 PM
pprkut closed D13420: Add support for the object typehint..
Jun 13 2018, 8:56 PM · KDevelop
pprkut committed R52:8c5e258640e8: Fix using reserved type names in identifiers. (authored by pprkut).
Fix using reserved type names in identifiers.
Jun 13 2018, 8:56 PM
pprkut closed D13313: Fix using reserved type names in identifiers..
Jun 13 2018, 8:56 PM · KDevelop

Jun 7 2018

pprkut requested review of D13420: Add support for the object typehint..
Jun 7 2018, 8:04 PM · KDevelop
pprkut added a dependent revision for D13313: Fix using reserved type names in identifiers.: D13420: Add support for the object typehint..
Jun 7 2018, 8:04 PM · KDevelop
pprkut updated the diff for D13313: Fix using reserved type names in identifiers..

Renamed isObjectTypehint => isClassTypehint to avoid confusion when
'object' typehint support is implemented.

Jun 7 2018, 7:39 PM · KDevelop

Jun 3 2018

pprkut added inline comments to D13313: Fix using reserved type names in identifiers..
Jun 3 2018, 7:50 PM · KDevelop
pprkut requested review of D13313: Fix using reserved type names in identifiers..
Jun 3 2018, 7:41 PM · KDevelop

Feb 24 2018

pprkut added inline comments to D9713: Add script to unlock a broken session via ConsoleKit..
Feb 24 2018, 8:28 AM · Plasma

Jan 27 2018

pprkut added inline comments to D9713: Add script to unlock a broken session via ConsoleKit..
Jan 27 2018, 2:29 PM · Plasma

Jan 6 2018

pprkut added a comment to D9624: Install parser headers and cmake config files to support client packages.

Not really a cmake expert. Changes look sound, but can't really judge whether they are correct. Generally looks fine to me, apart from installing the php.g grammar file.

Jan 6 2018, 8:03 PM

Dec 28 2017

pprkut updated the task description for T6804: PHP 7.2 features.
Dec 28 2017, 9:49 AM · KDevelop
pprkut updated the task description for T6803: PHP 7.1 features.
Dec 28 2017, 9:45 AM · KDevelop
pprkut updated the task description for T6809: PHP 7.0 features.
Dec 28 2017, 9:43 AM · KDevelop
pprkut updated the task description for T6816: PHP 5.5 features.
Dec 28 2017, 9:40 AM · KDevelop
pprkut closed T6817: PHP 5.4 features as Resolved.
Dec 28 2017, 9:38 AM · KDevelop
pprkut committed R52:bb4f4cf9dd71: Update generated phpfunctions from recent checkout of phpdoc-en. (authored by pprkut).
Update generated phpfunctions from recent checkout of phpdoc-en.
Dec 28 2017, 9:27 AM
pprkut committed R52:860db9213f25: Update create_functions.php to work with newer versions of the PHP… (authored by pprkut).
Update create_functions.php to work with newer versions of the PHP…
Dec 28 2017, 9:27 AM
pprkut closed D9507: Update create_functions.php to work with newer versions of the PHP documentation..
Dec 28 2017, 9:27 AM
pprkut added a comment to D9507: Update create_functions.php to work with newer versions of the PHP documentation..

Sure, but it's a rather large diff and I didn't want it to clutter up this review. I'll push it as a follow-up commit

Dec 28 2017, 9:00 AM

Dec 26 2017

pprkut created D9507: Update create_functions.php to work with newer versions of the PHP documentation..
Dec 26 2017, 1:46 PM
pprkut committed R52:222b77722f57: Exclude interfaces from circular inheritance check. (authored by pprkut).
Exclude interfaces from circular inheritance check.
Dec 26 2017, 1:38 PM

Dec 18 2017

pprkut committed R52:38d54d1e7530: Add support for PHP 7's context sensitive lexer. (authored by pprkut).
Add support for PHP 7's context sensitive lexer.
Dec 18 2017, 7:09 PM
pprkut closed D9380: Add support for PHP 7's context sensitive lexer..
Dec 18 2017, 7:09 PM

Dec 17 2017

pprkut created D9380: Add support for PHP 7's context sensitive lexer..
Dec 17 2017, 6:37 PM
pprkut committed R52:3afa3af595b9: Add support for __DIR__ and __TRAIT__. (authored by pprkut).
Add support for __DIR__ and __TRAIT__.
Dec 17 2017, 4:30 PM
pprkut closed D9363: Add support for __DIR__ and __TRAIT__..
Dec 17 2017, 4:30 PM
pprkut added a comment to D9363: Add support for __DIR__ and __TRAIT__..

__DIR__ is a constant holding the current directory of the file the constant is used in
__TRAIT__ is a constant holding the current name of the trait the constant is used in

Dec 17 2017, 12:44 PM
pprkut updated the diff for D9363: Add support for __DIR__ and __TRAIT__..

Add more test cases in the completion test

Dec 17 2017, 11:50 AM

Dec 16 2017

pprkut created D9363: Add support for __DIR__ and __TRAIT__..
Dec 16 2017, 9:54 PM

Sep 17 2017

pprkut committed R165:b145f47f0009: Only remove init connections to the database on server shutdown. (authored by pprkut).
Only remove init connections to the database on server shutdown.
Sep 17 2017, 3:24 PM
pprkut closed D7858: Only remove init connections to the database on server shutdown..
Sep 17 2017, 3:24 PM · KDE PIM
pprkut updated the diff for D7858: Only remove init connections to the database on server shutdown..

Coding adjustments and added comments.

Sep 17 2017, 10:53 AM · KDE PIM
pprkut created D7858: Only remove init connections to the database on server shutdown..
Sep 17 2017, 9:19 AM · KDE PIM

Aug 8 2017

pprkut committed R32:6488d966bd6e: Add const modifier to IndexedDeclaration constructor. (authored by pprkut).
Add const modifier to IndexedDeclaration constructor.
Aug 8 2017, 4:41 PM
pprkut committed R32:44687d3762e9: Avoid crash when trying to import invalid context. (authored by pprkut).
Avoid crash when trying to import invalid context.
Aug 8 2017, 4:40 PM
pprkut committed R32:6a7434de813d: Add an ignoreError flag to the DVcsJob class. (authored by pprkut).
Add an ignoreError flag to the DVcsJob class.
Aug 8 2017, 4:40 PM
pprkut committed R32:922eb8c33826: Change the command to get the current branch name for git. (authored by pprkut).
Change the command to get the current branch name for git.
Aug 8 2017, 4:40 PM
pprkut committed R32:bd65a0e9e69e: List correct repository in .reviewboardrc (authored by pprkut).
List correct repository in .reviewboardrc
Aug 8 2017, 4:35 PM
pprkut committed R32:462edf1d8a1b: Add support for traits to ClassDeclarationData. (authored by pprkut).
Add support for traits to ClassDeclarationData.
Aug 8 2017, 4:35 PM

Jun 27 2017

pprkut accepted D6342: Add more typehints to arguments in PHP.

The changes look good, although I think it would be preferable to have the basic types in a separate commit from the more complicated ones like iterable, self, object, etc.

Jun 27 2017, 3:58 PM · KDevelop

Jun 22 2017

pprkut added inline comments to D6342: Add more typehints to arguments in PHP.
Jun 22 2017, 4:01 PM · KDevelop

Jun 19 2017

pprkut committed R52:2bc3f4d2e613: Support more cases of function argument unpacking. (authored by pprkut).
Support more cases of function argument unpacking.
Jun 19 2017, 1:27 PM
pprkut committed R52:d7c27dbe59e7: Add unit test for variadic functions with typehints. (authored by pprkut).
Add unit test for variadic functions with typehints.
Jun 19 2017, 1:27 PM
pprkut closed D6271: Minor improvements around the support for variadics by committing R52:2bc3f4d2e613: Support more cases of function argument unpacking..
Jun 19 2017, 1:27 PM
pprkut added a comment to D6271: Minor improvements around the support for variadics.

Fair enough, was just playing it safe :)

Jun 19 2017, 1:21 PM
pprkut created D6271: Minor improvements around the support for variadics.
Jun 19 2017, 12:19 PM

Jun 18 2017

pprkut committed R52:1cb4b3e37e5c: Support for variadic functions in documentation popup. (authored by pprkut).
Support for variadic functions in documentation popup.
Jun 18 2017, 5:24 PM
pprkut closed D6256: Support for variadic functions in documentation popup. by committing R52:1cb4b3e37e5c: Support for variadic functions in documentation popup..
Jun 18 2017, 5:24 PM
pprkut retitled D6256: Support for variadic functions in documentation popup. from [WIP] Support for variadic functions in documentation popup. to Support for variadic functions in documentation popup..
Jun 18 2017, 12:55 PM
pprkut updated the diff for D6256: Support for variadic functions in documentation popup..

Fixed showing correct structure type for variadic arguments.

Jun 18 2017, 12:52 PM
pprkut created D6256: Support for variadic functions in documentation popup..
Jun 18 2017, 10:53 AM

Jun 7 2017

pprkut committed R52:fb372fb18735: Fix potentially uninitialized property in the declaration builder. (authored by pprkut).
Fix potentially uninitialized property in the declaration builder.
Jun 7 2017, 6:42 PM
pprkut committed R52:077b02757c30: Implement syntax support for function argument unpacking. (authored by pprkut).
Implement syntax support for function argument unpacking.
Jun 7 2017, 6:42 PM
pprkut closed D5908: Implement syntax support for function argument unpacking. by committing R52:077b02757c30: Implement syntax support for function argument unpacking..
Jun 7 2017, 6:42 PM

May 24 2017

pprkut added inline comments to D5908: Implement syntax support for function argument unpacking..
May 24 2017, 2:09 PM

May 18 2017

pprkut updated the diff for D5908: Implement syntax support for function argument unpacking..

Correct base branch, try 2

May 18 2017, 8:35 AM
pprkut updated the diff for D5908: Implement syntax support for function argument unpacking..

Correct base branch

May 18 2017, 8:20 AM
pprkut created D5908: Implement syntax support for function argument unpacking..
May 18 2017, 8:13 AM
pprkut committed R52:1b622a0929a1: Merge remote-tracking branch 'origin/5.1' (authored by pprkut).
Merge remote-tracking branch 'origin/5.1'
May 18 2017, 7:41 AM

May 12 2017

pprkut committed R52:fd433b23319a: Fix duchain unit tests. (authored by pprkut).
Fix duchain unit tests.
May 12 2017, 6:20 PM
pprkut committed R52:435e829d408f: Fix whitespace errors in declarationbuilder. (authored by pprkut).
Fix whitespace errors in declarationbuilder.
May 12 2017, 6:20 PM
pprkut closed D5817: Fix duchain unit tests. by committing R52:435e829d408f: Fix whitespace errors in declarationbuilder..
May 12 2017, 6:20 PM
pprkut added a comment to D5817: Fix duchain unit tests..

The changes are currently based on the 5.1 branch, but I couldn't verify them locally. Almost none of the tests pass for me :(
I tested the changes on master and there everything is fine.

May 12 2017, 10:42 AM

May 11 2017

pprkut created D5817: Fix duchain unit tests..
May 11 2017, 8:20 PM
pprkut committed R52:17202e149e54: Add support for variadic functions. (authored by pprkut).
Add support for variadic functions.
May 11 2017, 7:09 PM
pprkut closed D5703: Add support for variadic functions. by committing R52:17202e149e54: Add support for variadic functions..
May 11 2017, 7:09 PM

May 5 2017

pprkut updated the diff for D5703: Add support for variadic functions..

Used PushValue

May 5 2017, 6:24 AM

May 3 2017

pprkut created D5703: Add support for variadic functions..
May 3 2017, 7:14 PM

Mar 6 2017

pprkut accepted D4902: Support of Class::{expr}() syntax from Php 5.4.

lgtm as well :)

Mar 6 2017, 8:54 AM · KDevelop