- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Apr 1 2020
Jan 28 2020
Jan 23 2020
Nov 9 2019
Jul 19 2019
Jul 14 2019
Oct 31 2018
Updated. Thanks! I will push it :)
Oct 29 2018
- changed as requested, will push tomorrow or so
- Initial test, works with the patch, fails without :)
Oct 27 2018
In D16356#347314, @mwolff wrote:I assume you ran the tests (esp. for clang?) and it all keeps passing? if so, then +1
+2 if you could write a proper test for the case you explained in your commit message
Oct 22 2018
- updated based on the suggestions from Milian Wolff
Oct 21 2018
Sorry, forgot to push it. Should it go to 5.3 or master?
- updated again master
- mentioned templates in commit title
Thx for the review :)
I will update the patch (and post it here again).
Oct 9 2018
Changed to (correct) ktexteditor repository. Someday... I will learn how to use phabricator :)
Oct 7 2018
This did not work for templates as "isComment" uses line attributes and at the time the template is inserted it is always "C/C++ Code/Data"-attribute never a comment. It only becomes a "doxygen comment"-attribute after the template "editing" is finished.
In D16018#338441, @cullmann wrote:...
For the code:
Hmm, why do you use rtrim? That removes trailing spaces, that won't help the startsWith checks. Or do I misread that?
Oct 4 2018
Used PATH_SUFFIXES to cleanup the find_path a bit more
Oct 3 2018
Added additional search PATHS with CLANG_LIBRARY_DIRS, like it was used in the original version (without this patch). This should hopefully work on opensuse as well.
"cpuid.h" on my system is in (listing ALL locations):
- /usr/lib64/clang/7.0.0/include/cpuid.h
- /usr/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/include/cpuid.h
- /usr/lib64/gcc/x86_64-pc-linux-gnu/8.2.0/include/cpuid.h
- and a few in /usr/src/linux-* (linux kernel sources)
Oct 2 2018
Sorry, you are right. I forgot the most important part of the patch. Sorry for the noise :(