Feed Advanced Search

Mar 10 2019

cordlandwehr committed R72:eac69baab4ef: Refactor welcome page and download integration (authored by cordlandwehr).
Refactor welcome page and download integration
Mar 10 2019, 1:24 PM
cordlandwehr added reviewers for D19654: Add lazy instantiation for submenus: apol, mart.
Mar 10 2019, 12:20 PM · Kirigami
cordlandwehr requested review of D19654: Add lazy instantiation for submenus.
Mar 10 2019, 12:18 PM · Kirigami

Feb 9 2019

cordlandwehr committed R72:9cf9339ae487: Remove widget based KNS download (authored by cordlandwehr).
Remove widget based KNS download
Feb 9 2019, 5:13 PM
cordlandwehr committed R72:63921a41a2c1: Wrap all UI strings with i18n (authored by cordlandwehr).
Wrap all UI strings with i18n
Feb 9 2019, 5:13 PM
cordlandwehr committed R72:b74b71ec4936: Modernize QML and add Downloads Page (authored by cordlandwehr).
Modernize QML and add Downloads Page
Feb 9 2019, 5:13 PM
cordlandwehr committed R72:da3c95e4a905: Adapt to internal layout of action icons (authored by cordlandwehr).
Adapt to internal layout of action icons
Feb 9 2019, 5:13 PM

Dec 22 2018

cordlandwehr accepted D12864: Upgrade to ubuntu bionic and Qt 5.12.
Dec 22 2018, 8:03 PM · Android
cordlandwehr added a comment to D12864: Upgrade to ubuntu bionic and Qt 5.12.

@dfaure it's absolutely fine for me to dump this repository and reference kdeorg/android-sdk. The ci-tooling repository looks much more mature and we should not have two competing solutions for an infrastructure task (especially, since the ci-tooling one is actively used and maintained)

Dec 22 2018, 7:31 PM · Android

Nov 25 2018

cordlandwehr closed D17139: Add highlighting file for Wayland Debug Traces.
Nov 25 2018, 2:43 PM · Frameworks, Kate
cordlandwehr committed R216:abb86831466b: Add highlighting file for Wayland Debug Traces (authored by cordlandwehr).
Add highlighting file for Wayland Debug Traces
Nov 25 2018, 2:43 PM

Nov 24 2018

cordlandwehr updated the diff for D17139: Add highlighting file for Wayland Debug Traces.
  • Fix detection of interface names with numbers
  • Fix reference for nomal text itemData
  • Add test data for Wayland trace highlighting
Nov 24 2018, 6:09 PM · Frameworks, Kate
cordlandwehr requested review of D17139: Add highlighting file for Wayland Debug Traces.
Nov 24 2018, 4:10 PM · Frameworks, Kate

Oct 12 2018

cordlandwehr added inline comments to D16156: Keeping the given code document filename consistent..
Oct 12 2018, 5:28 PM · KDE Edu

Oct 7 2018

cordlandwehr committed R73:647461e83841: Add fallback when project could not be loaded (authored by cordlandwehr).
Add fallback when project could not be loaded
Oct 7 2018, 8:37 AM
cordlandwehr added a comment to D15990: Makes the Code Editor Widget tabs closable..

Closing the source file directly leads to deleting the whole code document. IMO that is a too big operation to connect to the small [X] icon, which one could accidentally press, even when switching documents.
Either there should be a confirmation dialog that the source code really shall be deleted. Or there should be a code file deletion option that is only provided in a menu to avoid accidental code deletion.

Oct 7 2018, 8:13 AM · KDE Edu

Oct 3 2018

cordlandwehr accepted D15914: Fix compilation on Windows.
Oct 3 2018, 5:24 PM · Windows, KDE Edu
cordlandwehr added a comment to D15914: Fix compilation on Windows.

Yes, Pino is right, the export headers for the plugins are artifacts from a refactoring, which is not needed anymore.
It would be great if you could remove the export headers for both of the plugins.

Oct 3 2018, 12:02 PM · Windows, KDE Edu

Jul 12 2018

cordlandwehr added a reviewer for D13970: Handle empty preview lists: dhaumann.

Somehow removed all reviewers with my last message (sorry!)
Trying to fix this now.

Jul 12 2018, 4:45 PM · Frameworks
cordlandwehr committed R304:c4275aaf79fc: Handle empty preview lists (authored by cordlandwehr).
Handle empty preview lists
Jul 12 2018, 4:43 PM
cordlandwehr closed D13970: Handle empty preview lists.
Jul 12 2018, 4:43 PM · Frameworks

Jul 8 2018

D13970: Handle empty preview lists now requires review to proceed.

I had a crash at the respective locations while porting Artikulate to the QtQuick based API, since those KNS resource files do not provide previews.
However, IMO this patch fixes an unsafe access to a list element without checking that it exists.

Jul 8 2018, 8:32 PM · Frameworks
cordlandwehr requested review of D13970: Handle empty preview lists.
Jul 8 2018, 4:29 PM · Frameworks

Jun 25 2018

cordlandwehr committed R169:27fb2591c54b: Handle enabled property of simple models (authored by cordlandwehr).
Handle enabled property of simple models
Jun 25 2018, 6:26 PM
cordlandwehr committed R72:57328cea4c53: Remove language goal selector page (authored by cordlandwehr).
Remove language goal selector page
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:4f542b137c01: Initial port to use Kirigam menu for training actions (authored by cordlandwehr).
Initial port to use Kirigam menu for training actions
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:c0cef4f1a0c7: Split main menu actions into training and config part (authored by cordlandwehr).
Split main menu actions into training and config part
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:ef248c5a5307: Enforce drawer to be open (authored by cordlandwehr).
Enforce drawer to be open
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:eddbb1b9c31d: Rename sections (authored by cordlandwehr).
Rename sections
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:b28791466406: Remove unused header (authored by cordlandwehr).
Remove unused header
Jun 25 2018, 6:13 PM
cordlandwehr closed D13696: Handle enabled property of simple models.
Jun 25 2018, 6:09 PM · Kirigami

Jun 24 2018

cordlandwehr updated the diff for D13696: Handle enabled property of simple models.

Fixed logical error

Jun 24 2018, 6:36 AM · Kirigami

Jun 23 2018

cordlandwehr requested review of D13696: Handle enabled property of simple models.
Jun 23 2018, 11:06 AM · Kirigami

Jan 2 2018

cordlandwehr committed R72:3a593b11e2f5: Port setting pages from tab groups (authored by cordlandwehr).
Port setting pages from tab groups
Jan 2 2018, 8:16 PM
cordlandwehr committed R72:fa647b52fed3: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Jan 2 2018, 8:16 PM
cordlandwehr committed R72:62e404df82a3: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Jan 2 2018, 8:16 PM
cordlandwehr committed R72:4330a235cd88: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Jan 2 2018, 8:16 PM
cordlandwehr committed R72:47aabe0ab656: GIT_SILENT made messages (after extraction) (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT made messages (after extraction)
Jan 2 2018, 8:16 PM
cordlandwehr committed R72:2f07dd5006be: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Jan 2 2018, 8:16 PM
cordlandwehr committed R72:193ccd4e1306: Fix the desktop file (Exec key) (authored by ltoscano).
Fix the desktop file (Exec key)
Jan 2 2018, 8:16 PM

Aug 19 2017

cordlandwehr accepted D7392: Add script to add or remove framework releases.

Yes, I was wondering if we will provide several versions in parallel especially since the patches usually only work for one specific release.
But I see the point in a possible future provision of multiple versions.

Aug 19 2017, 1:46 PM
cordlandwehr added a comment to D7392: Add script to add or remove framework releases.

Do you have a specific reason to split this into two separate steps and not having an "update" action?

Aug 19 2017, 1:28 PM
cordlandwehr accepted D7396: Update to KF 5.37.0.
Aug 19 2017, 1:23 PM

Aug 14 2017

cordlandwehr accepted D7276: Fix KAuth code generator.
Aug 14 2017, 5:47 PM
cordlandwehr accepted D7277: Add KTextEditor recipe.
Aug 14 2017, 5:44 PM

Aug 10 2017

cordlandwehr accepted D7220: Add Baloo recipe.
Aug 10 2017, 8:20 PM

Aug 8 2017

cordlandwehr committed R32:de37265e0536: Process QML runtime errors (authored by cordlandwehr).
Process QML runtime errors
Aug 8 2017, 5:05 PM
cordlandwehr committed R32:87a69ce3b5f3: Add view even if document is not proper UrlDocument (authored by cordlandwehr).
Add view even if document is not proper UrlDocument
Aug 8 2017, 5:04 PM
cordlandwehr committed R32:99db1a6956bb: Use folder prefix is filename is not unique (authored by cordlandwehr).
Use folder prefix is filename is not unique
Aug 8 2017, 5:04 PM
cordlandwehr committed R32:cb684c9d0aef: Fix assert due to non normalized indexed string (authored by cordlandwehr).
Fix assert due to non normalized indexed string
Aug 8 2017, 5:04 PM
cordlandwehr committed R32:467c47d6c8d7: Fix obvious typo in copyright header. (authored by cordlandwehr).
Fix obvious typo in copyright header.
Aug 8 2017, 5:03 PM
cordlandwehr committed R32:1d87fc630265: Do not assert if process survives kill. (authored by cordlandwehr).
Do not assert if process survives kill.
Aug 8 2017, 5:03 PM
cordlandwehr committed R32:386991aa25e5: Fix Title Flickering on Document Change (authored by cordlandwehr).
Fix Title Flickering on Document Change
Aug 8 2017, 5:03 PM
cordlandwehr committed R32:ccdbe161eccb: Avoid CMP0063 CMake warnigs (authored by cordlandwehr).
Avoid CMP0063 CMake warnigs
Aug 8 2017, 5:03 PM
cordlandwehr committed R32:6e56496997fe: Fix declaration name access if not fully parsed (authored by cordlandwehr).
Fix declaration name access if not fully parsed
Aug 8 2017, 5:02 PM
cordlandwehr committed R32:46d2612955c8: Fix declaration name access if not fully parsed (authored by cordlandwehr).
Fix declaration name access if not fully parsed
Aug 8 2017, 5:02 PM
cordlandwehr committed R32:a974f4193aa7: Fix Display of Ampersand in Context Menu (authored by cordlandwehr).
Fix Display of Ampersand in Context Menu
Aug 8 2017, 5:02 PM
cordlandwehr committed R32:1eb49ae801db: Fix Display of Ampersand in Context Menu (authored by cordlandwehr).
Fix Display of Ampersand in Context Menu
Aug 8 2017, 5:02 PM
cordlandwehr committed R32:c5f254145778: Use complete include subpath. (authored by cordlandwehr).
Use complete include subpath.
Aug 8 2017, 5:02 PM
cordlandwehr committed R32:259218d904bd: Fix default fallback for Sublime::View. (authored by cordlandwehr).
Fix default fallback for Sublime::View.
Aug 8 2017, 4:59 PM

Aug 7 2017

cordlandwehr accepted D7119: Add Plasma framework recipe.
Aug 7 2017, 7:23 PM
cordlandwehr accepted D7120: Add KRunner recipe.
Aug 7 2017, 7:21 PM
cordlandwehr accepted D7118: Add KPeople recipe.
Aug 7 2017, 7:20 PM · Frameworks
cordlandwehr accepted D7137: Add KNewStuff recipe.
Aug 7 2017, 7:19 PM
cordlandwehr accepted D7138: Add KWallet recipe.
Aug 7 2017, 7:19 PM
cordlandwehr accepted D7140: Add KEmoticons recipe.
Aug 7 2017, 7:17 PM
cordlandwehr accepted D7141: Add KNotifyConfig recipe.
Aug 7 2017, 7:17 PM
cordlandwehr accepted D7144: Add KInit recipe.
Aug 7 2017, 7:16 PM
cordlandwehr accepted D7145: Add KDED recipe.
Aug 7 2017, 7:16 PM
cordlandwehr accepted D7148: Add KCMUtils recipe.
Aug 7 2017, 7:15 PM
cordlandwehr accepted D7150: Add KParts recipe.
Aug 7 2017, 7:14 PM
cordlandwehr accepted D7151: Add KActivitiesStats recipe.
Aug 7 2017, 7:13 PM
cordlandwehr accepted D7152: Add KDESu recipe.
Aug 7 2017, 7:12 PM

Aug 3 2017

cordlandwehr accepted D7079: Add Kirigami recipe.
Aug 3 2017, 7:58 PM
cordlandwehr accepted D7080: Add BluezQt recipe.
Aug 3 2017, 7:57 PM
cordlandwehr accepted D7081: Add NetworkManagerQt recipe.
Aug 3 2017, 7:56 PM
cordlandwehr accepted D7082: Add ModemManagerQt recipe.
Aug 3 2017, 7:55 PM
cordlandwehr accepted D7083: Add Breeze icon theme recipe.
Aug 3 2017, 7:54 PM
cordlandwehr accepted D7101: Add Oxygen icons recipe.
Aug 3 2017, 7:53 PM
cordlandwehr accepted D7104: Add KSyntaxHighlighting recipe.
Aug 3 2017, 7:52 PM
cordlandwehr accepted D7109: Add KXmlRpcClient recipe.
Aug 3 2017, 7:50 PM

Jul 31 2017

cordlandwehr accepted D7023: Improve handling of host tools.

Very nice :)

Jul 31 2017, 6:15 PM
cordlandwehr accepted D7022: Add KIO recipe.
Jul 31 2017, 6:03 PM
cordlandwehr accepted D7020: Add KXmlGui recipe.
Jul 31 2017, 6:02 PM
cordlandwehr accepted D7019: Move handling of cmake/qmake dev files to the KF5 class.
Jul 31 2017, 6:02 PM
cordlandwehr accepted D7009: Add KTextWidgets recipe.
Jul 31 2017, 6:00 PM
cordlandwehr accepted D7006: Add KIconThemes recipe.
Jul 31 2017, 5:58 PM
cordlandwehr accepted D7005: Add KConfigWidgets recipe.
Jul 31 2017, 5:58 PM
cordlandwehr accepted D7004: Add KService recipe.
Jul 31 2017, 5:56 PM
cordlandwehr accepted D7003: Add KFileMetaData recipe.
Jul 31 2017, 5:56 PM
cordlandwehr accepted D7002: Add KActivities recipe.
Jul 31 2017, 5:55 PM
cordlandwehr accepted D7001: Make KAuth actually build.
Jul 31 2017, 5:55 PM
cordlandwehr accepted D7000: Add KNotification recipe.
Jul 31 2017, 5:54 PM
cordlandwehr accepted D6997: Add KPackage recipe.
Jul 31 2017, 5:52 PM
cordlandwehr accepted D6998: Add KCompletion recipe.
Jul 31 2017, 5:52 PM
cordlandwehr accepted D6996: Make kglobalaccel actually build.
Jul 31 2017, 5:51 PM

Jul 30 2017

cordlandwehr accepted D6991: Add Sonnet recipe.
Jul 30 2017, 2:33 PM
cordlandwehr accepted D6989: Add KWayland recipe.
Jul 30 2017, 2:31 PM
cordlandwehr accepted D6988: Add recipe for Prison.

Only minor comment about the SRC_URI.

Jul 30 2017, 11:41 AM
cordlandwehr accepted D6987: Add KConfig recipe.
Jul 30 2017, 11:36 AM