Feed Advanced Search

Jul 19 2019

vonreth added a comment to D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.

Then they should be blacklisted. But if that's the right destination for those services they should all be moved.

Jul 19 2019, 5:46 PM
vonreth added a comment to D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.

Wouldn't the same not apply for others too?

Jul 19 2019, 3:38 PM
vonreth committed R138:a2e8bd08f6ca: Fix unsetting of options (authored by vonreth).
Fix unsetting of options
Jul 19 2019, 3:10 PM
vonreth added a reviewer for D22561: Properly detect linux binaries: bcooksley.
Jul 19 2019, 2:59 PM
vonreth requested review of D22561: Properly detect linux binaries.
Jul 19 2019, 2:59 PM
vonreth committed R138:04a149477759: Don't recognize files in dSYM/ as binaries (authored by vonreth).
Don't recognize files in dSYM/ as binaries
Jul 19 2019, 2:39 PM
vonreth committed R877:f2c370518489: Fix dep (authored by vonreth).
Fix dep
Jul 19 2019, 2:17 PM
vonreth added a comment to D22530: Copy kioslave into KDE Connect app package.

I think this one can be closed now?

Jul 19 2019, 12:36 PM
vonreth accepted D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.

sounds good

Jul 19 2019, 12:36 PM
vonreth committed R138:73ecc5a74170: Fix archive name (authored by vonreth).
Fix archive name
Jul 19 2019, 12:42 AM

Jul 18 2019

vonreth committed R138:d2e01f1f5b6e: Fiy typo (authored by vonreth).
Fiy typo
Jul 18 2019, 5:30 PM
vonreth committed R138:514506d717f7: dSYM not dSym (authored by vonreth).
dSYM not dSym
Jul 18 2019, 5:21 PM
vonreth committed R877:9929361d815e: Don't build dbus static lib (authored by vonreth).
Don't build dbus static lib
Jul 18 2019, 2:35 PM
vonreth committed R877:72a3605742ec: We can't cache dbus, as it hardcodes the location of the daemon (authored by vonreth).
We can't cache dbus, as it hardcodes the location of the daemon
Jul 18 2019, 2:35 PM
vonreth added a comment to D22530: Copy kioslave into KDE Connect app package.

I think that we can asume that we want to use it if its not blacklisted and thus exists in the archiveDir

Jul 18 2019, 12:51 PM
vonreth added a comment to D22530: Copy kioslave into KDE Connect app package.

Could you think ab out a more general solution? Maybe move it to the macdmgpackager?
In order to work this needs to be done for all packages, not only kde-connect.

Jul 18 2019, 12:48 PM
vonreth committed R138:28b234f33346: Disable dbg image creation on mac for now (authored by vonreth).
Disable dbg image creation on mac for now
Jul 18 2019, 11:48 AM
vonreth committed R138:443bfe941c43: Fix file name (authored by vonreth).
Fix file name
Jul 18 2019, 11:33 AM
vonreth committed R138:d28d6c59a039: Seperate symbols when generating a dmg file on mac (authored by vonreth).
Seperate symbols when generating a dmg file on mac
Jul 18 2019, 11:22 AM
vonreth committed R138:dc35df910e79: Remove legacy code (authored by vonreth).
Remove legacy code
Jul 18 2019, 9:29 AM
vonreth committed R138:1ca373ed8e13: Seperate debug symbols on mac (authored by vonreth).
Seperate debug symbols on mac
Jul 18 2019, 9:29 AM
vonreth closed D22518: Seperate debug symbols on mac.
Jul 18 2019, 9:29 AM

Jul 17 2019

vonreth added a reviewer for D22518: Seperate debug symbols on mac: fazevedo.
Jul 17 2019, 7:43 PM
vonreth added reviewers for D22518: Seperate debug symbols on mac: bcooksley, dschmidt.
Jul 17 2019, 7:40 PM
vonreth requested review of D22518: Seperate debug symbols on mac.
Jul 17 2019, 7:38 PM
vonreth committed R138:ea2b4b83b92a: Unify mac image name with the other installers (authored by vonreth).
Unify mac image name with the other installers
Jul 17 2019, 3:03 PM
vonreth committed R138:e9e689ff9890: Fix appx name (authored by vonreth).
Fix appx name
Jul 17 2019, 3:03 PM
vonreth committed R138:2ddc1c55d1ee: Make sign tool more verbose for now (authored by vonreth).
Make sign tool more verbose for now
Jul 17 2019, 2:28 PM
vonreth committed R138:65a3d3eb7a21: Make cache hash less strict (authored by vonreth).
Make cache hash less strict
Jul 17 2019, 1:49 PM
vonreth committed R138:08b51fab5967: Use sed to split env, this fixes support for zsh which lask IFS (authored by vonreth).
Use sed to split env, this fixes support for zsh which lask IFS
Jul 17 2019, 9:35 AM

Jul 15 2019

vonreth committed R138:a62f7593b135: Cleanup (authored by vonreth).
Cleanup
Jul 15 2019, 6:51 PM
vonreth committed R877:a6eab67aea01: Return something (authored by vonreth).
Return something
Jul 15 2019, 6:33 PM
vonreth committed R877:362c76377ac2: x264 install single threaded (authored by vonreth).
x264 install single threaded
Jul 15 2019, 6:31 PM
vonreth committed R138:c9a78e571996: Improve the logic of the install step (authored by vonreth).
Improve the logic of the install step
Jul 15 2019, 6:02 PM
vonreth committed R138:05b5d5b6612d: Only sign if we create the cache package (authored by vonreth).
Only sign if we create the cache package
Jul 15 2019, 5:53 PM
vonreth committed R138:46f0fc936f9f: Don't fail if signing failed (authored by vonreth).
Don't fail if signing failed
Jul 15 2019, 5:45 PM
vonreth committed R138:08f77a496f22: Fix command (authored by vonreth).
Fix command
Jul 15 2019, 5:31 PM
vonreth committed R138:99ed5ae96d10: Fix command length computation (authored by vonreth).
Fix command length computation
Jul 15 2019, 5:28 PM
vonreth committed R138:165e3f5fcc5d: Fix signing (authored by vonreth).
Fix signing
Jul 15 2019, 5:24 PM
vonreth committed R138:0a6465e31b8d: Fail if sign fails (authored by vonreth).
Fail if sign fails
Jul 15 2019, 4:42 PM
vonreth committed R138:11922425c318: Allow to reuse the result of the filter (authored by vonreth).
Allow to reuse the result of the filter
Jul 15 2019, 4:42 PM
vonreth committed R993:9b151c07497b: Sign the cache (authored by vonreth).
Sign the cache
Jul 15 2019, 4:19 PM
vonreth committed R138:7eea55fe87a9: Allow to sign the cache (authored by vonreth).
Allow to sign the cache
Jul 15 2019, 4:17 PM
vonreth committed R993:bdc77edb1e0a: Drop Qt_ prefix for cache version (authored by vonreth).
Drop Qt_ prefix for cache version
Jul 15 2019, 1:30 PM
vonreth committed R993:ace44b6508c7: Revert "Drop Qt_ prefix for cache version" (authored by vonreth).
Revert "Drop Qt_ prefix for cache version"
Jul 15 2019, 1:30 PM
vonreth added a reverting change for R993:bdc77edb1e0a: Drop Qt_ prefix for cache version: R993:ace44b6508c7: Revert "Drop Qt_ prefix for cache version".
Jul 15 2019, 1:30 PM
vonreth committed R993:02d783957912: Use default kshim target (authored by vonreth).
Use default kshim target
Jul 15 2019, 1:30 PM
vonreth committed R138:74eb9215e03c: Cache location of signtool (authored by vonreth).
Cache location of signtool
Jul 15 2019, 12:56 PM

Jul 11 2019

vonreth committed R834:0d8e2f993d5c: Try to display a notification even if we get the warning that it is disabled (authored by vonreth).
Try to display a notification even if we get the warning that it is disabled
Jul 11 2019, 8:18 AM
vonreth requested changes to D22364: Fix dependencies and kio-slave in Dolphin on macOS.
Jul 11 2019, 7:28 AM

Jul 10 2019

vonreth accepted D22384: Add Atelier QML recipe.
Jul 10 2019, 9:33 PM
vonreth added inline comments to D22384: Add Atelier QML recipe.
Jul 10 2019, 8:05 PM
vonreth requested changes to D22384: Add Atelier QML recipe.
Jul 10 2019, 6:59 PM
vonreth committed R138:2f05424f2ec9: seperate gcc symbols during the install step (authored by vonreth).
seperate gcc symbols during the install step
Jul 10 2019, 2:43 PM
vonreth committed R138:7df8497b63a0: Save blueprint config in cache manifest, if config differs, don't restore from… (authored by vonreth).
Save blueprint config in cache manifest, if config differs, don't restore from…
Jul 10 2019, 1:33 PM
vonreth committed R138:c5d598c113cb: quote file names (authored by vonreth).
quote file names
Jul 10 2019, 12:37 PM

Jul 9 2019

vonreth accepted D22105: Fix SFTP Plugin of KIO for Windows.

looks good

Jul 9 2019, 6:09 PM · Frameworks, Dolphin
vonreth added a comment to D22105: Fix SFTP Plugin of KIO for Windows.

I think you need to set(CMAKE_CXX_STANDARD 17) to make this compile with mingw

Jul 9 2019, 6:00 PM · Frameworks, Dolphin
vonreth added a reviewer for D22338: Save blueprint config in cache manifest, if config differs, don't restore from cache: bcooksley.
Jul 9 2019, 9:41 AM
vonreth updated the diff for D22338: Save blueprint config in cache manifest, if config differs, don't restore from cache.

Remove debug oupu

Jul 9 2019, 9:40 AM
vonreth requested review of D22338: Save blueprint config in cache manifest, if config differs, don't restore from cache.
Jul 9 2019, 9:36 AM
vonreth committed R993:4ad4177a901d: Fix duplicated config entry (authored by vonreth).
Fix duplicated config entry
Jul 9 2019, 6:52 AM

Jul 8 2019

vonreth committed R993:8ddceeabd48e: Use seperate manifest for the installer (authored by vonreth).
Use seperate manifest for the installer
Jul 8 2019, 8:01 PM
vonreth committed R993:fcac810bc22d: Upload packages (authored by vonreth).
Upload packages
Jul 8 2019, 5:29 PM
vonreth committed R993:3d9e11cef279: Update craft prebuilt config (authored by vonreth).
Update craft prebuilt config
Jul 8 2019, 5:13 PM
vonreth committed R993:4ea6870fdb83: Fix git url (authored by vonreth).
Fix git url
Jul 8 2019, 12:37 PM
vonreth committed R138:abc57db40e2a: Only uninstalle file that are part of the installer (authored by vonreth).
Only uninstalle file that are part of the installer
Jul 8 2019, 11:30 AM
vonreth committed R138:a432d5115efc: Fix bootstrap (authored by vonreth).
Fix bootstrap
Jul 8 2019, 8:42 AM

Jul 5 2019

vonreth committed R138:32cbaad1b9b9: Build kshimgen from tar (authored by vonreth).
Build kshimgen from tar
Jul 5 2019, 1:07 PM
vonreth committed R993:497bb7e094c3: Add a special pipeline to provide standalone prebuilt applications for craft (authored by vonreth).
Add a special pipeline to provide standalone prebuilt applications for craft
Jul 5 2019, 12:27 PM
vonreth committed R993:ad0338b7f949: Add a special pipeline to provide standalone prebuilt applications for craft (authored by vonreth).
Add a special pipeline to provide standalone prebuilt applications for craft
Jul 5 2019, 12:06 PM

Jul 4 2019

vonreth committed R138:f84a8dac9a7d: Don't cache master (authored by vonreth).
Don't cache master
Jul 4 2019, 8:34 PM
vonreth committed R993:e204fe8fef3f: Try new kshim (authored by vonreth).
Try new kshim
Jul 4 2019, 7:18 PM
vonreth committed R993:c076765177b5: Build Qt 5.13.0 on craft experimental (authored by vonreth).
Build Qt 5.13.0 on craft experimental
Jul 4 2019, 7:18 PM
vonreth committed R138:7279450c407e: Add tag (authored by vonreth).
Add tag
Jul 4 2019, 7:10 PM
vonreth committed R877:9b8685e25950: Fix qtwebkit (authored by vonreth).
Fix qtwebkit
Jul 4 2019, 7:00 PM
vonreth committed R877:8b53f309e8db: Add qt 5.13.0 (authored by vonreth).
Add qt 5.13.0
Jul 4 2019, 5:57 PM

Jul 3 2019

vonreth added inline comments to D22105: Fix SFTP Plugin of KIO for Windows.
Jul 3 2019, 9:41 PM · Frameworks, Dolphin
vonreth accepted D21602: Add NSIS Script for KDE Connect.

ship it.
Snore toast will already get installed but the notifications will be missing.

Jul 3 2019, 7:27 AM · Craft, KDE Connect
vonreth added a comment to D22105: Fix SFTP Plugin of KIO for Windows.

Any reason why you skip the symlinks?
I mean displaying thm should be fine, dolphin probably can also follow them.
Creating them on windows is a bit more problematic.

Jul 3 2019, 7:21 AM · Frameworks, Dolphin
vonreth committed R877:366703f1fb61: Fix instll dir (authored by vonreth).
Fix instll dir
Jul 3 2019, 7:19 AM

Jul 2 2019

vonreth committed R877:813d2d9ecfce: Update snoretoast to 0.6.0 (authored by vonreth).
Update snoretoast to 0.6.0
Jul 2 2019, 11:39 AM

Jul 1 2019

vonreth committed R834:b4d4becff24b: Mention nigtly builds (authored by vonreth).
Mention nigtly builds
Jul 1 2019, 1:35 PM
vonreth committed R138:ca61e73edce0: Don't set CREATE_NEW_CONSOLE as the created process can't be killed (authored by vonreth).
Don't set CREATE_NEW_CONSOLE as the created process can't be killed
Jul 1 2019, 12:20 PM
vonreth committed R834:c79c831dce7b: Fix guid (authored by vonreth).
Fix guid
Jul 1 2019, 9:36 AM
vonreth committed R834:55800f1eb016: Version bump (authored by vonreth).
Version bump
Jul 1 2019, 9:22 AM

Jun 28 2019

vonreth committed R834:760c09610aab: Add logo and build status to readme (authored by vonreth).
Add logo and build status to readme
Jun 28 2019, 7:56 AM
vonreth committed R834:b1f89d197d35: Don't print error if there is none (authored by vonreth).
Don't print error if there is none
Jun 28 2019, 7:41 AM
vonreth committed R834:d55b1ac40d6b: toStdWchar seems to work again with msvc2019 (authored by vonreth).
toStdWchar seems to work again with msvc2019
Jun 28 2019, 7:41 AM
vonreth committed R834:f5410c550efe: Use a lowercase name for the exe, as we are on Windows that change schould not… (authored by vonreth).
Use a lowercase name for the exe, as we are on Windows that change schould not…
Jun 28 2019, 6:43 AM
vonreth committed R834:0c2ba6de2940: No need for modification of image path (authored by vonreth).
No need for modification of image path
Jun 28 2019, 6:37 AM
vonreth committed R834:c6cef156c672: Only write icon if it desn't exist yet (authored by vonreth).
Only write icon if it desn't exist yet
Jun 28 2019, 6:37 AM

Jun 27 2019

vonreth committed R834:8ca27e71f1e4: Provide a default image if none is provided (authored by vonreth).
Provide a default image if none is provided
Jun 27 2019, 9:19 PM
vonreth committed R834:ae84cfc5f3b9: Refactor rc compilation (authored by vonreth).
Refactor rc compilation
Jun 27 2019, 9:19 PM
vonreth committed R834:64dca2e720ff: Generate new ico (authored by vonreth).
Generate new ico
Jun 27 2019, 8:58 PM
vonreth accepted D22126: Add snoretoast icon.

I love them and this should be enough :D

Jun 27 2019, 8:19 PM
vonreth added a comment to D22126: Add snoretoast icon.

I think a bigger one than 265 could be used here (windows start menu)

Jun 27 2019, 8:00 PM
vonreth added a comment to D22126: Add snoretoast icon.

Ah your right.

Jun 27 2019, 7:57 PM
vonreth added a comment to D22126: Add snoretoast icon.

I had a look at https://github.com/KDE/extra-cmake-modules/blob/master/modules/ECMAddAppIcon.cmake#L221 a 1024 icon could also be useful.

Jun 27 2019, 7:47 PM
vonreth added a comment to D22126: Add snoretoast icon.

I learned the hard way what errors you can make during export 🙈 (if you have no idea what your doing)
Could you already dump the png's?

Jun 27 2019, 7:28 PM