Feed Advanced Search

Jul 23 2019

vonreth committed R877:25d3f1da8cf9: Yasm servers are down, build it from src (authored by vonreth).
Yasm servers are down, build it from src
Jul 23 2019, 10:00 AM
vonreth accepted D22678: Remove kdeconnectd in kdeconnect-kde blueprint.
Jul 23 2019, 9:47 AM

Jul 22 2019

vonreth added a comment to D22659: Fix bracket.
Applications/19.08 was branched before the commit introducing this issue
Jul 22 2019, 8:09 PM · Frameworks, Dolphin
vonreth committed R138:aac95bfb78e8: Don't store windows path in manifest (authored by vonreth).
Don't store windows path in manifest
Jul 22 2019, 7:03 PM
vonreth committed R138:1c8c3c7c4f08: Use simple replace (authored by vonreth).
Use simple replace
Jul 22 2019, 7:00 PM
vonreth committed R320:872083cefb55: Fix bracket (authored by vonreth).
Fix bracket
Jul 22 2019, 6:58 PM
vonreth closed D22659: Fix bracket.
Jul 22 2019, 6:58 PM · Frameworks, Dolphin
vonreth committed R138:8ac5fe49d11b: Properly deploy libexec on mac (authored by vonreth).
Properly deploy libexec on mac
Jul 22 2019, 6:55 PM
vonreth committed R138:edca833659e9: Ensure forward slashes (authored by vonreth).
Ensure forward slashes
Jul 22 2019, 6:55 PM
vonreth closed D22649: Properly deploy libexec on mac.
Jul 22 2019, 6:55 PM
vonreth added a reviewer for D22659: Fix bracket: brute4s99.
Jul 22 2019, 6:05 PM · Frameworks, Dolphin
vonreth requested review of D22659: Fix bracket.
Jul 22 2019, 6:05 PM · Frameworks, Dolphin
vonreth added a comment to D22649: Properly deploy libexec on mac.

This has become possible as https://commits.kde.org/craft/da3bc08fb74971a162f1b483bb598a809c726c94 now correctly filters

Jul 22 2019, 2:15 PM
vonreth added reviewers for D22649: Properly deploy libexec on mac: fazevedo, Inoki.
Jul 22 2019, 2:13 PM
vonreth requested review of D22649: Properly deploy libexec on mac.
Jul 22 2019, 2:13 PM
vonreth committed R138:da3bc08fb749: Fix filter, so only binaries get selected (authored by vonreth).
Fix filter, so only binaries get selected
Jul 22 2019, 2:07 PM
vonreth accepted D22644: Add kpeoplevcard blueprint.
Jul 22 2019, 1:54 PM
vonreth added a comment to D22644: Add kpeoplevcard blueprint.

We usually place blueprints along with the blurepriints they are released with.
as this is currently unreleased maybe kde/unreleased?

Jul 22 2019, 1:45 PM
vonreth committed R877:8643e6bd0449: Fix deps (authored by vonreth).
Fix deps
Jul 22 2019, 1:21 PM
vonreth committed R877:9b4c3810c764: dolphin needs kio-extras on mac too (authored by vonreth).
dolphin needs kio-extras on mac too
Jul 22 2019, 12:58 PM
vonreth committed R138:9b0b94e8d21a: Fix exception (authored by vonreth).
Fix exception
Jul 22 2019, 12:32 PM
vonreth committed R138:beffc536df79: Make download errors more verbose in ci mode (authored by vonreth).
Make download errors more verbose in ci mode
Jul 22 2019, 12:27 PM
vonreth committed R138:32a0f8b9fc91: Fix typo (authored by vonreth).
Fix typo
Jul 22 2019, 12:15 PM
vonreth added a comment to D22604: Add kpeople and kirigami as dependencies.

build time deps are only required during build (cmake, ninja etc) runtime deps are always needed and need to be shipped

Jul 22 2019, 11:58 AM
vonreth committed R138:c9fdc890610b: Fail if a fetching from cache fails in a cache build (authored by vonreth).
Fail if a fetching from cache fails in a cache build
Jul 22 2019, 11:57 AM
vonreth committed R138:24b2f8925816: Cleanup (authored by vonreth).
Cleanup
Jul 22 2019, 11:57 AM
vonreth committed R138:f1b0fd781e58: Remove dead code (authored by vonreth).
Remove dead code
Jul 22 2019, 11:57 AM
vonreth added a comment to D22604: Add kpeople and kirigami as dependencies.

And it doesn't link and is not needed during runtime?

Jul 22 2019, 11:50 AM
vonreth added a comment to D22635: add new dependencies for KDE Connect.

same as https://phabricator.kde.org/D22604

Jul 22 2019, 11:34 AM
vonreth accepted D22604: Add kpeople and kirigami as dependencies.
Jul 22 2019, 11:33 AM
vonreth accepted D22615: Add qml dirs definitions into MacOSDMGPackager.
Jul 22 2019, 11:26 AM
vonreth requested changes to D22635: add new dependencies for KDE Connect.

they are runtime deps

Jul 22 2019, 11:16 AM

Jul 21 2019

vonreth added a comment to D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.

I think that change had some unforseen effects https://binary-factory.kde.org/job/Dolphin_Release_macos/498/console

Yes, a filesharelist softlink to fileshareset is also imported...

How about just copying kioslave to avoid such effect?

Jul 21 2019, 10:23 AM
vonreth added a comment to D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.

I think that change had some unforseen effects https://binary-factory.kde.org/job/Dolphin_Release_macos/498/console

Jul 21 2019, 9:53 AM
vonreth committed R138:847584a13ad1: Fix filename of archives (authored by vonreth).
Fix filename of archives
Jul 21 2019, 9:26 AM
vonreth committed R877:3468e3da9bdb: Use the correct build system on the correct platform (authored by vonreth).
Use the correct build system on the correct platform
Jul 21 2019, 9:22 AM
vonreth committed R138:5406f2a00d85: Disable shortpaths on unix again (authored by vonreth).
Disable shortpaths on unix again
Jul 21 2019, 9:21 AM
vonreth added a comment to D22105: Fix SFTP Plugin of KIO for Windows.

Please revert the changes to qCDebug

Jul 21 2019, 8:34 AM · Frameworks, Dolphin

Jul 20 2019

vonreth committed R993:26f7589bf776: Fix csft shortpath dir on unix (authored by vonreth).
Fix csft shortpath dir on unix
Jul 20 2019, 11:41 AM
vonreth abandoned D22338: Save blueprint config in cache manifest, if config differs, don't restore from cache.

was merged

Jul 20 2019, 10:05 AM
vonreth committed R138:5edff547b4ff: Properly detect linux binaries (authored by vonreth).
Properly detect linux binaries
Jul 20 2019, 10:04 AM
vonreth closed D22561: Properly detect linux binaries.
Jul 20 2019, 10:04 AM
vonreth accepted D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.
Jul 20 2019, 10:03 AM
vonreth committed R138:4594d8d4c119: Log more (authored by vonreth).
Log more
Jul 20 2019, 9:52 AM
vonreth committed R138:14cd4bb3e0ff: As we now encounter path issues on linux lets try shortpaths there too (authored by vonreth).
As we now encounter path issues on linux lets try shortpaths there too
Jul 20 2019, 9:36 AM
vonreth committed R877:f26c286ab52d: Try atutotools build with mingw (authored by vonreth).
Try atutotools build with mingw
Jul 20 2019, 9:15 AM

Jul 19 2019

vonreth added a comment to D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.

Then they should be blacklisted. But if that's the right destination for those services they should all be moved.

Jul 19 2019, 5:46 PM
vonreth added a comment to D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.

Wouldn't the same not apply for others too?

Jul 19 2019, 3:38 PM
vonreth committed R138:a2e8bd08f6ca: Fix unsetting of options (authored by vonreth).
Fix unsetting of options
Jul 19 2019, 3:10 PM
vonreth added a reviewer for D22561: Properly detect linux binaries: bcooksley.
Jul 19 2019, 2:59 PM
vonreth requested review of D22561: Properly detect linux binaries.
Jul 19 2019, 2:59 PM
vonreth committed R138:04a149477759: Don't recognize files in dSYM/ as binaries (authored by vonreth).
Don't recognize files in dSYM/ as binaries
Jul 19 2019, 2:39 PM
vonreth committed R877:f2c370518489: Fix dep (authored by vonreth).
Fix dep
Jul 19 2019, 2:17 PM
vonreth added a comment to D22530: Copy kioslave into KDE Connect app package.

I think this one can be closed now?

Jul 19 2019, 12:36 PM
vonreth accepted D22558: Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing.

sounds good

Jul 19 2019, 12:36 PM
vonreth committed R138:73ecc5a74170: Fix archive name (authored by vonreth).
Fix archive name
Jul 19 2019, 12:42 AM

Jul 18 2019

vonreth committed R138:d2e01f1f5b6e: Fiy typo (authored by vonreth).
Fiy typo
Jul 18 2019, 5:30 PM
vonreth committed R138:514506d717f7: dSYM not dSym (authored by vonreth).
dSYM not dSym
Jul 18 2019, 5:21 PM
vonreth committed R877:9929361d815e: Don't build dbus static lib (authored by vonreth).
Don't build dbus static lib
Jul 18 2019, 2:35 PM
vonreth committed R877:72a3605742ec: We can't cache dbus, as it hardcodes the location of the daemon (authored by vonreth).
We can't cache dbus, as it hardcodes the location of the daemon
Jul 18 2019, 2:35 PM
vonreth added a comment to D22530: Copy kioslave into KDE Connect app package.

I think that we can asume that we want to use it if its not blacklisted and thus exists in the archiveDir

Jul 18 2019, 12:51 PM
vonreth added a comment to D22530: Copy kioslave into KDE Connect app package.

Could you think ab out a more general solution? Maybe move it to the macdmgpackager?
In order to work this needs to be done for all packages, not only kde-connect.

Jul 18 2019, 12:48 PM
vonreth committed R138:28b234f33346: Disable dbg image creation on mac for now (authored by vonreth).
Disable dbg image creation on mac for now
Jul 18 2019, 11:48 AM
vonreth committed R138:443bfe941c43: Fix file name (authored by vonreth).
Fix file name
Jul 18 2019, 11:33 AM
vonreth committed R138:d28d6c59a039: Seperate symbols when generating a dmg file on mac (authored by vonreth).
Seperate symbols when generating a dmg file on mac
Jul 18 2019, 11:22 AM
vonreth committed R138:dc35df910e79: Remove legacy code (authored by vonreth).
Remove legacy code
Jul 18 2019, 9:29 AM
vonreth committed R138:1ca373ed8e13: Seperate debug symbols on mac (authored by vonreth).
Seperate debug symbols on mac
Jul 18 2019, 9:29 AM
vonreth closed D22518: Seperate debug symbols on mac.
Jul 18 2019, 9:29 AM

Jul 17 2019

vonreth added a reviewer for D22518: Seperate debug symbols on mac: fazevedo.
Jul 17 2019, 7:43 PM
vonreth added reviewers for D22518: Seperate debug symbols on mac: bcooksley, dschmidt.
Jul 17 2019, 7:40 PM
vonreth requested review of D22518: Seperate debug symbols on mac.
Jul 17 2019, 7:38 PM
vonreth committed R138:ea2b4b83b92a: Unify mac image name with the other installers (authored by vonreth).
Unify mac image name with the other installers
Jul 17 2019, 3:03 PM
vonreth committed R138:e9e689ff9890: Fix appx name (authored by vonreth).
Fix appx name
Jul 17 2019, 3:03 PM
vonreth committed R138:2ddc1c55d1ee: Make sign tool more verbose for now (authored by vonreth).
Make sign tool more verbose for now
Jul 17 2019, 2:28 PM
vonreth committed R138:65a3d3eb7a21: Make cache hash less strict (authored by vonreth).
Make cache hash less strict
Jul 17 2019, 1:49 PM
vonreth committed R138:08b51fab5967: Use sed to split env, this fixes support for zsh which lask IFS (authored by vonreth).
Use sed to split env, this fixes support for zsh which lask IFS
Jul 17 2019, 9:35 AM

Jul 15 2019

vonreth committed R138:a62f7593b135: Cleanup (authored by vonreth).
Cleanup
Jul 15 2019, 6:51 PM
vonreth committed R877:a6eab67aea01: Return something (authored by vonreth).
Return something
Jul 15 2019, 6:33 PM
vonreth committed R877:362c76377ac2: x264 install single threaded (authored by vonreth).
x264 install single threaded
Jul 15 2019, 6:31 PM
vonreth committed R138:c9a78e571996: Improve the logic of the install step (authored by vonreth).
Improve the logic of the install step
Jul 15 2019, 6:02 PM
vonreth committed R138:05b5d5b6612d: Only sign if we create the cache package (authored by vonreth).
Only sign if we create the cache package
Jul 15 2019, 5:53 PM
vonreth committed R138:46f0fc936f9f: Don't fail if signing failed (authored by vonreth).
Don't fail if signing failed
Jul 15 2019, 5:45 PM
vonreth committed R138:08f77a496f22: Fix command (authored by vonreth).
Fix command
Jul 15 2019, 5:31 PM
vonreth committed R138:99ed5ae96d10: Fix command length computation (authored by vonreth).
Fix command length computation
Jul 15 2019, 5:28 PM
vonreth committed R138:165e3f5fcc5d: Fix signing (authored by vonreth).
Fix signing
Jul 15 2019, 5:24 PM
vonreth committed R138:0a6465e31b8d: Fail if sign fails (authored by vonreth).
Fail if sign fails
Jul 15 2019, 4:42 PM
vonreth committed R138:11922425c318: Allow to reuse the result of the filter (authored by vonreth).
Allow to reuse the result of the filter
Jul 15 2019, 4:42 PM
vonreth committed R993:9b151c07497b: Sign the cache (authored by vonreth).
Sign the cache
Jul 15 2019, 4:19 PM
vonreth committed R138:7eea55fe87a9: Allow to sign the cache (authored by vonreth).
Allow to sign the cache
Jul 15 2019, 4:17 PM
vonreth committed R993:bdc77edb1e0a: Drop Qt_ prefix for cache version (authored by vonreth).
Drop Qt_ prefix for cache version
Jul 15 2019, 1:30 PM
vonreth committed R993:ace44b6508c7: Revert "Drop Qt_ prefix for cache version" (authored by vonreth).
Revert "Drop Qt_ prefix for cache version"
Jul 15 2019, 1:30 PM
vonreth added a reverting change for R993:bdc77edb1e0a: Drop Qt_ prefix for cache version: R993:ace44b6508c7: Revert "Drop Qt_ prefix for cache version".
Jul 15 2019, 1:30 PM
vonreth committed R993:02d783957912: Use default kshim target (authored by vonreth).
Use default kshim target
Jul 15 2019, 1:30 PM
vonreth committed R138:74eb9215e03c: Cache location of signtool (authored by vonreth).
Cache location of signtool
Jul 15 2019, 12:56 PM

Jul 11 2019

vonreth committed R834:0d8e2f993d5c: Try to display a notification even if we get the warning that it is disabled (authored by vonreth).
Try to display a notification even if we get the warning that it is disabled
Jul 11 2019, 8:18 AM
vonreth requested changes to D22364: Fix dependencies and kio-slave in Dolphin on macOS.
Jul 11 2019, 7:28 AM

Jul 10 2019

vonreth accepted D22384: Add Atelier QML recipe.
Jul 10 2019, 9:33 PM
vonreth added inline comments to D22384: Add Atelier QML recipe.
Jul 10 2019, 8:05 PM
vonreth requested changes to D22384: Add Atelier QML recipe.
Jul 10 2019, 6:59 PM
vonreth committed R138:2f05424f2ec9: seperate gcc symbols during the install step (authored by vonreth).
seperate gcc symbols during the install step
Jul 10 2019, 2:43 PM