Jun 27 2019
Jun 26 2019
We also should add a maintainer for review
Resolved on master
Jun 25 2019
Jun 21 2019
Jun 20 2019
Jun 19 2019
Ouch thx 🙈
Jun 18 2019
ah ok, I thought it was linked without your code change
Jun 17 2019
Hi, wile adding snoretoast as dep is correct, removing phonon might break existing releases.
Jun 15 2019
Jun 14 2019
Jun 13 2019
Jun 11 2019
I tried to reproduce your issue and failed with the latest version of craft.
Jun 10 2019
Jun 9 2019
I think we should wait until the code was released and then only version dependant.
how is snoretoast actually used here? you are requiring the library for building and linking, but then:
- snoretoastactions.h, which is part of the headers of snoretoast, is copied here
- the snoretoast library is never used, as the utilities of it are invoked instead If the library does all the work already, then I'd prefer to use it directly instead of spawning executables all the time...
Piyush, what about this? It seems the snoretoast library provides a SnoreToasts class to do this instead of spawning an helper tool, what about using it instead?
@vonreth can probably explain better, but basically the situation as I understand it is on Windows you need to be installed in a special place and registered with the OS in order to show notifications. Since KNotifications is a library, an app using it can't (feasibly) be properly registered with the OS. It is possible we could come up with some complicated solution which would require every KNotification-using app to do some special and probably difficult to understand change to support Windows. Or we can have SnoreNotify.exe take care of all that nonsense for us. Note that, up to this point, there have been no special KNotifications changes to the generic KDE Connect codebase to make this work, just some tweaks to the Windows installer to pull in SnoreToast.
Jun 8 2019
Jun 7 2019
Jun 6 2019
Jun 5 2019
looks good, if the section is does end up in the right place this looks perfect :)
we don't provide an option for custome uninstall icons and using the app icon would be confusing.
Jun 4 2019
Some ideas, if I sound grumpy... I'm tired, good night :)