Feed Advanced Search

Wed, Jun 12

abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

@ngraham still in the works unfortunately. Found an issue with it actually in one of the info panel widgets, tried to fix that a little. Last worked on it in the weekend, I'll let you know when it's done (hopefully really soon)

Wed, Jun 12, 4:10 PM · Dolphin

Thu, Jun 6

abalaji added inline comments to D16425: Added new Suspend then Hibernate option.
Thu, Jun 6, 2:37 AM · Plasma

Wed, Jun 5

abalaji added inline comments to D16425: Added new Suspend then Hibernate option.
Wed, Jun 5, 3:50 AM · Plasma

Tue, Jun 4

abalaji added inline comments to D16425: Added new Suspend then Hibernate option.
Tue, Jun 4, 4:11 AM · Plasma

Wed, May 29

abalaji added inline comments to D16425: Added new Suspend then Hibernate option.
Wed, May 29, 9:49 PM · Plasma

May 13 2019

abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

@ngraham I'm all settled down and have enough free time in a day to start contributing once again. I'll put up the updated diffs in the coming days

May 13 2019, 1:55 AM · Dolphin

Apr 28 2019

abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Hey, I'll be free come May, then I'll get back into action :)

Apr 28 2019, 4:44 AM · Dolphin

Apr 5 2019

abalaji added a comment to D9078: HiDPI fixes for thumbnails in gwenview.

@ngraham @volkov sure I don't mind, I already have too many things open haha, and I haven't been delivering :/. Life's been too hard on me lately and I can't catch a break. I expect to be freed up during the summer, so hopefully I can come back and finish some of the other work

Apr 5 2019, 4:57 PM

Mar 16 2019

abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Well true, probably for the best to go for 19.08. Sorry, I should have
tried to manage my time better

Mar 16 2019, 11:16 PM · Dolphin
abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Oh rip, looks like I missed the bus. I have it done halfway locally,
perhaps I can get it cleaned up by tomorrow. Any chance for 19.04?

Mar 16 2019, 10:43 PM · Dolphin

Feb 21 2019

abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Hey @ngraham Im so sorry, I didn't see your message come through. I've been pretty busy the past week because of midterms at my university. I'll split this into two asap

Feb 21 2019, 11:25 PM · Dolphin

Feb 11 2019

abalaji added a comment to D18915: Fix batchrename changing extension to lower case.

Added a couple inline comments for you to address. Also, please use four spaces instead of tabs, and keep the spacing consistent (spaces around +, space between if () and the {. I have yet to run and test this, but if you check the comment on the left side of the diff, I wonder if just removing that .toLower() is enough.

Feb 11 2019, 3:57 AM · Frameworks

Jan 4 2019

abalaji awarded D16425: Added new Suspend then Hibernate option a Love token.
Jan 4 2019, 2:59 PM · Plasma

Dec 22 2018

abalaji updated the diff for D17654: Fix translated text.
  • Add comments to i18n strings
Dec 22 2018, 8:10 AM · Spectacle

Dec 18 2018

abalaji added a comment to D17654: Fix translated text.

However, the whole structure of the messages after 958fdc0a2532e30e7edfd1ec71f63fd3c87b5d35 is a classic case of word puzzles [1]. Anyway. it is better with this patch. So my +1.

Dec 18 2018, 5:46 PM · Spectacle
abalaji updated the diff for D17654: Fix translated text.
  • Fix typo
Dec 18 2018, 2:20 PM · Spectacle
abalaji requested review of D17654: Fix translated text.
Dec 18 2018, 1:52 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Oh, I see, I'll just move them into the constructor

Dec 18 2018, 11:25 AM · Spectacle

Dec 17 2018

abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Change constexpr to const
Dec 17 2018, 2:12 AM · Spectacle

Dec 16 2018

abalaji added inline comments to D12626: Port QML Rectangle cropper to QWidget + QPainter.
Dec 16 2018, 2:10 PM · Spectacle

Dec 14 2018

abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Cleanup
Dec 14 2018, 1:28 PM · Spectacle
abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.
  • Fix leak and warning
Dec 14 2018, 11:16 AM · Dolphin
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Add my name to copyright
Dec 14 2018, 11:06 AM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

@ngraham sorry the past two weeks were quite busy for me, I've been travelling. I finally got some time to fix the help text. No more hacks like &nbsp

Dec 14 2018, 10:43 AM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Fix help text
Dec 14 2018, 10:41 AM · Spectacle

Dec 3 2018

abalaji added inline comments to D12162: Add support for touch scrolling in Dolphin.
Dec 3 2018, 9:36 PM · Dolphin
abalaji added inline comments to D12162: Add support for touch scrolling in Dolphin.
Dec 3 2018, 6:32 PM · Dolphin

Nov 30 2018

abalaji added inline comments to D12626: Port QML Rectangle cropper to QWidget + QPainter.
Nov 30 2018, 9:20 PM · Spectacle
abalaji added a comment to D17248: Add Rectangular Region mode on wayland [RFC].

Looks good! We can probably merge this before my D12626

Nov 30 2018, 1:22 AM · Spectacle
abalaji added inline comments to D17248: Add Rectangular Region mode on wayland [RFC].
Nov 30 2018, 1:19 AM · Spectacle

Nov 29 2018

abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • I don't think WA_TranslucentBackground is necessary
  • Change newline handling
Nov 29 2018, 9:34 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Fix window flags
Nov 29 2018, 9:27 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

No nevermind that did the trick, Qt::Popup is the way to go 👍 thanks @kpiwowarski!

Nov 29 2018, 9:26 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Hmph it was working properly with multiple screens, but with a single screen, it dodges the panels for me regardless of Qt::WindowStayOnTopHint. There should be a way to tell Qt to not do this.

Nov 29 2018, 9:21 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Well, with WindowStaysOnTop, what about 374009?

Nov 29 2018, 9:08 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Make bottom text static
  • Fix multi-screen situation
Nov 29 2018, 9:01 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

I was experimenting some with that and finnaly I've found solution!

Replace showFullScreen(); with

setWindowFlags(Qt::Tool|Qt::FramelessWindowHint|Qt::NoDropShadowWindowHint|Qt::WindowStaysOnTopHint);
show();
Nov 29 2018, 8:58 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Well, Qt::BypassWindowManagerHint is not really an option since the window manager is what's responsible for Alt-Tab and things like that. We'll have to make the widget extend across multiple screens some other way.

Nov 29 2018, 6:32 PM · Spectacle
abalaji added inline comments to D12626: Port QML Rectangle cropper to QWidget + QPainter.
Nov 29 2018, 9:30 AM · Spectacle
abalaji updated the summary of D12626: Port QML Rectangle cropper to QWidget + QPainter.
Nov 29 2018, 9:22 AM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

@ngraham @broulik I think I addressed all the comments. Let me know if there's anything else

Nov 29 2018, 2:07 AM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Microoptimize some arithmetic
Nov 29 2018, 2:05 AM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Update help text
Nov 29 2018, 1:45 AM · Spectacle
abalaji added inline comments to D12626: Port QML Rectangle cropper to QWidget + QPainter.
Nov 29 2018, 12:39 AM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Rename variable
  • Reorder includes
  • Don't stay on top
  • Don't hardcode font size
  • Use KLocalizedString
Nov 29 2018, 12:38 AM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Awesome work, I'm impressed. Now it's really fast, much faster than the current implementation. I left a few inline comments.

As-is, this almost entirely fixes https://bugs.kde.org/show_bug.cgi?id=374009, so it's at least worth a CCBUG: 374009. I left an inline comment detailing how you can make it fix that bug entirely. :)

Nov 29 2018, 12:15 AM · Spectacle

Nov 28 2018

abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Sorry @ngraham my bad, accidentally left some things uncommitted. It should now compile.

Nov 28 2018, 11:36 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • My bad
Nov 28 2018, 11:35 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Add back keyboard controls
Nov 28 2018, 4:01 AM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Merge in lost changes and fix compiler warnings
Nov 28 2018, 12:34 AM · Spectacle

Nov 27 2018

abalaji abandoned D12692: Add back magnifier to QPainter port of rectangle selection.

Now merged into D12626

Nov 27 2018, 9:55 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

FWIW this also needs to implement the recently-added feature where you can move and resize the rectangle with the arrow keys.

Nov 27 2018, 9:09 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Merge branch 'qpainter-magnifier' into performance-enhancements-new-features
Nov 27 2018, 9:04 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Realized parent is a QObject, which won't work with QWidget superclass
  • Now compiles
Nov 27 2018, 8:57 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Add more const
  • If braces
  • Color instead of colour
  • Better name: mouseLocation
  • Call super constructor
Nov 27 2018, 8:52 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Fix reference counting
  • Delet "delete this"
  • Forward declare
  • Simplify using bitwise operators
Nov 27 2018, 8:40 PM · Spectacle
abalaji added inline comments to D12626: Port QML Rectangle cropper to QWidget + QPainter.
Nov 27 2018, 8:19 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

The QWidgets port of the magnifier was originally added in a separate patch (D12692) because at the time the QML version hadn't landed yet, but now that it has I think we can merge the contents of that patch into this one so we can get 100% feature parity in one fell swoop. :)

Nov 27 2018, 8:08 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Change to Q_SIGNALS
Nov 27 2018, 8:07 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

"Include mouse pointer" setting now blends the cursor into the screenshot right away, letting the user see it while cropping, rather than blending it in after cropping

As for this change, I prefer the old way: When I want to take a region screenshot, I place my cursor where I want to start the selection hit Meta+Shift+PrtScr, then draw the selection and then place the cursor where I want it in the screenshot (e.g. pointing at something) and take it.

I could probably get used to placing the cursor first and then taking the selection, dunno, it's for usability/VDG to decide what is the best approach here.

Nov 27 2018, 8:02 PM · Spectacle
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Since then I've fixed the camera on my phone, so I think it's about time I record new videos for the description.

Nov 27 2018, 7:46 PM · Spectacle
abalaji updated the diff for D12692: Add back magnifier to QPainter port of rectangle selection.
  • Rebase
Nov 27 2018, 7:44 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Remove unnecessary change
Nov 27 2018, 7:43 PM · Spectacle
abalaji updated the diff for D12692: Add back magnifier to QPainter port of rectangle selection.
Nov 27 2018, 7:40 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Correct diff
Nov 27 2018, 7:38 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Rebase
Nov 27 2018, 7:35 PM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Rebase
Nov 27 2018, 7:35 PM · Spectacle
abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.
  • Rebase
Nov 27 2018, 7:24 PM · Dolphin

Oct 20 2018

abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

I think most it is in there. I'll have a quick look just in case and let
you know. If anything it might have to be with HiDPI

Oct 20 2018, 6:04 AM · Spectacle

Oct 9 2018

abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.
  • Remove unnecessary newline
Oct 9 2018, 5:24 AM · Dolphin
abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.
  • Tidy up diff
Oct 9 2018, 5:22 AM · Dolphin

Oct 8 2018

abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Hey @ngraham, as you can see I just added scrolling to two list views in the configure menu. Apart from that, there's just one minor issue in the information panel that I'm working on right now: when you touch a clickable thing like a link or a ratings star, then touch scroll, then release the touch point at the same spot on top of the clickable thing, it gets activated. I'm in the process of fixing this. But otherwise, a code review would be appreciated.

Oct 8 2018, 2:33 AM · Dolphin
abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.
  • Add scrolling to item lists in Configure menu
Oct 8 2018, 2:29 AM · Dolphin

Oct 5 2018

abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.
  • Rebase
Oct 5 2018, 6:49 PM · Dolphin
abalaji added a comment to D15942: Don't drag windows in empty areas from touch/pen events.

@davidedmundson awesome! I've been running around in circles trying to find this, glad that you fixed it! Although in the future we should support this properly.

Oct 5 2018, 5:26 PM · Plasma

Sep 23 2018

abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.
  • Rebase
Sep 23 2018, 2:58 AM · Dolphin

Sep 21 2018

abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Hey everyone, I can make some time for myself during this weekend to work on this, feel free to leave comments

Sep 21 2018, 5:03 AM · Dolphin

Sep 20 2018

acrouthamel awarded D12162: Add support for touch scrolling in Dolphin a Doubloon token.
Sep 20 2018, 2:52 AM · Dolphin

Aug 6 2018

abalaji added a comment to D7581: HiDPI Support for Gwenview.

@ngraham I can resume next week, having my exams right now

Aug 6 2018, 5:52 PM · Gwenview

Jul 18 2018

abalaji added a comment to D7581: HiDPI Support for Gwenview.

@fvogt I haven't worked on it for quite a while. I can resume working on this in a few weeks, after my exams are done.

Jul 18 2018, 9:46 AM · Gwenview
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Hi @rkflx sorry if me adding the arrow keys here threw you off, I personally thought it's trivial enough to have here, but I can move it into a new patch if that makes testing and review easier.

Jul 18 2018, 1:24 AM · Spectacle

Jul 1 2018

abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Thanks @steffenh, I've fixed the issues with the scroll bars.

Jul 1 2018, 4:40 PM · Dolphin
abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.
  • Fix issues with scroll bar on touch
Jul 1 2018, 4:31 PM · Dolphin
abalaji updated the diff for D12162: Add support for touch scrolling in Dolphin.

Rebase

Jul 1 2018, 3:30 PM · Dolphin

Jun 27 2018

abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.
Also, looks like the current policy for HiDPI is to "scale up" the moves, so if I set QT_SCALE_FACTOR=5, the smallest move is 5 real pixels. We probably want to change that, so that we move by `factor / Screen.devicePixelRatio` which would ensure we move by `factor` "real" pixels. Apart from that, 15px seems pretty good on my 2560x1440 monitor.

I knew I should have held out for that 4K laptop. Does anyone receiving me have a genuine HiDPI monitor to test with, along side simulating it with QT_SCALE_FACTOR.

Jun 27 2018, 4:18 PM · Documentation
abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.

A few thing tho @sharvey, it looks like currently the resize functionality only moves the bottom right corner, and I've preserved that. But was wondering if we can add in Ctrl or something to control that. Maybe something like:

Jun 27 2018, 3:28 AM · Documentation
abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Alright everyone, I just ported over the arrow key functionality over at D12626.

Jun 27 2018, 3:26 AM · Documentation
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.

Remove unused code

Jun 27 2018, 3:18 AM · Spectacle
abalaji updated the diff for D12626: Port QML Rectangle cropper to QWidget + QPainter.
  • Implement arrow keys to move and resize rectangle
Jun 27 2018, 3:17 AM · Spectacle

Jun 26 2018

abalaji added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 9:26 PM · Documentation
abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Why not make it a user configurable option?

Certainly a managble task, but I sense there's some reasonable reluctance to adding even more config options to our beloved Spectacle.

Jun 26 2018, 9:15 PM · Documentation
abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Hm, my intention when I triaged the bug was indeed to make it possible to set the selection rectangle from the keyboard. When I mentioned the separate patch, this was only about how to start the actual selection process. I don't think it makes sense to change the speed later again, we should get it right here.

The largeChange value is currently set at 15px. It's a variable (which I should probably make a const), so we can tweak it without monkeying about deeply in the code. All unmodified changes are 1px. I'd like to have people with various screen sizes help determine if 15px is a good setting.

Jun 26 2018, 8:56 PM · Documentation
abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.

And @rkflx, I'm also almost done porting this over to D12626

Jun 26 2018, 8:55 PM · Documentation
abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.

! In D13450#283442, @sharvey wrote:
My intent behind this patch remains geared toward incremental adjustments to the original mouse-drawn rectangle, not a full-blown replacement for drawing a rectangle entirely from the keyboard and having to make dramatic changes.

We discussed starting a rectangle with a keypress (maybe Space), but that idea was set aside for a separate patch. Perhaps we can revisit and further optimize the arrow keys then.

Jun 26 2018, 8:53 PM · Documentation
abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.

So, currently the arrow functionality depends on repeated Keys.onPressed events, which depend on keyboard repeat delay and rate (system settings -> input devices -> keyboard). This means we will always have an initial stutter followed by an arbitrary speed. This also disallows us to move in two directions at the same time, top and right for instance, since Qt only seems to generate repeated events for the last key pressed. Instead, this should be handled in a different way: have flags keeping track of pressed keys, which get set on Keys.onPressed and unset on Keys.onReleased, and requestPaint in the key press handler if one or more keys are set. Then onPaint repeatedly requestsPaint to keep calling itself if one or more of the keys remain pressed.

Jun 26 2018, 8:18 PM · Documentation

Jun 22 2018

abalaji added inline comments to D12626: Port QML Rectangle cropper to QWidget + QPainter.
Jun 22 2018, 10:01 PM · Spectacle
abalaji added a comment to D13450: Add arrow keys to move and resize selection rectangle.

@rkflx : A question about coding style and/or reviewer (you) preferences... do we object to the use of temporary local variables inside Javascript functions? I'm working on keeping the rectangle inside the screen. I've set up var screenWidth = cropDisplayCanvas.width at the top of my function. It's just for ease of use and readability... I can do tests and checks against screenWidth instead of writing long if tests with cropDisplayCanvas.width ... just to keep the lines of code a bit shorter and easier to read through.

Is this "against the rules"? I can certainly undo it if necessary. It's merely a tactic I've used in the past.

Sounds reasonable (at least that's how I would do it in C++, where I would even make it a const). Try searching for JavaScript style guides whether it's different there (although I doubt it).

Jun 22 2018, 9:46 PM · Documentation
abalaji added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

the border width is 2pixels when QT_DEVICE_PIXEL_RATIO set to 2, but I think should be 1 pixel

Are you sure? As the border is part of the UI visible to the user, I believe it should scale with whatever scaling factor the user set. Otherwise you might end up with a barely visible border on HiDPI screens.

Jun 22 2018, 8:42 PM · Spectacle

Jun 12 2018

abalaji retitled D12162: Add support for touch scrolling in Dolphin from Support for touch scrolling in Dolphin to Add support for touch scrolling in Dolphin.
Jun 12 2018, 7:00 PM · Dolphin
abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Hey @ngraham sorry I've been missing this whole time. I'm back in school and flooded with assignments atm :-(. If you're super interested in this, then I can work on this over the weekend. So at the moment, here's what's working on my config at least:

Jun 12 2018, 6:39 PM · Dolphin