I fixed the synchronizer dialog myself, wasn't that hard. -> 67c400b5

setAttribute(Qt::WA_DeleteOnClose)

is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.

@miroslavm Please submit the patch as differential (== review request) and link it to this task (if this is somehow possible).

Finally mark this done.

Merged. Let's see if somebody will complain...

File preview is also used in Krusader. Please add us to subscribers for behaviour changes. Thanks.

I usually never user krViewer.

Thanks! Can confirm in Krusader and a toy application (https://github.com/abika/cpp-qt-kf5-file-browser). Yes, it is probably a bug in Qt.

Thanks Martin! Not a surprise I missed something again during testing:/

Thanks for the info. Problem is I can't switch to GCC4.8 (not even an official package in Arch Linux repos) and the CI doesn't cover this either.

Yes, I can reproduce this. Looks like I solved an issue and created a new one.

Alex, please check if I understood right the code combining and code comment.

I vote for the option.
It was clearly intended as a feature and somebody is might using it. A checkbox can also advertise the feature to users who didn't even know it was there.

When one is loading a saved Panel profile, old tabs are removed and profile-saved tabs are restored from settings. But locked tabs are loaded twice with other problems.

Oh damn, I overlooked this again. The title lead me to believe this is something unimportant in kde-devel.

Thanks Martin!

Done. Somebody has to add 2.6.0 to the release list on bugzilla. I still don't have permission.

I took the liberty and commited your patch.

Tomorrow or Tuesday - hopefully.
@palant If you want to be included in the author list, add yourself to the main.cpp.

Actually the ListPanelFunc object is destroyed before the ListPanel, so when you do the check for this->panel, this points to already freed memory.

In T5716#86663, @martinkostolny wrote:

I agree. Probably lame but how about "Job-Man Show"? :)

Ok now?

• Fix for crash when closing currently refreshing panel
• Safer version of "Fix for crash when closing currently refreshing panel" (f01640db)

The code was ugly, but accessing a deleted object results in undefinefd behaviour.

There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.

Can someone please give an opinion on this?

Same here: can compile but not test. I guess, its fine.

Done with 5a26343a.

Thanks for pointing this out! It's my code so I will fix it right away.

Thanks! Typos fixed

Actually, there are some not so far away: KDE Partition Manager, K3b and KFloppy.

FYI: https://bugs.kde.org/show_bug.cgi?id=298292

I wouldn't say this is "overreacting".

• The security flaw is real. An attacker can probably get root access by exploiting Krusaders root mode
• Krusader is the only GUI application that comes with an "execute as root" feature that I know of (anything else?). And yes, there is a reason for it.
• Again: it is still possible to execute Krusader as root. But we are not advertising it anymore. Those who really need this can still create the desktop entry/action.

As a next step, if I didn't miss anything, calcSpaceFileSystem in AbstractJobThread::countLocalFiles() could be removed.
The packjob should be passed a list of URLs instead of file names which would eliminate the need to determine the URLs.

Just found something: in krservices "kdesu" is still defined for tools and never used.

Thanks!

Ship it!

Wait, screw that. I mixed up arguments.

TL;DR: I agree with Wladimir and would recommend to remove Krusader root mode altogether because we shouldn't support unsafe usage.

Ok, coming back to this. I needed some time to re-think it.

• Dialogs: merged "delay" checkbox with "reverser queue" button in copy/move dialogs
• JobMan: improved coding style and documentation
• JobMan: run next job not started yet even if queue mode is off

Thanks, works fine. Question is why Ubuntu is having a different tool doing the same thing.

Added a small fix: _count > 0 instead of _count > 1; the dummy file itself is not counted.

Great! Thanks again for the quick response.

In D2857#85422, @asensi wrote:

Is the working directory really important for (any) application?

I don't recall using any, although probably some exist, and if ListPanelFunc::runCommand() works and allows that those application work correctly, probably it would be better for Krusader to use that code.

I don't want to be pedantic but there is a small misbehavior: when the current item is ".." and "Show hidden files" setting is changed (Alt+".") the current jumps to the first file now. Probably nobody will ever notice but checking against empty _quickFilterMask should also solve it.

Thank you testing.

I couldn't find any regressions.
seems to work correctly

Merged with master

Merged with master

Merged with master

Merged with master

Merged with master

Merged with master (and Phabricator fails again to autoclose this)

I see. Is the working directory really important for (any) application? It seems strange that Krusader does this different compared to e.g. Dolphin.

Could it be that the issue there was being caused by the extra ListPanel::start() call?

Quick test says: yes!

Ok, I see now that this is also not a good solution. The settings are going down to the PanelPopup and KrInterviews. All this should be copied. Sorry I didn't got this earlier.

I personally prefer the old behavior. After restart going back to the "nearest" parent folder of a deleted path was pretty nice. And if it was a removable device I can mount it and go back to the folder with the history.

Like I said, I don't really care. In KFind case sensitivity is also off by default.

Hmm, works fine but using a temporary config group seems a bit hackish.

I personally don't care. Default search with grep is case sensitive. Any other opinions?

Thanks for the fix!

In D4316#81044, @asensi wrote:

About that F11 subject: Is it a change in the user interface of Krusader? :-?

Thanks! Merged with master.

Sorry, missed it again. Changes are fine!