Feed Advanced Search

May 20 2020

broulik accepted D29420: Generate DBus interface.
May 20 2020, 1:28 PM · Frameworks
broulik added a comment to T13156: Better support for ultra-wide screens.

Patch to make notifications follow notification icon, so that when your panel isn't full width, the notifications stay in sight as well: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5

May 20 2020, 11:12 AM · VDG
broulik committed R120:862bb0696ae7: [Notifications] Position popups relative to notification icon (authored by broulik).
[Notifications] Position popups relative to notification icon
May 20 2020, 10:58 AM
broulik committed R120:2f9e2dd630f3: Merge branch 'Plasma/5.19' (authored by broulik).
Merge branch 'Plasma/5.19'
May 20 2020, 6:58 AM
broulik committed R120:f364b62cf2b1: [Battery Monitor] Fix ScrollView anchoring (authored by broulik).
[Battery Monitor] Fix ScrollView anchoring
May 20 2020, 6:57 AM
broulik committed R120:08f7df946561: [OSD] Fix ProgressBar potentially growing the dialog (authored by broulik).
[OSD] Fix ProgressBar potentially growing the dialog
May 20 2020, 6:39 AM
broulik accepted D29464: [applets/appmenu] Hide old menu before showing new menu.
May 20 2020, 6:20 AM · Plasma
broulik requested changes to D29464: [applets/appmenu] Hide old menu before showing new menu.

Oops, I didnt't properly apply the patch. So yeah, the flickering for which I added this code is still there.

May 20 2020, 6:11 AM · Plasma
broulik accepted D29464: [applets/appmenu] Hide old menu before showing new menu.
May 20 2020, 6:01 AM · Plasma

May 19 2020

broulik committed R120:4ed46dfe80e3: Merge branch 'Plasma/5.19' (authored by broulik).
Merge branch 'Plasma/5.19'
May 19 2020, 8:34 PM
broulik added a comment to D29464: [applets/appmenu] Hide old menu before showing new menu.

That focus loss flickering was fixed at some point iirc. I'll try the patch tomororw but lgtm

May 19 2020, 8:32 PM · Plasma
broulik accepted D29465: [applets/appmenu] Improve menu feel.

Clever with the hoverEnabled, I had to think twice to understand it, though :p

May 19 2020, 8:23 PM · Plasma
broulik reclaimed D20569: Use more compact OSD.
May 19 2020, 5:46 PM · Plasma
broulik committed R120:65633268b72e: [Notifications] Restore item spacing (authored by broulik).
[Notifications] Restore item spacing
May 19 2020, 1:43 PM
broulik committed R871:5d1d3e6371e2: Port to CommandLauncherJob and add --desktop-entry argument (authored by broulik).
Port to CommandLauncherJob and add --desktop-entry argument
May 19 2020, 1:07 PM
broulik committed R285:16e7c7f42f4b: Pass desktop name to DrKonqi (authored by broulik).
Pass desktop name to DrKonqi
May 19 2020, 12:58 PM
broulik committed R241:19d23d386cf7: [KProcessRunner] Use only executable name for scope (authored by broulik).
[KProcessRunner] Use only executable name for scope
May 19 2020, 9:58 AM
broulik closed D29228: [KProcessRunner] Use only executable name for scope.
May 19 2020, 9:58 AM · Frameworks
broulik committed R871:a80dabb53f71: Port to CommandLauncherJob (authored by broulik).
Port to CommandLauncherJob
May 19 2020, 9:57 AM
broulik committed R871:bf6d1ea5943a: Port to CommandLauncherJob (authored by broulik).
Port to CommandLauncherJob
May 19 2020, 9:47 AM
broulik added a comment to D28673: [PackageUrlInterceptor] Make QRegularExpression static.

so, can the regexp be replaced or does it need to stay?

May 19 2020, 8:22 AM · Frameworks
broulik added inline comments to D29391: Introduce setWindow and CloseWhenWindowActivated.
May 19 2020, 6:48 AM · Frameworks
broulik accepted D29799: [kcms/notifications] Port "no search result" message to PlaceholderMessage.
May 19 2020, 6:28 AM · Plasma

May 18 2020

broulik abandoned D25984: Load translations.

Looks like D27595 fixes the issue

May 18 2020, 3:18 PM · Kirigami
broulik updated the diff for D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField.
  • Drop placeholderText since the Kirigami issue has been resolved
May 18 2020, 3:18 PM · Plasma
broulik committed R120:d81147994e45: Merge branch 'Plasma/5.19' (authored by broulik).
Merge branch 'Plasma/5.19'
May 18 2020, 3:00 PM
broulik committed R120:64794034ebe7: Merge branch 'Plasma/5.18' into Plasma/5.19 (authored by broulik).
Merge branch 'Plasma/5.18' into Plasma/5.19
May 18 2020, 3:00 PM
broulik committed R120:d71181245f13: [Notifications] Don't take updated time into account for sorting (authored by broulik).
[Notifications] Don't take updated time into account for sorting
May 18 2020, 2:58 PM
broulik closed D29771: [Notifications] Don't take updated time into account for sorting.
May 18 2020, 2:58 PM · Plasma
broulik abandoned D25466: Add Captive Portal auto-refresh handling.
May 18 2020, 2:52 PM · Plasma
broulik added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

I am not sure we can just do this given the amount of modules kded loads. Can we be certain that all the modules don't do custom pixmap painting?

May 18 2020, 2:13 PM · Frameworks
broulik committed R856:a3f400c8589e: Install MutationObserver in DOMContentLoaded (authored by broulik).
Install MutationObserver in DOMContentLoaded
May 18 2020, 11:57 AM
broulik committed R120:97e843d3ead3: [Free Space Notifer] Use critical notification instead of tray icon and monitor… (authored by broulik).
[Free Space Notifer] Use critical notification instead of tray icon and monitor…
May 18 2020, 11:25 AM
broulik closed D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too.
May 18 2020, 11:25 AM · Plasma
broulik committed R856:ccd47495c4aa: Add logo.png for GitLab (authored by broulik).
Add logo.png for GitLab
May 18 2020, 10:52 AM
broulik accepted D28312: Implement urls using hints.
May 18 2020, 10:16 AM · Frameworks
broulik committed R856:8c4c240c0c10: Restore ability to send tel: URLs to the phone (authored by broulik).
Restore ability to send tel: URLs to the phone
May 18 2020, 9:37 AM
broulik closed D29691: Restore ability to send tel: URLs to the phone.

https://invent.kde.org/plasma/plasma-browser-integration/commit/8c4c240c0c1064893aaba0cd94fadf73f0e908ce

May 18 2020, 9:37 AM · Plasma

May 15 2020

broulik planned changes to D29775: [kcmkwin/kwinrules] Create RulesModel on demand.
May 15 2020, 8:43 PM · KWin
broulik added inline comments to D29772: Don't compare string with empty string.
May 15 2020, 2:54 PM · KWin
broulik committed R126:424217083a8c: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob (authored by broulik).
[kstart] Port to ApplicationLauncherJob and CommandLauncherJob
May 15 2020, 2:51 PM
broulik closed D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob.
May 15 2020, 2:51 PM · Plasma
broulik updated the diff for D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob.
  • Drop manual startup stuff
  • Drop C stuff
May 15 2020, 2:44 PM · Plasma
broulik committed R297:4ae4de9ff469: Add systemd user service file for kded (authored by broulik).
Add systemd user service file for kded
May 15 2020, 2:40 PM
broulik closed D29034: Add systemd user service file for kded.
May 15 2020, 2:40 PM · Frameworks
broulik added inline comments to D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
May 15 2020, 2:28 PM · Plasma
broulik added inline comments to D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
May 15 2020, 2:18 PM · Plasma
broulik updated the test plan for D29775: [kcmkwin/kwinrules] Create RulesModel on demand.
May 15 2020, 2:15 PM · KWin
broulik added a comment to D27595: Watch for language change events, and forward those to the QML engine.

Is there no better way to do this? e.g. the KWin Rules KCM spends 20% of its startup time in "retranslate" :/

May 15 2020, 2:09 PM · Kirigami
broulik requested review of D29775: [kcmkwin/kwinrules] Create RulesModel on demand.
May 15 2020, 1:43 PM · KWin
broulik added inline comments to D29772: Don't compare string with empty string.
May 15 2020, 9:38 AM · KWin
broulik added inline comments to D29760: Replace MapProxySource with some javascript code.
May 15 2020, 9:18 AM · Plasma
broulik added inline comments to D29772: Don't compare string with empty string.
May 15 2020, 9:13 AM · KWin
broulik requested review of D29771: [Notifications] Don't take updated time into account for sorting.
May 15 2020, 8:37 AM · Plasma
broulik requested review of D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too.
May 15 2020, 8:13 AM · Plasma
broulik committed R120:c94d4d2cb7fa: Merge branch 'Plasma/5.19' (authored by broulik).
Merge branch 'Plasma/5.19'
May 15 2020, 6:57 AM
broulik committed R120:9e545131faa9: [Kicker] Fix jump list actions in RunnerMatchesModel (authored by broulik).
[Kicker] Fix jump list actions in RunnerMatchesModel
May 15 2020, 6:57 AM
broulik closed D29744: [Kicker] Fix jump list actions in RunnerMatchesModel.
May 15 2020, 6:57 AM · Plasma
broulik added a comment to D29765: Add a blurless SDDM theme.

Can we perhaps add infrastructure so that a theme can provide options?
For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always show clock" and "show media controls".
I'm not keen on duplicating the entire theme for a single option.

May 15 2020, 6:55 AM · Plasma

May 14 2020

broulik updated the diff for D29034: Add systemd user service file for kded.
  • fix exec
  • add slice
May 14 2020, 4:11 PM · Frameworks
broulik created T13156: Better support for ultra-wide screens.
May 14 2020, 12:58 PM · VDG
broulik requested review of D29744: [Kicker] Fix jump list actions in RunnerMatchesModel.
May 14 2020, 12:45 PM · Plasma
broulik committed R856:76666e2e0bc0: [Reminder] Also advert Chromie store for Vivaldi and Brave (authored by broulik).
[Reminder] Also advert Chromie store for Vivaldi and Brave
May 14 2020, 7:21 AM
broulik closed D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave.
May 14 2020, 7:21 AM · Plasma
broulik updated the diff for D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave.
  • Also for brave
May 14 2020, 6:21 AM · Plasma
broulik added inline comments to D29736: Revert "Improve partial maximization strings".
May 14 2020, 5:45 AM · KWin

May 13 2020

broulik added inline comments to D28154: Add users KCM.
May 13 2020, 2:05 PM · Plasma
broulik added a comment to D28154: Add users KCM.

Pretty cool

May 13 2020, 2:02 PM · Plasma
broulik accepted D29705: Correctly align natural layout in present windows.
May 13 2020, 12:34 PM · KWin
broulik requested changes to D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
May 13 2020, 8:49 AM · Plasma
broulik requested changes to D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
May 13 2020, 7:03 AM · Plasma

May 12 2020

broulik requested review of D29691: Restore ability to send tel: URLs to the phone.
May 12 2020, 6:42 PM · Plasma
broulik committed R120:ddefcfb7c901: [Battery Monitor] Fix toolTipMainText when plugged in (authored by broulik).
[Battery Monitor] Fix toolTipMainText when plugged in
May 12 2020, 1:31 PM
broulik closed D29633: [Battery Monitor] Fix toolTipMainText when plugged in.
May 12 2020, 1:31 PM · Plasma
broulik closed D29674: [kcmkwin/kwinrules] Change translation domain.
May 12 2020, 8:58 AM · KWin
broulik committed R108:65f611f7008c: [kcmkwin/kwinrules] Change translation domain (authored by broulik).
[kcmkwin/kwinrules] Change translation domain
May 12 2020, 8:58 AM
broulik abandoned D29413: [kcmkwin/kwinrules] Fix about data and translations.
May 12 2020, 8:57 AM · KWin
broulik added a reviewer for D29674: [kcmkwin/kwinrules] Change translation domain: kde-i18n-doc.
May 12 2020, 8:57 AM · KWin
broulik updated the diff for D29674: [kcmkwin/kwinrules] Change translation domain.
  • Change Messages.sh, too
May 12 2020, 8:56 AM · KWin
broulik requested review of D29674: [kcmkwin/kwinrules] Change translation domain.
May 12 2020, 8:56 AM · KWin
broulik added a comment to D29413: [kcmkwin/kwinrules] Fix about data and translations.

i18nd is NOT the solution. Period.

May 12 2020, 8:47 AM · KWin
broulik accepted D29673: [kcmkwin/kwinoptions] Fix default for MaximizeButtonRightClickCommand.
May 12 2020, 8:32 AM · KWin
broulik added inline comments to D29671: [kcmkwin/kwinoptions] Use text to describe maximize button actions.
May 12 2020, 8:26 AM · KWin

May 11 2020

broulik added inline comments to D29632: [kcms/keys] Use better collator settings.
May 11 2020, 4:20 PM · Plasma
broulik added inline comments to D29644: Select application after it is added.
May 11 2020, 4:20 PM · Plasma
broulik accepted D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open.

Thanks
please phrase the commit message the opposite way. State what the commit changes, not what the state was before the commit.

May 11 2020, 4:18 PM · Plasma
broulik added inline comments to D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging.
May 11 2020, 4:14 PM · Plasma
broulik requested changes to D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging.

The tooltip logic was completely rewritten in 5.19. This patch does not apply to 5.18.
Also, D29633

May 11 2020, 4:13 PM · Plasma
broulik added inline comments to D29632: [kcms/keys] Use better collator settings.
May 11 2020, 3:04 PM · Plasma
broulik requested review of D29633: [Battery Monitor] Fix toolTipMainText when plugged in.
May 11 2020, 1:38 PM · Plasma
broulik created T13140: Allow KCModule::save() to be async.
May 11 2020, 12:50 PM · KF6
broulik requested review of D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob.
May 11 2020, 10:06 AM · Plasma
broulik committed R119:c6a8b2f5e940: [Global Shortcuts KCM] Also check PortableText (authored by broulik).
[Global Shortcuts KCM] Also check PortableText
May 11 2020, 7:50 AM
broulik closed D29475: [Global Shortcuts KCM] Also check PortableText.
May 11 2020, 7:50 AM · Plasma
broulik closed D29594: Close low battery notificaton when showing critical.
May 11 2020, 7:50 AM · Plasma
broulik committed R122:afff6ae64f42: Close low battery notificaton when showing critical (authored by broulik).
Close low battery notificaton when showing critical
May 11 2020, 7:50 AM

May 10 2020

broulik accepted D29601: Port KRun::runApplication to ApplicationLauncherJob.
May 10 2020, 3:17 PM · Plasma
broulik requested review of D29594: Close low battery notificaton when showing critical.
May 10 2020, 11:48 AM · Plasma

May 8 2020

broulik updated the test plan for D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave.
May 8 2020, 2:40 PM · Plasma
broulik requested review of D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave.
May 8 2020, 2:40 PM · Plasma