Feed Advanced Search

Feb 20 2019

trmdi updated the diff for D19096: [Kicker] Fix "Tooltip can not be displayed".

Do not drag the item after right clicking on it.

Feb 20 2019, 6:18 PM · Plasma
trmdi planned changes to D19096: [Kicker] Fix "Tooltip can not be displayed".
Feb 20 2019, 3:58 PM · Plasma
trmdi updated the diff for D19096: [Kicker] Fix "Tooltip can not be displayed".

Fix tooltip's height.

Feb 20 2019, 6:51 AM · Plasma

Feb 19 2019

trmdi retitled D19096: [Kicker] Fix "Tooltip can not be displayed" from Improvements for long label items to Improvements for long label items in Application Dashboard.
Feb 19 2019, 7:16 PM · Plasma
trmdi updated the diff for D19096: [Kicker] Fix "Tooltip can not be displayed".
Feb 19 2019, 7:12 PM · Plasma

Feb 18 2019

trmdi added a reviewer for D19096: [Kicker] Fix "Tooltip can not be displayed": VDG.
Feb 18 2019, 4:16 AM · Plasma
trmdi updated the diff for D19096: [Kicker] Fix "Tooltip can not be displayed".
Feb 18 2019, 4:14 AM · Plasma

Feb 17 2019

trmdi planned changes to D19096: [Kicker] Fix "Tooltip can not be displayed".
Feb 17 2019, 5:54 PM · Plasma
trmdi added a reviewer for D19096: [Kicker] Fix "Tooltip can not be displayed": Plasma.
Feb 17 2019, 5:46 PM · Plasma
trmdi requested review of D19096: [Kicker] Fix "Tooltip can not be displayed".
Feb 17 2019, 5:45 PM · Plasma

Feb 13 2019

trmdi updated the diff for D18976: Improve Contextmenu.
Feb 13 2019, 5:32 PM · Plasma
trmdi added a comment to D18976: Improve Contextmenu.

Oh, wait...
I've just seen it is disabled unexpectedly. Do you know why ?

Feb 13 2019, 5:08 PM · Plasma
trmdi updated the diff for D18976: Improve Contextmenu.
Feb 13 2019, 8:15 AM · Plasma
trmdi updated the summary of D18976: Improve Contextmenu.
Feb 13 2019, 1:55 AM · Plasma
trmdi requested review of D18976: Improve Contextmenu.
Feb 13 2019, 1:51 AM · Plasma
trmdi abandoned D18918: Make the text of "View Settings" action more specific.
Feb 13 2019, 1:44 AM · Plasma

Feb 12 2019

trmdi added inline comments to D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 5:08 PM · Plasma
trmdi added inline comments to D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 4:58 PM · Plasma
trmdi added inline comments to D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 4:03 PM · Plasma
trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 3:06 PM · Plasma
trmdi added a comment to D18918: Make the text of "View Settings" action more specific.

I don't think it is needed, you can try to update the action text just a little before the menu is shown

Qmenu has an aboutToShow signal and containment has as a contextuakActionsAboutToShow signal

Feb 12 2019, 2:12 PM · Plasma
trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 1:11 PM · Plasma
trmdi added a comment to D18918: Make the text of "View Settings" action more specific.

for Latte panels after startup or after switching layouts if the user right clicks the panel the menu is appearing correctly as:

Panel Setings... ?

Feb 12 2019, 1:08 PM · Plasma
trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 10:41 AM · Plasma
trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 6:48 AM · Plasma
trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 6:20 AM · Plasma
trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 6:01 AM · Plasma
trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 12 2019, 5:22 AM · Plasma

Feb 11 2019

trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 11 2019, 6:14 PM · Plasma
trmdi added a dependency for D18918: Make the text of "View Settings" action more specific: D18926: add Type property for Latte::View.
Feb 11 2019, 5:12 PM · Plasma
trmdi added a dependent revision for D18926: add Type property for Latte::View: D18918: Make the text of "View Settings" action more specific.
Feb 11 2019, 5:12 PM · Plasma
trmdi added a comment to D18918: Make the text of "View Settings" action more specific.

ok, just checked the previous mentioned class has access to containment() that means that through its configuration the menu could be informed for the type, so directly access to Latte::View is not needed...

Feb 11 2019, 5:05 PM · Plasma
trmdi accepted D18926: add Type property for Latte::View.
Feb 11 2019, 5:02 PM · Plasma
trmdi added a comment to D18918: Make the text of "View Settings" action more specific.

Personally I dont like the approach, this wont work in some cases e.g. when right clicking plasma taskmanager.

Feb 11 2019, 5:00 PM · Plasma
trmdi planned changes to D18918: Make the text of "View Settings" action more specific.
Feb 11 2019, 12:26 PM · Plasma
trmdi added inline comments to D18918: Make the text of "View Settings" action more specific.
Feb 11 2019, 8:12 AM · Plasma
trmdi updated the diff for D18918: Make the text of "View Settings" action more specific.
Feb 11 2019, 5:44 AM · Plasma
trmdi requested review of D18918: Make the text of "View Settings" action more specific.
Feb 11 2019, 4:55 AM · Plasma

Feb 10 2019

trmdi added a comment to T10274: Improve Dynamic Background options.

@trmdi

"Prefer Plasma theme's background and color for popups"

that could indicate that tooltips will be colored also and that is not the case

Feb 10 2019, 1:37 PM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.

Should "Prefer plasma opaque background for popups" be renamed to "Prefer Plasma theme's background and color for popups"

Feb 10 2019, 12:23 PM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.

Please open a bug report explaining all the details that you consider as bug and also screenshots of the settings in order to reproduce in my system.

Feb 10 2019, 9:18 AM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.

it was an issue with manual Reverse theme, fixed with last commit

Feb 10 2019, 8:48 AM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.

Sounds like a bug, open a bug report and a screenshot for your Dynamic background and Coloring options

Feb 10 2019, 8:03 AM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.

Have you enabled that option and the background is not changing to plasma one for pop ups?

Feb 10 2019, 7:32 AM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.

There is a new option for this in Dynamic Background maybe it should be the Default

Feb 10 2019, 6:21 AM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.

When Color > Theme !== Plasma and a plasmoid popup is showing, color behavior need to be changed:

Feb 10 2019, 5:57 AM · Latte Dock

Feb 9 2019

trmdi added a comment to T10274: Improve Dynamic Background options.
  1. How do you find the proposed HIG for sub-categories, e.g. Colors->Theme, Colors->From Window? and for Effects page also by using the new SubCategories:
Feb 9 2019, 3:36 AM · Latte Dock

Feb 8 2019

trmdi added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

You can select "Abandon revision" as action.

Feb 8 2019, 8:42 AM · Plasma
trmdi abandoned D18804: Workaround for the bug 393630 - Framework part.
Feb 8 2019, 8:40 AM · Frameworks
trmdi updated the summary of D18805: Workaround for the bug 393630 - SystemTray part.
Feb 8 2019, 4:15 AM · Plasma
trmdi updated the diff for D18805: Workaround for the bug 393630 - SystemTray part.

Use @davidedmundson 's approach.

Feb 8 2019, 3:57 AM · Plasma

Feb 7 2019

trmdi added a comment to D18805: Workaround for the bug 393630 - SystemTray part.
Feb 7 2019, 5:04 PM · Plasma
trmdi added a comment to D18805: Workaround for the bug 393630 - SystemTray part.
Feb 7 2019, 9:39 AM · Plasma
trmdi added a comment to D18804: Workaround for the bug 393630 - Framework part.

Can you explain what you're working around?

Feb 7 2019, 9:29 AM · Frameworks
trmdi retitled D18804: Workaround for the bug 393630 - Framework part from Workaround for the bug 393630 to Workaround for the bug 393630 - Framework part.
Feb 7 2019, 9:23 AM · Frameworks
trmdi updated the summary of D18804: Workaround for the bug 393630 - Framework part.
Feb 7 2019, 9:07 AM · Frameworks
trmdi added reviewers for D18805: Workaround for the bug 393630 - SystemTray part: davidedmundson, anthonyfieroni, fvogt.
Feb 7 2019, 9:05 AM · Plasma
trmdi requested review of D18805: Workaround for the bug 393630 - SystemTray part.
Feb 7 2019, 9:02 AM · Plasma
trmdi added a comment to D18804: Workaround for the bug 393630 - Framework part.

Did you understand why it happen?

Feb 7 2019, 8:07 AM · Frameworks
trmdi added a reviewer for D18804: Workaround for the bug 393630 - Framework part: ngraham.
Feb 7 2019, 7:57 AM · Frameworks
trmdi requested review of D18804: Workaround for the bug 393630 - Framework part.
Feb 7 2019, 7:55 AM · Frameworks

Feb 6 2019

trmdi added a comment to D18717: improvements for global shortcuts.

@trmdi would you like to commit it for you?
Can I use your fullname shown at: https://phabricator.kde.org/p/trmdi/ ?
and what is your email?

Feb 6 2019, 6:44 AM · Plasma
trmdi added a comment to D18717: improvements for global shortcuts.

1, please make a check that sortedViewsList returns count()>0 and if it doesnt it can return a nullptr
-> done

Feb 6 2019, 5:29 AM · Plasma
trmdi updated the diff for D18717: improvements for global shortcuts.
Feb 6 2019, 2:20 AM · Plasma

Feb 5 2019

trmdi added a comment to D16643: Correct the accept flag of the event object on DragMove .

Please update your name on Identity, then i'll sync it from there.

Feb 5 2019, 7:32 PM · Frameworks
trmdi added a comment to D16643: Correct the accept flag of the event object on DragMove .

Nice, my first patch finally has been accepted.
Thanks everyone!

Feb 5 2019, 7:04 PM · Frameworks
trmdi added a comment to D16643: Correct the accept flag of the event object on DragMove .

@trmdi: Do you have push access? If not, which name <mail> should be used for the commit?

Feb 5 2019, 6:54 PM · Frameworks
trmdi updated the diff for D16643: Correct the accept flag of the event object on DragMove .
Feb 5 2019, 6:35 PM · Frameworks
trmdi updated the diff for D18717: improvements for global shortcuts.
Feb 5 2019, 6:25 PM · Plasma
trmdi added a comment to D18717: improvements for global shortcuts.

it looks and behave nice, lets see with Layout how it will look but I believe there will be no issues,
we are ok to commit if the property is moved to Layout

Feb 5 2019, 6:05 PM · Plasma
trmdi updated the diff for D18717: improvements for global shortcuts.
Feb 5 2019, 5:50 PM · Plasma

Feb 4 2019

trmdi added a comment to D18717: improvements for global shortcuts.

@trmdi can you confirm me the following for your code ?

  1. When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set priority for which view to be forwarded
  2. When the user changed the isPreferredForShortcuts for first time afterwards [1] is never used again EXCEPT if the user set the property ` preferredForShortcutsTouched=false `

    on its own

Is this what you wanted to achieve?

Note: this is important, the preferredForShortcutsTouched property must be moved from universalsettings to layout

Feb 4 2019, 1:23 PM · Plasma
trmdi requested review of D18717: improvements for global shortcuts.
Feb 4 2019, 7:59 AM · Plasma

Feb 3 2019

trmdi added a comment to D18620: Display shortcut badges while holding Super.

@trmdi can you please test latest master for global shortcuts?

Feb 3 2019, 2:42 AM · Plasma

Jan 31 2019

trmdi added a comment to D18620: Display shortcut badges while holding Super.

@trmdi this is ok, you can merge it and afterwards we can discuss how the Meta behavior should be enabled/disabled/adjusted...
Meta is also used for showing Application Launcher so the two functionalities could be messed up together.
any ideas?

Jan 31 2019, 5:18 PM · Plasma

Jan 30 2019

trmdi updated the diff for D18620: Display shortcut badges while holding Super.
Jan 30 2019, 6:22 PM · Plasma
trmdi updated the diff for D18620: Display shortcut badges while holding Super.
Jan 30 2019, 5:55 PM · Plasma
trmdi added a comment to D18620: Display shortcut badges while holding Super.

@trmdi

  1. does it work? any issues?
  2. under wayland did you have any success?
Jan 30 2019, 5:52 PM · Plasma
trmdi requested review of D18620: Display shortcut badges while holding Super.
Jan 30 2019, 5:29 PM · Plasma

Jan 15 2019

trmdi added a comment to D18258: Wait forever until the lock file can be locked.

Ok, no problem.

Jan 15 2019, 5:51 PM · Plasma, Latte Dock
trmdi added a comment to D18258: Wait forever until the lock file can be locked.

Can you help me to land it? I don't have the permission.

No prob, I will need a full name and email

Jan 15 2019, 5:34 PM · Plasma, Latte Dock
trmdi added a comment to D18258: Wait forever until the lock file can be locked.

Can you help me to land it? I don't have the permission.

Jan 15 2019, 5:29 PM · Plasma, Latte Dock
This is a test notification, sent at Tue, Jan 15, 3:44 PM.
Jan 15 2019, 8:44 AM
This is a test notification, sent at Tue, Jan 15, 3:44 PM.
Jan 15 2019, 8:44 AM
trmdi added a reviewer for D18258: Wait forever until the lock file can be locked: Latte Dock.
Jan 15 2019, 5:36 AM · Plasma, Latte Dock
Restricted Application added a project to D18258: Wait forever until the lock file can be locked: Plasma.
Jan 15 2019, 5:34 AM · Plasma, Latte Dock
Restricted Application added a project to D18258: Wait forever until the lock file can be locked: Plasma.
Jan 15 2019, 5:34 AM · Plasma, Latte Dock
trmdi requested review of D18258: Wait forever until the lock file can be locked.
Jan 15 2019, 5:33 AM · Plasma, Latte Dock

Jan 9 2019

trmdi added a comment to D16643: Correct the accept flag of the event object on DragMove .
Jan 9 2019, 9:30 AM · Frameworks
trmdi added a comment to D16643: Correct the accept flag of the event object on DragMove .

@broulik
I've updated the patch, can you review it ?

Jan 9 2019, 9:01 AM · Frameworks
trmdi added a comment to T10274: Improve Dynamic Background options.

"Monochrome contents when not touching any window" is not always true.

Jan 9 2019, 8:54 AM · Latte Dock

Jan 8 2019

trmdi added a comment to T10274: Improve Dynamic Background options.

Sorry, I didn't understand how the feature works clearly. I need to learn more about it. 😂

Jan 8 2019, 11:23 AM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.
Jan 8 2019, 4:05 AM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.
Jan 8 2019, 3:50 AM · Latte Dock

Jan 7 2019

trmdi added a comment to T10274: Improve Dynamic Background options.
Jan 7 2019, 5:04 PM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.
Jan 7 2019, 4:24 PM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.
Jan 7 2019, 3:01 PM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.
Jan 7 2019, 1:50 PM · Latte Dock
trmdi added a comment to T10274: Improve Dynamic Background options.
Jan 7 2019, 3:52 AM · Latte Dock

Jan 6 2019

trmdi added a comment to T10274: Improve Dynamic Background options.
Jan 6 2019, 5:56 PM · Latte Dock