Feed Advanced Search

Feb 16 2018

safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

Would you please add a HACK so that we know when to remove this?

You mean as a comment ?

Feb 16 2018, 7:45 AM · Frameworks, Plasma

Feb 15 2018

safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

@mart I fixed this issue by changing these lines to:

113            LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft
114            LayoutMirroring.childrenInherit: true
Feb 15 2018, 8:34 PM · Frameworks, Plasma
safaalfulaij added a comment to D10144: Various general and RTL fixes.

Please also rebase/merge with current master

Feb 15 2018, 4:15 AM · Elisa
safaalfulaij updated the diff for D10144: Various general and RTL fixes.

+1 and placeholders

Feb 15 2018, 3:24 AM · Elisa

Feb 11 2018

safaalfulaij updated the diff for D10144: Various general and RTL fixes.

No dynamic substrings

Feb 11 2018, 12:02 PM · Elisa
safaalfulaij added inline comments to D10144: Various general and RTL fixes.
Feb 11 2018, 11:42 AM · Elisa
safaalfulaij updated the diff for D10144: Various general and RTL fixes.

Sorry, last one

Feb 11 2018, 11:24 AM · Elisa
safaalfulaij updated the diff for D10144: Various general and RTL fixes.

leftovers

Feb 11 2018, 11:21 AM · Elisa
safaalfulaij updated the diff for D10144: Various general and RTL fixes.

Make them localizable

Feb 11 2018, 11:17 AM · Elisa

Feb 9 2018

safaalfulaij added a comment to D10144: Various general and RTL fixes.

I tried the patch again and noticed some issues with the track number in the all tracks view and the duration for the all tracks and album views and mediaplaylist. See below:

Feb 9 2018, 2:24 PM · Elisa
safaalfulaij updated the diff for D10144: Various general and RTL fixes.
  • Add 5 as to be in the safe-side
  • Take detailed view into account
Feb 9 2018, 2:23 PM · Elisa

Feb 8 2018

safaalfulaij updated the diff for D10144: Various general and RTL fixes.
  • Fix duration in position bar in the header
  • Make the cd-track string translatable
Feb 8 2018, 7:52 AM · Elisa
safaalfulaij added inline comments to D10144: Various general and RTL fixes.
Feb 8 2018, 7:43 AM · Elisa

Feb 5 2018

safaalfulaij committed R883:1509959: Update Arabic translations..
Update Arabic translations.
Feb 5 2018, 7:51 PM

Feb 4 2018

safaalfulaij added a comment to D10144: Various general and RTL fixes.

Sorry for adding a lot of headache. :(

Feb 4 2018, 9:17 PM · Elisa
safaalfulaij added inline comments to D10144: Various general and RTL fixes.
Feb 4 2018, 9:11 PM · Elisa
safaalfulaij updated the diff for D10144: Various general and RTL fixes.
  • Remove the fixing of tracknumber

I played a bit with it and it's not really needed

  • Add the same for the media view, with respect to layouting of CDs and stuff
  • Fix the info widget
Feb 4 2018, 9:03 PM · Elisa

Feb 3 2018

safaalfulaij added inline comments to D10144: Various general and RTL fixes.
Feb 3 2018, 12:48 PM · Elisa

Feb 1 2018

safaalfulaij committed R883:1509647: Update Arabic translations..
Update Arabic translations.
Feb 1 2018, 7:33 AM
safaalfulaij committed R883:1509644: Update Arabic translations..
Update Arabic translations.
Feb 1 2018, 7:05 AM

Jan 29 2018

safaalfulaij committed R883:1509501: Update Arabic translations..
Update Arabic translations.
Jan 29 2018, 5:46 PM

Jan 28 2018

safaalfulaij added a project to D10144: Various general and RTL fixes: Elisa.
Jan 28 2018, 8:54 PM · Elisa
safaalfulaij added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I really don't see why we need this if we have Kolourpaint.
“Export image”→ “Kolourpaint”.

Jan 28 2018, 7:28 AM · VDG, Spectacle

Jan 27 2018

safaalfulaij added inline comments to D10144: Various general and RTL fixes.
Jan 27 2018, 1:51 PM · Elisa

Jan 26 2018

safaalfulaij committed R120:bac2ae0cd272: [Klipper] Force plain text on the edit dialog (authored by safaalfulaij).
[Klipper] Force plain text on the edit dialog
Jan 26 2018, 9:10 AM
safaalfulaij closed D10111: [Klipper] Force plain text on the edit dialog.
Jan 26 2018, 9:10 AM · Plasma
safaalfulaij updated the diff for D10111: [Klipper] Force plain text on the edit dialog.

setAcceptRichText

Jan 26 2018, 6:28 AM · Plasma
safaalfulaij added a comment to D10111: [Klipper] Force plain text on the edit dialog.

This is how it looks currently:

Jan 26 2018, 4:51 AM · Plasma

Jan 25 2018

safaalfulaij updated the diff for D10083: [Look and Feel] Reverse the button order.

Align the warning text to the right

Jan 25 2018, 8:25 AM · Plasma
safaalfulaij added a comment to D10083: [Look and Feel] Reverse the button order.

Yes I do.
But shall we ask VDG or not?

Jan 25 2018, 7:54 AM · Plasma

Jan 24 2018

safaalfulaij updated the diff for D10083: [Look and Feel] Reverse the button order.

Leftover

Jan 24 2018, 6:23 PM · Plasma
safaalfulaij added a comment to D10083: [Look and Feel] Reverse the button order.

Look and feel before:

Jan 24 2018, 6:17 PM · Plasma
safaalfulaij committed R78:92a5fc9d780a: Fix some complicated plural messages (authored by safaalfulaij).
Fix some complicated plural messages
Jan 24 2018, 6:45 AM
safaalfulaij closed D10062: Fix some complicated plural messages.
Jan 24 2018, 6:45 AM · KDE PIM
safaalfulaij added inline comments to D10062: Fix some complicated plural messages.
Jan 24 2018, 6:13 AM · KDE PIM
safaalfulaij updated the diff for D10062: Fix some complicated plural messages.

Fix leftover from previous diff

Jan 24 2018, 6:11 AM · KDE PIM

Jan 23 2018

safaalfulaij updated the diff for D10062: Fix some complicated plural messages.

Simplify it

Jan 23 2018, 10:02 PM · KDE PIM

Jan 22 2018

safaalfulaij added inline comments to D10013: [Part] Force LTR direction on the diff viewer.
Jan 22 2018, 2:14 PM
safaalfulaij committed R40:9bde2918a735: [Build Addon] Force LTR direction on the treeWidget for RTL locales (authored by safaalfulaij).
[Build Addon] Force LTR direction on the treeWidget for RTL locales
Jan 22 2018, 7:12 AM
safaalfulaij closed D10003: [Build Addon] Force LTR direction on the treeWidget for RTL locales.
Jan 22 2018, 7:12 AM · Kate
safaalfulaij added a comment to D10003: [Build Addon] Force LTR direction on the treeWidget for RTL locales.
In D10003#194173, @sars wrote:

If that is the right thing to do for RTL locales then go for it. It does not change anything for LTR locales :)

Jan 22 2018, 7:11 AM · Kate
safaalfulaij committed R883:1509136: Update Arabic translations..
Update Arabic translations.
Jan 22 2018, 7:08 AM

Jan 21 2018

safaalfulaij abandoned D10012: [Part] Force LTR direction on the diff viewer.
Jan 21 2018, 9:24 PM
safaalfulaij added a comment to D10013: [Part] Force LTR direction on the diff viewer.

Moving the scrollbar to left will show the actual content, but hide the line numbering:

Jan 21 2018, 9:23 PM
safaalfulaij added a comment to D10012: [Part] Force LTR direction on the diff viewer.

Moving the scrollbar to left will show the actual content, but hide the line numbering:

Jan 21 2018, 9:19 PM
safaalfulaij committed R883:1509078: Update Arabic translations..
Update Arabic translations.
Jan 21 2018, 7:36 AM
safaalfulaij retitled D10003: [Build Addon] Force LTR direction on the treeWidget for RTL locales from [Build Addon] For LTR direction on the treeWidget for RTL locales to [Build Addon] Force LTR direction on the treeWidget for RTL locales.
Jan 21 2018, 4:50 AM · Kate
safaalfulaij added a comment to D10003: [Build Addon] Force LTR direction on the treeWidget for RTL locales.

I don't know but should we also use the fixed-width font here? Since it is parsed I don't see the need of it, and it will make the widget strange a bit.

Jan 21 2018, 4:50 AM · Kate
safaalfulaij committed R40:cc715aef03db: [Build Addon] Use system’s fixed font for output page (authored by safaalfulaij).
[Build Addon] Use system’s fixed font for output page
Jan 21 2018, 4:42 AM
safaalfulaij closed D9997: [Build Addon] Use system’s fixed font for output page.
Jan 21 2018, 4:42 AM · Kate

Jan 20 2018

safaalfulaij added a comment to D9997: [Build Addon] Use system’s fixed font for output page.

I wonder how one could just debug with that :)

Jan 20 2018, 8:23 PM · Kate

Jan 19 2018

safaalfulaij added a comment to T3418: (Meta) Fix several RTL layout issues in Plasma widgets.

Systemsettings pages that are in QML don't have the correct LayoutMirroring set.

Jan 19 2018, 3:30 PM · Plasma

Jan 18 2018

safaalfulaij updated the task description for T7781: KI18n, defaults and overrides.
Jan 18 2018, 2:33 PM · Frameworks
safaalfulaij created T7781: KI18n, defaults and overrides.
Jan 18 2018, 2:31 PM · Frameworks

Jan 16 2018

safaalfulaij committed R89:2bdc47f7d088: Small RTL fixes with the OverlayWidget (authored by safaalfulaij).
Small RTL fixes with the OverlayWidget
Jan 16 2018, 6:08 AM
safaalfulaij closed D9897: Small RTL fixes with the OverlayWidget.
Jan 16 2018, 6:08 AM · KDE PIM

Jan 15 2018

safaalfulaij added a comment to T7049: RTL menu support.

Hi Mutlaq,
Can you use this function instead of the one you used? I think it's more general and should allow other locales (like Persian or Hebrew) to have a correct layout in system with a LTR layout.

Jan 15 2018, 2:09 PM
safaalfulaij committed R119:b127e545b552: [Kickoff] Fix RTL issues (authored by safaalfulaij).
[Kickoff] Fix RTL issues
Jan 15 2018, 10:51 AM
safaalfulaij closed D9786: [Kickoff] Fix RTL issues.
Jan 15 2018, 10:51 AM · Plasma
safaalfulaij updated the diff for D9786: [Kickoff] Fix RTL issues.
  • 0 instead of undefined
  • change statments order
Jan 15 2018, 10:31 AM · Plasma

Jan 14 2018

safaalfulaij added inline comments to D9275: fix RTL appearance for ComboBox.
Jan 14 2018, 1:43 PM · Frameworks, Plasma
safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

To test it in Latte I added in the head of /shell/package/contents/configuration/AppearanceConfig.qml

import org.kde.plasma.components 3.0 as PlasmaComponents3

and I set up the ComboBox in that file to:

PlasmaComponents3.ComboBox

But I can't understand how changing this V3 solved V2..

V2 components are based totally at Qt Styles, V3 are reimplementing the behavior
PlasmaComponents2.ComboBox is a ComboBoxStyle but
PlasmaComponents3.ComboBox is a real ComboBox

Jan 14 2018, 1:42 PM · Frameworks, Plasma
safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

with your example me I cant reproduce it either...
I can only reproduce it with Latte Settings window, all other components are aligned correctly except the PlasmaComponent3.Combobox list items.

you are right, this might be a downstream bug...

Do you want to revert it
I can do it

Jan 14 2018, 8:48 AM · Frameworks, Plasma
safaalfulaij added a comment to T3418: (Meta) Fix several RTL layout issues in Plasma widgets.

I was wondering why there are many LayoutMirroring.enabled definitions in the Task Manager applet.
I tried removing them all and it seems that (for a reason) the mirroring from Plasma don't get applied on the Item in main.qml, while in the Kickoff it get applied.
Something is strange here.

Jan 14 2018, 7:09 AM · Plasma
safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

how did you test it?

I tried in an qml app (Latte dock) by passing the parameter "--reverse"...
If your system is already using in RTL language, have you tried with --reverse?

Jan 14 2018, 7:05 AM · Frameworks, Plasma

Jan 13 2018

safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly.

It wasnt, use english text in the list items to see the issue without the patch.

Jan 13 2018, 9:05 PM · Frameworks, Plasma
safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly.

Jan 13 2018, 7:59 PM · Frameworks, Plasma

Jan 11 2018

safaalfulaij added a comment to D9793: Fall back to language name for translations lookup if locale name fails.

Why is this an issue?
There's no difference really in loading ar/LC_MESSAGES/xxx.qm and LC_MESSAGES/xxx_ar.qm (or something like that), i.e. you would have the same problem if all translations would be in the same folder.

Jan 11 2018, 7:44 PM · Frameworks, Build System
safaalfulaij added a comment to D9793: Fall back to language name for translations lookup if locale name fails.

I went through Qt code, as Qt applications are opened with my language correctly where KF ones (those with QM) don't.
The whole issue is that we have each locale's translations in a separate folder (ar/LC_MESSAGES, en/LC_MESSAGES, de/LC_MESSAGES, etc.)
Qt uses internally find_translation which goes through a list of guesses to find the correct language, according to the LANGUAGE preferences and the locale itself.
Maybe we can borrow that code and utilize it, that would be much better.

Jan 11 2018, 4:20 PM · Frameworks, Build System
safaalfulaij updated the diff for D9786: [Kickoff] Fix RTL issues.
  • Align header labels to left
Jan 11 2018, 6:58 AM · Plasma
safaalfulaij updated the diff for D9786: [Kickoff] Fix RTL issues.
  • Just align it correctly
Jan 11 2018, 4:35 AM · Plasma

Jan 10 2018

safaalfulaij added a comment to D9786: [Kickoff] Fix RTL issues.

I see.

How about playing with leftMargin of the Flickable to right-align it? Something along the lines of

leftMargin: Math.max(0, width - contentWidth)
Jan 10 2018, 12:10 PM · Plasma
safaalfulaij added a comment to D9786: [Kickoff] Fix RTL issues.

I'll answer that here to put some visuals.

Jan 10 2018, 11:19 AM · Plasma
safaalfulaij added a comment to D9786: [Kickoff] Fix RTL issues.

After applying:

Jan 10 2018, 10:55 AM · Plasma
safaalfulaij triaged T7722: Use system font for HTML views as Low priority.
Jan 10 2018, 6:52 AM · KMyMoney

Jan 6 2018

safaalfulaij added inline comments to D9698: Added service menu.
Jan 6 2018, 5:59 PM

Dec 26 2017

safaalfulaij committed R39:1a76f4082583: Fix Unit Test (authored by safaalfulaij).
Fix Unit Test
Dec 26 2017, 4:30 AM

Dec 24 2017

safaalfulaij committed R39:0f2335f3edc0: Fix compilation (authored by safaalfulaij).
Fix compilation
Dec 24 2017, 8:13 PM
safaalfulaij closed D7660: Fix a regression caused by changing backspace key behavior.
Dec 24 2017, 8:13 PM · Frameworks
safaalfulaij updated the diff for D7660: Fix a regression caused by changing backspace key behavior.

Fix compilation issues

Dec 24 2017, 5:44 AM · Frameworks

Dec 23 2017

safaalfulaij committed R39:c9b412d40334: Fix a regression caused by changing backspace key behavior (authored by safaalfulaij).
Fix a regression caused by changing backspace key behavior
Dec 23 2017, 7:37 PM
safaalfulaij closed D7660: Fix a regression caused by changing backspace key behavior.
Dec 23 2017, 7:37 PM · Frameworks

Dec 1 2017

safaalfulaij committed R883:1505553: Update Arabic translations..
Update Arabic translations.
Dec 1 2017, 4:58 AM
safaalfulaij committed R883:1505552: Update Arabic translations..
Update Arabic translations.
Dec 1 2017, 4:42 AM

Nov 27 2017

safaalfulaij created T7501: Fix bidi text in statusbar.
Nov 27 2017, 6:13 PM

Nov 23 2017

safaalfulaij added a comment to D7660: Fix a regression caused by changing backspace key behavior.

I can commit but it is showing as not accepted.
So I'll just wait for the final confirmation.

Nov 23 2017, 5:16 PM · Frameworks

Nov 6 2017

safaalfulaij added a comment to D7701: [WIP] Minimze the use of bidi markers in IRCView..

Ok, I applied the comment, but now I have no idea how to merge, rebase and other stuff, sorry! :(
Please do it instead since my knowledge in Git is below zero.

Nov 6 2017, 5:51 PM
safaalfulaij updated the diff for D7701: [WIP] Minimze the use of bidi markers in IRCView..
  • Fix comment and apply comments
Nov 6 2017, 5:49 PM
safaalfulaij updated the diff for D7701: [WIP] Minimze the use of bidi markers in IRCView..
  • Revert last nonsense commit
Nov 6 2017, 5:41 PM
safaalfulaij updated the diff for D7701: [WIP] Minimze the use of bidi markers in IRCView..
  • Rebase (I think I messed up my git copy as usual)
Nov 6 2017, 2:23 PM
safaalfulaij updated the diff for D7701: [WIP] Minimze the use of bidi markers in IRCView..
  • Fix comment and apply comments
Nov 6 2017, 2:05 PM

Nov 5 2017

safaalfulaij updated the diff for D7660: Fix a regression caused by changing backspace key behavior.
  • Applying last comment (hopefully I did what you meant :!)
Nov 5 2017, 2:12 PM · Frameworks

Oct 26 2017

safaalfulaij added a comment to D7660: Fix a regression caused by changing backspace key behavior.

@safaalfulaij, any progress on the latest comments?

Oct 26 2017, 4:58 AM · Frameworks

Sep 22 2017

safaalfulaij added a comment to T7049: RTL menu support.

I don't think there is, but there is one review that had this sort of talk, here, and this for Qt5 not mirroring the layout.

Sep 22 2017, 3:04 PM
safaalfulaij added a comment to T7049: RTL menu support.

Are you using a LTR locale, and the application is RTL?
If that's the case, then it's not a bug we can fix, since all Qt apps behave this way, and should be fixed upstream.

Sep 22 2017, 2:35 PM
safaalfulaij added a comment to T7049: RTL menu support.

KDE Frameworks 5.37.0
Qt 5.9.1 (built against 5.9.1)
The xcb windowing system

Sep 22 2017, 11:02 AM
safaalfulaij added a comment to T7049: RTL menu support.

Yes I know it's missing qtbase_ar, but it has qt_ar, which (if you notice) is bigger than the other qt_* files, because it is still in the old structure.
If you check the file in Qt translations repo, you'll see that special string used for mirroring, and it's "finished" so is being used.

Sep 22 2017, 10:48 AM
safaalfulaij added a comment to T7049: RTL menu support.

Sorry but I don't get what you mean.
Are you talking about Windows version, or Linux version?
Everything works as it should here on ArchLinux, with Qt5.9 translations installed.
I didn't try KStars, but it should work correctly as other Qt and KF5 applications.

Sep 22 2017, 10:24 AM
safaalfulaij updated the diff for D7660: Fix a regression caused by changing backspace key behavior.
  • Typos and better if statement structure
Sep 22 2017, 10:12 AM · Frameworks

Sep 15 2017

safaalfulaij committed R230:69fd8b9e4142: Add myself to relicensecheck.pl (authored by safaalfulaij).
Add myself to relicensecheck.pl
Sep 15 2017, 8:09 PM