In D9275#207435, @mvourlakos wrote:Would you please add a HACK so that we know when to remove this?
You mean as a comment ?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Feb 16 2018
Feb 16 2018
Feb 15 2018
Feb 15 2018
In D9275#207260, @mvourlakos wrote:@mart I fixed this issue by changing these lines to:
113 LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft 114 LayoutMirroring.childrenInherit: true
In D10144#205645, @astippich wrote:Please also rebase/merge with current master
+1 and placeholders
Feb 11 2018
Feb 11 2018
No dynamic substrings
Sorry, last one
leftovers
Make them localizable
Feb 9 2018
Feb 9 2018
In D10144#203439, @astippich wrote:
- Add 5 as to be in the safe-side
- Take detailed view into account
Feb 8 2018
Feb 8 2018
- Fix duration in position bar in the header
- Make the cd-track string translatable
Feb 5 2018
Feb 5 2018
Update Arabic translations.
Feb 4 2018
Feb 4 2018
Sorry for adding a lot of headache. :(
- Remove the fixing of tracknumber
I played a bit with it and it's not really needed
- Add the same for the media view, with respect to layouting of CDs and stuff
- Fix the info widget
Feb 3 2018
Feb 3 2018
Feb 1 2018
Feb 1 2018
Update Arabic translations.
Update Arabic translations.
Jan 29 2018
Jan 29 2018
Update Arabic translations.
Jan 28 2018
Jan 28 2018
I really don't see why we need this if we have Kolourpaint.
“Export image”→ “Kolourpaint”.
Jan 27 2018
Jan 27 2018
Jan 26 2018
Jan 26 2018
safaalfulaij committed R120:bac2ae0cd272: [Klipper] Force plain text on the edit dialog (authored by safaalfulaij).
[Klipper] Force plain text on the edit dialog
setAcceptRichText
This is how it looks currently:
Jan 25 2018
Jan 25 2018
Align the warning text to the right
Yes I do.
But shall we ask VDG or not?
Jan 24 2018
Jan 24 2018
Leftover
safaalfulaij committed R78:92a5fc9d780a: Fix some complicated plural messages (authored by safaalfulaij).
Fix some complicated plural messages
Fix leftover from previous diff
Jan 23 2018
Jan 23 2018
Simplify it
Jan 22 2018
Jan 22 2018
safaalfulaij committed R40:9bde2918a735: [Build Addon] Force LTR direction on the treeWidget for RTL locales (authored by safaalfulaij).
[Build Addon] Force LTR direction on the treeWidget for RTL locales
safaalfulaij added a comment to D10003: [Build Addon] Force LTR direction on the treeWidget for RTL locales.
In D10003#194173, @sars wrote:If that is the right thing to do for RTL locales then go for it. It does not change anything for LTR locales :)
Update Arabic translations.
Jan 21 2018
Jan 21 2018
Update Arabic translations.
safaalfulaij retitled D10003: [Build Addon] Force LTR direction on the treeWidget for RTL locales from [Build Addon] For LTR direction on the treeWidget for RTL locales to [Build Addon] Force LTR direction on the treeWidget for RTL locales.
safaalfulaij added a comment to D10003: [Build Addon] Force LTR direction on the treeWidget for RTL locales.
I don't know but should we also use the fixed-width font here? Since it is parsed I don't see the need of it, and it will make the widget strange a bit.
safaalfulaij committed R40:cc715aef03db: [Build Addon] Use system’s fixed font for output page (authored by safaalfulaij).
[Build Addon] Use system’s fixed font for output page
Jan 20 2018
Jan 20 2018
I wonder how one could just debug with that :)
Jan 19 2018
Jan 19 2018
Jan 18 2018
Jan 18 2018
Jan 16 2018
Jan 16 2018
safaalfulaij committed R89:2bdc47f7d088: Small RTL fixes with the OverlayWidget (authored by safaalfulaij).
Small RTL fixes with the OverlayWidget
Jan 15 2018
Jan 15 2018
Hi Mutlaq,
Can you use this function instead of the one you used? I think it's more general and should allow other locales (like Persian or Hebrew) to have a correct layout in system with a LTR layout.
[Kickoff] Fix RTL issues
- 0 instead of undefined
- change statments order
Jan 14 2018
Jan 14 2018
In D9275#190606, @mvourlakos wrote:To test it in Latte I added in the head of /shell/package/contents/configuration/AppearanceConfig.qml
import org.kde.plasma.components 3.0 as PlasmaComponents3and I set up the ComboBox in that file to:
PlasmaComponents3.ComboBoxBut I can't understand how changing this V3 solved V2..
V2 components are based totally at Qt Styles, V3 are reimplementing the behavior
PlasmaComponents2.ComboBox is a ComboBoxStyle but
PlasmaComponents3.ComboBox is a real ComboBox
In D9275#190569, @mvourlakos wrote:with your example me I cant reproduce it either...
I can only reproduce it with Latte Settings window, all other components are aligned correctly except the PlasmaComponent3.Combobox list items.you are right, this might be a downstream bug...
Do you want to revert it
I can do it
I was wondering why there are many LayoutMirroring.enabled definitions in the Task Manager applet.
I tried removing them all and it seems that (for a reason) the mirroring from Plasma don't get applied on the Item in main.qml, while in the Kickoff it get applied.
Something is strange here.
In D9275#190497, @mvourlakos wrote:how did you test it?
I tried in an qml app (Latte dock) by passing the parameter "--reverse"...
If your system is already using in RTL language, have you tried with --reverse?
Jan 13 2018
Jan 13 2018
In D9275#190464, @mvourlakos wrote:In D9275#190441, @safaalfulaij wrote:Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly.
It wasnt, use english text in the list items to see the issue without the patch.
Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly.
Jan 11 2018
Jan 11 2018
safaalfulaij added a comment to D9793: Fall back to language name for translations lookup if locale name fails.
Why is this an issue?
There's no difference really in loading ar/LC_MESSAGES/xxx.qm and LC_MESSAGES/xxx_ar.qm (or something like that), i.e. you would have the same problem if all translations would be in the same folder.
safaalfulaij added a comment to D9793: Fall back to language name for translations lookup if locale name fails.
I went through Qt code, as Qt applications are opened with my language correctly where KF ones (those with QM) don't.
The whole issue is that we have each locale's translations in a separate folder (ar/LC_MESSAGES, en/LC_MESSAGES, de/LC_MESSAGES, etc.)
Qt uses internally find_translation which goes through a list of guesses to find the correct language, according to the LANGUAGE preferences and the locale itself.
Maybe we can borrow that code and utilize it, that would be much better.
- Align header labels to left
- Just align it correctly
Jan 10 2018
Jan 10 2018
In D9786#188720, @broulik wrote:I see.
How about playing with leftMargin of the Flickable to right-align it? Something along the lines of
leftMargin: Math.max(0, width - contentWidth)
I'll answer that here to put some visuals.
After applying:
Jan 6 2018
Jan 6 2018
Dec 26 2017
Dec 26 2017
Fix Unit Test
Dec 24 2017
Dec 24 2017
Fix compilation
safaalfulaij updated the diff for D7660: Fix a regression caused by changing backspace key behavior.
Fix compilation issues
Dec 23 2017
Dec 23 2017
safaalfulaij committed R39:c9b412d40334: Fix a regression caused by changing backspace key behavior (authored by safaalfulaij).
Fix a regression caused by changing backspace key behavior
Dec 1 2017
Dec 1 2017
Update Arabic translations.
Update Arabic translations.
Nov 27 2017
Nov 27 2017
Nov 23 2017
Nov 23 2017
I can commit but it is showing as not accepted.
So I'll just wait for the final confirmation.
Nov 6 2017
Nov 6 2017
Ok, I applied the comment, but now I have no idea how to merge, rebase and other stuff, sorry! :(
Please do it instead since my knowledge in Git is below zero.
- Fix comment and apply comments
- Revert last nonsense commit
- Rebase (I think I messed up my git copy as usual)
- Fix comment and apply comments
Nov 5 2017
Nov 5 2017
safaalfulaij updated the diff for D7660: Fix a regression caused by changing backspace key behavior.
- Applying last comment (hopefully I did what you meant :!)
Oct 26 2017
Oct 26 2017
In D7660#158479, @ngraham wrote:@safaalfulaij, any progress on the latest comments?
Sep 22 2017
Sep 22 2017
Are you using a LTR locale, and the application is RTL?
If that's the case, then it's not a bug we can fix, since all Qt apps behave this way, and should be fixed upstream.
KDE Frameworks 5.37.0
Qt 5.9.1 (built against 5.9.1)
The xcb windowing system
Yes I know it's missing qtbase_ar, but it has qt_ar, which (if you notice) is bigger than the other qt_* files, because it is still in the old structure.
If you check the file in Qt translations repo, you'll see that special string used for mirroring, and it's "finished" so is being used.
Sorry but I don't get what you mean.
Are you talking about Windows version, or Linux version?
Everything works as it should here on ArchLinux, with Qt5.9 translations installed.
I didn't try KStars, but it should work correctly as other Qt and KF5 applications.
safaalfulaij updated the diff for D7660: Fix a regression caused by changing backspace key behavior.
- Typos and better if statement structure
Sep 15 2017
Sep 15 2017
safaalfulaij committed R230:69fd8b9e4142: Add myself to relicensecheck.pl (authored by safaalfulaij).
Add myself to relicensecheck.pl