Feed Advanced Search

Oct 28 2018

intelfx added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.
  • just because we cannot match a theme 100% does not imply that we have to adapt our implementation (there will always be a color in theme xy that does not properly exist in KTextEditor)
Oct 28 2018, 6:59 PM · Kate, Frameworks

Aug 16 2018

intelfx added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.

@cullmann So, how do you propose to port Solarized to Kate/KDevelop then?

Aug 16 2018, 5:33 PM · Kate, Frameworks

Aug 15 2018

intelfx added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.

@mwolff @dhaumann @brauch I'm sorry for my silence — I stopped using KDE/KDevelop some time ago and did not track this changeset properly. Could you please reiterate what was the conclusion and what were @mwolff's requested changes?

Aug 15 2018, 11:51 AM · Kate, Frameworks

Aug 8 2017

intelfx committed R32:eeaee84fcb17: Sublime::UrlDocument: don't (incorrectly) do a deep copy of the URL (authored by intelfx).
Sublime::UrlDocument: don't (incorrectly) do a deep copy of the URL
Aug 8 2017, 4:53 PM
intelfx committed R32:32e3eb65e94e: Re-add "SessionPrettyContents" field in the sessionrc. (authored by intelfx).
Re-add "SessionPrettyContents" field in the sessionrc.
Aug 8 2017, 4:38 PM
intelfx committed R32:bf3c99b298b9: Cleanup and fix session description handling and updating. (authored by intelfx).
Cleanup and fix session description handling and updating.
Aug 8 2017, 4:37 PM
intelfx committed R32:af511b5d22da: Refactor EnvironmentSelectionWidget and move KComboBox to its internal layout. (authored by intelfx).
Refactor EnvironmentSelectionWidget and move KComboBox to its internal layout.
Aug 8 2017, 4:37 PM
intelfx committed R32:17d1ccc0ca19: Add a test for ItemRepositoryRegistry disk-storage management. (authored by intelfx).
Add a test for ItemRepositoryRegistry disk-storage management.
Aug 8 2017, 4:33 PM
intelfx committed R32:f62eb939b7a4: Allow explicitly deleting the active session. (authored by intelfx).
Allow explicitly deleting the active session.
Aug 8 2017, 4:33 PM
intelfx committed R32:ac9ed009d7bf: Fix session dialog: endInsertRows() -> endRemoveRows(). (authored by intelfx).
Fix session dialog: endInsertRows() -> endRemoveRows().
Aug 8 2017, 4:33 PM
intelfx committed R32:daaa943da8d4: Properly unlock session when SessionController is destroyed. (authored by intelfx).
Properly unlock session when SessionController is destroyed.
Aug 8 2017, 4:33 PM
intelfx committed R32:259a45764e88: Separate item-repository classes into different files. (authored by intelfx).
Separate item-repository classes into different files.
Aug 8 2017, 4:33 PM
intelfx committed R32:1c9ed803942e: Use d-ptr in ItemRepositoryRegistry to hide implementation from the public API. (authored by intelfx).
Use d-ptr in ItemRepositoryRegistry to hide implementation from the public API.
Aug 8 2017, 4:33 PM
intelfx committed R32:49345019920f: Shutdown DUChain and item-repositories by ICore::shutdownCompleted() when… (authored by intelfx).
Shutdown DUChain and item-repositories by ICore::shutdownCompleted() when…
Aug 8 2017, 4:33 PM
intelfx committed R32:0a0b700cce27: Refactor ItemRepositoryRegistry::open(): do not check the cache-dir for… (authored by intelfx).
Refactor ItemRepositoryRegistry::open(): do not check the cache-dir for…
Aug 8 2017, 4:33 PM
intelfx committed R32:4e40c8eb7d33: Add signal ICore::shutdownCompleted() and emit it after cleanup. (authored by intelfx).
Add signal ICore::shutdownCompleted() and emit it after cleanup.
Aug 8 2017, 4:33 PM
intelfx committed R32:da2c83bcc476: Refactor ItemRepositoryRegistry::open(): make a reusable user interrogation… (authored by intelfx).
Refactor ItemRepositoryRegistry::open(): make a reusable user interrogation…
Aug 8 2017, 4:33 PM
intelfx committed R32:a3caa1c0f356: Refactor ItemRepositoryRegistry::open(): fix usage of getCustomCounter(). (authored by intelfx).
Refactor ItemRepositoryRegistry::open(): fix usage of getCustomCounter().
Aug 8 2017, 4:33 PM
intelfx committed R32:bc828ea91ac2: Make the ItemRepositoryRegistry class a singleton; get rid of locking. (authored by intelfx).
Make the ItemRepositoryRegistry class a singleton; get rid of locking.
Aug 8 2017, 4:33 PM
intelfx committed R32:752ac924f40f: Add and use API for clearing item-repository cache dirs. (authored by intelfx).
Add and use API for clearing item-repository cache dirs.
Aug 8 2017, 4:33 PM
intelfx committed R32:fcbd75b02e4d: Make ItemRepositoryRegistry::repositoryPathForSession() private. (authored by intelfx).
Make ItemRepositoryRegistry::repositoryPathForSession() private.
Aug 8 2017, 4:33 PM
intelfx committed R32:f98340a55c8f: Separate repository path acquisition into a distinct function. (authored by intelfx).
Separate repository path acquisition into a distinct function.
Aug 8 2017, 4:33 PM
intelfx committed R32:afb22dc4cfb0: Separate include pathes with newlines when listing them in a missing include… (authored by intelfx).
Separate include pathes with newlines when listing them in a missing include…
Aug 8 2017, 4:28 PM
intelfx committed R32:b28f0aecc634: Properly strip HTML from assistants' title and action descriptions. (authored by intelfx).
Properly strip HTML from assistants' title and action descriptions.
Aug 8 2017, 4:27 PM
intelfx committed R32:58a84b2756ca: Don't set "Solve" button title twice. (authored by intelfx).
Don't set "Solve" button title twice.
Aug 8 2017, 4:27 PM
intelfx committed R32:232ee03017a0: Fix double-rendering of text in "Solve" button of the problem navigation… (authored by intelfx).
Fix double-rendering of text in "Solve" button of the problem navigation…
Aug 8 2017, 4:27 PM
intelfx committed R32:0ee5b635c370: Fix filtered output item classification when multiple keywords are in the same… (authored by intelfx).
Fix filtered output item classification when multiple keywords are in the same…
Aug 8 2017, 4:27 PM
intelfx committed R32:6a5433ca5252: In the EnvironmentGroupList, implicitly take the group to be default if empty… (authored by intelfx).
In the EnvironmentGroupList, implicitly take the group to be default if empty…
Aug 8 2017, 4:27 PM
intelfx committed R32:afa4953170b9: Minor: move output widget listview attribute setting to where it's created. (authored by intelfx).
Minor: move output widget listview attribute setting to where it's created.
Aug 8 2017, 4:27 PM
intelfx committed R32:13cd0625bda3: Add ordering to the project build set. (authored by intelfx).
Add ordering to the project build set.
Aug 8 2017, 4:27 PM
intelfx committed R32:b1e4e916f37e: Initialize pointer to the buildsetmodel (ProjectControllerPrivate::buildset)… (authored by intelfx).
Initialize pointer to the buildsetmodel (ProjectControllerPrivate::buildset)…
Aug 8 2017, 4:27 PM
intelfx committed R32:55ede832eb04: Trivial: fixup session enumeration at loading (do not list "." and ".."). (authored by intelfx).
Trivial: fixup session enumeration at loading (do not list "." and "..").
Aug 8 2017, 4:26 PM
intelfx committed R32:16f7401f69dc: Trivial: fixup unit-tests for itemsForUrl(): provide well-formed URLs. (authored by intelfx).
Trivial: fixup unit-tests for itemsForUrl(): provide well-formed URLs.
Aug 8 2017, 4:26 PM
intelfx committed R32:eff03faf3fd5: OutputExecuteJob: honor the default environment group setting. (authored by intelfx).
OutputExecuteJob: honor the default environment group setting.
Aug 8 2017, 4:24 PM
intelfx committed R32:70596a891c37: Merge branch 'outputexecutejob' (authored by intelfx).
Merge branch 'outputexecutejob'
Aug 8 2017, 4:18 PM
intelfx committed R32:ccddfba59deb: OutputExecuteJob: use QHash for storing environment overrides. (authored by intelfx).
OutputExecuteJob: use QHash for storing environment overrides.
Aug 8 2017, 4:18 PM
intelfx committed R32:b6b8381ef703: OutputExecuteJob: get rid of slots in public API. (authored by intelfx).
OutputExecuteJob: get rid of slots in public API.
Aug 8 2017, 4:18 PM
intelfx committed R32:a8bd95319ddc: OutputExecuteJob: properly use flags. (authored by intelfx).
OutputExecuteJob: properly use flags.
Aug 8 2017, 4:18 PM
intelfx committed R32:321f8c3a9b4b: OutputExecuteJob: normalize connections. (authored by intelfx).
OutputExecuteJob: normalize connections.
Aug 8 2017, 4:18 PM
intelfx committed R32:1c082a06313c: OutputExecuteJob: use d-pointer to hide the class internals from public API. (authored by intelfx).
OutputExecuteJob: use d-pointer to hide the class internals from public API.
Aug 8 2017, 4:18 PM
intelfx committed R32:f34fc0d538db: OutputExecuteJob: do not enforce working directory existence by default. (authored by intelfx).
OutputExecuteJob: do not enforce working directory existence by default.
Aug 8 2017, 4:18 PM
intelfx committed R32:a851e006e20b: OutputExecuteJob: properly register JobProperties flags in Qt. (authored by intelfx).
OutputExecuteJob: properly register JobProperties flags in Qt.
Aug 8 2017, 4:18 PM
intelfx committed R32:d36ef1bb35bc: OutputExecuteJob: use KShell::joinArgs(). (authored by intelfx).
OutputExecuteJob: use KShell::joinArgs().
Aug 8 2017, 4:18 PM
intelfx committed R32:e32dc9c0997d: Revert "OutputExecuteJob: use KShell::joinArgs(); update job name on each… (authored by intelfx).
Revert "OutputExecuteJob: use KShell::joinArgs(); update job name on each…
Aug 8 2017, 4:18 PM
intelfx committed R32:a5161ee0a22e: OutputExecuteJob: improve working directory checking. (authored by intelfx).
OutputExecuteJob: improve working directory checking.
Aug 8 2017, 4:18 PM
intelfx committed R32:6e34b8b4e372: OutputExecuteJob: fix wording in messages ("had" -> "has", specify executable… (authored by intelfx).
OutputExecuteJob: fix wording in messages ("had" -> "has", specify executable…
Aug 8 2017, 4:18 PM
intelfx committed R32:7c1d9e5db1c7: OutputExecuteJob: clear LC_ALL if portable messages are required. (authored by intelfx).
OutputExecuteJob: clear LC_ALL if portable messages are required.
Aug 8 2017, 4:18 PM
intelfx committed R32:50358d210d21: OutputExecuteJob: fix timeouts and messages in doKill(). (authored by intelfx).
OutputExecuteJob: fix timeouts and messages in doKill().
Aug 8 2017, 4:18 PM
intelfx committed R32:5046bda7255d: OutputExecuteJob: use KShell::joinArgs(); update job name on each command line… (authored by intelfx).
OutputExecuteJob: use KShell::joinArgs(); update job name on each command line…
Aug 8 2017, 4:18 PM
intelfx committed R32:c46b5ceb94c5: OutputExecuteJob: add a separate error messages wording for builders (more user… (authored by intelfx).
OutputExecuteJob: add a separate error messages wording for builders (more user…
Aug 8 2017, 4:18 PM
intelfx committed R32:f6f66e0b178a: Add class OutputExecuteJob. (authored by intelfx).
Add class OutputExecuteJob.
Aug 8 2017, 4:18 PM
intelfx committed R32:7d0b2cb35078: Properly handle session deletion (using their lock status). (authored by intelfx).
Properly handle session deletion (using their lock status).
Aug 8 2017, 4:18 PM
intelfx committed R32:9791ac141f33: Add missing TestCore::shutdown() calls in tests' cleanup. (authored by intelfx).
Add missing TestCore::shutdown() calls in tests' cleanup.
Aug 8 2017, 4:18 PM
intelfx committed R32:770938dfae97: Refactor session loading/parsing code. (authored by intelfx).
Refactor session loading/parsing code.
Aug 8 2017, 4:18 PM
intelfx committed R32:e689368bbcad: Minor: replace custom KGuiItems with KStandardGuiItems in a session deletion… (authored by intelfx).
Minor: replace custom KGuiItems with KStandardGuiItems in a session deletion…
Aug 8 2017, 4:18 PM
intelfx committed R32:61fd1270da44: Fix session locking: consider session unlocked when and only when the D-Bus… (authored by intelfx).
Fix session locking: consider session unlocked when and only when the D-Bus…
Aug 8 2017, 4:18 PM
intelfx committed R32:b494439eb7d1: Fix session locking: avoid blocking in D-Bus calls for too long. (authored by intelfx).
Fix session locking: avoid blocking in D-Bus calls for too long.
Aug 8 2017, 4:18 PM
intelfx committed R32:3306c54df37e: Refactor session locking dialog. (authored by intelfx).
Refactor session locking dialog.
Aug 8 2017, 4:18 PM
intelfx committed R32:19a6961964a0: Refactor BuilderJob: use QList instead of QSet to store build actions - to keep… (authored by intelfx).
Refactor BuilderJob: use QList instead of QSet to store build actions - to keep…
Aug 8 2017, 4:18 PM
intelfx committed R32:7ca376d5de99: Merge branches 'projectkcm' and 'builderjob' (authored by intelfx).
Merge branches 'projectkcm' and 'builderjob'
Aug 8 2017, 4:18 PM
intelfx committed R32:9e2870e47dfa: Refactor BuilderJob: use QVector instead of QList to store subjob metadata. (authored by intelfx).
Refactor BuilderJob: use QVector instead of QList to store subjob metadata.
Aug 8 2017, 4:17 PM
intelfx committed R32:774edf9694ec: Refactor BuilderJob: call updateJobName() where appropriate. (authored by intelfx).
Refactor BuilderJob: call updateJobName() where appropriate.
Aug 8 2017, 4:17 PM
intelfx committed R32:41001f657d2d: Refactor BuilderJob: generate a human-readable job name; flatten job… (authored by intelfx).
Refactor BuilderJob: generate a human-readable job name; flatten job…
Aug 8 2017, 4:17 PM
intelfx committed R32:5b2526471311: ProjectManagerViewPlugin refactor: fix a minor style issue. (authored by intelfx).
ProjectManagerViewPlugin refactor: fix a minor style issue.
Aug 8 2017, 4:17 PM
intelfx committed R32:5ada18e541d5: Fix KCM selection for the project settings: use only suitable/related builder… (authored by intelfx).
Fix KCM selection for the project settings: use only suitable/related builder…
Aug 8 2017, 4:17 PM
intelfx committed R32:6681fcc7ffb8: Get rid of BuildItemBuilderJob in Project Manager View plugin. (authored by intelfx).
Get rid of BuildItemBuilderJob in Project Manager View plugin.
Aug 8 2017, 4:17 PM
intelfx committed R32:662b05e033a9: Fix new session creation in pick-session dialog. (authored by intelfx).
Fix new session creation in pick-session dialog.
Aug 8 2017, 4:17 PM
intelfx committed R32:1d04adfe8742: Set base directory of the CVS diff job properly. (authored by intelfx).
Set base directory of the CVS diff job properly.
Aug 8 2017, 4:17 PM
intelfx committed R32:0679f2233e2c: Oops, fix build errors (authored by intelfx).
Oops, fix build errors
Aug 8 2017, 4:17 PM
intelfx committed R32:2c4121fcb6e7: Add "-N" to CVS diff options. (authored by intelfx).
Add "-N" to CVS diff options.
Aug 8 2017, 4:17 PM
intelfx committed R32:7ea8d60b4a64: Distinguish process crash from non-zero exit code in DVcsJob. (authored by intelfx).
Distinguish process crash from non-zero exit code in DVcsJob.
Aug 8 2017, 4:17 PM
intelfx committed R32:2613b89f6f8e: Separate "directory valid" and "file is known" conditions in CVS plugin. (authored by intelfx).
Separate "directory valid" and "file is known" conditions in CVS plugin.
Aug 8 2017, 4:17 PM
intelfx committed R32:9b6d409b8276: Correctly handle non-zero exit codes of "cvs diff". (authored by intelfx).
Correctly handle non-zero exit codes of "cvs diff".
Aug 8 2017, 4:17 PM
intelfx committed R32:b9d6b7a7da7c: Fix new session creation in pick-session dialog. (authored by intelfx).
Fix new session creation in pick-session dialog.
Aug 8 2017, 4:17 PM
intelfx committed R32:5c2cf15e0b57: Oops, fix build errors (authored by intelfx).
Oops, fix build errors
Aug 8 2017, 4:17 PM
intelfx committed R32:8245741520a0: Set base directory of the CVS diff job properly. (authored by intelfx).
Set base directory of the CVS diff job properly.
Aug 8 2017, 4:17 PM
intelfx committed R32:8e902263a7a8: Move status gathering into VCSDiffPatchSource. (authored by intelfx).
Move status gathering into VCSDiffPatchSource.
Aug 8 2017, 4:17 PM
intelfx committed R32:0eed1816cd9f: Separate "directory valid" and "file is known" conditions in CVS plugin. (authored by intelfx).
Separate "directory valid" and "file is known" conditions in CVS plugin.
Aug 8 2017, 4:17 PM
intelfx committed R32:c11e4ef49ef8: Add "-N" to CVS diff options. (authored by intelfx).
Add "-N" to CVS diff options.
Aug 8 2017, 4:17 PM
intelfx committed R32:788e09be1ab2: Distinguish process crash from non-zero exit code in DVcsJob. (authored by intelfx).
Distinguish process crash from non-zero exit code in DVcsJob.
Aug 8 2017, 4:17 PM
intelfx committed R32:0d71c7e778e0: Correctly handle non-zero exit codes of "cvs diff". (authored by intelfx).
Correctly handle non-zero exit codes of "cvs diff".
Aug 8 2017, 4:17 PM
intelfx committed R32:569aa69572fc: Merge branch '1.4' (authored by intelfx).
Merge branch '1.4'
Aug 8 2017, 4:17 PM
intelfx committed R32:33fb2f8063aa: Screen completionProperties() with a DU-chain lock. (authored by intelfx).
Screen completionProperties() with a DU-chain lock.
Aug 8 2017, 4:17 PM
intelfx committed R32:3bec676da7f9: Merge branch '1.4' (authored by intelfx).
Merge branch '1.4'
Aug 8 2017, 4:16 PM
intelfx committed R32:1b3ee79bb533: Enumerators are rather variables than types, so mark accordingly. (authored by intelfx).
Enumerators are rather variables than types, so mark accordingly.
Aug 8 2017, 4:16 PM
intelfx committed R32:0f2de910a004: Handle default remote branch descriptions in Git plugin. (authored by intelfx).
Handle default remote branch descriptions in Git plugin.
Aug 8 2017, 4:16 PM
intelfx committed R32:6f479018b349: Handle default remote branch descriptions in Git plugin. (authored by intelfx).
Handle default remote branch descriptions in Git plugin.
Aug 8 2017, 4:16 PM

May 24 2017

intelfx added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.

Then I can also apply the patch locally and try it out myself and maybe come up with a concrete idea to fix this all.

May 24 2017, 1:35 PM · Kate, Frameworks

May 14 2017

intelfx added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.

For solarized you showed the screenshots in your original mail. I'm more concerned about backwards compatibility with other schemes. I.e. yes - we do care about the status quo. Can you give an example for a color scheme where this would break stuff? Then I can also apply the patch locally and try it out myself and maybe come up with a concrete idea to fix this all.

May 14 2017, 11:10 AM · Kate, Frameworks
intelfx added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.

Hey there,

sorry for the long delay. In general this sounds like a good idea. But what do you mean by "However, just making that change will make Kate/KDevelop incompatible with all existing color schemes"? Can you show some before/after screenshots for an existing color scheme? I mean for your solarized theme it looks fine.

May 14 2017, 10:28 AM · Kate, Frameworks

May 10 2017

intelfx updated the summary of D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.
May 10 2017, 11:01 PM · Kate, Frameworks
intelfx updated the summary of D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.
May 10 2017, 11:00 PM · Kate, Frameworks
intelfx created D5804: KatePluginSearchView: use selection foreground for search highlights.
May 10 2017, 10:57 PM · Kate
intelfx created D5803: ContextBrowserPlugin: fix using selection foreground for search highlights.
May 10 2017, 10:55 PM
intelfx created D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.
May 10 2017, 10:49 PM · Kate, Frameworks

Sep 10 2016

intelfx committed R33:6125c1dd9a1a: Correctly handle non-zero exit codes of "cvs diff". (authored by intelfx).
Correctly handle non-zero exit codes of "cvs diff".
Sep 10 2016, 4:34 AM
intelfx committed R33:50e88b40c1c7: Enumerators are rather variables than types, so mark accordingly. (authored by intelfx).
Enumerators are rather variables than types, so mark accordingly.
Sep 10 2016, 4:29 AM
intelfx committed R33:34f09431ac68: Global search and elimination of 0xffffffff. (authored by intelfx).
Global search and elimination of 0xffffffff.
Sep 10 2016, 4:29 AM
intelfx committed R33:4ba2bb33f376: Add "-N" to CVS diff options when working dir is being diff'ed. (authored by intelfx).
Add "-N" to CVS diff options when working dir is being diff'ed.
Sep 10 2016, 4:29 AM
intelfx committed R33:c0a74f44387c: Enumerators are rather variables than types, so mark accordingly. (authored by intelfx).
Enumerators are rather variables than types, so mark accordingly.
Sep 10 2016, 4:29 AM