It should be lighter in the case of dark themes, that's what I get empirically and what the code points to. How do I reproduce this?

@ngraham I can change this patch so only the logout avatar' size is increased and then land that on the 5.17 as there is no risk of breaking anything. I can then change the lock screen as well, but for 5.18. They won't be precisely the same size in 5.17 though.

There is already a patch trying to change this, it would be good to involve Sefa as well: D18000

+1

+1 to the patch

continued in D25252

I'm not seeing any binding loop warnings when testing this fwiw.

Yeah you guys are right. I tested this further and still got some binding loop errors with paintedWidth/Height.

friendly ping

Before:

There's definitely a difference, whereas the shadows are now rough and dark this is subtler.

I'd prefer the shadows to have equal strength all around, I couldn't get used to weaker shadows in the corners.

In D25150#558758, @ngraham wrote:

I think so. This is a bugfix.

Would this be an acceptable change for the 5.17 branch?

Might also be worth mentioning this now makes it consistent with sidebar view, which doesn't use this emblem.

In D24720#558099, @safaalfulaij wrote:

Hi :)
Please tag me in case you need any RTL help.
Yes, headers are aligned based on direction before, which was bad. It's almost better to align them to the other side even if they're not translated. You never know.
And good that you spotted the issue with QML's Layouts regarding RTL:)

As a user, I'm happy to see more work being done to refactor the code and make it easier! <3

In D24720#557915, @ngraham wrote:

It it just awaiting review from a Plasma person?

I don't think worsening text legibilty with some themes is a good feature for an LTS release.

In D25043#556268, @ndavis wrote:

In D25043#555976, @filipf wrote:

Not a fan of this for 2 reasons:

• we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:
  
• it's not consistent with how this effect is achieved elsewhere in Plasmashell (where the opacity is 0.6 and not 0.5 or 0.3, so it seems that was wrong here).
  
  I'd just raise the opacity values instead.

Wait, this is the Breeze Dark colorscheme with the Breeze desktop theme? The desktop theme that gets its colors from the system colorscheme? If so, something is seriously wrong here.

In D25043#556015, @davidedmundson wrote:

@kbroulik we should try to wait if there is an ongoing discussion.

I have the latest package installed in KDE Neon Dev Unstable, does it need to be compiled instead for some very recent change?

Yes, there's a partner patch adding a disabledText role to Plasma theme to bring it in line with kirigami.
I think Neon builds once every night? If you don't have it your console will be spewing errors saying "no such role"

In D25043#555980, @broulik wrote:

in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:

Make sure your plasma-framework is up to date

Not a fan of this for 2 reasons:

• we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:

@davidedmundson I believe you wrote the code for the the avatar size in the lock and login screens (property real faceSize: Math.min(width, height - usernameDelegate.height - units.smallSpacing).

Tested the patch and it no longer accepts strings or values under 24.

Testing it. Usability wise the strength is perfectly fine; the shadows still do their job.

Yeah there is a conceptual issue here we need to look into solving. IMO we should just always have white UI elements and the background dimmed.

Admittedly this doesn't look super fortuate either when the wallpaper is darker:

also apply the same fix to the login screen

In T11925#205795, @ngraham wrote:

maybe we should consider doing the same here and make the opacity and blur settings global such that they affect both apps and Plasma equally.

I'd go with 80% opacity. That's not the trendy value, lower opacity values are. Text will be legible but the aesthetics are improved.

In T10495#205468, @davidedmundson wrote:

Update: I did an amazing rewrite of wallpaper that cleaned a lot up, but this task still arguably remains.

In D24901#553055, @KonqiDragon wrote:

Is it possible to make a smooth effect animation? Like in sidebar.

In D24901#553008, @ngraham wrote:

5.17

also make the effect appear on activeFocus (tabbing)

Makes sense. It's unrelated to this patch but what's up with the double message ("No space on device left" and "not enough free disk space") here?

Everything should work fine now hopefully.

• pin button now appears in the "Status and Notifications" popup again
• simpler code for checking layout mirroring

Based on a search of some examples of RTL UI settings I'm going to say headings also go on the right side, so it seems they were actually not correctly placed before.

The latest version already works with RTL without the fillWidth code being needed. So as far as I can tell the diff you posted only effectively removes the margins from headings. But I think we should keep them, i.e., align those headings with the container (@GB_2 already mentioned this : D24720#548745)

restore original margin between sidebar and container

Gonna leave all color scheme updates to @ndavis and @cblack who have been working on a new palette for Breeze etc.

In D24720#550200, @ngraham wrote:

Seems like the RTL problem may be that your RowLayouts that are within the parent ColumnLayout don't have Layout.fillWidth: true set. Does the problem go away if you set that?

So much nicer, awesome work. +1 for the visuals of the rehauled kcm.

In D24720#549292, @ngraham wrote:

Nice, this feels indistinguishible from the current one, which is a good sign. I see what you mean about the Headings in RTL. Does the Kirigami version work properly? If so, I wonder if it might be worth it to just use that instead given that the future of PlasmaComponents is on shaky ground (T11558: kill plasma components in favour of qqc2-desktop-style)

make all this work right with RTL layouts

Agreed, let's not change the padding.

don't alter padding