In D19822#439167, @hein wrote:

I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means either the feature or the checkbox should probably go. Firefox gets away without the option BTW.

Looks good. Since it's a proprietary program just check if they have any restrictions about having to use their icons. And yep, the xmlerrors file should be removed.

Don't break the slideshow wallpaper plugin by putting everything in a form layout

lose the unecessary QtQuick.Controls 1 import

If there's no objections I'll land this tomorrow night so we can keep working on fixing the plugins.

I still think we should make it configurable. We'd want to be able to avoid situations with parents or a newbies going something like: "I was watching/listening to X and your darn Linux stopped playing sound!".

In D12055#436412, @ndavis wrote:

I don't see this border at all in the current version of Breeze GTK with Firefox.

These borders are still pretty bad looking, I think we should go through with this.

Ever since increasing the list item size to accommodate 32px icons, System Settings' sidebar has felt somehow wrong to me

Visually I don't think there's anything to object to, and this is a useful message to have. The wording seems fine. Someone should also confirm that the code is sane.

make the "Folders" string translatable

In D18809#436246, @victorr wrote:

File /wallpapers/image/imagepackage/contents/ui/config.qml
Word "Folders" without translation

Kirigami.Heading {
    text: "Folders"
    level: 2
}

This is a good feature. I'd definitely add an option so it can be turned on/off regardless of how well we fix up the icon. Sometimes you need to dummy-proof installs so all that matters is that it can be configured; by default it could be turned on IMO.

I've done a lot of clean up because: (1) some code is not needed for the FormLayout; (2) things worked the same without some code; (3) ported the combobox to QQC2 because the main layout is also using QQC2 comboboxes and everything still fits with normal scaling.

remove line: twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : []

port everything

Second line results in a stack not defined error.

In D19873#434949, @mart wrote:

So,
FormLayout has api to align two or more of them with each other, which is the list property FormLayout.twinFormLayouts

I wonder if there is a way to make the parent and child formlayouts visible ot each other to use such property.

the parent is in plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml, loading the individual wallpapers config in the stackview at line 162.

so, we could try something like:
the wallpaper configs will expose a formLayout property.
the main formLayout has something like
twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : []

then the parent layout may be i guess injected at instantiation as a property of the wallpaper plugin, so the child formlayout can set twinformlayouts as well

this is all untested, so is a bit of R&D project, but if you would like to give a try it may be finally the properfix(tm)

Initial implementation of twinFormLayouts

In D19802#435421, @abetts wrote:

The title labels appear to be very far from the content. Is that just the size on the images or does it actually look very far when the config screen is full size?

Change strings according to Nate's suggestions

Beautiful.

In D19873#434571, @davidre wrote:

It seems it was changed in this commit to explicitly use Kirigami units: 98d9f681a37e2ac2feb6bf5cb5e8a54f4c7e874e
Was the Color wallpaper forgotten or did this reason not apply to it? Should we revert it?

In D19873#434568, @davidre wrote:

Mhm if I change it to use units like Color instead of Kirigami units it seems aligned properly:

@mart would you happen to know how to trick one FormLayout into thinking its content is as wide as another FormLayout's content?

In D19873#434468, @ngraham wrote:

In D19873#434441, @filipf wrote:

I just have to figure out how trick the image wallpaper's FormLayout into thinking its form is as wide as the main one's.

That's why. :) They come from different sources, so the plugin's formLayout doesn't have access to the width data for the chooser's formLayout. However if you can figure out how to make this work, I think that would definitely be the ideal solution because then it wouldn't need any hacks.

In D19873#434426, @ngraham wrote:

In D19873#434232, @filipf wrote:

This is just theoretical, but what are the obstacles with adding this whole row to the actual FormLayout file and just setting visible: when_image_wallpaper_is_used ?

Because the wallpaper chooser is plugin-based, and the image wallpaper is just one plugin out of many. In principle a wallpaper plugin could have whatever UI it wants, and its configuration UI has to live in a different place. It's just a visual trick that they look integrated together in the page.

This is just theoretical, but what are the obstacles with adding this whole row to the actual FormLayout file and just setting visible: when_image_wallpaper_is_used ?

I actually like the left margin because it contributes to visual hierarchy when headings are present:

I think I'm still off by a pixel, will test better tomorrow.

Abandoning due to the impending overhaul of notifications.

rebase

fix dumb value

Alright so I'd like to give RoundButton another chance. Its advantage is that the frame is considerably smaller.

Try using RoundButton

avoid using headings, fix spinbox strings

Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours?

In D19044#432878, @mart wrote:

In D19044#432875, @filipf wrote:

In D19044#432853, @mart wrote:

uuh, no, this duplicates more, i meant moving things from the control to the template

But I moved most of things from src/controls/InlineMessage.qml to src/controls/templates/InlineMessage.qml?

i was put off by phabricator being stupid and telling src/controls/templates/InlineMessage.qml (173 lines)
Copied to src/styles/Material/InlineMessage.qml

however yeah, it seems alright, sorry, go for it =)

In D19044#432853, @mart wrote:

uuh, no, this duplicates more, i meant moving things from the control to the template

Definitely some silly mistakes in there, thanks for showing me how to do it right!

In D19797#431918, @ngraham wrote:

+1 for porting to Kirigami.Formlayout, but I'm not sure that the new layout is an improvement. Something about it just doesn't feel quite right to me.

This might be a case where we could benefit from using actual headers ("Numbers" and "Pieces"), maybe?

1 strips per comic -> 1 strip per comic

when value for minutes is 1 use "min" instead of "mins", when value for days is 1 use "day"
instead of "days"

forgot anchors again

forgot to add anchors