Feed Advanced Search

Jan 21 2020

paolini added a comment to D26333: Fix assertion failure when creating a python script in kig.

Closing... I was unsure what to do. The commit that I made contained the wrong reference, so that there is no evidence here that the patch was applied.
BTW that was

Jan 21 2020, 5:18 PM · KDE Edu

Jan 18 2020

paolini committed R331:faec9ac0f6f7: Going back to original Py_Finalize() to maintain compatibility with pithon2 and… (authored by paolini).
Going back to original Py_Finalize() to maintain compatibility with pithon2 and…
Jan 18 2020, 6:18 AM
paolini closed D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.
Jan 18 2020, 6:18 AM · KDE Edu
paolini updated the diff for D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.

Going back to original Py_Finalize() to maintain compatibility with pithon2 and earlier versions of python3

Jan 18 2020, 5:43 AM · KDE Edu

Jan 16 2020

paolini added inline comments to D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.
Jan 16 2020, 11:17 PM · KDE Edu

Jan 13 2020

paolini added a comment to D26166: Add a QDialogButtonBox to the Coordinate Precision Dialog.

Is there a reason why the patch was not applied to master? It would seem plausible...

Jan 13 2020, 3:57 PM · KDE Edu

Jan 11 2020

paolini committed R331:211f8501ec4c: Fix crash upon exit after transition python2 -> python3 when using scripting… (authored by paolini).
Fix crash upon exit after transition python2 -> python3 when using scripting…
Jan 11 2020, 6:56 PM
paolini added a comment to D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.

Since I forgot to mention, this is a patch agains bug #416037

Jan 11 2020, 6:55 PM · KDE Edu

Jan 10 2020

paolini updated the diff for D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.

Removed comments

Jan 10 2020, 12:02 AM · KDE Edu

Jan 9 2020

paolini requested review of D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.
Jan 9 2020, 5:44 PM · KDE Edu

Jan 8 2020

paolini added a comment to D26333: Fix assertion failure when creating a python script in kig.

patch applied to release/19.12 also

Jan 8 2020, 9:14 AM · KDE Edu
paolini committed R331:4c689131bd85: Fix https://bugs.kde.org/show_bug.cgi?id=401512 (authored by paolini).
Fix https://bugs.kde.org/show_bug.cgi?id=401512
Jan 8 2020, 9:13 AM
paolini added a comment to D26333: Fix assertion failure when creating a python script in kig.

Pushed in git@git.kde.org:kig branch master. I should do the same in Applications/19.12, I guess

Jan 8 2020, 9:05 AM · KDE Edu
paolini committed R331:49c1f484de25: Merge branch 'master' of git.kde.org:kig (authored by paolini).
Merge branch 'master' of git.kde.org:kig
Jan 8 2020, 8:49 AM
paolini committed R331:3f26783588ea: Fix https://bugs.kde.org/show_bug.cgi?id=401512 (authored by paolini).
Fix https://bugs.kde.org/show_bug.cgi?id=401512
Jan 8 2020, 8:49 AM

Jan 7 2020

paolini added a comment to D26333: Fix assertion failure when creating a python script in kig.

On second thought I would vote for Py_INCREF... an object_imp can change dinamically, but I think the worst case would be an "InvalidObject", which still is an object.
We should apply this patch in the git repository; I think I can do it myself.

Jan 7 2020, 4:22 AM · KDE Edu

Dec 31 2019

paolini added a reviewer for D26333: Fix assertion failure when creating a python script in kig: KDE Edu.
Dec 31 2019, 4:25 PM · KDE Edu
paolini requested review of D26333: Fix assertion failure when creating a python script in kig.
Dec 31 2019, 4:24 PM · KDE Edu
paolini added a comment to T12453: patch to bug https://bugs.kde.org/show_bug.cgi?id=401512 (assertion failure when using python scripting in kig).

I uploaded the result of a git diff in

Dec 31 2019, 3:34 PM · KDE Applications
paolini added a comment to T12453: patch to bug https://bugs.kde.org/show_bug.cgi?id=401512 (assertion failure when using python scripting in kig).

my collegue Franco Pasquarelli proposed the following patch

Dec 31 2019, 2:04 AM · KDE Applications
paolini triaged T12453: patch to bug https://bugs.kde.org/show_bug.cgi?id=401512 (assertion failure when using python scripting in kig) as High priority.
Dec 31 2019, 2:01 AM · KDE Applications

Jun 1 2018

paolini closed D13139: Kig bug 394676.

pushed patch to master

Jun 1 2018, 3:39 PM · KDE Edu
paolini committed R331:f324508e822d: Fix bug 394676 (authored by paolini).
Fix bug 394676
Jun 1 2018, 3:37 PM
paolini accepted D13139: Kig bug 394676.

Now that the goldenpoint got merged in master, we should also push this bug patch (in master). I can take care of that.
perhaps a bug should also be merged into other branches of kig?

Jun 1 2018, 3:31 PM · KDE Edu

May 30 2018

paolini added a comment to D13139: Kig bug 394676.

I think we should wait for David Narvaez to decide what to do

May 30 2018, 5:03 PM · KDE Edu

May 26 2018

paolini added a comment to D13139: Kig bug 394676.

This patch is on top of the golden ratio point patch.

May 26 2018, 11:26 PM · KDE Edu
paolini added a comment to D12913: Golden ratio point.

As I said, this is not a probem specific of the Golden Ratio. You should have a look at the bug report https://bugs.kde.org/show_bug.cgi?id=394676
This is a consequence of a somewhat obscure information that can (should) be associated to a construction.
I know this very well since I am responsible for it.

May 26 2018, 10:42 PM · KDE Edu

May 25 2018

paolini added a comment to D12913: Golden ratio point.

I just filed a bug report for the problem mentioned above: https://bugs.kde.org/show_bug.cgi?id=394676
in that report there is no mention of the new GoldenRatio property; it would raise the number of properties
of a segment from 5 to 6, the method mentioned in the bug report should return "true" for the GoldenRatio
property, since the constructed point is contained in the segment.

May 25 2018, 4:42 PM · KDE Edu
paolini added a comment to D12913: Golden ratio point.

About the crash above: the problem resides in AbstractLineImp::isPropertyDefinedOnOrThroughThisImp...
However it involves more than the new Golden Point. Perhaps the right action should be to file a bug
report.
It seems that the implementation of this property is wrong with respect to the hierarchy of objects

May 25 2018, 2:36 PM · KDE Edu
paolini added a comment to D12913: Golden ratio point.

I get a crash with a construction involving the new 'golden ratio' point:

  1. construct a segment s = AB
  2. construct the golden point G from the segment
  3. circle of center C (somewhere) through G
  4. position C such that the circle has two distinct intersections with the segment, one is G
  5. contruct the intersections between the segment and the circle
May 25 2018, 1:52 PM · KDE Edu

May 16 2018

paolini accepted D12913: Golden ratio point.

I would not object in accepting this revision

May 16 2018, 3:24 PM · KDE Edu
paolini added a comment to D12913: Golden ratio point.

Concerning the external point... I would *not* add a construction for it... I am afraid that such construction would be somewhat confusing.

May 16 2018, 3:03 PM · KDE Edu
paolini added a comment to D12913: Golden ratio point.

As you see... most (if not all) of the figures representing the golden section show the larger segment on the left. And when you say
"short to long equals long to whole", this is simply the result of a phrase where the subject is actually the "long", something like
"the long is 'in between' the whole and the rest".
Moreover you could as well say
"whole to long equals long to short" (and I would prefer this latter phrasing as more corresponding to the definition:

May 16 2018, 2:44 PM · KDE Edu
paolini added a comment to D12913: Golden ratio point.

I have one remark. Since the result is different depending on how we orient the segment (say) AB we have to decide if the construction
gives the point on the segment nearest to A or the one nearest to B. The proposed solution:

May 16 2018, 1:04 PM · KDE Edu