Feed Advanced Search

May 5 2019

johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.

Sorry for the delay... I was finally able to get the crashing machine set up again.

May 5 2019, 6:18 AM · Plasma
johngehrig updated the diff for D20859: Crash in sddmthemeinstaller invalid use of errorString.

Ordering changed, qWarning first.
job->errorString() displayed for all values of job->error().
A QString object was created, so job is no longer passed to KMessageBox.

May 5 2019, 6:03 AM · Plasma

Apr 29 2019

johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.

Thanks for the clarification! I understand what you are saying :)

Apr 29 2019, 8:12 PM · Plasma
johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.

The API for errorString() calls out that it should not be called when error() == 0. The code does not explicitly check for this scenario.

Apr 29 2019, 4:57 PM · Plasma
johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.

@anthonyfieroni Yes, I think there also an issue with KAuth here. This machine never gets to the auth prompt, which works fine on another machine.

Apr 29 2019, 4:49 PM · Plasma

Apr 27 2019

johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.

It looks like my alternate error "unknown error" isn't showing up in the dialog... So this isn't quite right yet.

Apr 27 2019, 3:40 AM · Plasma
Restricted Application added a project to D20859: Crash in sddmthemeinstaller invalid use of errorString: Plasma.
Apr 27 2019, 3:29 AM · Plasma
johngehrig requested review of D20859: Crash in sddmthemeinstaller invalid use of errorString.
Apr 27 2019, 3:28 AM · Plasma