D19122

ping

modify existing desktop file instead of installing a new one

I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the device's properties still have Optical=true.
Adding "updateBackend(udi);" before "emit deviceAdded(udi);" gives Udisks time to become consistent.

Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.

Gwenview supports these formats only when it is built with KDcraw.
I used the approach from okular: when okular is built with support for a set of formats, then a separate desktop file is installed for them.
And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

ping

extend the comment

fix commit description

re-target to Plasma/5.12

See also https://bugreports.qt.io/browse/QTBUG-73122

rebased

It makes sense to sync with Calligra.

Looks like the bug is caused by removing the line "updateBackend(udi);"

This change causes a bug: when you eject a mounted CD from the applet, then CD-ROM tray closes immediately after ejecting.

Oh, I see.

I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa

Is it possible to implement support for foreign windows in KWin QPA plugin?

The problem with this change is that speed is shown in bytes, not in bytes/s.

I mentioned in D14835 that the total number of received/transmitted bytes is more useful than the current speed.
One can see the current speed on the graph.

ping

https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html

std::bind can be hard to read and can result in larger object files and binaries due to type information that will not be produced by equivalent lambdas.

Maybe bump up required Qt version?
Qt 5.9 is the current LTS release and the next LTS release Qt 5.12 is coming soon.

rename slot

Why not use include(ECMEnableSanitizers)?

The constant 0.001 is taken from libzip. It means that the callback will be called each time when compressing more than 1/1000 part of a file.
At least it doesn't change the old behavior.