Feed Advanced Search

Tue, Jan 21

nicolamori added a comment to D24817: Restore scripting functionalities and Qt bindings..

I just uploaded a new revision with installation rules for the bindings shared libraries. I also checked the QCAD license: they release the code under GPLv3 with no exceptions (as far as I understood) for the bindings code, so I guess there's no licensing issue in using the bindings in Amarok.
I tested the code with a simple script (BurnPlaylist) which works with minor tweaks to the script itself. However, some scripts are missing some Amarok components that have been removed, e.g. UltimateLyrics gives a warning([WARNING] [ScriptItem] Script has no script engine attached: "UltimateLyrics") and does not work, I think because LyricsManager has been removed.
I'd say then that the work on restoring the Qt bindings is done, and now it has to be decided whether to go on (which means restoring the removed scripting functionalities, something I cannot do) or stop here and drop these modifications.

Tue, Jan 21, 4:24 PM
nicolamori updated the diff for D24817: Restore scripting functionalities and Qt bindings..
  • scripting: add installation rule for qt script bindings plugin libraries.
  • scripting: add readme file with credits to QCAD project.
Tue, Jan 21, 4:02 PM

Oct 24 2019

nicolamori added a watcher for Amarok: nicolamori.
Oct 24 2019, 11:40 AM

Oct 21 2019

nicolamori added a comment to D24817: Restore scripting functionalities and Qt bindings..

Hi Heiko, I know that QtScript is EOL but I don't have the knowledge nor spare time to do more than this ATM. I never contributed to Amarok nor any other KDE project, and also my experience with Qt is limited to some simple GUI. Nevertheless, I hope that this work migth be useful for more experienced programmers who wishes to introduce QJSEngine in Amarok, or for me to really start contributing. For the time being, I'd like to receive comments about how to proceed and what's to be changed/fixed.

Oct 21 2019, 8:22 AM
nicolamori requested review of D24817: Restore scripting functionalities and Qt bindings..
Oct 21 2019, 6:27 AM