Me too

In D21915#482877, @aacid wrote:

In D21915#482182, @knambiar wrote:

In D21915#482145, @aacid wrote:

The other question is if "enabled" was ever the correct atom to check for

libinput Tapping Enabled

I'm fairly sure we were checking for libinput Tapping Enabled atom in the past, and so does GNOME: https://gitlab.gnome.org/GNOME/gtk/blob/master/gdk/x11/gdkdevicemanager-xi2.c#L410

I can't find any use of that, the current use of "enabled" was added by @atulbi

• Now we have separate m_touchpadOffAtom for synaptics and Libinput. On Libinput, used m_enabled prop.
• setTouchpadOff will be ignored on X Libinput.

In D21278#466804, @romangg wrote:

by kded on key press other than Kded Keyboard shortcuts

Do you mean it's sent on shortcut or not? Just wondering why I couldn't replicate the issue in my testing.

kded5 did not crash until I pressed some key which is not Kded Keyboard shortcuts. Like Ctrl+Alt+T did not crash it, but just pressing any other key crashed it.
Sending patch for it in a while.

In D21278#466801, @davidedmundson wrote:

m_connection seems to be having null or 0x0 value.

Which means we're calling XcbAtom::atom after being constructed from the default constructor not the proper one.

That doesn't sound right. If you can explain why we end up in this situation and it's legit, I'll accept, otherwise it looks like we're just treating a symptom.

Thank you so much for fixing it.
Wanted it to be on beta.

In D20186#465586, @ngraham wrote:

Also keep in mind that it's possible to have global config files in /etc/X11/xorg.conf.d/ I have one such file there myself that I made to work around the lack of this feature being implemented yet:

$  cat /etc/X11/xorg.conf.d/99-libinput.conf
Section "InputClass"
        Identifier "libinput touchpad catchall"
        MatchIsTouchpad "on"
        MatchDevicePath "/dev/input/event*"
        Driver "libinput"
        Option "ClickMethod" "clickfinger" # other option is "buttonareas"
        Option "DisableWhileTyping" "false"
        Option "AccelSpeed" "0.2"
        #Option "MiddleEmulation" "true" # Only use this with the "buttonareas" clickmethod
EndSection

Others may have similar settings. If possible, it might be nice to read these config files to determine the default option state in the KCM. Then once the user modifies anything, a new user-specific config file gets written that takes priority.

In D20186#465395, @romangg wrote:

I found a grave issue now when testing though: Saved values are not restored on Reboot. Are they saved at all to a config file?

EDIT: No, they are not. In X11 + evdev the KCM does this, not the backend. We need to:

1. add config file write and load functions to the X11-libinput backend
2. add a hook to kcm_init such that the load function is called on startup.
   
   @atulbi: Do you have time to try this tomorrow?

In D20186#465361, @ngraham wrote:

@atulbi This has caused a failure in the CI:

https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console

09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal error: libinput-properties.h: No such file or directory
09:12:41   #include <libinput-properties.h>
09:12:41            ^~~~~~~~~~~~~~~~~~~~~~~
09:12:41  compilation terminated.

Looks like we need to make the libinput xorg dev package a mandatory dep (boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I know it's short notice but we branch in two days; do you think you could fix this? Thanks!

In D20186#465278, @ngraham wrote:

Are you ready for me to land this?

Set visible to false, until accel profiles are not supported.

Finally no more greyed settings there \o/

• lmr mapping working now

• Added Copyright notice
• Corrected asterisk placement

In D20186#462883, @GB_2 wrote:

Ping

• Remove CMakeLists.txt.user

• Added abstract class LibinputCommon.
• All the Q_PROPERTY are in LibinputCommon.
• Added Disable Horizontal Support on X11 on Libinput.

• Removed last commit

• Added new abstract class LibinputCommon
• Add overriding destructor
• Added support for disable horizontal scrolling on Libinput On X11.

In D20186#458259, @ngraham wrote:

@atulbi were you able to get in touch with @romangg? Can I help in any way?

The feature freeze for Plasma 5.16 is in a little over two weeks (https://community.kde.org/Schedules/Plasma_5) and it would really nice to finally have full Libinput support in our KCM in that release. Right now we'd still have enough time for testing because of the beta period, but we'll need to get it in within the next two weeks.

In D20186#454420, @ngraham wrote:

@atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first.

In D20186#443596, @romangg wrote:

Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the code is shared.

• Resolved issues

In D20186#443723, @knambiar wrote:

Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product.

@atulbi Congratulations, you’re now the maintainer of Touchpad KCM. In certain countries, there’s something called “inheritance tax” and you just inherited a few dozen bugs. Don’t despair, many of them should be fixed by now and some will be fixed by this commit.

In D20186#443554, @ngraham wrote:

In D20186#443262, @knambiar wrote:

I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D

Hey, I would be happy to take that responsibility.

Fantastic.

@ngraham @jriddell Would you let me know the technicalities to make Atul maintainer of Touchpad KCM? I couldn't find a guideline in the wiki/techbase.

Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product.

@atulbi is anything special needed to compile the KCM? After compiling plasma-desktop with your patch, no touchpad shared library was produced.

In D20186#442088, @knambiar wrote:

Got to Know a lot about how X works with input handling. XD

I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D

• Code Cleanup and resolved unexpected behaviour

• Avoid Setup Backend two times

In D20186#441892, @ngraham wrote:

Thanks so much for this!

• Minor changes to optimise code

Thanks. Yes, I'll take this for sure.

• fixed warning

• Changed C-style cast to static cast
• improve whitespace

No , I don't have commit rights

• added test for defaults

• Added dbus test for default values

• Added dbus test

Added unit test

Yes Next I'm going to implement unit test once this get finalized