Feed Advanced Search

Aug 24 2018

smithjd added a comment to D15047: Export the StorageDevices object..

There is no need for this, just create a new StorageDevices where you need it.
Creating a second StorageDevices instance in a process is quite cheap.

Aug 24 2018, 2:49 AM · Baloo, Frameworks
smithjd edited dependencies for D11529: Balooctl: Deindex unfound files with check command., added: 2; removed: 1.
Aug 24 2018, 1:56 AM · Baloo, Frameworks
smithjd added a dependent revision for D13216: Overhaul the file index scheduler.: D11529: Balooctl: Deindex unfound files with check command..
Aug 24 2018, 1:56 AM · Baloo, Frameworks
smithjd added a dependent revision for D15047: Export the StorageDevices object.: D11529: Balooctl: Deindex unfound files with check command..
Aug 24 2018, 1:56 AM · Baloo, Frameworks
smithjd removed a dependent revision for D13424: Run a file changed check when the file watches are updated.: D11529: Balooctl: Deindex unfound files with check command..
Aug 24 2018, 1:56 AM · Baloo, Frameworks
smithjd added a reviewer for D15047: Export the StorageDevices object.: broulik.

This was included in https://phabricator.kde.org/D11529 and is now broken out.

Aug 24 2018, 1:50 AM · Baloo, Frameworks
smithjd requested review of D15047: Export the StorageDevices object..
Aug 24 2018, 1:46 AM · Baloo, Frameworks

Aug 23 2018

smithjd added a comment to D13291: [kioclient] Use UDS_DISPLAY_NAME for file names..

kioclient5 ls settings:/
system-administration

dolphin settings:/
System Administration

In dolphin, you can click on "System Administration". With kioclient5, I can use kioclient5 ls settings:/system-administration (dito for dolphin). Does this still work after your change?

Aug 23 2018, 9:41 PM · Frameworks, Plasma
smithjd added a comment to D13291: [kioclient] Use UDS_DISPLAY_NAME for file names..

kioclient5 ls settings:/
system-administration

Aug 23 2018, 6:55 PM · Frameworks, Plasma
smithjd updated the summary of D13291: [kioclient] Use UDS_DISPLAY_NAME for file names..
Aug 23 2018, 2:10 AM · Frameworks, Plasma
smithjd committed R293:4fb236441c77: Remove src not dest url when a url is newly unindexable. (authored by smithjd).
Remove src not dest url when a url is newly unindexable.
Aug 23 2018, 12:28 AM
smithjd committed R293:13965c81bdb8: [tags_kio] Simplify the filename path query matching by using a capture group. (authored by smithjd).
[tags_kio] Simplify the filename path query matching by using a capture group.
Aug 23 2018, 12:28 AM
smithjd committed R293:ce26715cf4af: Revert "Skip queueing newly unindexable files and remove them from the index… (authored by smithjd).
Revert "Skip queueing newly unindexable files and remove them from the index…
Aug 23 2018, 12:28 AM
smithjd added a reverting change for R293:1129a0e03220: Skip queueing newly unindexable files and remove them from the index…: R293:ce26715cf4af: Revert "Skip queueing newly unindexable files and remove them from the index….
Aug 23 2018, 12:28 AM

Aug 15 2018

smithjd added a comment to D14739: [KRunner] Allow modifying the keyboard shortcuts..

Perhaps the intent of this patch could change to adding a KShortcutsDialog to the kcm where the MOVETOSTARTOFLINE and MOVETOENDOFLINE keyboard shortcuts could be reassigned?

Aug 15 2018, 7:58 PM · Plasma
smithjd triaged T8505: [kio_tags] Improve tagged folder support as Normal priority.
Aug 15 2018, 3:54 AM · Baloo
smithjd renamed T9349: [kio_tags] Fix file previews and mimetype lookup for multiple files of the same file name from [kio_tags] Fix file previews / metadata lookup for multiples of the same file name to [kio_tags] Fix file previews and mimetype lookup for multiple files of the same file name.
Aug 15 2018, 3:53 AM · Baloo

Aug 12 2018

smithjd committed R293:8779f5b2a657: [tags_kio] Simplify file path lookup while loop. (authored by smithjd).
[tags_kio] Simplify file path lookup while loop.
Aug 12 2018, 1:53 AM
smithjd created T9349: [kio_tags] Fix file previews and mimetype lookup for multiple files of the same file name.
Aug 12 2018, 1:41 AM · Baloo
smithjd added a comment to T8505: [kio_tags] Improve tagged folder support .

What works: Everything, after first entering or operating on the folder tagged directly in the IO slave. (Copy to filesystem, etc.)

Aug 12 2018, 1:23 AM · Baloo
smithjd renamed T8505: [kio_tags] Improve tagged folder support from Repair tags:/ protocol to [kio_tags] Improve tagged folder support .
Aug 12 2018, 1:13 AM · Baloo

Aug 11 2018

smithjd added a comment to D14739: [KRunner] Allow modifying the keyboard shortcuts..

We also have

system settings -> shortcuts -> standard shortcuts

These can have alternatives which would work for this. I don't know if these work with QQC2 TextFields, we should fix it if not.

Setting alternatives would require unsetting 2 existing default application shortcuts, leaving CTRL-S and CTRL-E unavailable for default actions for other applications. Setting alternatives works for textFields.

Thanks for kconfig magic you can override them (without a gui) on a per-app basis albeit there's no UI for that.

I can't seem to find any information on this.

Aug 11 2018, 9:30 PM · Plasma
smithjd added a comment to D14739: [KRunner] Allow modifying the keyboard shortcuts..

Most of the keys on that side of the keyboard are already bound globally into combos, so the best solution IMO is to intercept the required keycombos in KRunner instead of having to rearrange the global app keycombos around KRunner. This is what this patch does to implement bash-style cursor jumps in KRunner, though this is not so great on the HIG front as the intercepted combos are both standard application shortcuts, also duplicating the standard application shortcuts for beginning of line / end of line.

Aug 11 2018, 7:36 PM · Plasma
smithjd added a comment to D14739: [KRunner] Allow modifying the keyboard shortcuts..

Yes, except the CTRL + S combo is default for save in other applications, with no easy way I can think of to reassign it for just KRunner.

Aug 11 2018, 6:43 PM · Plasma
smithjd added a comment to D14739: [KRunner] Allow modifying the keyboard shortcuts..

I now see that KDE has default application shortcuts for beginning of line and end of line (HOME and END) and skip word forwards or backwards (CTRL + RARROW/LARROW), that also work in KRunner, that should obsolete this patch.

Aug 11 2018, 6:37 PM · Plasma
smithjd added a comment to D14739: [KRunner] Allow modifying the keyboard shortcuts..

I tend to frequenty hit additional keys while not watching the runner window. Although the shortcut is no longer in common with Bash (the CTRL + S shortcut would also have made more sense for Bash) the idea is the same. You can already do this from the keyboard, but it requires a select all keycombo AND an arrow key each time you need to jump forward or backwards.

Aug 11 2018, 6:27 PM · Plasma
smithjd updated the summary of D14739: [KRunner] Allow modifying the keyboard shortcuts..
Aug 11 2018, 5:47 PM · Plasma
smithjd updated the test plan for D14739: [KRunner] Allow modifying the keyboard shortcuts..
Aug 11 2018, 5:47 PM · Plasma
smithjd updated the test plan for D14739: [KRunner] Allow modifying the keyboard shortcuts..
Aug 11 2018, 5:45 PM · Plasma
smithjd updated the diff for D14739: [KRunner] Allow modifying the keyboard shortcuts..
  • [KRunner] Change start of line shortcut to CTRL + S.
Aug 11 2018, 5:45 PM · Plasma
smithjd requested review of D14739: [KRunner] Allow modifying the keyboard shortcuts..
Aug 11 2018, 5:41 AM · Plasma

Jul 30 2018

smithjd committed R293:b8bd7191f1bc: [tags_kio] Clean up parser debug and comments. (authored by smithjd).
[tags_kio] Clean up parser debug and comments.
Jul 30 2018, 1:34 AM

Jul 29 2018

smithjd committed R293:8895f6d6907e: [tags_kio] Fix multiple filename copies. (authored by smithjd).
[tags_kio] Fix multiple filename copies.
Jul 29 2018, 6:26 PM

Jul 26 2018

smithjd committed R293:69437f0329e0: [tags_kio] Use UDS_URL instead of UDS_TARGET_URL. (authored by smithjd).
[tags_kio] Use UDS_URL instead of UDS_TARGET_URL.
Jul 26 2018, 2:37 AM
smithjd added a reverting change for R293:69437f0329e0: [tags_kio] Use UDS_URL instead of UDS_TARGET_URL.: R293:aebc0f6f502d: Revert "[tags_kio] Use UDS_URL instead of UDS_TARGET_URL.".
Jul 26 2018, 2:37 AM
smithjd committed R293:aebc0f6f502d: Revert "[tags_kio] Use UDS_URL instead of UDS_TARGET_URL." (authored by smithjd).
Revert "[tags_kio] Use UDS_URL instead of UDS_TARGET_URL."
Jul 26 2018, 2:37 AM
smithjd committed R293:f069f89d0c4b: [tags_kio] Query target filepaths instead of appending paths to the file UDS… (authored by smithjd).
[tags_kio] Query target filepaths instead of appending paths to the file UDS…
Jul 26 2018, 2:37 AM

Jul 19 2018

smithjd edited reviewers for D13291: [kioclient] Use UDS_DISPLAY_NAME for file names., added: Plasma; removed: kossebau.
Jul 19 2018, 9:46 PM · Frameworks, Plasma
smithjd updated subscribers of D13291: [kioclient] Use UDS_DISPLAY_NAME for file names..
Jul 19 2018, 9:45 PM · Frameworks, Plasma
smithjd committed R154:9e24e26c54eb: Work around enum constant in boolean context compiler warning. (authored by smithjd).
Work around enum constant in boolean context compiler warning.
Jul 19 2018, 3:39 AM
smithjd committed R154:520ae3eec04d: QStyleOptionViewItemV4 is deprecated, port away. (authored by smithjd).
QStyleOptionViewItemV4 is deprecated, port away.
Jul 19 2018, 12:30 AM

Jul 18 2018

smithjd committed R141:858eccffb577: Unused variable. (authored by smithjd).
Unused variable.
Jul 18 2018, 11:39 PM
smithjd committed R141:0ca72299ac0b: Compare value. (authored by smithjd).
Compare value.
Jul 18 2018, 11:39 PM
smithjd committed R141:ded765b3cbe1: Overrides. (authored by smithjd).
Overrides.
Jul 18 2018, 10:54 PM

Jun 29 2018

smithjd committed R344:8b9b0d553f80: Inhibit power management when playing audio. (authored by smithjd).
Inhibit power management when playing audio.
Jun 29 2018, 5:41 AM
smithjd closed D9748: Give Juk a playback power inhibitor..
Jun 29 2018, 4:45 AM

Jun 26 2018

smithjd retitled D13425: File indexer closing improvements. from file indexer closing inprovements. to File indexer closing improvements..
Jun 26 2018, 5:29 PM · Baloo, Frameworks
smithjd updated the diff for D13424: Run a file changed check when the file watches are updated..

Change commit description.

Jun 26 2018, 5:28 PM · Baloo, Frameworks
smithjd updated the diff for D13425: File indexer closing improvements..

Change git commit description.

Jun 26 2018, 5:26 PM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..

re-word commits.

Jun 26 2018, 5:19 PM · Baloo, Frameworks
smithjd committed R146:c24ec37033f0: KMainWindow::helpMenu() is deprecated, port away. (authored by smithjd).
KMainWindow::helpMenu() is deprecated, port away.
Jun 26 2018, 12:56 AM
smithjd committed R146:9d6e9f019340: No default value in switch. (authored by smithjd).
No default value in switch.
Jun 26 2018, 12:56 AM
smithjd committed R146:699215b40699: KLineEdit::setClearButtonShown() is deprecated, port away. (authored by smithjd).
KLineEdit::setClearButtonShown() is deprecated, port away.
Jun 26 2018, 12:56 AM
smithjd committed R146:05c6b6ee802c: QStyleOptionViewItemV4 is deprecated, port away. (authored by smithjd).
QStyleOptionViewItemV4 is deprecated, port away.
Jun 26 2018, 12:56 AM
smithjd committed R146:c398f477fe0a: KToolInvocation::invokeBrowser() is deprecated, port away. (authored by smithjd).
KToolInvocation::invokeBrowser() is deprecated, port away.
Jun 26 2018, 12:56 AM

Jun 25 2018

smithjd committed R145:e66f581995e8: Provide a default to fix a fall through statement in FavoriteRoomsModel. (authored by smithjd).
Provide a default to fix a fall through statement in FavoriteRoomsModel.
Jun 25 2018, 10:51 PM
smithjd committed R145:29765f2f2a0b: Fix a fall through statement in FavoriteRoomsModel. (authored by smithjd).
Fix a fall through statement in FavoriteRoomsModel.
Jun 25 2018, 10:51 PM
smithjd committed R145:e54591fa9e06: KCoreConfigSkeleton::readConfig () is deprecated, port away. (authored by smithjd).
KCoreConfigSkeleton::readConfig () is deprecated, port away.
Jun 25 2018, 10:51 PM
smithjd committed R145:697977237ae6: KCoreConfigSkeleton::writeConfig () is deprecated, port away. (authored by smithjd).
KCoreConfigSkeleton::writeConfig () is deprecated, port away.
Jun 25 2018, 10:51 PM
smithjd committed R145:9456016f18ea: QStyleOptionViewItemV4 is deprecated, port away. (authored by smithjd).
QStyleOptionViewItemV4 is deprecated, port away.
Jun 25 2018, 10:51 PM

Jun 24 2018

smithjd updated the summary of D9748: Give Juk a playback power inhibitor..
Jun 24 2018, 12:19 AM
smithjd updated the diff for D9748: Give Juk a playback power inhibitor..

Switch to using a plain DBus inhibitor.

Jun 24 2018, 12:19 AM

Jun 21 2018

smithjd updated the diff for D11529: Balooctl: Deindex unfound files with check command..

Rebase

Jun 21 2018, 1:20 AM · Baloo, Frameworks
smithjd edited dependencies for D11529: Balooctl: Deindex unfound files with check command., added: 1; removed: 1.
Jun 21 2018, 1:20 AM · Baloo, Frameworks
smithjd removed a dependent revision for D13216: Overhaul the file index scheduler.: D11529: Balooctl: Deindex unfound files with check command..
Jun 21 2018, 1:20 AM · Baloo, Frameworks
smithjd added a dependent revision for D13424: Run a file changed check when the file watches are updated.: D11529: Balooctl: Deindex unfound files with check command..
Jun 21 2018, 1:20 AM · Baloo, Frameworks
smithjd updated the diff for D13424: Run a file changed check when the file watches are updated..
  • Remove a fixme.
Jun 21 2018, 1:08 AM · Baloo, Frameworks
smithjd edited dependencies for D13424: Run a file changed check when the file watches are updated., added: 1; removed: 1.
Jun 21 2018, 1:06 AM · Baloo, Frameworks
smithjd removed a dependent revision for D13216: Overhaul the file index scheduler.: D13424: Run a file changed check when the file watches are updated..
Jun 21 2018, 1:06 AM · Baloo, Frameworks
smithjd added a dependent revision for D13425: File indexer closing improvements.: D13424: Run a file changed check when the file watches are updated..
Jun 21 2018, 1:06 AM · Baloo, Frameworks
smithjd removed a dependent revision for D13424: Run a file changed check when the file watches are updated.: D13425: File indexer closing improvements..
Jun 21 2018, 1:05 AM · Baloo, Frameworks
smithjd removed a dependency for D13425: File indexer closing improvements.: D13424: Run a file changed check when the file watches are updated..
Jun 21 2018, 1:05 AM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..
  • Re-write the the file index scheduler.
  • Update the balooctl tool with the changed suspend/resume behaviour.
Jun 21 2018, 1:05 AM · Baloo, Frameworks
smithjd updated the diff for D13425: File indexer closing improvements..

Consolidate file indexer close changes into a single review.

Jun 21 2018, 1:03 AM · Baloo, Frameworks
smithjd updated the summary of D13425: File indexer closing improvements..
Jun 21 2018, 1:02 AM · Baloo, Frameworks
smithjd retitled D13424: Run a file changed check when the file watches are updated. from On config change halt the file indexer and run a file changed check when the file watches are updated. to Run a file changed check when the file watches are updated..
Jun 21 2018, 1:00 AM · Baloo, Frameworks
smithjd updated the diff for D13424: Run a file changed check when the file watches are updated..

Run a full check for unindexed files when the watches are installed.

Jun 21 2018, 1:00 AM · Baloo, Frameworks

Jun 11 2018

smithjd updated the test plan for D13291: [kioclient] Use UDS_DISPLAY_NAME for file names..
Jun 11 2018, 1:23 AM · Frameworks, Plasma
smithjd committed R293:de960247db8c: [tags_kio] The url query should be a key-value pair. (authored by smithjd).
[tags_kio] The url query should be a key-value pair.
Jun 11 2018, 12:51 AM

Jun 7 2018

smithjd added a dependent revision for D13424: Run a file changed check when the file watches are updated.: D13425: File indexer closing improvements..
Jun 7 2018, 11:58 PM · Baloo, Frameworks
smithjd added a dependency for D13425: File indexer closing improvements.: D13424: Run a file changed check when the file watches are updated..
Jun 7 2018, 11:58 PM · Baloo, Frameworks
smithjd added a dependency for D13425: File indexer closing improvements.: D13216: Overhaul the file index scheduler..
Jun 7 2018, 11:56 PM · Baloo, Frameworks
smithjd added a dependent revision for D13216: Overhaul the file index scheduler.: D13425: File indexer closing improvements..
Jun 7 2018, 11:56 PM · Baloo, Frameworks
smithjd requested review of D13425: File indexer closing improvements..
Jun 7 2018, 11:54 PM · Baloo, Frameworks
smithjd committed R293:794ee9256584: The power state signal should only be emitted when the power state changes. (authored by smithjd).
The power state signal should only be emitted when the power state changes.
Jun 7 2018, 11:47 PM
smithjd updated the diff for D13424: Run a file changed check when the file watches are updated..

Separate out the content indexer halt on quit.

Jun 7 2018, 11:46 PM · Baloo, Frameworks
smithjd retitled D13424: Run a file changed check when the file watches are updated. from On config change, halt the file indexer and run a file changed check when the file watches are updated. to On config change halt the file indexer and run a file changed check when the file watches are updated..
Jun 7 2018, 11:39 PM · Baloo, Frameworks
smithjd updated the summary of D13216: Overhaul the file index scheduler..
Jun 7 2018, 11:37 PM · Baloo, Frameworks
smithjd updated the summary of D13216: Overhaul the file index scheduler..
Jun 7 2018, 11:18 PM · Baloo, Frameworks
smithjd added reviewers for D13424: Run a file changed check when the file watches are updated.: mgallien, bruns.
Jun 7 2018, 11:11 PM · Baloo, Frameworks
smithjd added a dependency for D13424: Run a file changed check when the file watches are updated.: D13216: Overhaul the file index scheduler..
Jun 7 2018, 11:07 PM · Baloo, Frameworks
smithjd added a dependent revision for D13216: Overhaul the file index scheduler.: D13424: Run a file changed check when the file watches are updated..
Jun 7 2018, 11:07 PM · Baloo, Frameworks
smithjd requested review of D13424: Run a file changed check when the file watches are updated..
Jun 7 2018, 11:01 PM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..
  • Re-write the the file index scheduler.
  • Update the balooctl tool with the changed suspend/resume behaviour.
Jun 7 2018, 10:57 PM · Baloo, Frameworks
smithjd added a comment to D13216: Overhaul the file index scheduler..

According to the arc documentation, a --merge commit should land the commits separately.

Still, I can not see the individual commits.

Jun 7 2018, 9:00 PM · Baloo, Frameworks
smithjd added a comment to D13216: Overhaul the file index scheduler..

According to the arc documentation, a --merge commit should land the commits separately.

Jun 7 2018, 8:44 PM · Baloo, Frameworks
smithjd added a comment to D13216: Overhaul the file index scheduler..

@smithjd You have probaly become another victim of phabricator/arc. Your commits have been squashed by arc ...
If you wan't your commits to stay separated, you have to do a git checkout of the first commit, do a arc diff HEAD^1, checkout the next commit, arc diff HEAD^1, and so on.

Jun 7 2018, 8:02 PM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..

Split-up scheduler overhaul patchset.

Jun 7 2018, 12:27 AM · Baloo, Frameworks

Jun 4 2018

smithjd added a reviewer for D13216: Overhaul the file index scheduler.: mgallien.
Jun 4 2018, 3:52 PM · Baloo, Frameworks
smithjd added a reviewer for D13216: Overhaul the file index scheduler.: bruns.
Jun 4 2018, 3:50 PM · Baloo, Frameworks