In D15047#314477, @bruns wrote:There is no need for this, just create a new StorageDevices where you need it.
Creating a second StorageDevices instance in a process is quite cheap.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Aug 24 2018
Aug 24 2018
smithjd edited dependencies for D11529: Balooctl: Deindex unfound files with check command., added: 2; removed: 1.
smithjd added a dependent revision for D13216: Overhaul the file index scheduler.: D11529: Balooctl: Deindex unfound files with check command..
smithjd added a dependent revision for D15047: Export the StorageDevices object.: D11529: Balooctl: Deindex unfound files with check command..
smithjd removed a dependent revision for D13424: Run a file changed check when the file watches are updated.: D11529: Balooctl: Deindex unfound files with check command..
This was included in https://phabricator.kde.org/D11529 and is now broken out.
Aug 23 2018
Aug 23 2018
In D13291#314199, @bruns wrote:In D13291#314195, @smithjd wrote:kioclient5 ls settings:/
system-administrationdolphin settings:/
System AdministrationIn dolphin, you can click on "System Administration". With kioclient5, I can use kioclient5 ls settings:/system-administration (dito for dolphin). Does this still work after your change?
kioclient5 ls settings:/
system-administration
smithjd committed R293:4fb236441c77: Remove src not dest url when a url is newly unindexable. (authored by smithjd).
Remove src not dest url when a url is newly unindexable.
smithjd committed R293:13965c81bdb8: [tags_kio] Simplify the filename path query matching by using a capture group. (authored by smithjd).
[tags_kio] Simplify the filename path query matching by using a capture group.
smithjd committed R293:ce26715cf4af: Revert "Skip queueing newly unindexable files and remove them from the index… (authored by smithjd).
Revert "Skip queueing newly unindexable files and remove them from the index…
Aug 15 2018
Aug 15 2018
Perhaps the intent of this patch could change to adding a KShortcutsDialog to the kcm where the MOVETOSTARTOFLINE and MOVETOENDOFLINE keyboard shortcuts could be reassigned?
smithjd renamed T9349: [kio_tags] Fix file previews and mimetype lookup for multiple files of the same file name from [kio_tags] Fix file previews / metadata lookup for multiples of the same file name to [kio_tags] Fix file previews and mimetype lookup for multiple files of the same file name.
Aug 12 2018
Aug 12 2018
smithjd committed R293:8779f5b2a657: [tags_kio] Simplify file path lookup while loop. (authored by smithjd).
[tags_kio] Simplify file path lookup while loop.
What works: Everything, after first entering or operating on the folder tagged directly in the IO slave. (Copy to filesystem, etc.)
smithjd renamed T8505: [kio_tags] Improve tagged folder support from Repair tags:/ protocol to [kio_tags] Improve tagged folder support .
Aug 11 2018
Aug 11 2018
In D14739#306749, @davidedmundson wrote:We also have
system settings -> shortcuts -> standard shortcuts
These can have alternatives which would work for this. I don't know if these work with QQC2 TextFields, we should fix it if not.
Setting alternatives would require unsetting 2 existing default application shortcuts, leaving CTRL-S and CTRL-E unavailable for default actions for other applications. Setting alternatives works for textFields.
Thanks for kconfig magic you can override them (without a gui) on a per-app basis albeit there's no UI for that.
I can't seem to find any information on this.
Most of the keys on that side of the keyboard are already bound globally into combos, so the best solution IMO is to intercept the required keycombos in KRunner instead of having to rearrange the global app keycombos around KRunner. This is what this patch does to implement bash-style cursor jumps in KRunner, though this is not so great on the HIG front as the intercepted combos are both standard application shortcuts, also duplicating the standard application shortcuts for beginning of line / end of line.
Yes, except the CTRL + S combo is default for save in other applications, with no easy way I can think of to reassign it for just KRunner.
I now see that KDE has default application shortcuts for beginning of line and end of line (HOME and END) and skip word forwards or backwards (CTRL + RARROW/LARROW), that also work in KRunner, that should obsolete this patch.
I tend to frequenty hit additional keys while not watching the runner window. Although the shortcut is no longer in common with Bash (the CTRL + S shortcut would also have made more sense for Bash) the idea is the same. You can already do this from the keyboard, but it requires a select all keycombo AND an arrow key each time you need to jump forward or backwards.
- [KRunner] Change start of line shortcut to CTRL + S.
Jul 30 2018
Jul 30 2018
smithjd committed R293:b8bd7191f1bc: [tags_kio] Clean up parser debug and comments. (authored by smithjd).
[tags_kio] Clean up parser debug and comments.
Jul 29 2018
Jul 29 2018
smithjd committed R293:8895f6d6907e: [tags_kio] Fix multiple filename copies. (authored by smithjd).
[tags_kio] Fix multiple filename copies.
Jul 26 2018
Jul 26 2018
smithjd committed R293:69437f0329e0: [tags_kio] Use UDS_URL instead of UDS_TARGET_URL. (authored by smithjd).
[tags_kio] Use UDS_URL instead of UDS_TARGET_URL.
smithjd committed R293:aebc0f6f502d: Revert "[tags_kio] Use UDS_URL instead of UDS_TARGET_URL." (authored by smithjd).
Revert "[tags_kio] Use UDS_URL instead of UDS_TARGET_URL."
smithjd committed R293:f069f89d0c4b: [tags_kio] Query target filepaths instead of appending paths to the file UDS… (authored by smithjd).
[tags_kio] Query target filepaths instead of appending paths to the file UDS…
Jul 19 2018
Jul 19 2018
smithjd edited reviewers for D13291: [kioclient] Use UDS_DISPLAY_NAME for file names., added: Plasma; removed: kossebau.
smithjd committed R154:9e24e26c54eb: Work around enum constant in boolean context compiler warning. (authored by smithjd).
Work around enum constant in boolean context compiler warning.
smithjd committed R154:520ae3eec04d: QStyleOptionViewItemV4 is deprecated, port away. (authored by smithjd).
QStyleOptionViewItemV4 is deprecated, port away.
Jul 18 2018
Jul 18 2018
Unused variable.
Compare value.
Overrides.
Jun 29 2018
Jun 29 2018
smithjd committed R344:8b9b0d553f80: Inhibit power management when playing audio. (authored by smithjd).
Inhibit power management when playing audio.
Jun 26 2018
Jun 26 2018
smithjd retitled D13425: File indexer closing improvements. from file indexer closing inprovements. to File indexer closing improvements..
Change commit description.
Change git commit description.
re-word commits.
smithjd committed R146:c24ec37033f0: KMainWindow::helpMenu() is deprecated, port away. (authored by smithjd).
KMainWindow::helpMenu() is deprecated, port away.
No default value in switch.
smithjd committed R146:699215b40699: KLineEdit::setClearButtonShown() is deprecated, port away. (authored by smithjd).
KLineEdit::setClearButtonShown() is deprecated, port away.
smithjd committed R146:05c6b6ee802c: QStyleOptionViewItemV4 is deprecated, port away. (authored by smithjd).
QStyleOptionViewItemV4 is deprecated, port away.
smithjd committed R146:c398f477fe0a: KToolInvocation::invokeBrowser() is deprecated, port away. (authored by smithjd).
KToolInvocation::invokeBrowser() is deprecated, port away.
Jun 25 2018
Jun 25 2018
smithjd committed R145:e66f581995e8: Provide a default to fix a fall through statement in FavoriteRoomsModel. (authored by smithjd).
Provide a default to fix a fall through statement in FavoriteRoomsModel.
smithjd committed R145:29765f2f2a0b: Fix a fall through statement in FavoriteRoomsModel. (authored by smithjd).
Fix a fall through statement in FavoriteRoomsModel.
smithjd committed R145:e54591fa9e06: KCoreConfigSkeleton::readConfig () is deprecated, port away. (authored by smithjd).
KCoreConfigSkeleton::readConfig () is deprecated, port away.
smithjd committed R145:697977237ae6: KCoreConfigSkeleton::writeConfig () is deprecated, port away. (authored by smithjd).
KCoreConfigSkeleton::writeConfig () is deprecated, port away.
smithjd committed R145:9456016f18ea: QStyleOptionViewItemV4 is deprecated, port away. (authored by smithjd).
QStyleOptionViewItemV4 is deprecated, port away.
Jun 24 2018
Jun 24 2018
Switch to using a plain DBus inhibitor.
Jun 21 2018
Jun 21 2018
Rebase
smithjd edited dependencies for D11529: Balooctl: Deindex unfound files with check command., added: 1; removed: 1.
smithjd removed a dependent revision for D13216: Overhaul the file index scheduler.: D11529: Balooctl: Deindex unfound files with check command..
smithjd added a dependent revision for D13424: Run a file changed check when the file watches are updated.: D11529: Balooctl: Deindex unfound files with check command..
- Remove a fixme.
smithjd edited dependencies for D13424: Run a file changed check when the file watches are updated., added: 1; removed: 1.
smithjd removed a dependent revision for D13216: Overhaul the file index scheduler.: D13424: Run a file changed check when the file watches are updated..
smithjd added a dependent revision for D13425: File indexer closing improvements.: D13424: Run a file changed check when the file watches are updated..
smithjd removed a dependent revision for D13424: Run a file changed check when the file watches are updated.: D13425: File indexer closing improvements..
smithjd removed a dependency for D13425: File indexer closing improvements.: D13424: Run a file changed check when the file watches are updated..
- Re-write the the file index scheduler.
- Update the balooctl tool with the changed suspend/resume behaviour.
Consolidate file indexer close changes into a single review.
smithjd retitled D13424: Run a file changed check when the file watches are updated. from On config change halt the file indexer and run a file changed check when the file watches are updated. to Run a file changed check when the file watches are updated..
Run a full check for unindexed files when the watches are installed.
Jun 11 2018
Jun 11 2018
smithjd committed R293:de960247db8c: [tags_kio] The url query should be a key-value pair. (authored by smithjd).
[tags_kio] The url query should be a key-value pair.
Jun 7 2018
Jun 7 2018
smithjd added a dependent revision for D13424: Run a file changed check when the file watches are updated.: D13425: File indexer closing improvements..
smithjd added a dependency for D13425: File indexer closing improvements.: D13216: Overhaul the file index scheduler..
smithjd added a dependent revision for D13216: Overhaul the file index scheduler.: D13425: File indexer closing improvements..
smithjd committed R293:794ee9256584: The power state signal should only be emitted when the power state changes. (authored by smithjd).
The power state signal should only be emitted when the power state changes.
Separate out the content indexer halt on quit.
smithjd retitled D13424: Run a file changed check when the file watches are updated. from On config change, halt the file indexer and run a file changed check when the file watches are updated. to On config change halt the file indexer and run a file changed check when the file watches are updated..
smithjd added reviewers for D13424: Run a file changed check when the file watches are updated.: mgallien, bruns.
smithjd added a dependent revision for D13216: Overhaul the file index scheduler.: D13424: Run a file changed check when the file watches are updated..
- Re-write the the file index scheduler.
- Update the balooctl tool with the changed suspend/resume behaviour.
In D13216#275582, @bruns wrote:In D13216#275581, @smithjd wrote:According to the arc documentation, a --merge commit should land the commits separately.
Still, I can not see the individual commits.
According to the arc documentation, a --merge commit should land the commits separately.
In D13216#275538, @bruns wrote:@smithjd You have probaly become another victim of phabricator/arc. Your commits have been squashed by arc ...
If you wan't your commits to stay separated, you have to do a git checkout of the first commit, do a arc diff HEAD^1, checkout the next commit, arc diff HEAD^1, and so on.
Split-up scheduler overhaul patchset.
Jun 4 2018
Jun 4 2018