In D8831#168209, @kfunk wrote:

Thanks a lot for these patches!

So the actual error is: gcc.exe: error: \\.\NUL: Invalid argument

In D8831#168189, @brauch wrote:

I understand what the patch does, but can you explain why this fixes your issue?

• remove unnecessary ifdef block

Commit: https://phabricator.kde.org/R32:86bbc9ffe63b

In D8523#161270, @kfunk wrote:

@geetamc Note: Please fixup your user name to in Git (git config user.name).

I needed to amend your patch in order to fix this issue:

remote: Audit failure - Commit 55f2f00c8376837c9084b36413ae45b3f5652569 - Non-full name: Geetam
remote: FATAL: VREF/kde-update-checks: helper program exit status 256
remote: Push declined - commits failed audit

Thanks for the patch!

• fixed weird indentation

In D6689#125180, @kfunk wrote:

Thanks for the patches, Geetam.

I encourage you to start using Arcanist to upload the patches as that will a) make reviewing the patches easier (because there's "context" in the diff view), b) add proper author information to the Phab Diff.

Please see: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

In D5777#109999, @apol wrote:

I don't really understand the patch, there's the bit there so that if (cmd.isEmpty) kdesu -t. What are you trying to fix?

used KShell:splitArgs to split su command.

@apol Thanks, I will surely.
But I will update the revision right now without the change as I accidentally created the diff against an older base.

Ignore the previous update, I am making a new review request.

-Added a default value for entry "suCommand" in makebuilderconfig.kcfg
-The qstring suCommand is checked for emptiness instead of qstringlist "suCommandWithArg".
(Reason: when an empty qstring is split, the returned qstringlist.isEmpty() is False)

Added a comment explaining the need of "if(suCommandIsDigit)" block.

In D5122#107479, @zhigalin wrote:

Hello and thanks for your effort.
Just a few considerations:

• When you edit an UI file, make sure not to forget to increase it's version
• You also forgot to bind kcfg_suCommand.enabled(bool) to kcfg_installAsRoot.toggled(bool)
• You must use QStringLiteral, not just plain strings
• Try placing less newlines around

In D5719#107141, @brauch wrote:

Yes, makes sense. Do you have commit access?

In D5122#99210, @ltoscano wrote:

Few suggestions related to the commit message: it should follow the guidelines for git message.
So the first line should be a short summary of the change (no need to mention the bug), "allow users to install via custom command" or something like that.

The bug should report in one of the other line not as link but with

BUG: nnnnnn

If entry "Su Command" is an integer in range [0, 3) (which can be a scenario when user, for the first time opens his/her project in the updated kdevelop)
then suCommand is set appropriately and is written to entry "Su Command" .

Alright so I feel, regarding my last comment, Having an extra variable suCommandStr and an extra readEntry() is unnecessary, In the switch block I will simply assign suCommand the appropriate value, and write suCommand to the "Su Command" Entry.
Also I feel updating the diff will give you guys a better Idea so I will do the same in a while.

@ematirov Thank you for reviewing! Have a look at the inline comment.

arguments such as "-t" now pass correctly.

I believe that having combo box editable is a cleaner way to solve the same problem, I will revert the changes if reviewers feel that having a plain text edit and an entry for Custom Command in combo box is more appropriate.

I forgot to implement a feature mentioned by brauch, will do it tomorrow.

Since I am new to submitting patches would you please tell me when updating diff should I upload the diff representing the latest changes or one that represents the whole patch?

The build was successful, the patch now works as intended please let me know if I missed something.

In D5122#96551, @kfunk wrote:

In D5122#96545, @geetamc wrote:

My build fails right now after a git pull

kdevelop/languages/clang/duchain/macronavigationcontext.cpp:58:28: error: ‘prefix’ was not declared in this scope

You need to git pull in kdevplatform and recompile/reinstall.

I have made most of the changes also I have an exam tomorrow so I will definitely update the diff by tomorrow.

Thank you both brauch and kfunk for reviewing.

-Corrected the casing of "Custom Command"
-Appended ':' to the label
-Label and text edit of Custom Command are now disabled by default
-removed unnecessary 'else'

My build fails right now after a git pull

In D5122#96534, @brauch wrote:

Can you make the line edit disabled when something else than "custom command" is selected?
Otherwise, LGTM, thanks for the patch!