Hmm, we already had a patch to do this: D16648: Open externally called files/directories in new tabs.

Sorry, we had discussed this with @zzag in the VDG room and I (perhaps erroneously?) left with the impression that this was set at its previous value to preserve a certain look-and-feel, and was therefore something we could change since we were adjusting that look-and-feel elsewhere. I did test it and didn't notice any visual regressions.

OK cool, let's give that a try. I think it could work nicely.

So like this?

Works for me. Probably a candidate for the Plasma/5.15 branch. @hein?

Sweet, will add the dep in another patch.

+1; Colors is the only KCM where we ship random stuff like this.

I kind of agree. I like the new size for Medium, and I think the default should maybe be a bit smaller (halfway between the current medium and the current large) but I also don't see the great value in adding more sizes. I think we can probably accomplish the visual goals we have in mind by tweaking the existing sizes to be less power-of-two-ey.

Calling this done as the current version uses modern APIs and more-or-less matches the mockups.

@GB_2 is porting this to use the new visual style.

Are the Summary section and title accurate?

In D19011#415228, @dvratil wrote:

Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for Thunderbolt? @abetts, maybe?

+1, I find these really annoying and want to turn them off.

Makes sense to do this while we're tweaking the appearance of the shadows for 5.16 anyway.

Rebase on current master

Every patch with UI changes needs screenshots in the Summary section--preferably before-and-after. :)

I love it. Looks perfect to me now.

I love it. Looks perfect to me now.

Looks good to me now!

Nah, I think that would begin to re-introduce the bug we're trying to solve (shadows not being visible in Breeze Dark).

Ah yes, gotta make the same change in kstyle/breeze.kcfg too. @ndavis can you do that?

Fantastic! Looks great, works great.

Or they could all be a bit bigger, and the snowflake versions could simply take up a teensy bit more of the snowflake's top-right corner.

Works perfectly now for both mice and touchpads. This gets a "ship it!" from me!

I changed this from black to Shade Black as a compromise to get https://cgit.kde.org/breeze.git/commit/?id=9fb5d3abb18cde0ef63102cb06f1a936152ccaef done and I think we have to consider the experiment a failure. It results in various visual regressions and black is a better default.

Just for the smaller versions.

That could work, yeah. Give it a try!

One final request: add an 18px tall spacer between the checkboxes and the comboboxes, like how Dolphin does it: https://cgit.kde.org/dolphin.git/tree/src/settings/general/behaviorsettingspage.cpp#n61

The Zs look a bit small in Kickoff and especially Kicker when using a non-high-DPI display:

Getting there! I'm not sure the shadow on the top handle works though.

Actually those concerns should be in the icon theme patch, never mind.

Oh and one more minor thing: the Zs look a bit small in Kickoff and especially Kicker when using a non-high-DPI display:

Almost perfect! I have one remaining visual nitpick:

Very nice! This fixes the bug and the code change looks sane. @hein are you good with this?

Clever! Works great.

In D18986#414641, @rooty wrote:

This is a rough draft of what a side view 64 px version would look like with a microphone on top (I can't stand film reels in icons, sorry...)

I will admit that the current head-on view is more attractive than the previous side view version. :) But I still worry about recognizability. Here's what the icon will look like in Kamoso, for example:

+1 shipit!

Very nice feature! It works well in my testing. Code looks good too. I have only UI suggestions: in addition to the inline comments, I think the layout on the settings page needs work. Let's not abandon the FormLayout style here. I think your addition of a title on the page is good, but then let's keep the FormLayout style for the checkboxes and just change their left label to be "General".

Just noticed this: should similar support be added into gvpart.desktop too?

Very much against adding a scrollbar into the preview area. I think we can come up with a better solution.

In D18986#414556, @rooty wrote:

I don't know... I've been mulling this over for the last couple of days and... I'm not sold on the side view, because any variant of a side view will look broadly different from the other camera icons we already have

Thanks @rempt! Would you like me to land this, or are you going to take care of it since you're more familiar with the branches?

If accepted, it would be nice if this could get into the bugfix branch so that it can land in advance of the Gwenview patch, which is slated to go into KDE Applications 19.04.0. That way hopefully there will never be a situation where Gwenview temporarily becomes the default handler for .kra files.