Feed Advanced Search

Sep 15 2019

nazark updated the diff for D23706: Fix wrong window titles.
Sep 15 2019, 3:55 PM · Dolphin

Sep 14 2019

nazark updated the diff for D23706: Fix wrong window titles.
Sep 14 2019, 5:47 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

What about something like this?

Sep 14 2019, 5:43 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

Oh, and you are right again.
The previous solution seems to fix it without a regression, but obviously the code itself feels at the very least "not good".

Sep 14 2019, 5:24 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

Updated!
I didn't think about this solution, thanks, clearly it's way better than mine.

Sep 14 2019, 4:48 PM · Dolphin
nazark updated the diff for D23706: Fix wrong window titles.
Sep 14 2019, 4:46 PM · Dolphin

Sep 10 2019

nazark added a comment to D23706: Fix wrong window titles.

Ping

Sep 10 2019, 1:42 PM · Dolphin

Sep 3 2019

nazark added a reviewer for D23706: Fix wrong window titles: Dolphin.
Sep 3 2019, 7:54 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

Yep, that's exactly what I did to fix that the first time I tried to write a patch!
The problem is, it doesn't solve it.
It will show the name of a folder wrong, if its url in places contains trailing slash (and it's easy to do, the patch that you linked still allows users to manually create/edit such urls in "places").
(The version which just always strips the trailing slash: https://i.imgur.com/QR0GGnx.png)

Sep 3 2019, 3:47 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

As far as I understand, nope, that commit just changes the url which is going to be added to "places".
Firstly, it doesn't fix the bug, and secondly, a user still can add/modify a url in places so that it contains a trailing slash, and current version of dolphin will show it's name wrong (if opened manually, as on the screenshots in "Test Plan").

Sep 3 2019, 3:41 PM · Dolphin
nazark updated the summary of D23706: Fix wrong window titles.
Sep 3 2019, 3:23 PM · Dolphin
nazark requested review of D23706: Fix wrong window titles.
Sep 3 2019, 3:21 PM · Dolphin

Aug 27 2019

nazark updated the summary of D23482: Make non-empty textual columns come first in sorting.
Aug 27 2019, 3:56 PM · Dolphin
nazark added a comment to D23482: Make non-empty textual columns come first in sorting.

Done

Aug 27 2019, 3:55 PM · Dolphin
nazark updated the test plan for D23482: Make non-empty textual columns come first in sorting.
Aug 27 2019, 3:54 PM · Dolphin
nazark added a comment to D23482: Make non-empty textual columns come first in sorting.

If this is not a desired default behavior, I'll need some hints on how to make a setting for it.

Aug 27 2019, 6:43 AM · Dolphin
nazark requested review of D23482: Make non-empty textual columns come first in sorting.
Aug 27 2019, 6:43 AM · Dolphin

Aug 19 2019

nazark added a comment to D23264: Fix a typo.

Thanks,

Aug 19 2019, 3:01 PM · Dolphin
nazark requested review of D23264: Fix a typo.
Aug 19 2019, 2:24 PM · Dolphin