- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Jan 12 2020
Nov 12 2019
Sep 29 2019
Thank you very much. The patch has landed.
This patch looks good now. I can land it for you.
To do so, I need you full name and email to amend the author information. Shall I use the name and mail from the mail that you sent me?
Sep 28 2019
I like the new version.
Sep 27 2019
This patch works fine. Support for .ui files is a great addition.
Sep 19 2019
Done!
Sep 16 2019
Ok, this looks good. Please push it.
Sep 15 2019
Can you explain the reasoning for the patch?
Aug 29 2019
Feb 25 2019
Feb 24 2019
done
I see that one test fails after committing this patch. The example output was modified by /autotests/update-reference-data.sh but I did not submit it. I thought it was not related to the markdown change.
Increased kateversion to 5.0.
Feb 23 2019
Even folding works inside fenced blocks.
- added more languages,
- updated language version
- updated test files
Feb 20 2019
So it's accepted?
Feb 19 2019
Clean up test by using QTest data.
Remove duplicate if statement.
Added tests and code fixes to deal with overlong sequences and content
above U+10FFFF.
Feb 18 2019
- Remove VALUE define.
- Spelling fix.
Feb 17 2019
Feb 13 2019
Feb 9 2019
I think bug 404127 is fixed in 0.3.1. The bindings file states where the rust directory is. That directory contains Cargo.toml.
Feb 8 2019
Jan 22 2019
On NixOS, all executables are under /nix/store/$HASH-$NAME/bin. These get linked into the PATH. Seeing that Akonadi was not respecting PATH previously I wonder how it could work there.
So I checked https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/kde/akonadi/akonadi-paths.patch
Jan 21 2019
Dec 30 2018
Dec 29 2018
Sure. It's here https://phabricator.kde.org/D17856
Here is a patch that solves the problem:
diff --git a/src/core/kconfigini.cpp b/src/core/kconfigini.cpp index 39e5936..b674973 100644 --- a/src/core/kconfigini.cpp +++ b/src/core/kconfigini.cpp @@ -673,7 +673,12 @@ QByteArray KConfigIniBackend::stringToPrintable(const QByteArray &aString, Strin switch (s[i]) { default: // The \n, \t, \r cases (all < 32) are handled below; we can ignore them here - if (((unsigned char)s[i]) < 32 || ((unsigned char)s[i]) >= 127) { + if (((unsigned char)s[i]) < 32) { + goto doEscape; + } + // GroupString and KeyString should be valid UTF-8, but ValueString + // can be a bytearray with non-UTF-8 bytes that should be escaped. + if (type == ValueString && ((unsigned char)s[i]) >= 127) { goto doEscape; } *data++ = s[i];
Found it. This is the failing test.
FAIL! : KConfigTest::testEncoding() Compared values are not the same Actual (lines.first()) : "[UTF-8:\\xc3\\xb6l]\n" Expected (QByteArray("[UTF-8:\xc3\xb6l]\n")): "[UTF-8:\xC3\xB6l]\n" Loc: [/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.11/autotests/kconfigtest.cpp(463)]
Dec 28 2018
Can you give some more details? I see no problem on Jenkins. https://build.kde.org/job/Frameworks/job/kconfig/
Dec 18 2018
I pushed two encore commits fixing the two raised issues.
Add a check for reading in the unit test.
Added a unit test and changed the code so that 0x7f (DEL) is also
escaped.
Dec 9 2018
Thank you very much Owen! Hope you're enjoying Rust Qt Binding Generator.
It's a very clear patch and well documented. I'd prefer it to use an enum though. I've put a suggestion in the code.
I would prefer it if the patch would parse Cargo.toml to determine the edition of Rust. This can be done with the toml crate.
I've tried the patch. To get a 2018 project to compile, cargo needs to know about the 2018 edition feature:
rust_qt_binding_generator = { path = "../rust_qt_binding_generator", features = ["use-2018-edition"] }
Thank you for the simple patch. Is use-2018-edition a feature that is automatically set by Cargo when edition = "2018"? I've not found the documentation on that.