Feed Advanced Search

Apr 23 2019

mathiastillman committed R878:99454c0b15ba: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue. (authored by mathiastillman).
Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue.
Apr 23 2019, 8:32 PM
mathiastillman closed D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue..
Apr 23 2019, 8:32 PM · Plasma
mathiastillman added a reviewer for D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue.: mvourlakos.
Apr 23 2019, 8:07 PM · Plasma
mathiastillman requested review of D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue..
Apr 23 2019, 8:05 PM · Plasma

Feb 14 2019

mathiastillman committed R878:ddb941d4656c: Fix window thumbnails not working since frameworks 5.55 (authored by mathiastillman).
Fix window thumbnails not working since frameworks 5.55
Feb 14 2019, 1:01 PM
mathiastillman closed D19002: Fix window thumbnails not working since frameworks 5.55.
Feb 14 2019, 1:01 PM · Plasma
mathiastillman abandoned D19003: Update visibility of mainItem of the window thumbnail since this is no longer done automatically in KDE Frameworks 5.55..
Feb 14 2019, 12:57 PM · Plasma
mathiastillman requested review of D19003: Update visibility of mainItem of the window thumbnail since this is no longer done automatically in KDE Frameworks 5.55..
Feb 14 2019, 12:56 PM · Plasma
mathiastillman requested review of D19002: Fix window thumbnails not working since frameworks 5.55.
Feb 14 2019, 12:32 PM · Plasma

Aug 2 2018

mathiastillman committed R119:1124adacde68: Merge branch 'Plasma/5.13' (authored by mathiastillman).
Merge branch 'Plasma/5.13'
Aug 2 2018, 7:35 AM
mathiastillman committed R119:16e2952e03c0: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by mathiastillman).
Merge branch 'Plasma/5.12' into Plasma/5.13
Aug 2 2018, 7:35 AM
mathiastillman committed R119:690570a4cefd: fontinst quits after KJob is done (authored by mathiastillman).
fontinst quits after KJob is done
Aug 2 2018, 7:34 AM

Aug 1 2018

mathiastillman added a comment to D14493: fontinst quits after KJob is done.

Okay, so should I wait for someone else to reply before committing it to the 5.12 and 5.13 branches?

Aug 1 2018, 12:17 PM · Plasma

Jul 31 2018

mathiastillman added a comment to D14493: fontinst quits after KJob is done.

It would indeed, but I will wait for input before pushing it as I'm not entirely sure how it's decided what release a patch goes in to.

Jul 31 2018, 5:18 PM · Plasma
mathiastillman committed R119:60c895758f20: fontinst quits after KJob is done (authored by mathiastillman).
fontinst quits after KJob is done
Jul 31 2018, 10:42 AM
mathiastillman closed D14493: fontinst quits after KJob is done.
Jul 31 2018, 10:40 AM · Plasma
mathiastillman added a comment to D14493: fontinst quits after KJob is done.

Either one is fine by me as well, so pick whichever one you fancy :)

Jul 31 2018, 10:01 AM · Plasma
mathiastillman updated the diff for D14493: fontinst quits after KJob is done.

Grammatical fixes ;)

Jul 31 2018, 9:57 AM · Plasma
mathiastillman added a comment to D14493: fontinst quits after KJob is done.

Well, it's sort of a daemon, but it doesn't run until the user logs out - there's a built-in timeout of 30 seconds that will check for any connected clients and if none are found it will kill itself. The KCM communicates with the fontinst daemon via dbus :)

Jul 31 2018, 9:53 AM · Plasma
mathiastillman updated the diff for D14493: fontinst quits after KJob is done.

Use a QEventLoopLocker instead of completely disabling the quit lock functionality.

Jul 31 2018, 9:43 AM · Plasma
mathiastillman added a comment to D14493: fontinst quits after KJob is done.

Okay, that makes sense. kfontinst doesn't actually display a UI at all, instead it just receives dbus commands from kcm - so there is no real GUI class, it just uses QCoreApplication. I could add a QEventLoopLocker to KFI::FontInst though, but, from reading the code it seems as though there's no way to actually cancel the running kjob (nor the running fontinst). That might be a cleaner approach than completely disabling the quit lock, however.

Jul 31 2018, 9:39 AM · Plasma
mathiastillman added reviewers for D14493: fontinst quits after KJob is done: dfaure, aacid, gateau.
Jul 31 2018, 8:23 AM · Plasma
mathiastillman updated the summary of D14493: fontinst quits after KJob is done.
Jul 31 2018, 7:32 AM · Plasma
mathiastillman updated the summary of D14493: fontinst quits after KJob is done.
Jul 31 2018, 7:22 AM · Plasma
mathiastillman added a comment to D14493: fontinst quits after KJob is done.

It does indeed fix both of those bugs. I have added that in the summary now, sorry about that.

Jul 31 2018, 6:57 AM · Plasma
mathiastillman updated the summary of D14493: fontinst quits after KJob is done.
Jul 31 2018, 6:56 AM · Plasma

Jul 30 2018

mathiastillman requested review of D14493: fontinst quits after KJob is done.
Jul 30 2018, 5:13 PM · Plasma