In D28127#647747, @ahiemstra wrote:

Seems fine to me now. You didn't have a developer account right?

I have finished my corrections. Is it nice now? Thanks.

• A better cast to float

I should learn to better use arc...

• typo

• Oops fix bad named functions

Hem, you are right, I missed it because I was testing old binary.

• fix pointer

• Follow ahiemstra suggestions :
  • cast to float directly
  • move 2 repeated lines to initAcpiBattery

In D25018#562834, @ahiemstra wrote:

Do you have a developer account to push the changes? Otherwise I can do that for you.

How will this be merged? Will it be in time for Kde 19.12 ?

How can you interpret these weird charge_now values correctly? If the range is [1/1000, 901] Wh, while the real range is [0, 45] Wh, how does the charge curve look like while charging or discharging? Are there (continues) values in [46, 901] Wh? Do you assume all of those as 100%?

Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100?

Yes : this is a percentage. States out of this value are bad hardware : I have a travel battery which shows crazy values along time, from 0,001Wh capacity till 901Wh (Real capacity is near 45Wh).

Thanks. Just some thoughts : designcharge is usefull if you want to see the percentage of charge you reach against what it should be with a new battery. For some adicional sensors, of course, even if I dont see what ones you are thinking about.

• hopefully correct all problems found in nice ahiemstra's revision
• - indentation corrected to 4 chars
• - function braces in newline
• - We can calculate charge even if current is <= zero.

So asking again for feedback, if I understand well how phabricator works ...

In D25018#558503, @ahiemstra wrote:

Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over. While the original implementation may not have been ideal either, the update function at least made sure the ACPI stuff got only read once per update. If you need some inspiration, Memory.c has a fairly decent implementation.

How to test : just add an ACPI cooling device to ksysguard, it would always show 0% before this patch. To find one cooling device that actually changes, you can use the 'acpi -V' command

• Added a loadtheme function to allow sound theme switching on config change.

• Add .arcconfig file to the project to make contribution easier.

I think I cannot commit as I never did ;-)