Hi all and thank you Nicolas for bringing me in.
What is the time limit (deadline)? I think I can do the job for KTp. Can you please describe what should be done? Fix deprecation warning from Qt or KF5? What version of Qt, up to 5.15? My experience makes me thinking that we'll need quite a lot of ifdefs for clear build with Qt 5.15. And even a clear build doesn't mean source compatibility with Qt 6. For example there are no QString::midRef() and other QStringRefs in Qt 6, but they're not deprecated and have no other replacement in Qt 5.15.
I think I'll have time from the Sunday (Nov 22); ATM I have no PC to work on.

Maybe we can use the upstream formatter? It is available since Qt 5.15.

Oh, I'm sorry I missed this somehow.
Of course land this if it works. 👍 Seems correct to me.

Everyone, thanks for the comments!
Keep in mind that TelepathyQt-0.9.8 is the first version that uses Python 3 instead of Python 2.

Re-added an accidentally removed comment.

Hi!
Thank you for taking this up.
Would you mind to use the same approach as in plasma-workspace? In case of your changes we'll lose the translations, but with desktop_to_json we won't have such a problem.

LGTM (we can bump the TpQt min version and simplify the code later on)

LGTM (we can bump the TpQt min version and simplify the code later on)

I thought more about this and now I agree with this patch. I focused on the thought "how to make it work as it worked before" instead of thinking about "what's right or wrong with the proposed changes".

Hey-ho! One-line fix 😄 :facepalm: :

In D25269#561463, @arojas wrote:

What about pushing this as-is for 19.12 and bumping the dependency and using the new target on master (19.12 is already branched)

Yes, probably it would be better to land this patch for now.
Long story short — I rewrote targets for TelepathyQt, because we exported them under the same name as the library files. CMake doesn't allow to export a target under multiple names, nor add_library(telepathy-qt5 ALIAS TelepathyQt5::Core). It is sad that we relied on ${TELEPATHY_QT5_LIBRARIES} that had not the recommended full path (like /usr/lib/libtelepathy-qt5.so.0.9.7) or the lookup path and linking flag (such as -L/usr/lib -ltelepathy-qt5), but just the "telepathy-qt5" name that happened to match the odd target name.

Wait a sec... where we link against "telepathy-qt target"? I see only ${TELEPATHY_QT5_LIBRARIES} and IMO it was just wrong to treat LIBRARIES variable as targets.

Hello.
I removed [1] the custom FindPythonLibrary module, so the patch is not applicable anymore (I'll release TelepathyQt-0.9.8 with fixes sometime soon).

xincludator.py: Change output format to UTF-8 (fix LANG=C)

Do we have any reason to stick to 2.8.12?
Is there any single user or developer who need a new TelepathyQtLogger but can't update CMake at least to 3.5?
CMake 3.5 is available since Ubuntu 16.04. I think it is old enough to be required.

Better yet, I forgot REQUIRED option. Probably I was in a rush to address your comment before going to work.
@heikobecker, thank you twice :).

Simplify FindPythonInterp invocation.

Use FindPythonInterp on CMake < 3.12

Ouch! Thanks, @heikobecker! I think that we can use FindPythonInterp for now.

BreakConstructorInitializers: BeforeComma changes the output to an acceptable form.

In T11214#191683, @zzag wrote:

In T11214#191682, @akulichalexandr wrote:

I already played with ColumnLimit and all other options from the docs and various sources. IMO the result is disappointing and clang-format is not capable to do things right :-(

Have you tried disabling ColumnLimit (by setting it to 0)?

In my config it'll still be multi line.

In fact, the suggested clang-format file does the same as mine.

In T11214#191565, @ognarb wrote:

In T11214#191564, @alexeymin wrote:

Will formatter ruin beautiful multi-line formatting into single line?

like here

or

?

This will depends on the Style used. But clang format has a lot of configuration options: https://clang.llvm.org/docs/ClangFormatStyleOptions.html.

I tried my best to apply and enforce clang-format for my project, but I failed to do so in a reasonable time.
I've got an impression that clang-format configuration doesn't provide enough options to format code well enough, but maybe I should spend more hours :-).