Feed Advanced Search

Feb 19 2020

jakobkummerow added a comment to D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs.

Thank you!

Feb 19 2020, 11:05 AM · Plasma

Feb 17 2020

jakobkummerow added a comment to D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs.

Thanks for landing this! My name is Jakob Kummerow, email: jakob.kummerow@gmail.com

Feb 17 2020, 10:59 AM · Plasma

Feb 13 2020

jakobkummerow added a comment to D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs.

ahiemstra: Thanks! I don't have commit access, so I'd appreciate it if you could land this for me.

Feb 13 2020, 4:09 PM · Plasma
jakobkummerow updated the diff for D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs.

Minor update: size_t instead of int.

Feb 13 2020, 3:01 PM · Plasma
jakobkummerow updated the diff for D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs.

OK, here's a version that scales the buffer size as needed.

Feb 13 2020, 3:00 PM · Plasma
jakobkummerow added a comment to D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs.

cfeck: Sure, an even better long-term fix would be to stop depending on a hard-coded buffer size. Interleaved reading and parsing would be one way to achieve that; another way would be a dynamic buffer size: start small, and if it's too small then allocate a new buffer that's twice as large and try again.

Feb 13 2020, 1:07 PM · Plasma
jakobkummerow requested review of D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs.
Feb 13 2020, 11:22 AM · Plasma