In D11303#225792, @mwolff wrote:

excellent, lgtm. do you have commit rights?

Of course. This is my first unit test, tell me if this one is okay. It passes on my machine. Before my patch, only one context with 6 declaration was created.

Can you push that for me? I don't have the rights for pusing. My email is gufideg at gmail.com. Thanks.

• Remove code duplication in cmakecachemodel.cpp

Here's two screenshot of the new ui:

In D8215#153611, @apol wrote:

Why does it need to be in a different column? Am I missing something?

• Fix a bug where STRINGS were not filled when cache variable also marked as advanced

My email is gufideg at gmail.com. Thank you for your patience in this review.

• Removed else brakets in else if

• Added a comment to explain the operations done to warning string and optimizations

• Clear -Werror instead of removing it

• Remove '-Werror=' properly and only if found at the start of the string

• Changed std::copy_if to erase + remove_if in the same container

• Revert "Filter out warnings as error from parser's compile flags"
• Filter clang flags in the clang parser

@kfunk I'll check this out soon!

• Reverted Wno-error, and appending extraArguments at the end of options

Seems reasonable @kfunk . I'll update this patch accordingly. Although, I think there should be an option to "override" buildsystem arguments for the parser, to enable more fine grained option about what warnings the parse emit or not.