In D29258#675261, @vonreth wrote:

It probably won't hurt

Bump.

Qt5Network added as required

In D29258#674669, @vonreth wrote:

You could also just deploy the binary with msys.

Thanks for looking into that matter.

Bump.

Could anyone review my patch again?

In D29258#659423, @brute4s99 wrote:

SnoreToast fails to build on MSYS2 due to missing
which apparently is not available for this compiler.

I'm sorry, missing what exactly?

I see. I've updated the patch. Linking to downloaded library is now possible, and there is a fallback if no library is present.

In D28441#638400, @aacid wrote:

Is this an actual problem with the app or just a test fix (i.e. do i need to make a release to fix a potential crash?)

In D26498#638035, @pino wrote:

In D26498#637978, @wojnilowicz wrote:

Following patch fixes the issue

0001-Fix-RSITimerTest-noPopupBreak.patch1 KBDownload

Is this solution good for you?

This patch fixes the rsibreak_tests crash, however the test still fails in RSITimerTest::triggerSimpleBigBreak(), in the way I already mentioned.

In D26498#637506, @pino wrote:

Hi @aacid & @wojnilowicz:

unfortunately this commit breaks the rsibreak_tests:

• in some states, m_shortInputCounter is a nullptr, so RSITimer::timeout() tries to ->tick() a null pointer
• even doing a nullptr check for the code above, RSITimerTest::triggerSimpleBigBreak() fails: ` FAIL! : RSITimerTest::triggerSimpleBigBreak() Compared values are not the same Actual (spy1Relax.count()): 100 Expected (relaxCountExp) : 97 Loc: [SRCDIR/test/rsitimer_test.cpp(186)] `
  
  Can you please look into both the issues? Thanks!

In D26498#592315, @aacid wrote:

Thanks a lot for your contribution :)

In D26498#591716, @aacid wrote:

Doesn't seem to really work for me.

I mean, yes it works in the sense that the timer doesn't go back to 20 seconds but at the end of my "you should rest" period i always get the "oh you've been bad my not resting" screen if i have used this feature of ignoring a few seconds.

Did not forgot.

Forgot to reset m_shortInputCounter in RSITimer::doBreakNow.

Here is how the new columns look like.