Feed Advanced Search

Jul 13 2020

liushuyu abandoned D25539: feat(kcm): add revert timer.

This patch has been migrated to https://invent.kde.org/plasma/kscreen/-/merge_requests/1

Jul 13 2020, 10:11 PM · Plasma

Dec 16 2019

liushuyu added a comment to D25539: feat(kcm): add revert timer.

Any other suggestions for this patch?

Dec 16 2019, 4:07 AM · Plasma

Nov 28 2019

liushuyu updated the diff for D25539: feat(kcm): add revert timer.

Address ndavis' comments

Nov 28 2019, 4:15 AM · Plasma
liushuyu added a comment to D25539: feat(kcm): add revert timer.

Is there a way to tell the revert timer not to be used if the user only makes a change that requires a session restart? It wouldn't be very useful to ask a user to confirm if the screen is displaying correctly if the change can't be seen.

Nov 28 2019, 4:14 AM · Plasma

Nov 27 2019

liushuyu added a comment to D25539: feat(kcm): add revert timer.

After applying the patches from https://cgit.kde.org/kirigami.git/commit/?id=8c1e5b1336e6dcae0a1b7756977fcd9368f853a2,
it now looks like this:

Nov 27 2019, 6:52 PM · Plasma
liushuyu updated the diff for D25539: feat(kcm): add revert timer.

Update icons and stop the timer on actions pressed

Nov 27 2019, 6:50 PM · Plasma
liushuyu added a comment to D25539: feat(kcm): add revert timer.

Now it looks like this

Nov 27 2019, 2:08 AM · Plasma
liushuyu added inline comments to D25539: feat(kcm): add revert timer.
Nov 27 2019, 2:07 AM · Plasma
liushuyu updated the diff for D25539: feat(kcm): add revert timer.

Use InlineMessage instead of MessageBox and move the timer to the QML portion

Nov 27 2019, 2:05 AM · Plasma

Nov 26 2019

liushuyu updated the diff for D25539: feat(kcm): add revert timer.

Fix the diff

Nov 26 2019, 4:59 AM · Plasma
liushuyu added a reviewer for D25539: feat(kcm): add revert timer: Plasma.
Nov 26 2019, 4:16 AM · Plasma
liushuyu requested review of D25539: feat(kcm): add revert timer.
Nov 26 2019, 4:01 AM · Plasma