In D16138#573019, @hindenburg wrote:

What's the ping? Should Konsole ship a default profile? and if so which one? or fix this code?

Rebased

I figure out that the previous patch was backward-incompatible.

In D16138#419673, @hindenburg wrote:

Testing this and a few concerns right off the start

1. manage profiles doesn't show any of my profiles (should be 5)

In D16138#408094, @sandsmark wrote:

This fix looks wrong anyways, shouldn't clutter up the home directory of users just because we run (IMHO).

Hi, everyone! Sorry for the delay.

In D16138#347398, @hindenburg wrote:

Without this patch, when you change any profile settings, it creates a 'Profile 1.profile'. This is my understanding of how it is suppose to work.

In D16138#341653, @hindenburg wrote:

I don't recall off-hand what happens w/o these 2 files - most distros include profiles

Commit 8a2796d280dd7e891724cb6e6d873a57e2ae8c52 fixed this issue in 5.12.0. I was working on previous kwin version and, although I have fixed the issue for myself while ago, I was waiting for a better timing to port to HEAD and to compile/test. It is unnecessary now.

In D5644#106864, @mwolff wrote:

do you have commit rights?

In D5682#106930, @luebking wrote:

The desktop grid seeems more suited to handle the windows VD.

In D5682#106872, @luebking wrote:

KWin *has* global shortcuts for minimizing and stickyness. Those should either be forwarded or picked up from KGlobalAccel, rather than adding some randonmly hardcoded strings where the user might have entirely different expectation on what they do.

In D5682#106761, @graesslin wrote:

That would also be "magic". How would a user know about it? That is my main concern. We cannot just add key handling and not tell users about it. If we accept this review - or the idea of global shortcuts - we would have a workflow suited for you and nobody else.
Nobody would be able to use this unless reading the source code.

In D5682#106643, @graesslin wrote:

How are users supposed to know about this? I'm strictly against adding further "magic" to PW or to implement personal features.

I have no commit rights. Someone must commit in my behalf.

In D5656#106401, @nalvarez wrote:

I'm pretty sure this breaks ABI by adding a new virtual function... If an application was compiled against a previous version of KTextEditor and calls documentSave(), when run with a newer KTextEditor version (with this patch) it may end up calling the new documentReload(ReloadDocument). With garbage in the first argument.

D5673 shows a use-case for this feature.

In D3602#70908, @graesslin wrote:

Do you have commit rights or should I push the change for you?

Changes the design to remove the recursion and the tryOpposite boolean flag.

In D3602#67538, @subdiff wrote:

I don't use directional shortcuts for switching between windows, but in general I like your idea very much and if Thomas gives his ok, it would improve the user experience in usecases like your one. You described it very well.

In D3602#67334, @graesslin wrote:

Conceptually I'm not sure about it. If I click switch to window on left, I expect it to do that and not to switch to a window right of it. What does a user expect and is your changed behavior still in accordance to what the user expects?

I'm not going to decide on that, this needs input from the usability experts.