Feel free to push to 19.08

Nice! Does this mean that we can start to use PSQL as backend?

Thanks, I'll push to master since it could be considered a behavior change ;)

Am I wrong or the new action doesn't show up in the View menu on the menubar?

Yes, I meant the one on the video preview.

Please push it. D23538 will have to be rebased.

Thanks for the patch. Please rebase it on top of D22183 (or wait until we merge it, should happen soon).

Patch looks almost good now.

Hmm, this is categorized logging which means if you are seeing that message you have explicitly enabled ark logging.

D23232 shall be it :)

Patch looks good, but please note that bug #344617 also asks to make the filter button a toggle.
So either we rename the bug report to only refer to the search button, or this commit should have CCBUG: rather than BUG:.

In T8473#137607, @elvisangelaccio wrote:

For the record, see also D10246 and https://git.reviewboard.kde.org/r/127054/

In D23445#518989, @feverfew wrote:

In D23445#518985, @ngraham wrote:

Thanks for the quick fix. Stable branch please!

Still not commit access (probably because of bugs like these...), please commit for me :)

In D23075#518967, @GB_2 wrote:

Why remove the up button when it doesn't use much space and is useful?
Just because these file managers don't have it doesn't mean we also shouldn't include it (Nemo, Thunar, PCManFM have it for example). It is very useful when you navigate back and forth between different directories, but then want to quickly go back to the folder that is a few folders above. If you would use the back button then you would have to click it a lot more.
You can also use it when you are in a pinned directoy and easily want to go to the parent folder.

In D23075#512181, @ndavis wrote:

In D23075#512110, @elvisangelaccio wrote:

Wow, this is quite a radical change :)

I'm not against changing the default layout, but we should be 100% sure to get it right. It would be very annoying if we have to change it again in six months because people didn't like it.

My comments after a quick try:

1. I don't think we should add the "Go Up" button because you can already achieve the same action by using the url navigator buttons.

I kind of agree, but don't have a strong opinion since it's a common control in file managers and doesn't take up much space.

Actually, it seems this breaks the build of dolphinmainwindowtest:

I'd push to master TBH.

In D22183#511449, @elvisangelaccio wrote:

Btw I think I spotted a regression:

1. Start playback
2. Right-click on info panel -> uncheck "Preview"
3. Right-click again -> check "Preview"
   
   The phonon widget does not show up again.

In D23412#518459, @meven wrote:

A simpler alternative could be to use m_sortByActions, I have tested it.

In D21691#518422, @ngraham wrote:

Sadly this caused https://bugs.kde.org/show_bug.cgi?id=411193.

In D23168#518262, @ngraham wrote:

@elvisangelaccio maybe we should move FindTaglib.cmake into ECM. Quite a few projects seem to have their own copies of it.

In D23255#514314, @broulik wrote:

I think a warning is appropriate as opening a gazillion applications could lead to an unresponsive system.

Thanks. Please push to master.

Haven't tested the patch, but the change looks good to me.

Thanks for the patch. Please read https://community.kde.org/Policies/Commit_Policy about how to write a good commit message.

In D22802#512261, @rjvbb wrote:

Untested: have you tried to make dolphinprivate a PUBLIC dependency of kdeinit_dolphin?

Appears that this works too:

target_link_libraries(kdeinit_dolphin PUBLIC
    dolphinprivate
    PRIVATE
    dolphinstatic
    KF5::Crash
)

I'll be AFK for a week for vacation. Will do a proper review once I'm back ;)

Wow, this is quite a radical change :)

Can you try to build another kdeinit app (i.e. khelpcenter) to check if you get the same error?

Btw I think I spotted a regression:

Got the following errore while pushing:

Thanks

In D22420#503573, @AndreyYashkin wrote:

In D22420#503317, @elvisangelaccio wrote:

I'd still like to understand what happend at the change in 4e40fe810d324.

@ngraham Any idea?

@elvisangelaccio, I read the description of change in 4e40fe810d324 and bug 298467, which was fixed in it more carefull and understood that the change was supposed to introduce the feature of setting the focus back to the active view. However, it seems that Ctrl-D or exit command cases were not tested good enough.

Please push to master or wait after August 15th (Applications 19.08 Release day) if you need this in the stable branch too.

Thanks, LGTM now.

In D22444#496089, @elvisangelaccio wrote:

Please use a descriptive commit message: https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages

There seems to be another issue: if I run dolphin <some folder> from cmd line I always get Add 'file' to place, no matter what the folder is.

Reverted this commit and then pushed diff 61904.

Note that the commit message will need BUG: (with the colons) in order to automagically close the bug report.

In R318:dc586ada63d1822fbbe38a0dd3449c73b03928e0#3803979, @AndreyYashkin wrote:

@elvisangelaccio, you have forgotten or I did not say clear enough that it is the previous cosmetic cosmetic version(Diff 61904) that was correct! Read my remark again in the revision conversation, please. @hein did not respond and I cannot say even if this one is fully correct for Korean. The one line solution does groupping of some Cyrillic symbols, which cannot be grouped toggether(aleast in Russian dictionary)
This was my fall. Sorry again for it.

I'd still like to understand what happend at the change in 4e40fe810d324.

Thanks, going to push to 19.08 :)

Well, I like that we are replacing 20+ lines of code with only one ;)

In D22594#498890, @ngraham wrote:

As for the feature itself, for the past few years I'd been opposed to this, on the basis that people should just use the built-in Baloo-based search instead. But unfortunately the requests keep coming in

Code looks good, but I spotted a regression: 'Add to Places' is now disabled if you don't select any folder. Currently it is possible to add the current folder as place without the need for any selection.

LGTM. Feel free to push on 19.08.

I like this solution better. I'll push on master only for now, and we'll see if we break something ;)

Can you expland a bit the commit message explaining how does libkgapi use the filename?

Please push to master. Thanks!